UserController::edit() - Code Metrics - Inspection of "fix invitations index bug" - xoco70/kendozone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 635a5e...84f4be )

by Julien

created 2018-04-02 09:55 UTC

UserController::edit() A

↳ Parent: UserController

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	10
nc	2
nop	1
dl	0
loc	14
ccs	10
cts	10
cp	1
crap	2
rs	9.4285
c	1
b	0
f	0

<?php

namespace App\Http\Controllers;


use App\Association;
use App\Club;
use App\Country;
use App\Federation;
use App\Grade;
use App\Http\Requests\UserRequest;
use App\Notifications\AccountCreated;
use App\Role;
use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\QueryException;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Response;
use Illuminate\Support\Facades\View;
use Maatwebsite\Excel\Facades\Excel;
use URL;

class UserController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return View
     */
    public function index()
    {
        $users = User::with('country', 'role', 'association', 'federation')
            ->forUser(Auth::user())
            ->where('id', '>', 1)
            ->paginate(config('constants.PAGINATION'));

        return view('users.index', compact('users'));
    }

    /**
     * Show the form for creating a new resource.
     * @return View
     * @throws AuthorizationException
     */
    public function create()
    {

        $user = new User();
        if (Auth::user()->cannot('create', $user)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            throw new AuthorizationException();
        }

        $roles = Role::grantedRoles(Auth::user()->role_id)->pluck('name', 'id');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $grades = Grade::getAllPlucked();
        $countries = Country::getAllPlucked();
        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $clubs = Club::fillSelect(Auth::user()->federation_id, Auth::user()->association_id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        return view('users.form', compact('user', 'grades', 'countries', 'roles', 'federations', 'associations', 'clubs')); //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param UserRequest $userForm
     * @return \Illuminate\Http\RedirectResponse|Response
     */
    public function store(UserRequest $userForm)
    {
        try {
            $userForm->store();
            $user = User::where('email', $userForm->email)->first();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $user->notify(new AccountCreated($user));
            flash()->success(trans('msg.user_create_successful'));

        } catch (QueryException $e) {
            flash()->error(trans('msg.user_already_exists'));

            return redirect()->back()->withInput();
        }
        return redirect(route('users.index'));
    }

    /**
     * Display the specified resource.
     *
     * @param User $user
     * @return View
     */
    public function show(User $user)
    {


        return view('users.show', compact('user'));
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param User $user
     * @return View
     * @throws AuthorizationException
     */
    public function edit(User $user)
    {
        if (Auth::user()->cannot('edit', $user)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            throw new AuthorizationException();
        }
        $roles = Role::grantedRoles(Auth::user()->role_id)->pluck('name', 'id');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $grades = Grade::orderBy('order')->pluck('name', 'id');
        $countries = Country::pluck('name', 'id');
        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $clubs = Club::fillSelect(Auth::user()->federation_id, Auth::user()->association_id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return view('users.form', compact('user', 'grades', 'countries', 'roles', 'federations', 'associations', 'clubs')); //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  UserRequest $userForm
     * @param User $user
     * @return Response
     */
    public function update(UserRequest $userForm, User $user)
    {
        if ($userForm->update($user)) {
            flash()->success(trans('msg.user_update_successful'));

        } else
            flash()->error(Lang::get('msg.user_update_error'));


        if ($user->id == Auth::user()->id) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return redirect(URL::action('UserController@edit', Auth::user()->slug));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }

        return redirect(route('users.index'));

    }


    public function export()
    {

        Excel::create(trans_choice('core.user', 2), function ($excel) {

            $appName = (app()->environment() == 'local' ? getenv('APP_NAME') : config('app.name'));

            // Set the title
            $excel->setTitle(trans_choice('core.user', 2));

            // Chain the setters
            $excel->setCreator($appName)
                ->setCompany($appName);

            // Call them separately
            $excel->setDescription('A list of users');
            $excel->sheet(trans_choice('core.user', 2), function ($sheet) {
                //TODO Here we should join grade, role, country to print name not FK
                $users = User::all();
//                $users = User::with(['grade', 'role'])->get();
                $sheet->fromArray($users);
            });


        })->export('xls');
    }

    public function getMyTournaments(Request $request)

    {
        $tournaments = Auth::user()->myTournaments()->with('owner')
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->orderBy('created_at', 'desc')
            ->paginate(config('constants.PAGINATION'));;

        $title = trans('core.tournaments_registered');

        return view('users.tournaments', compact('tournaments', 'title'));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param User $user
     * @return \Illuminate\Http\JsonResponse
     * @throws \Exception
     */
    public function destroy(User $user)
    {

        if ($user->delete()) {
            return Response::json(['msg' => trans('msg.user_delete_successful'), 'status' => 'success']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return Response::json(['msg' => trans('msg.user_delete_error'), 'status' => 'error']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    }

    /**
     * @param $userSlug
     * @return \Illuminate\Http\JsonResponse
     */
    public function restore($userSlug)

    {
        $user = User::withTrashed()->whereSlug($userSlug)->first();
        if ($user->restore()) {
            return Response::json(['msg' => trans('msg.user_restore_successful'), 'status' => 'success']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return Response::json(['msg' => trans('msg.user_restore_successful'), 'status' => 'error']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    }

    public function myFederations(User $user)
    {
        return Federation::fillSelectForVueJs($user);
    }

    public function myAssociations(User $user, $federationId)
    {
        return Association::fillSelectForVuejs($user, $federationId);
    }

    public function myClubs(User $user, $federationId, $associationId)
    {
        return Club::fillSelectForVueJs($user, $federationId, $associationId);
    }

}


Push — master ( 635a5e...84f4be )

UserController::edit() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Http\Controllers;
4
5
6			use App\Association;
7			use App\Club;
8			use App\Country;
9			use App\Federation;
10			use App\Grade;
11			use App\Http\Requests\UserRequest;
12			use App\Notifications\AccountCreated;
13			use App\Role;
14			use App\User;
15			use Illuminate\Auth\Access\AuthorizationException;
16			use Illuminate\Database\QueryException;
17			use Illuminate\Http\Request;
18			use Illuminate\Support\Facades\Auth;
19			use Illuminate\Support\Facades\Lang;
20			use Illuminate\Support\Facades\Response;
21			use Illuminate\Support\Facades\View;
22			use Maatwebsite\Excel\Facades\Excel;
23			use URL;
24
25			class UserController extends Controller
26			{
27			/**
28			* Display a listing of the resource.
29			*
30			* @return View
31			*/
32			public function index()
33			{
34			$users = User::with('country', 'role', 'association', 'federation')
35			->forUser(Auth::user())
36			->where('id', '>', 1)
37			->paginate(config('constants.PAGINATION'));
38
39			return view('users.index', compact('users'));
40			}

xoco70 / kendozone

Push — master ( 635a5e...84f4be )

UserController::edit() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like