UserRequest - Code Metrics - Inspection of "fix invitations index bug" - xoco70/kendozone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 635a5e...84f4be )

by Julien

created 2018-04-02 09:55 UTC

UserRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

87.8%

Importance

Changes

Metric	Value
dl	0
loc	99
ccs	36
cts	41
cp	0.878
rs	10
c	0
b	0
f	0
wmc	13
lcom	1
cbo	4

3 Methods

Rating	Name	Size	Complexity
A	authorize()	4	1
C	update()	30	7
A	rules()	17	2

<?php

namespace App\Http\Requests;

use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Route;

class UserRequest extends Request
{

    protected $method;

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */

    public function authorize()
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {

        $uniqueUser = '';
        $passwordRules = '';
        if (Route::getCurrentRoute()->getName() == 'users.create') {

            $passwordRules = '|required|min:6';
            $uniqueUser = '|unique:users';
        }
        $rules = [
            'name' => 'required|max:255',
            'email' => 'required|email|max:255' . $uniqueUser,
            'password' => 'confirmed' . $passwordRules,
        ];
        return $rules;
    }


    public function store()
    {

        $data = $this->except('_token');

        if ($this->is("users")) {
            $data['provider'] = "created";
        } else {
            $data['provider'] = "register";
        }

        $data['provider_id'] = $data['email'];
        $data['verified'] = 1;

        $user = new User;


        $user->fill($data);
        $user->password = bcrypt($this->password);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (Auth::user()->cannot('store', $user)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            throw new AuthorizationException();
        }
        return $user->save();
    }

    public function update(User $user)
    {
//        $this->authorize('update', [$user, Auth::user()]);

        if (Auth::user()->cannot('update', $user)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            throw new AuthorizationException();
        }
        $except = [];
        if (trim($this->role_id) == '') {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            array_push($except, 'role_id');
        }

        if (trim($this->password) == '' && trim($this->password_confirmation) == '') {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            array_push($except, 'password');
        }
        array_push($except, '_token');

        $req = $this->except($except);
        if ($this->avatar == "") {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $req['avatar'] = null;
        }

        $user->fill($req);

        if (!in_array('password', $except)) {
            $user->password = bcrypt($this->password);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return $user->save();
    }


}


1		<?php
2
3		namespace App\Http\Requests;
4
5		use App\User;
6		use Illuminate\Auth\Access\AuthorizationException;
7		use Illuminate\Support\Facades\Auth;
8		use Illuminate\Support\Facades\Route;
9
10		class UserRequest extends Request
11		{
12
13		protected $method;
14
15		/**
16		* Determine if the user is authorized to make this request.
17		*
18		* @return bool
19		*/
20
21	5	public function authorize()
22		{
23	5	return true;
24		}
25
26		/**
27		* Get the validation rules that apply to the request.
28		*
29		* @return array
30		*/
31	6	public function rules()
32		{
33
34	6	$uniqueUser = '';
35	6	$passwordRules = '';
36	6	if (Route::getCurrentRoute()->getName() == 'users.create') {
37
38		$passwordRules = '\|required\|min:6';
39		$uniqueUser = '\|unique:users';
40		}
41		$rules = [
42	6	'name' => 'required\|max:255',
43	6	'email' => 'required\|email\|max:255' . $uniqueUser,
44	6	'password' => 'confirmed' . $passwordRules,
45		];
46	6	return $rules;
47		}
48
49
50	1	public function store()
51		{
52
53	1	$data = $this->except('_token');
54
55	1	if ($this->is("users")) {
56	1	$data['provider'] = "created";
57		} else {
58		$data['provider'] = "register";
59		}
60
61	1	$data['provider_id'] = $data['email'];
62	1	$data['verified'] = 1;
63
64	1	$user = new User;
65
66
67	1	$user->fill($data);
68	1	$user->password = bcrypt($this->password);
		0 ignored issues – show Documentation introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<App\Http\Requests\UserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
69
70	1	if (Auth::user()->cannot('store', $user)) {
		0 ignored issues – show Bug introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `cannot()` does only exist in the following implementations of said interface: `App\Profile`, `App\User`, `Illuminate\Foundation\Auth\User`, `Lab404\Tests\Stubs\Models\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
71		throw new AuthorizationException();
72		}
73	1	return $user->save();
74		}
75
76	4	public function update(User $user)
77		{
78		// $this->authorize('update', [$user, Auth::user()]);
79
80	4	if (Auth::user()->cannot('update', $user)) {
		0 ignored issues – show Bug introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `cannot()` does only exist in the following implementations of said interface: `App\Profile`, `App\User`, `Illuminate\Foundation\Auth\User`, `Lab404\Tests\Stubs\Models\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
81		throw new AuthorizationException();
82		}
83	4	$except = [];
84	4	if (trim($this->role_id) == '') {
		0 ignored issues – show Documentation introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report The property `role_id` does not exist on `object<App\Http\Requests\UserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
85	1	array_push($except, 'role_id');
86		}
87
88	4	if (trim($this->password) == '' && trim($this->password_confirmation) == '') {
		0 ignored issues – show Documentation introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<App\Http\Requests\UserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report The property `password_confirmation` does not exist on `object<App\Http\Requests\UserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
89
90	3	array_push($except, 'password');
91		}
92	4	array_push($except, '_token');
93
94	4	$req = $this->except($except);
95	4	if ($this->avatar == "") {
		0 ignored issues – show Documentation introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report The property `avatar` does not exist on `object<App\Http\Requests\UserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
96	4	$req['avatar'] = null;
97		}
98
99	4	$user->fill($req);
100
101	4	if (!in_array('password', $except)) {
102	1	$user->password = bcrypt($this->password);
		0 ignored issues – show Documentation introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<App\Http\Requests\UserRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
103		}
104	4	return $user->save();
105		}
106
107
108		}
109

xoco70 / kendozone

Push — master ( 635a5e...84f4be )

UserRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like