FederationController::update() - Code Metrics - Inspection of "Bump ini from 1.3.4 to 1.3.7" - xoco70/kendozone - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#47)

unknown

created 2020-12-10 17:13 UTC

FederationController::update() A

↳ Parent: FederationController

Complexity

Conditions	3
Paths	7

Size

Total Lines	19
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.512

Importance

Changes

Metric	Value
cc	3
eloc	13
nc	7
nop	2
dl	0
loc	19
ccs	8
cts	13
cp	0.6153
crap	3.512
rs	9.8333
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;


use App\Exceptions\NotOwningFederationException;
use App\Federation;
use App\Http\Requests\FederationRequest;
use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\QueryException;
use Illuminate\Support\Facades\Auth;

class FederationController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return Federation
     */
    public function index()
    {
        $federations = Federation::with('president', 'country'); // ,'vicepresident','secretary','treasurer','admin'

        $federations = $federations->where('id', '>', 1)->get();
        return view('federations.index', compact('federations'));



    }


    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $federation = Federation::findOrFail($id);
        return view('federations.show', compact('federation'));

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param $id
     * @return \Illuminate\Http\Response
     * @throws AuthorizationException
     */
    public function edit($id)
    {
        $federation = Federation::findOrFail($id);
        if (Auth::user()->cannot('edit', $federation)) {
            throw new AuthorizationException();
        }

        $users = User::where('country_id', '=', $federation->country_id)->pluck('name', 'id');
        return view('federations.edit', compact('federation', 'users'));

    }

    /**
     * Update the specified resource in storage.
     *
     * @param FederationRequest|\Illuminate\Http\Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     * @throws NotOwningFederationException
     */
    public function update(FederationRequest $request, $id)
    {
        $federation = Federation::findOrFail($id);
        if (Auth::user()->cannot('update', $federation)) {
            throw new NotOwningFederationException();
        }
        try {
            $federation->update($request->all());
            $users = User::where('country_id', '=', $federation->country_id)->pluck('name', 'id');

            $msg = trans('msg.federation_edit_successful', ['name' => $federation->name]);
            flash()->success($msg);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

            return redirect(route('federations.index'));


        } catch (QueryException $e) {

            $msg = trans('msg.federation_president_already_exists');
            flash()->error($msg);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            return redirect()->back();


        }
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5
6		use App\Exceptions\NotOwningFederationException;
7		use App\Federation;
8		use App\Http\Requests\FederationRequest;
9		use App\User;
10		use Illuminate\Auth\Access\AuthorizationException;
11		use Illuminate\Database\QueryException;
12		use Illuminate\Support\Facades\Auth;
13
14		class FederationController extends Controller
15		{
16		/**
17		* Display a listing of the resource.
18		*
19		* @return Federation
20		*/
21	2	public function index()
22		{
23	2	$federations = Federation::with('president', 'country'); // ,'vicepresident','secretary','treasurer','admin'
24
25	2	$federations = $federations->where('id', '>', 1)->get();
26	2	return view('federations.index', compact('federations'));
		0 ignored issues – show Bug Best Practice introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report The expression `return view('federations...compact('federations'))` returns the type `Illuminate\Contracts\Vie...ry\|Illuminate\View\View` which is incompatible with the documented return type `App\Federation`. Loading history...
27
28
29		}
30
31
32		/**
33		* Display the specified resource.
34		*
35		* @param int $id
36		* @return \Illuminate\Http\Response
37		*/
38		public function show($id)
39		{
40		$federation = Federation::findOrFail($id);
41		return view('federations.show', compact('federation'));
		0 ignored issues – show Bug Best Practice introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report The expression `return view('federations... compact('federation'))` returns the type `Illuminate\Contracts\Vie...ry\|Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
42		}
43
44		/**
45		* Show the form for editing the specified resource.
46		*
47		* @param $id
48		* @return \Illuminate\Http\Response
49		* @throws AuthorizationException
50		*/
51	1	public function edit($id)
52		{
53	1	$federation = Federation::findOrFail($id);
54	1	if (Auth::user()->cannot('edit', $federation)) {
55	1	throw new AuthorizationException();
56		}
57
58	1	$users = User::where('country_id', '=', $federation->country_id)->pluck('name', 'id');
59	1	return view('federations.edit', compact('federation', 'users'));
		0 ignored issues – show Bug Best Practice introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report The expression `return view('federations...'federation', 'users'))` returns the type `Illuminate\Contracts\Vie...ry\|Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
60		}
61
62		/**
63		* Update the specified resource in storage.
64		*
65		* @param FederationRequest\|\Illuminate\Http\Request $request
66		* @param int $id
67		* @return \Illuminate\Http\Response
68		* @throws NotOwningFederationException
69		*/
70	1	public function update(FederationRequest $request, $id)
71		{
72	1	$federation = Federation::findOrFail($id);
73	1	if (Auth::user()->cannot('update', $federation)) {
74		throw new NotOwningFederationException();
75		}
76		try {
77	1	$federation->update($request->all());
78	1	$users = User::where('country_id', '=', $federation->country_id)->pluck('name', 'id');
		0 ignored issues – show Unused Code introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report The assignment to `$users` is dead and can be removed. Loading history...
79	1	$msg = trans('msg.federation_edit_successful', ['name' => $federation->name]);
80	1	flash()->success($msg);
		0 ignored issues – show Bug introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report Are you sure the usage of `flash()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
81
82	1	return redirect(route('federations.index'));
		0 ignored issues – show Bug Best Practice introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report The expression `return redirect(route('federations.index'))` returns the type `Illuminate\Http\Redirect...nate\Routing\Redirector` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
83
84		} catch (QueryException $e) {
85
86		$msg = trans('msg.federation_president_already_exists');
87		flash()->error($msg);
		0 ignored issues – show Bug introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report Are you sure the usage of `flash()` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
88		return redirect()->back();
		0 ignored issues – show Bug Best Practice introduced 2018-10-24 09:33 UTC by Report Bug Copy Issue Report The expression `return redirect()->back()` returns the type `Illuminate\Http\Redirect...nate\Routing\Redirector` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
89
90		}
91		}
92		}
93

xoco70 / kendozone

Pull Request — master (#47)

FederationController::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like