ClubController - Code Metrics - Inspection of "fix details" - xoco70/kendozone - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 815d3e...28d501 )

by Julien

created 2017-10-06 17:38 UTC

ClubController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	181
Duplicated Lines	15.47 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
dl	28
loc	181
rs	10
c	0
b	0
f	0
wmc	19
lcom	1
cbo	7

6 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	15	2
A	create()	0	18	1
B	store()	9	26	6
A	show()	0	5	1
A	update()	0	21	4
A	destroy()	9	9	2

How to fix Duplicated Code

<?php

namespace App\Http\Controllers;

use App\Association;
use App\Club;
use App\Federation;
use App\Http\Requests\ClubRequest;
use App\User;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\QueryException;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\View;
use Response;

class ClubController extends Controller
{
    // Only Super Admin and Club President can manage Clubs

    /**
     * Display a listing of the resource.
     *
     * @return Collection|View
     */
    public function index()
    {

        if (Request::ajax()) {
            return Club::fillSelect(Auth::user()->federation_id, Auth::user()->association_id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        } else {
            $clubs = Club::with('president', 'association.federation')
                ->forUser(Auth::user())
                ->where('id', '>', 1)
                ->get();

            return view('clubs.index', compact('clubs'));
        }

    }


    /**
     * Show the form for creating a new resource.
     * @return View
     * @throws AuthorizationException
     */
    public function create()
    {


        $club = new Club;
        // Authorization

        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user())->pluck('name', 'id')->prepend('-', 0);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $users = Auth::user()->fillSelect();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}


        $defaultLng = Auth::user()->latitude ?? geoip()->lat;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $defaultLat = Auth::user()->longitude ?? geoip()->lon;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}


        return view('clubs.form', compact('club', 'users', 'federations', 'associations', 'defaultLng', 'defaultLat')); //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param ClubRequest $request
     * @return JsonResponse|RedirectResponse
     */
    public function store(ClubRequest $request)
    {

        try {
            if ($request->president_id == 0) $request->merge(['president_id' => null]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($request->federation_id == 0) $request->merge(['federation_id' => null]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($request->association_id == 0) $request->merge(['association_id' => null]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $club = Club::create($request->all());

            if (Request::ajax()) {

                return Response::json(['msg' => trans('msg.club_create_successful', ['name' => $club->name]), 'status' => 'success', 'data' => $club], 200);
            } else {
                $msg = trans('msg.club_edit_successful', ['name' => $club->name]);
                flash()->success($msg);


                return redirect("clubs");

            }
        } catch (QueryException $e) {
            $user = User::find($request->president_id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $msg = trans('msg.club_president_already_exists', ['user' => $user->name]);
            flash()->error($msg);

            return redirect()->back();
        }

    }


    /**
     * Display the specified resource.
     *
     * @param  int $id
     * @return View
     */
    public function show($id)
    {
        $club = Club::findOrFail($id);
        return view('clubs.show', compact('club'));
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     * @return View
     * @throws AuthorizationException
     */
    public function edit($id)
    {

        $defaultLng = Auth::user()->latitude ?? geoip()->lat;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $defaultLat = Auth::user()->longitude ?? geoip()->lon;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $club = Club::findOrFail($id);
        $this->authorize('edit', [$club, Auth::user()]);

        $federations = Federation::fillSelect();
        $associations = Association::forUser(auth()->user())->pluck('name', 'id')->prepend('-', 0);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $users = Auth::user()->fillSelect();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return view('clubs.form', compact('club', 'users', 'associations', 'federations', 'defaultLng', 'defaultLat')); //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param ClubRequest|Request $request
     * @param  int $id
     * @return \Illuminate\Http\Response
     * @throws AuthorizationException
     */
    public function update(ClubRequest $request, $id)
    {
        $club = Club::findOrFail($id);

        $this->authorize('update', [$club, Auth::user()]);

        try {
            if ($request->president_id == 0) $request->merge(['president_id' => null]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($request->association_id == 0) $request->merge(['association_id' => null]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $club->update($request->all());
            $msg = trans('msg.club_edit_successful', ['name' => $club->name]);
            flash()->success($msg);

            return redirect("clubs");
        } catch (QueryException $e) {
            // Already
            $msg = "User" . $request->id . "is already president of another club";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            flash()->error($msg);

            return redirect()->back();
        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param $clubId
     * @return JsonResponse
     * @internal param Club $club
     */
    public function destroy($clubId)

    {
        $club = Club::find($clubId);
        if ($club->delete()) {
            return Response::json(['msg' => trans('msg.club_delete_successful', ['name' => $club->name]), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.club_delete_error', ['name' => $club->name]), 'status' => 'error']);
        }
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function restore($id)


    {
        $club = Club::withTrashed()->find($id);
        if ($club->restore()) {
            return Response::json(['msg' => trans('msg.club_restored_successful', ['name' => $club->name]), 'status' => 'success']);
        } else {
            return Response::json(['msg' => trans('msg.club_restored_error', ['name' => $club->name]), 'status' => 'error']);
        }
    }
}


Push — master ( 815d3e...28d501 )

ClubController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Association;
6			use App\Club;
7			use App\Federation;
8			use App\Http\Requests\ClubRequest;
9			use App\User;
10			use Illuminate\Auth\Access\AuthorizationException;
11			use Illuminate\Database\QueryException;
12			use Illuminate\Http\JsonResponse;
13			use Illuminate\Http\RedirectResponse;
14			use Illuminate\Support\Collection;
15			use Illuminate\Support\Facades\Auth;
16			use Illuminate\Support\Facades\Request;
17			use Illuminate\Support\Facades\View;
18			use Response;
19
20			class ClubController extends Controller
21			{
22			// Only Super Admin and Club President can manage Clubs
23
24			/**
25			* Display a listing of the resource.
26			*
27			* @return Collection\|View
28			*/
29			public function index()
30			{
31
32			if (Request::ajax()) {
33			return Club::fillSelect(Auth::user()->federation_id, Auth::user()->association_id);
			0 ignored issues – show Bug introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report Accessing `federation_id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Bug introduced 2017-10-06 15:51 UTC by Report Bug Copy Issue Report Accessing `association_id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34			} else {
35			$clubs = Club::with('president', 'association.federation')
36			->forUser(Auth::user())
37			->where('id', '>', 1)
38			->get();
39

xoco70 / kendozone

Push — master ( 815d3e...28d501 )

ClubController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like