App\Repositories\Eloquent\BaseRepository

Complexity

Total Complexity

10

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	pluck()	0	3	1
A	all()	0	3	1

<?php

namespace App\Repositories\Eloquent;


use App\Repositories\Contracts\RepositoryInterface;
use App\Repositories\Exceptions\RepositoryException;
use Illuminate\Container\Container as Application;
use Illuminate\Database\Eloquent\Model;

abstract class BaseRepository implements RepositoryInterface
{
    /**
     * @var Application
     */
    protected $app;
    /**
     * @var Model
     */
    protected $model;

    /**
     * @param Application $app
     */
    public function __construct(Application $app)
    {
        $this->app = $app;
        $this->makeModel();

    }

    /**
     * @return Model
     * @throws RepositoryException
     */
    public function makeModel()
    {
        $model = $this->app->make($this->model());
        if (!$model instanceof Model) {
            throw new RepositoryException("Class {$this->model()} must be an instance of Illuminate\\Database\\Eloquent\\Model");
        }
        return $this->model = $model;
    }

    /**
     * Specify Model class name
     *
     * @return string
     */
    abstract public function model();

    public function all($columns = array('*'))
    {
        return $this->model->get($columns);
    }

    public function create(array $columns)
    {
        return $this->model->create($columns);
    }

    public function findByField($field = null, $value = null, $columns = ['*'])
    {
        return $this->model->where($field, '=', $value)->get($columns);

    }

    public function find($value = null, $columns = ['*'])
    {
        return $this->model->where('id', '=', $value)->first($columns);

    }

    /**
     * Retrieve data array for populate field select
     *
     * @param string $column
     * @param string|null $key
     *
     * @return \Illuminate\Support\Collection|array
     */
    public function pluck($column, $key = null)
    {
        return $this->model->pluck($column, $key);
    }


    /**
     * Load relations
     *
     * @param array|string $relations
     *
     * @return $this
     */
    public function with($relations)
    {
        $this->model = $this->model->with($relations);

It seems like $this->model->with($relations) of type Illuminate\Database\Eloquent\Builder is incompatible with the declared type Illuminate\Database\Eloquent\Model of property $model.

        return $this;
    }


    public function orderBy($column, $direction = 'asc')
    {
        $this->model = $this->model->orderBy($column, $direction);

It seems like $this->model->orderBy($column, $direction) can also be of type Illuminate\Database\Eloquent\Builder or Illuminate\Database\Query\Builder. However, the property $model is declared as type Illuminate\Database\Eloquent\Model. Maybe add an additional type check?

        return $this;
    }

}