Sulao\LRTS\Routing\UriValidator::matches()

Complexity

Conditions	5
Paths	4

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function matches(
        \Illuminate\Routing\Route $route,
        \Illuminate\Http\Request $request
    ) {
        $match = parent::matches($route, $request);

        if ($match && in_array(Router::$mismatchAction, [404, 301, 302])) {
            $pathSlash = Helper::getTrailingSlashes($request->getPathInfo());
            $routeSlash = Helper::getTrailingSlashes($route->originalUri);

It seems like $route->originalUri can also be of type object; however, parameter $path of Sulao\LRTS\Helper::getTrailingSlashes() does only seem to accept string, maybe add an additional type check?

            if ($routeSlash !== $pathSlash) {
                if (Router::$mismatchAction == 404) {
                    abort(404);
                }

                $uri = $request->getUri();
                $arr = explode('?', $uri);
                $arr[0] = Helper::appendSlashes($arr[0], $route->originalUri);

It seems like $route->originalUri can also be of type object; however, parameter $origin of Sulao\LRTS\Helper::appendSlashes() does only seem to accept string, maybe add an additional type check?

                $uri = implode('?', $arr);

                abort(Router::$mismatchAction, '', ['Location' => $uri]);
            }
        }

        return $match;
    }