Sulao\LRTS\Routing\UrlGenerator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	toRoute()	0	11	2
A	to()	0	5	1

<?php

namespace Sulao\LRTS\Routing;

use Illuminate\Routing\Exceptions\UrlGenerationException;
use Illuminate\Routing\Route;
use Illuminate\Support\Str;
use Sulao\LRTS\Helper;

class UrlGenerator extends \Illuminate\Routing\UrlGenerator
{
    /**
     * Get the URL for a given route instance.
     *
     * @param  Route  $route
     * @param  mixed  $parameters
     * @param  bool  $absolute
     * @return string
     *
     * @throws UrlGenerationException
     */
    public function toRoute($route, $parameters, $absolute)
    {
        $url = parent::toRoute($route, $parameters, $absolute);

        if (Str::endsWith($route->originalUri, '/')) {

It seems like $route->originalUri can also be of type object; however, parameter $haystack of Illuminate\Support\Str::endsWith() does only seem to accept string, maybe add an additional type check?

            $arr = explode('?', $url);
            $arr[0] = Helper::appendSlashes($arr[0], $route->originalUri);

It seems like $route->originalUri can also be of type object; however, parameter $origin of Sulao\LRTS\Helper::appendSlashes() does only seem to accept string, maybe add an additional type check?

            $url = implode('?', $arr);
        }

        return $url;
    }

    /**
     * Generate an absolute URL to the given path.
     *
     * @param string    $path
     * @param mixed     $extra
     * @param bool|null $secure
     *
     * @return string
     */
    public function to($path, $extra = [], $secure = null)
    {
        return Helper::appendSlashes(
            parent::to($path, $extra, $secure),
            $path
        );
    }
}