SoapModelAccessTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	104
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getTestSoapConnection()	0	8	1
A	testApiAccess()	0	16	1
A	testAuthenticatedPUT()	0	50	1
A	testAuthenticatedPOST()	0	17	1

<?php
/**
 * @todo Test Relation getters
 * @todo Test filter and limit through GET params
 * @todo Test DELETE verb
 */
class SoapModelAccessTest extends SapphireTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static $fixture_file = 'SoapModelAccessTest.yml';

    protected $extraDataObjects = array(
        'SoapModelAccessTest_Comment',
        'SoapModelAccessTest_Page',
    );

    public function getTestSoapConnection()
    {
        // We can't actually test the SOAP server itself because there's not currently a way of putting it into "test mode"
        return new SOAPModelAccess();

        // One day, we should build this facility and then return something more like the item below:
        // return new SoapClient(Director::absoluteBaseURL() . 'soap/v1/wsdl');

50% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    public function testApiAccess()
    {
        $c = $this->getTestSoapConnection();
        $soapResponse = $c->getXML(
            'SoapModelAccessTest_Comment',
            1,
            null,
            null,
            'editor@test.com',
            'editor'

The call to SOAPModelAccess::getXML() has too many arguments starting with 'editor'.

        );

        $responseArr = Convert::xml2array($soapResponse);
        $this->assertEquals($responseArr['ID'], 1);

The method assertEquals() does not seem to exist on object<SoapModelAccessTest>.

        $this->assertEquals($responseArr['Name'], 'Joe');

The method assertEquals() does not seem to exist on object<SoapModelAccessTest>.

    }

    public function testAuthenticatedPUT()
    {
        $comment1 = $this->objFromFixture('SoapModelAccessTest_Comment', 'comment1');
        $comment1ID = $comment1->ID;

        // test wrong details
        $c = $this->getTestSoapConnection();

        $updateXML = <<<XML
<?xml version="1.0" encoding="UTF-8"?>
		<SoapModelAccessTest_Comment>
			<ID>$comment1ID</ID>
			<Name>Jimmy</Name>
		</SoapModelAccessTest_Comment>			
XML;

        $soapResponse = $c->putXML(
            'SoapModelAccessTest_Comment',
            $comment1->ID,
            null,
            $updateXML,
            'editor@test.com',
            'wrongpassword'
        );
        $this->assertEquals('<error type="authentication" code="401">Unauthorized</error>', $soapResponse);

The method assertEquals() does not seem to exist on object<SoapModelAccessTest>.

        // Check that the details weren't saved
        $c = $this->getTestSoapConnection();
        $soapResponse = $c->getXML('SoapModelAccessTest_Comment', $comment1->ID, null, 'editor@test.com', 'editor');
        $responseArr = Convert::xml2array($soapResponse);
        $this->assertEquals($comment1->ID, $responseArr['ID']);

The method assertEquals() does not seem to exist on object<SoapModelAccessTest>.

        $this->assertEquals('Joe', $responseArr['Name']);

The method assertEquals() does not seem to exist on object<SoapModelAccessTest>.

        // Now do an update with the right password
        $soapResponse = $c->putXML(

$soapResponse is not used, you could remove the assignment.

            'SoapModelAccessTest_Comment',
            $comment1->ID,
            null,
            $updateXML,
            'editor@test.com',
            'editor'
        );

        // Check that the details were saved
        $c = $this->getTestSoapConnection();
        $soapResponse = $c->getXML('SoapModelAccessTest_Comment', $comment1->ID, null, 'editor@test.com', 'editor');
        $responseArr = Convert::xml2array($soapResponse);
        $this->assertEquals($comment1->ID, $responseArr['ID']);

The method assertEquals() does not seem to exist on object<SoapModelAccessTest>.

        $this->assertEquals('Jimmy', $responseArr['Name']);

The method assertEquals() does not seem to exist on object<SoapModelAccessTest>.

    }

    public function testAuthenticatedPOST()
    {
        /*

61% of this comment could be valid code. Did you maybe forget this after debugging?

        $c = $this->getTestSoapConnection();
        $soapResponse = $c->getXML(
            "SoapModelAccessTest_Comment", 
            null,
            null,
            'editor@test.com',
            'editor'
        );
        Debug::message($soapResponse);
        $responseArr = Convert::xml2array($soapResponse);
        Debug::show($responseArr);
        $this->assertEquals($responseArr['Name'], 'Created Name');
        */
    }
}

/**
 * Everybody can view comments, logged in members in the "users" group can create comments,
 * but only "editors" can edit or delete them.
 */
class SoapModelAccessTest_Comment extends DataObject implements PermissionProvider,TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

Expected 1 space before "TestOnly"; 0 found

{
    public static $api_access = true;

    public static $db = array(
        'Name' => 'Varchar(255)',
        'Comment' => 'Text',
    );

    public static $has_many = array();

    public function providePermissions()
    {
        return array(
            'EDIT_Comment' => 'Edit Comment Objects',
            'CREATE_Comment' => 'Create Comment Objects',
            'DELETE_Comment' => 'Delete Comment Objects',
        );
    }

    public function canView($member = null)
    {
        return true;
    }

    public function canEdit($member = null)
    {
        return Permission::checkMember($member, 'EDIT_Comment');
    }

    public function canDelete($member = null)
    {
        return Permission::checkMember($member, 'DELETE_Comment');
    }

    public function canCreate($member = null)
    {
        return Permission::checkMember($member, 'CREATE_Comment');
    }
}

class SoapModelAccessTest_Page extends DataObject implements TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static $api_access = false;

    public static $db = array(
        'Title' => 'Text',
        'Content' => 'HTMLText',
    );
}