SapphireSoapServer

Complexity

Total Complexity

8

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	6

Importance

Changes	3
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	wsdl()	0	6	1
A	getWSDLURL()	0	4	1
B	Methods()	0	24	3
A	TargetNamespace()	0	4	1
A	ServiceURL()	0	4	1
A	index()	0	14	1

<?php
/**
 * Soap server class which auto-generates a WSDL
 * file to initialize PHPs integrated {@link SoapServer} class.
 *
 * See {@link SOAPModelAccess} for an auto-generated SOAP API for your models.
 *
 * @todo Improve documentation
 */
class SapphireSoapServer extends Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var array Map of method name to arguments.
     */
    private static $methods = array();

The property $methods is not used and could be removed.

    /**
     * @var array
     */
    private static $xsd_types = array(
        'int' => 'xsd:int',
        'boolean' => 'xsd:boolean',
        'string' => 'xsd:string',
        'binary' => 'xsd:base64Binary',
    );

    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'index',
        'wsdl',
    );

    public function wsdl()
    {
        $this->getResponse()->addHeader('Content-Type', 'text/xml; charset=utf-8');

        return $this->renderWith('SapphireSoapServer_wsdl');
    }

    /**
     * @return string
     */
    public function getWSDLURL()
    {
        return Director::absoluteBaseURLWithAuth().$this->Link().'wsdl';
    }

    /**
     * @return SS_List Collection of ArrayData elements describing
     *                 the method (keys: 'Name', 'Arguments', 'ReturnType')
     */
    public function Methods()
    {
        $methods = array();

        foreach ($this->stat('methods') as $methodName => $arguments) {

The expression $this->stat('methods') of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

            $returnType = $arguments['_returns'];
            unset($arguments['_returns']);

            $processedArguments = array();
            foreach ($arguments as $argument => $type) {
                $processedArguments[] = new ArrayData(array(
                    'Name' => $argument,
                    'Type' => self::$xsd_types[$type],
                ));
            }
            $methods[] = new ArrayData(array(
                'Name' => $methodName,
                'Arguments' => new ArrayList($processedArguments),
                'ReturnType' => self::$xsd_types[$returnType],
            ));
        }

        return new ArrayList($methods);
    }

    /**
     * @return string
     */
    public function TargetNamespace()
    {
        return Director::absoluteBaseURL();
    }

    /**
     * @return string
     */
    public function ServiceURL()
    {
        return Director::absoluteBaseURLWithAuth().$this->class.'/';
    }

    public function index()
    {
        $wsdl = $this->getViewer('wsdl')->process($this);
        $wsdlFile = TEMP_FOLDER.'/sapphire-wsdl-'.$this->class;
        $fh = fopen($wsdlFile, 'w');
        fwrite($fh, $wsdl);
        fclose($fh);

        $this->getResponse()->addHeader('Content-Type', 'text/xml; charset=utf-8');

        $s = new SoapServer($wsdlFile, array('cache_wsdl' => WSDL_CACHE_NONE));
        $s->setClass($this->class);
        $s->handle();
    }
}