xima-media / depmon

src/Service/Cache.php

<?php

namespace Xima\DepmonBundle\Service;

use Symfony\Component\Cache\Adapter\FilesystemAdapter;
use Symfony\Component\Cache\Simple\FilesystemCache;

/**
 * Class Cache
 * @package Xima\DepmonBundle\Service
 */
class Cache
{

    /**
     * @var FilesystemAdapter
     */
    private $cache;

    public function __construct($cacheDirectory = null)
    {
        if (!$cacheDirectory) {
            $cacheDirectory = __DIR__ . '/../../../../var/cache/app';
        }

        $this->cache = new FilesystemCache(

It seems like new Symfony\Component\Cache\Simple\FilesystemCache('depmon', 0, $cacheDirectory) of type Symfony\Component\Cache\Simple\FilesystemCache is incompatible with the declared type Symfony\Component\Cache\Adapter\FilesystemAdapter of property $cache.

            'depmon',
            0,
            $cacheDirectory
        );
    }

    /**
     *
     */
    public function get($key)
    {
        try {
            return $this->cache->get($key);

The call to Symfony\Component\Cache\Adapter\AbstractAdapter::get() has too few arguments starting with callback.

        } catch (\Psr\SimpleCache\InvalidArgumentException $e) {

Consider adding a comment why this CATCH block is empty.

        }
    }

    /**
     *
     */
    public function set($key, $value): bool
    {
        try {
            return $this->cache->set($key, $value);

The method set() does not exist on Symfony\Component\Cache\Adapter\FilesystemAdapter.

        } catch (\Psr\SimpleCache\InvalidArgumentException $e) {

Consider adding a comment why this CATCH block is empty.

        }

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

    }
}