Xgc\CarbonBundle\Form\DataTransformer\CarbonToArrayTransformer

Complexity

Total Complexity

2

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	reverseTransform()	0	9	2

<?php
declare(strict_types=1);

namespace Xgc\CarbonBundle\Form\DataTransformer;

use Carbon\Carbon;
use Symfony\Component\Form\Exception\TransformationFailedException;
use Symfony\Component\Form\Extension\Core\DataTransformer\DateTimeToArrayTransformer;

/**
 * Class CarbonToArrayTransformer
 *
 * @package Xgc\CarbonBundle\Form\DataTransformer
 */
class CarbonToArrayTransformer extends DateTimeToArrayTransformer
{
    /**
     * Transforms a localized date into a normalized date.
     *
     * @param array $value Localized date
     *
     * @return null|Carbon Normalized date
     * @throws TransformationFailedException
     *
     * @throws TransformationFailedException If the given value is not an array,
     *                                       if the value could not be transformed
     */
    public function reverseTransform($value): ?Carbon
    {
        $dateTime = parent::reverseTransform($value);

        if ($dateTime) {
            $dateTime = Carbon::instance($dateTime);
        }

        return $dateTime;

The expression return $dateTime could return the type DateTime which includes types incompatible with the type-hinted return null|Carbon\Carbon. Consider adding an additional type-check to rule them out.

    }
}