Issues in Css.php - All Issues - Inspection of "Developing" - xezzus/humanity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ffee62...1450e2 )

by Andrey

created 2016-01-07 07:29 UTC

Css.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace humanity;

class Css {

    public static $list = [];
    private static $host;
    private static $config;   

    public function __construct(){
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        # Config
        self::$config = (new Config)->get();
        # Host
        self::$host = parse_url('http://'.$_SERVER['HTTP_HOST']);
        if(isset(self::$host['host'])) self::$host = self::$host['host'];
        else self::$host = '/';
    }

    public function add($css){
        if(!is_array($css)) $css = [$css];
        self::$list = array_merge(self::$list,$css);
    }

    public function get(){

        $css = array_unique(self::$list);
        $code = '';
        foreach($css as $name){
            $file = self::$config['core']['css'].'/'.$name.'.css';
            if(is_file($file)) $code .= file_get_contents($file);
        }
        $minifier = new \MatthiasMullie\Minify\CSS();
        $minifier->add($code);
        $code = $minifier->minify();
        return "<style>$code</style>";
    }

    public function compile(){
        # ...
    }

}
?>



1		<?php
2		namespace humanity;
3
4		class Css {
5
6		public static $list = [];
7		private static $host;
8		private static $config;
9
10	View Code Duplication	public function __construct(){
		0 ignored issues – show Duplication introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
11		# Config
12		self::$config = (new Config)->get();
13		# Host
14		self::$host = parse_url('http://'.$_SERVER['HTTP_HOST']);
15		if(isset(self::$host['host'])) self::$host = self::$host['host'];
16		else self::$host = '/';
17		}
18
19		public function add($css){
20		if(!is_array($css)) $css = [$css];
21		self::$list = array_merge(self::$list,$css);
22		}
23
24	View Code Duplication	public function get(){
		0 ignored issues – show Duplication introduced 2016-01-03 11:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		$css = array_unique(self::$list);
26		$code = '';
27		foreach($css as $name){
28		$file = self::$config['core']['css'].'/'.$name.'.css';
29		if(is_file($file)) $code .= file_get_contents($file);
30		}
31		$minifier = new \MatthiasMullie\Minify\CSS();
32		$minifier->add($code);
33		$code = $minifier->minify();
34		return "<style>$code</style>";
35		}
36
37		public function compile(){
38		# ...
39		}
40
41		}
42		?>
		0 ignored issues – show Best Practice introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
43

xezzus / humanity

Push — master ( ffee62...1450e2 )

Css.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like