Uri::__construct() - Code Metrics - Inspection of "Developing" - xezzus/humanity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8dc597...ffee62 )

by Andrey

created 2016-01-07 07:25 UTC

Uri::__construct() A

↳ Parent: Uri

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	11
rs	9.4286
cc	3
eloc	9
nc	3
nop	0

<?php
namespace humanity;

class Uri {

    private $requestUri = '';

    public function __construct(){
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        $this->requestUri = $_SERVER['REQUEST_URI'];
        $tmp = explode('/',$this->requiestUri);

        foreach($tmp as $key=>$value){
            $value = trim($value);
            if(empty($value)) unset($tmp[$key]);
            else $tmp[$key] = $value;
        }
        $tmp = array_values($tmp);
        $this->requestUri = $tmp;

    }

    public function full(){
        return '/'.implode('/',$this->requestUri);
    }

    public function part($number){
        if(isset($this->requestUri[$number])) return (string) urldecode($this->requestUri[$number]);
        else return '';
    }

    public function host(){
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        return parse_url('http://'.$_SERVER['HTTP_HOST'])['host'];
    }

}
?>



1			<?php
2			namespace humanity;
3
4			class Uri {
5
6			private $requestUri = '';
7
8			public function __construct(){
			0 ignored issues – show Coding Style introduced 2016-01-07 07:28 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
9			$this->requestUri = $_SERVER['REQUEST_URI'];
10			$tmp = explode('/',$this->requiestUri);
			0 ignored issues – show Bug introduced 2016-01-07 07:28 UTC by Report Bug Copy Issue Report The property `requiestUri` does not seem to exist. Did you mean `requestUri`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
11			foreach($tmp as $key=>$value){
12			$value = trim($value);
13			if(empty($value)) unset($tmp[$key]);
14			else $tmp[$key] = $value;
15			}
16			$tmp = array_values($tmp);
17			$this->requestUri = $tmp;
			0 ignored issues – show Documentation Bug introduced 2016-01-07 07:28 UTC by Report Bug Copy Issue Report It seems like `$tmp` of type `array<integer,?>` is incompatible with the declared type `string` of property `$requestUri`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
18			}
19
20			public function full(){
21			return '/'.implode('/',$this->requestUri);
22			}
23
24			public function part($number){
25			if(isset($this->requestUri[$number])) return (string) urldecode($this->requestUri[$number]);
26			else return '';
27			}
28
29			public function host(){
			0 ignored issues – show Coding Style introduced 2016-01-07 07:28 UTC by Report Bug Copy Issue Report `host` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
30			return parse_url('http://'.$_SERVER['HTTP_HOST'])['host'];
31			}
32
33			}
34			?>
			0 ignored issues – show Best Practice introduced 2016-01-07 07:19 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
35

xezzus / humanity

Push — master ( 8dc597...ffee62 )

Uri::__construct() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like