Issues in Widget.php - Fixed Issues - Inspection of "Developing" - xezzus/humanity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 658920...8dc597 )

by Andrey

created 2016-01-07 07:22 UTC

Widget.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace humanity;

class Widget {

    public static $js;
    public static $css;
    private static $config;
    private static $app;
    private static $view;
    private static $property;
    private static $path;
    private static $uri;


    public function __construct(){
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        # Config
        self::$config = (new Config)->get();
        # Url
        self::$path = explode('/',parse_url(urldecode($_SERVER['REQUEST_URI']))['path']);
        foreach(self::$path as $key=>$value){
            $value = trim($value);
            if(empty($value)) unset(self::$path[$key]);
        }
        self::$path = array_values(self::$path);
        # Application
        self::$app = new Application;
        # View
        self::$view = new View;
        # Js
        self::$js = new Js;
        # Css
        self::$css = new Css;
    }

    public function __get($name){
        self::$property= $name;
        return new self;
    }

    public function __call($_name,$value){
        if(isset($value[0]) && !empty($value[0]) && is_array($value[0])) extract($value[0]);
        $file = self::$config['core']['widget'].'/'.self::$property.'/'.$_name.'.phtml';
        if(is_file($file)) require($file);
    }

}
?>


1			<?php
2			namespace humanity;
3
4			class Widget {
5
6			public static $js;
7			public static $css;
8			private static $config;
9			private static $app;
10			private static $view;
11			private static $property;
12			private static $path;
13			private static $uri;
			0 ignored issues – show Unused Code introduced 2016-01-07 07:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$uri` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14
15			public function __construct(){
			0 ignored issues – show Coding Style introduced 2016-01-03 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
16			# Config
17			self::$config = (new Config)->get();
18			# Url
19			self::$path = explode('/',parse_url(urldecode($_SERVER['REQUEST_URI']))['path']);
20			foreach(self::$path as $key=>$value){
21			$value = trim($value);
22			if(empty($value)) unset(self::$path[$key]);
23			}
24			self::$path = array_values(self::$path);
25			# Application
26			self::$app = new Application;
27			# View
28			self::$view = new View;
29			# Js
30			self::$js = new Js;
31			# Css
32			self::$css = new Css;
33			}
34
35			public function __get($name){
36			self::$property= $name;
37			return new self;
38			}
39
40			public function __call($_name,$value){
41			if(isset($value[0]) && !empty($value[0]) && is_array($value[0])) extract($value[0]);
42			$file = self::$config['core']['widget'].'/'.self::$property.'/'.$_name.'.phtml';
43			if(is_file($file)) require($file);
44			}
45
46			}
47			?>
48

xezzus / humanity

Push — master ( 658920...8dc597 )

Widget.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like