Xervice\Service\Lumen\ExceptionHandler\XerviceExceptionHandler::render()

Complexity

Conditions	3
Paths	4

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

0

<?php
    public function render($request, Exception $e): Response
    {
        $dataProvider = new ApiExceptionDataProvider();
        $dataProvider->setStatus($e->getCode())
            ->setException(get_class($e))
            ->setMessage($e->getMessage());

        if ($this->getFacade()->isDebug()) {

The method isDebug() does not exist on Xervice\Core\Facade\FacadeInterface. It seems like you code against a sub-type of Xervice\Core\Facade\FacadeInterface such as Xervice\Service\ServiceFacade.

            $dataProvider->setTrace($e->getTraceAsString());
        }

        $response = new JsonResponse();
        if (method_exists($e, 'getStatusCode')) {
            $response->setStatusCode($e->getStatusCode());
        } else {
            $response->setStatusCode(500);
        }

        $response->setData($dataProvider->toArray());

        return $response;

The expression return $response returns the type Illuminate\Http\JsonResponse which is incompatible with the type-hinted return Illuminate\Http\Response.

    }
}