Xervice\Processor\Business\Model\OutputHandler\RawJsonFileOutputHandler

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

92.31%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	validateHandler()	0	4	2
A	close()	0	3	1
A	init()	0	4	1
A	write()	0	3	1

<?php
declare(strict_types=1);

namespace Xervice\Processor\Business\Model\OutputHandler;


use DataProvider\ProcessRunDataProvider;
use Xervice\Processor\Business\Exception\ProcessException;

class RawJsonFileOutputHandler implements OutputHandlerInterface
{
    /**
     * @var resource
     */
    private $handler;

    /**
     * @param \DataProvider\ProcessRunDataProvider $runDataProvider
     *
     * @throws \Xervice\Processor\Business\Exception\ProcessException
     */
    public function init(ProcessRunDataProvider $runDataProvider): void
    {
        $this->handler = fopen($runDataProvider->getOutput(), 'w');

It seems like fopen($runDataProvider->getOutput(), 'w') can also be of type false. However, the property $handler is declared as type resource. Maybe add an additional type check?

        $this->validateHandler();
    }

    /**
     * @param array $data
     */
    public function write(array $data): void
    {
        fwrite($this->handler, json_encode($data));
    }

    public function close(): void
    {
        fclose($this->handler);
    }

    protected function validateHandler(): void
    {
        if (!$this->handler) {
            throw new ProcessException('Output file isn\'t writeable');
        }
    }

}