xchopin / LAWA-UL

src/TwigExtension/AuthExtension.php

<?php

/*
 * @author  Xavier Chopin <xavier.chopin@univ-lorraine.fr>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace App\TwigExtension;

use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Twig_Extension;
use Twig_SimpleFunction;

class AuthExtension extends Twig_Extension
{
    /**
     *
     * @var resource LDAP Instance
     */
    protected $ldap;

    /**
     * @var string Base Distinguished Name
     */
    protected $baseDN;

    /**
     * @var array List of the super admin written in app/config/parameters.yml
     */
    protected $administrators;

    /**
     * AuthExtension constructor.
     *
     * @param ContainerInterface $container
     */
    public function __construct(ContainerInterface $container)
    {
        $ldapInstance = ldap_connect(env('LDAP_HOST'), env('LDAP_PORT'));

It seems like env('LDAP_PORT') can also be of type string and boolean; however, parameter $port of ldap_connect() does only seem to accept integer, maybe add an additional type check?

        ldap_set_option($ldapInstance, LDAP_OPT_PROTOCOL_VERSION, 3);
        ldap_set_option($ldapInstance, LDAP_OPT_REFERRALS, 0);
        $container->set('ldap', /** @scrutinizer ignore-type */ $ldapInstance);
        $this->ldap = $ldapInstance;
        $this->baseDN = env('LDAP_BASE_DN');

It seems like env('LDAP_BASE_DN') can also be of type boolean. However, the property $baseDN is declared as type string. Maybe add an additional type check?

        $this->administrators = explode(',', env('ADMINISTRATORS'));
    }

    public function getName()
    {
        return 'auth';
    }

    public function getFunctions()
    {
        return [
            new Twig_SimpleFunction('auth', [$this, 'auth'])
        ];
    }

    public function auth()
    {
        $name = null;
        $logged = false;
        $isAdmin = false;
        $username = null;
        $viewAsMode = false;
        $originalUsername = null;

        if (isset($_SESSION['phpCAS']['user'])) {
            $logged = true;
            $username = $_SESSION['phpCAS']['user'];
            $query = ldap_search($this->ldap, $this->baseDN, "uid=$username");
            $name = ldap_get_entries($this->ldap, $query)[0]['displayname'][0];
            $isAdmin = (in_array($username, $this->administrators));

            if (isset($_SESSION['username'])) {
                $viewAsMode = true;
                $originalUsername = $_SESSION['username'];
            }
        }

        return (object)
        [
            'isLogged' => $logged,
            'isAdmin' =>  $isAdmin,
            'username' => $username,
            'name' => $name,
            'viewAsMode' => $viewAsMode,
            'originalUsername' => $originalUsername
        ];
    }
}