App\Controller\UserController::profile()

Complexity

Conditions	8
Paths	3

Size

Total Lines	44
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function profile(Request $request)

The parameter $request is not used and could be removed.

    {
        $user = User::find(self::loggedUser());

        if ($user === null) {
            $this->addFlash('error', "Student does not exist");
            return $this->redirectToRoute('home');
        }

        $events['all'] = User::eventsFrom(self::loggedUser(), date('Y-m-d H:i', strtotime("-1 week")));

$events was never initialized. Although not strictly required by PHP, it is generally a good practice to add $events = array(); before regardless.

        $events['cas'] = null;
        $events['moodle'] = null;

        if ($events['all'] != null) {
            usort($events['all'], function ($a, $b) {
                return $a->eventTime < $b->eventTime;
            });

            for ($i = 7; $i >= 0; $i--) {
                $cas_events[date('Y-m-d', strtotime("-$i day"))] = [];
                $moodle_events[date('Y-m-d', strtotime("-$i day"))] = [];
            }

            foreach ($events['all'] as $event) {
                $date = date('Y-m-d', strtotime($event->eventTime));
                if ($event->object->{'@type'} == 'SoftwareApplication') {
                    if (array_key_exists($date, $cas_events))

The variable $cas_events does not seem to be defined for all execution paths leading up to this point.

                        array_push($cas_events[$date], $event);
                } else {
                    if (array_key_exists($date, $moodle_events))

The variable $moodle_events does not seem to be defined for all execution paths leading up to this point.

                        array_push($moodle_events[$date], $event);
                }
            }

            $events['cas'] = $cas_events;
            $events['moodle'] = $moodle_events;

        }


        return $this->render('User/profile.twig', [
            'givenName' => $user->givenName,
            'events' => $events
        ]);
}