Iban::validateCountryCodeFormat() - Code Metrics - Inspection of "Use project phpunit instead of travis global phpun..." - xafardero/generate-iban - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

unknown

created 2017-02-01 17:27 UTC

Iban::validateCountryCodeFormat() A

↳ Parent: Iban

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	3
nc	2
nop	1

<?php

namespace IbanGenerator;

use IbanGenerator\Bban\BbanInterface;
use IbanGenerator\Bban\SpainBban;
use InvalidArgumentException;

class Iban
{
    /**
     * @var BbanInterface
     */
    private $bban;

    /**
     * @var string
     */
    private $countryCode;

    /**
     * @var string
     */
    private $checkDigits;

    /**
     * @var array
     */
    private static $countriesSupported = [
        'ES' => SpainBban::class,
    ];

    /**
     * Iban constructor.
     *
     * @param string $countryCode
     * @param string $checkDigits
     * @param BbanInterface $bban
     *
     * @throws InvalidArgumentException
     */
    public function __construct($countryCode, $checkDigits, BbanInterface $bban)
    {
        $countryCode = strtoupper($countryCode);
        static::validateCountryCodeFormat($countryCode);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        static::validateCheckDigitsFormat($checkDigits);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        static::validateControlDigit($countryCode, $checkDigits, $bban);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        $this->countryCode = $countryCode;
        $this->checkDigits = $checkDigits;
        $this->bban = $bban;
    }

    /**
     * @param string $iban
     *
     * @throws InvalidArgumentException
     *
     * @return static
     */
    public static function fromString($iban)
    {
        if (! preg_match('/^[0-9A-Z]{16,34}$/', $iban)) {
            throw new InvalidArgumentException('Iban should be between 16 and 34 characters');
        }

        $countryCode = substr($iban, 0, 2);
        $checkDigits = substr($iban, 2, 2);
        $bbanString = substr($iban, 4);

        if (! array_key_exists($countryCode, self::$countriesSupported)) {
            throw new InvalidArgumentException(
                sprintf(
                    'The country code %s is not supported',
                    $countryCode
                )
            );
        }
        $bbanClass = self::$countriesSupported[$countryCode];

        /**
         * @var BbanInterface
         */
        $bban = $bbanClass::fromString($bbanString);

        return new static($countryCode, $checkDigits, $bban);
    }

    /**
     * @return string
     */
    public function countryCode()
    {
        return $this->countryCode;
    }

    /**
     * @return string
     */
    public function ibanCheckDigits()
    {
        return $this->checkDigits;
    }

    /**
     * @return string
     */
    public function bankCode()
    {
        return $this->bban->bankCode();
    }

    /**
     * @return string
     */
    public function branchCode()
    {
        return $this->bban->branchCode();
    }

    /**
     * @return string
     */
    public function countryCheckDigits()
    {
        return $this->bban->checkDigits();
    }

    /**
     * @return string
     */
    public function accountNumber()
    {
        return $this->bban->accountNumber();
    }

    /**
     * @return string
     */
    public function __toString()
    {
        $bbanString = $this->bban;

        return $this->countryCode . $this->checkDigits . $bbanString;
    }

    /**
     * @param $countryCode
     *
     * @throws InvalidArgumentException
     */
    private static function validateCountryCodeFormat($countryCode)
    {
        if (! preg_match('/^[A-Z]{2}$/', $countryCode)) {
            throw new InvalidArgumentException('The country code should be 2 letters');
        }
    }

    /**
     * @param $checkDigits
     *
     * @throws InvalidArgumentException
     */
    private static function validateCheckDigitsFormat($checkDigits)
    {
        if (! preg_match('/^[\d]{2}$/', $checkDigits)) {
            throw new InvalidArgumentException('The IBAN checksum must be 2 numeric characters');
        }
    }

    /**
     * @param string $countryCode
     * @param string $checkDigits
     * @param BbanInterface $bban
     *
     * @throws InvalidArgumentException
     */
    private static function validateControlDigit(
        $countryCode,
        $checkDigits,
        BbanInterface $bban
    ) {
        $rearranged = strval($bban) . $countryCode . $checkDigits;
        $digitsList = str_split($rearranged);

        $digitsList = array_map(['self', 'digitToInt'], $digitsList);
        $stringToCompute = implode('', $digitsList);

        if (bcmod($stringToCompute, '97') !== '1') {
            throw new InvalidArgumentException('The IBAN checksum digits are not valid');
        }
    }

    /**
     * @param string $value
     *
     * @return int
     */
    private static function digitToInt($value)

    {
        if (is_numeric($value)) {
            return intval($value);
        }

        return ord($value) - 55;
    }
}


1			<?php
2
3			namespace IbanGenerator;
4
5			use IbanGenerator\Bban\BbanInterface;
6			use IbanGenerator\Bban\SpainBban;
7			use InvalidArgumentException;
8
9			class Iban
10			{
11			/**
12			* @var BbanInterface
13			*/
14			private $bban;
15
16			/**
17			* @var string
18			*/
19			private $countryCode;
20
21			/**
22			* @var string
23			*/
24			private $checkDigits;
25
26			/**
27			* @var array
28			*/
29			private static $countriesSupported = [
30			'ES' => SpainBban::class,
31			];
32
33			/**
34			* Iban constructor.
35			*
36			* @param string $countryCode
37			* @param string $checkDigits
38			* @param BbanInterface $bban
39			*
40			* @throws InvalidArgumentException
41			*/
42			public function __construct($countryCode, $checkDigits, BbanInterface $bban)
43			{
44			$countryCode = strtoupper($countryCode);
45			static::validateCountryCodeFormat($countryCode);
			0 ignored issues – show Bug introduced 2017-02-01 17:31 UTC by Report Bug Copy Issue Report Since `validateCountryCodeFormat()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `validateCountryCodeFormat()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
46			static::validateCheckDigitsFormat($checkDigits);
			0 ignored issues – show Bug introduced 2017-02-01 17:31 UTC by Report Bug Copy Issue Report Since `validateCheckDigitsFormat()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `validateCheckDigitsFormat()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
47			static::validateControlDigit($countryCode, $checkDigits, $bban);
			0 ignored issues – show Bug introduced 2017-02-01 17:31 UTC by Report Bug Copy Issue Report Since `validateControlDigit()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `validateControlDigit()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
48			$this->countryCode = $countryCode;
49			$this->checkDigits = $checkDigits;
50			$this->bban = $bban;
51			}
52
53			/**
54			* @param string $iban
55			*
56			* @throws InvalidArgumentException
57			*
58			* @return static
59			*/
60			public static function fromString($iban)
61			{
62			if (! preg_match('/^[0-9A-Z]{16,34}$/', $iban)) {
63			throw new InvalidArgumentException('Iban should be between 16 and 34 characters');
64			}
65
66			$countryCode = substr($iban, 0, 2);
67			$checkDigits = substr($iban, 2, 2);
68			$bbanString = substr($iban, 4);
69
70			if (! array_key_exists($countryCode, self::$countriesSupported)) {
71			throw new InvalidArgumentException(
72			sprintf(
73			'The country code %s is not supported',
74			$countryCode
75			)
76			);
77			}
78			$bbanClass = self::$countriesSupported[$countryCode];
79
80			/**
81			* @var BbanInterface
82			*/
83			$bban = $bbanClass::fromString($bbanString);
84
85			return new static($countryCode, $checkDigits, $bban);
86			}
87
88			/**
89			* @return string
90			*/
91			public function countryCode()
92			{
93			return $this->countryCode;
94			}
95
96			/**
97			* @return string
98			*/
99			public function ibanCheckDigits()
100			{
101			return $this->checkDigits;
102			}
103
104			/**
105			* @return string
106			*/
107			public function bankCode()
108			{
109			return $this->bban->bankCode();
110			}
111
112			/**
113			* @return string
114			*/
115			public function branchCode()
116			{
117			return $this->bban->branchCode();
118			}
119
120			/**
121			* @return string
122			*/
123			public function countryCheckDigits()
124			{
125			return $this->bban->checkDigits();
126			}
127
128			/**
129			* @return string
130			*/
131			public function accountNumber()
132			{
133			return $this->bban->accountNumber();
134			}
135
136			/**
137			* @return string
138			*/
139			public function __toString()
140			{
141			$bbanString = $this->bban;
142
143			return $this->countryCode . $this->checkDigits . $bbanString;
144			}
145
146			/**
147			* @param $countryCode
148			*
149			* @throws InvalidArgumentException
150			*/
151			private static function validateCountryCodeFormat($countryCode)
152			{
153			if (! preg_match('/^[A-Z]{2}$/', $countryCode)) {
154			throw new InvalidArgumentException('The country code should be 2 letters');
155			}
156			}
157
158			/**
159			* @param $checkDigits
160			*
161			* @throws InvalidArgumentException
162			*/
163			private static function validateCheckDigitsFormat($checkDigits)
164			{
165			if (! preg_match('/^[\d]{2}$/', $checkDigits)) {
166			throw new InvalidArgumentException('The IBAN checksum must be 2 numeric characters');
167			}
168			}
169
170			/**
171			* @param string $countryCode
172			* @param string $checkDigits
173			* @param BbanInterface $bban
174			*
175			* @throws InvalidArgumentException
176			*/
177			private static function validateControlDigit(
178			$countryCode,
179			$checkDigits,
180			BbanInterface $bban
181			) {
182			$rearranged = strval($bban) . $countryCode . $checkDigits;
183			$digitsList = str_split($rearranged);
184
185			$digitsList = array_map(['self', 'digitToInt'], $digitsList);
186			$stringToCompute = implode('', $digitsList);
187
188			if (bcmod($stringToCompute, '97') !== '1') {
189			throw new InvalidArgumentException('The IBAN checksum digits are not valid');
190			}
191			}
192
193			/**
194			* @param string $value
195			*
196			* @return int
197			*/
198			private static function digitToInt($value)
			0 ignored issues – show Unused Code introduced 2017-02-01 17:31 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
199			{
200			if (is_numeric($value)) {
201			return intval($value);
202			}
203
204			return ord($value) - 55;
205			}
206			}
207

xafardero / generate-iban

GitHub Access Token became invalid

Pull Request — master (#3)

Iban::validateCountryCodeFormat() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like