Xabbuh\PandaBundle\Command\ModifyCloudCommandTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	16	1
B	execute()	0	37	6

<?php

/*
 * This file is part of the XabbuhPandaBundle package.
 *
 * (c) Christian Flothmann <christian.flothmann@xabbuh.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Xabbuh\PandaBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

if (class_exists(ContainerAwareCommand::class)) {
    /**
     * Modify a panda cloud via command-line.
     *
     * @author Christian Flothmann <christian.flothmann@xabbuh.de>
     *
     * @final since 1.5
     */
    class ModifyCloudCommand extends ContainerAwareCommand
    {
        use ModifyCloudCommandTrait;

        protected static $defaultName = 'panda:cloud:modify';
    }
} else {
    /**
     * Modify a panda cloud via command-line.
     *
     * @author Christian Flothmann <christian.flothmann@xabbuh.de>
     *
     * @final since 1.5
     */
    class ModifyCloudCommand extends Command

The type Xabbuh\PandaBundle\Command\ModifyCloudCommand has been defined more than once; this definition is ignored, only the first definition in this file (L30-35) is considered.

    {
        use ModifyCloudCommandTrait;

        protected static $defaultName = 'panda:cloud:modify';

        private $container;

        public function setContainer(ContainerInterface $container = null)
        {
            $this->container = $container;
        }

        public function getContainer()
        {
            return $this->container;
        }
    }
}

trait ModifyCloudCommandTrait
{
    /**
     * {@inheritDoc}
     */
    protected function configure()
    {
        $this->setName(static::$defaultName); // BC with Symfony Console 3.3 and older not handling the property automatically

It seems like setName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->setDescription('Modify a cloud');

It seems like setDescription() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->addOption(

It seems like addOption() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'account',
            'a',
            InputOption::VALUE_REQUIRED,
            'The account to use to authenticate to the panda service'
        );
        $this->addOption('name', null, InputOption::VALUE_REQUIRED, 'The new cloud name');

It seems like addOption() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->addOption('s3-bucket', null, InputOption::VALUE_REQUIRED, 'The new AWS S3 bucket');

It seems like addOption() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->addOption('access-key', null, InputOption::VALUE_REQUIRED, 'The new access key');

It seems like addOption() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->addOption('secret-key', null, InputOption::VALUE_REQUIRED, 'The new secret key');

It seems like addOption() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->addArgument('cloud-id', InputArgument::REQUIRED, 'The id of the cloud being modified');

It seems like addArgument() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * {@inheritDoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $data = array();

        // change the cloud name
        if ($name = $input->getOption('name')) {
            $data['name'] = $name;
        }

        // change the s3 bucket
        if ($s3bucket = $input->getOption('s3-bucket')) {
            $data['s3_videos_bucket'] = $s3bucket;
        }

        // change the access key
        if ($accessKey = $input->getOption('access-key')) {
            $data['aws_access_key'] = $accessKey;
        }

        // change the secret key
        if ($secretKey = $input->getOption('secret-key')) {
            $data['aws_secret_key'] = $secretKey;
        }

        // if anything has changed
        if (count($data) > 0) {
            // push these changes to the panda service
            $cloudFactory = $this->getContainer()->get('xabbuh_panda.cloud_factory');

It seems like getContainer() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $cloud = $cloudFactory->get(
                $input->getArgument('cloud-id'),
                $input->getOption('account')
            );
            $cloud->setCloud($data, $input->getArgument('cloud-id'));
        }

        return 0;
    }
}