XabbuhPandaExtension::loadAccounts() - Code Metrics - Inspection of "drop Symfony < 2.8 support" - xabbuh/PandaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b65bd1...2051f3 )

by Christian

created 2017-05-23 19:01 UTC

XabbuhPandaExtension::loadAccounts() B

↳ Parent: XabbuhPandaExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	14
cts	14
cp	1
rs	8.9713
c	0
b	0
f	0
cc	2
eloc	14
nc	2
nop	2
crap	2

<?php

/*
 * This file is part of the XabbuhPandaBundle package.
 *
 * (c) Christian Flothmann <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Xabbuh\PandaBundle\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;

/**
 * XabbuhPandaExtension.
 *
 * @author Christian Flothmann <[email protected]>
 */
class XabbuhPandaExtension extends Extension
{
    /**
     * {@inheritDoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $configuration = new Configuration();
        $config = $this->processConfiguration($configuration, $configs);

        $container->setParameter(
            'xabbuh_panda.video_uploader.multiple_files',
            $config['video_uploader']['multiple_files']
        );
        $container->setParameter(
            'xabbuh_panda.video_uploader.cancel_button',
            $config['video_uploader']['cancel_button']
        );
        $container->setParameter(
            'xabbuh_panda.video_uploader.progress_bar',
            $config['video_uploader']['progress_bar']
        );

        $container->setParameter('xabbuh_panda.account.default', $config['default_account']);
        $container->setParameter('xabbuh_panda.cloud.default', $config['default_cloud']);

        // and load the service definitions
        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
        $loader->load('account_manager.xml');
        $loader->load('cloud_manager.xml');
        $loader->load('cloud_factory.xml');
        $loader->load('controller.xml');
        $loader->load('transformers.xml');
        $loader->load('video_uploader_extension.xml');

        $this->loadAccounts($config['accounts'], $container);
        $this->loadClouds($config['clouds'], $container);
    }

    private function loadAccounts(array $accounts, ContainerBuilder $container)
    {
        $accountManagerDefinition = $container->getDefinition('xabbuh_panda.account_manager');

        foreach ($accounts as $name => $accountConfig) {
            // register each account as a service
            $accountDefinition = new Definition(
                'Xabbuh\PandaClient\Api\Account',
                array(
                    $accountConfig['access_key'],
                    $accountConfig['secret_key'],
                    $accountConfig['api_host']
                )
            );
            $id = 'xabbuh_panda.'.strtr($name, ' -', '_').'_account';
            $container->setDefinition($id, $accountDefinition);

            // and pass it to the manager's registerAccount() method
            $accountManagerDefinition->addMethodCall(
                'registerAccount',
                array($name, new Reference($id))
            );
        }
    }

    private function loadClouds(array $clouds, ContainerBuilder $container)
    {
        $cloudManagerDefinition = $container->getDefinition('xabbuh_panda.cloud_manager');

        foreach ($clouds as $name => $cloudConfig) {
            // register each cloud as a service
            $cloudDefinition = new Definition(
                'Xabbuh\PandaClient\Api\Cloud',
                array(
                    $cloudConfig['id'],
                    isset($cloudConfig['account']) ? $cloudConfig['account'] : null,
                )
            );
            $cloudDefinition->setFactory(array(new Reference('xabbuh_panda.cloud_factory'), 'get'));

            $id = 'xabbuh_panda.'.strtr($name, ' -', '_').'_cloud';
            $container->setDefinition($id, $cloudDefinition);

            // and pass it to the manager's registerAccount() method
            $cloudManagerDefinition->addMethodCall(
                'registerCloud',
                array($name, new Reference($id))
            );
        }
    }

    /**
     * {@inheritDoc}
     */
    public function getNamespace()
    {
        return 'http://xabbuh.de/schema/dic/xabbuh/panda';
    }

    /**
     * {@inheritDoc}
     */
    public function getXsdValidationBasePath()
    {
        return __DIR__.'/../Resources/config/schema';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php
2
3		/*
4		* This file is part of the XabbuhPandaBundle package.
5		*
6		* (c) Christian Flothmann <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Xabbuh\PandaBundle\DependencyInjection;
13
14		use Symfony\Component\Config\FileLocator;
15		use Symfony\Component\DependencyInjection\ContainerBuilder;
16		use Symfony\Component\DependencyInjection\Definition;
17		use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
18		use Symfony\Component\DependencyInjection\Reference;
19		use Symfony\Component\HttpKernel\DependencyInjection\Extension;
20
21		/**
22		* XabbuhPandaExtension.
23		*
24		* @author Christian Flothmann <[email protected]>
25		*/
26		class XabbuhPandaExtension extends Extension
27		{
28		/**
29		* {@inheritDoc}
30		*/
31	4	public function load(array $configs, ContainerBuilder $container)
32		{
33	4	$configuration = new Configuration();
34	4	$config = $this->processConfiguration($configuration, $configs);
35
36	4	$container->setParameter(
37	4	'xabbuh_panda.video_uploader.multiple_files',
38	4	$config['video_uploader']['multiple_files']
39		);
40	4	$container->setParameter(
41	4	'xabbuh_panda.video_uploader.cancel_button',
42	4	$config['video_uploader']['cancel_button']
43		);
44	4	$container->setParameter(
45	4	'xabbuh_panda.video_uploader.progress_bar',
46	4	$config['video_uploader']['progress_bar']
47		);
48
49	4	$container->setParameter('xabbuh_panda.account.default', $config['default_account']);
50	4	$container->setParameter('xabbuh_panda.cloud.default', $config['default_cloud']);
51
52		// and load the service definitions
53	4	$loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
54	4	$loader->load('account_manager.xml');
55	4	$loader->load('cloud_manager.xml');
56	4	$loader->load('cloud_factory.xml');
57	4	$loader->load('controller.xml');
58	4	$loader->load('transformers.xml');
59	4	$loader->load('video_uploader_extension.xml');
60
61	4	$this->loadAccounts($config['accounts'], $container);
62	4	$this->loadClouds($config['clouds'], $container);
63	4	}
64
65	4	private function loadAccounts(array $accounts, ContainerBuilder $container)
66		{
67	4	$accountManagerDefinition = $container->getDefinition('xabbuh_panda.account_manager');
68
69	4	foreach ($accounts as $name => $accountConfig) {
70		// register each account as a service
71	1	$accountDefinition = new Definition(
72	1	'Xabbuh\PandaClient\Api\Account',
73		array(
74	1	$accountConfig['access_key'],
75	1	$accountConfig['secret_key'],
76	1	$accountConfig['api_host']
77		)
78		);
79	1	$id = 'xabbuh_panda.'.strtr($name, ' -', '_').'_account';
80	1	$container->setDefinition($id, $accountDefinition);
81
82		// and pass it to the manager's registerAccount() method
83	1	$accountManagerDefinition->addMethodCall(
84	1	'registerAccount',
85	1	array($name, new Reference($id))
86		);
87		}
88	4	}
89
90	4	private function loadClouds(array $clouds, ContainerBuilder $container)
91		{
92	4	$cloudManagerDefinition = $container->getDefinition('xabbuh_panda.cloud_manager');
93
94	4	foreach ($clouds as $name => $cloudConfig) {
95		// register each cloud as a service
96	2	$cloudDefinition = new Definition(
97	2	'Xabbuh\PandaClient\Api\Cloud',
98		array(
99	2	$cloudConfig['id'],
100	2	isset($cloudConfig['account']) ? $cloudConfig['account'] : null,
101		)
102		);
103	2	$cloudDefinition->setFactory(array(new Reference('xabbuh_panda.cloud_factory'), 'get'));
104
105	2	$id = 'xabbuh_panda.'.strtr($name, ' -', '_').'_cloud';
106	2	$container->setDefinition($id, $cloudDefinition);
107
108		// and pass it to the manager's registerAccount() method
109	2	$cloudManagerDefinition->addMethodCall(
110	2	'registerCloud',
111	2	array($name, new Reference($id))
112		);
113		}
114	4	}
115
116		/**
117		* {@inheritDoc}
118		*/
119	4	public function getNamespace()
120		{
121	4	return 'http://xabbuh.de/schema/dic/xabbuh/panda';
122		}
123
124		/**
125		* {@inheritDoc}
126		*/
127		public function getXsdValidationBasePath()
128		{
129		return __DIR__.'/../Resources/config/schema';
		0 ignored issues – show Bug Best Practice introduced 2015-11-26 22:49 UTC by Report Bug Copy Issue Report The return type of `return __DIR__ . '/../Resources/config/schema';` (`string`) is incompatible with the return type of the parent method `Symfony\Component\Depend...etXsdValidationBasePath` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
130		}
131		}
132

xabbuh / PandaBundle

Push — master ( b65bd1...2051f3 )

XabbuhPandaExtension::loadAccounts() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like