Xabbuh\PandaBundle\Command\EncodingInfoCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

5

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	11	1
A	doExecuteCommand()	0	32	2

<?php

/*
 * This file is part of the XabbuhPandaBundle package.
 *
 * (c) Christian Flothmann <christian.flothmann@xabbuh.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Xabbuh\PandaBundle\Command;

use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Fetch an encoding's data.
 *
 * @author Christian Flothmann <christian.flothmann@xabbuh.de>
 */
final class EncodingInfoCommand extends CloudCommand
{
    protected static $defaultName = 'panda:encoding:info';

    /**
     * {@inheritDoc}
     */
    protected function configure()
    {
        $this->setDescription('Fetch information for an encoding');
        $this->addArgument(
            'encoding-id',
            InputArgument::REQUIRED,
            'The id of the encoding being fetched'
        );

        parent::configure();
    }

    /**
     * {@inheritDoc}
     */
    protected function doExecuteCommand(InputInterface $input, OutputInterface $output)
    {
        $cloud = $this->getCloud($input);
        $encoding = $cloud->getEncoding($input->getArgument('encoding-id'));

It seems like $input->getArgument('encoding-id') targeting Symfony\Component\Console\Input\InputInterface::getArgument() can also be of type array<integer,string> or null; however, Xabbuh\PandaClient\Api\CloudInterface::getEncoding() does only seem to accept string, maybe add an additional type check?

        $table = new Table($output);
        $table->addRows(array(
            array('id', $encoding->getId()),
            array('video id', $encoding->getVideoId()),
            array('file extension', $encoding->getExtname()),
            array('profile id', $encoding->getProfileId()),
            array('profile name', $encoding->getProfileName()),
            array('path', $encoding->getPath()),
            array('width', $encoding->getWidth()),
            array('height', $encoding->getHeight()),
            array('audio bit rate', $encoding->getAudioBitrate()),
            array('video bit rate', $encoding->getVideoBitrate()),
            array('status', $encoding->getStatus()),
        ));

        if ('fail' === $encoding->getStatus()) {
            $table->addRow(array('error message', $encoding->getErrorMessage()));
        }

        $table->addRows(array(
            array('encoding progress', $encoding->getEncodingProgress()),
            array('encoding started', $encoding->getStartedEncodingAt()),
            array('encoding time', $encoding->getEncodingTime()),
            array('created at', $encoding->getCreatedAt()),
            array('updated at', $encoding->getUpdatedAt()),
        ));
        $table->render($output);

The call to Table::render() has too many arguments starting with $output.

    }
}