Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 6 | class xKerman_Restricted_ExpressionParser implements xKerman_Restricted_ParserInterface |
||
|
|
|||
| 7 | { |
||
| 8 | /** @var array $handlers handlers list to use */ |
||
| 9 | private $handlers; |
||
| 10 | /** |
||
| 11 | * constructor |
||
| 12 | */ |
||
| 13 | public function __construct() |
||
| 17 | /** |
||
| 18 | * parse given `$source` as PHP serialized value |
||
| 19 | * |
||
| 20 | * @param Source $source parser input |
||
| 21 | * @return array |
||
| 22 | * @throws UnserializeFailedException |
||
| 23 | */ |
||
| 24 | View Code Duplication | public function parse(xKerman_Restricted_Source $source) |
|
| 42 | } |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.