xKerman_Restricted_ArrayHandler

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	handle()	12	12	2
A	parseKey()	8	8	3

<?php

/**
 * Handler for PHP serialiezed array
 */
class xKerman_Restricted_ArrayHandler implements xKerman_Restricted_HandlerInterface

This class seems to be duplicated in your project.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /** @var ParserInterface $expressionParser parser for unserialize expression */
    private $expressionParser;
    /** @var integer */
    const CLOSE_BRACE_LENGTH = 1;
    /**
     * constructor
     *
     * @param ParserInterface $expressionParser parser for unserialize expression

Should the type for parameter $expressionParser not be xKerman_Restricted_ParserInterface?

     */
    public function __construct(xKerman_Restricted_ParserInterface $expressionParser)
    {
        $this->expressionParser = $expressionParser;

It seems like $expressionParser of type object<xKerman_Restricted_ParserInterface> is incompatible with the declared type object<ParserInterface> of property $expressionParser.

    }
    /**
     * parse given `$source` as PHP serialized array
     *
     * @param Source $source parser input

Should the type for parameter $source not be xKerman_Restricted_Source?

     * @param string $args   array length
     * @return array
     * @throws UnserializeFailedException
     */
    public function handle(xKerman_Restricted_Source $source, $args)
    {
        $length = intval($args, 10);
        $result = array();
        for ($i = 0; $i < $length; ++$i) {
            list($key, $source) = $this->parseKey($source);
            list($value, $source) = $this->expressionParser->parse($source);
            $result[$key] = $value;
        }
        $source->consume('}', self::CLOSE_BRACE_LENGTH);
        return array($result, $source);
    }
    /**
     * parse given `$source` as array key (s.t. integer|string)
     *
     * @param Source $source input
     * @return array
     * @throws UnserializeFailedException
     */
    private function parseKey($source)
    {
        list($key, $source) = $this->expressionParser->parse($source);
        if (!is_integer($key) && !is_string($key)) {
            return $source->triggerError();
        }
        return array($key, $source);
    }
}