Issues in DefaultController.php (main) - Issues in main - x-tools/xtools - Measure and Improve Code Quality continuously with Scrutinizer

Issues (196)

Security Analysis 6 potential vulnerabilities

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection (4)

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection (1)

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection (1)

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller/DefaultController.php (5 issues)

Labels

Severity

<?php

declare(strict_types=1);

namespace App\Controller;

use App\Model\Edit;
use App\Repository\ProjectRepository;
use MediaWiki\OAuthClient\Client;
use MediaWiki\OAuthClient\ClientConfig;
use MediaWiki\OAuthClient\Consumer;
use MediaWiki\OAuthClient\Exception;
use MediaWiki\OAuthClient\Token;
use OpenApi\Annotations as OA;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

/**
 * The DefaultController handles the homepage, about pages, and user authentication.
 */
class DefaultController extends XtoolsController
{
    /** @var Client The Oauth HTTP client. */
    protected Client $oauthClient;

    /**
     * Required to be defined by XtoolsController, though here it is unused.
     * @inheritDoc
     * @codeCoverageIgnore
     */
    public function getIndexRoute(): string
    {
        return 'homepage';
    }

    /**
     * Display the homepage.
     * @Route("/", name="homepage")
     * @Route("/index.php", name="homepageIndexPhp")
     * @return Response
     */
    public function indexAction(): Response
    {
        return $this->render('default/index.html.twig', [
            'xtPage' => 'home',
        ]);
    }

    /**
     * Redirect to the default project (or Meta) for Oauth authentication.
     * @Route("/login", name="login")
     * @param Request $request
     * @param RequestStack $requestStack
     * @param ProjectRepository $projectRepo
     * @param string $centralAuthProject
     * @return RedirectResponse
     * @codeCoverageIgnore
     */
    public function loginAction(
        Request $request,
        RequestStack $requestStack,
        ProjectRepository $projectRepo,
        string $centralAuthProject
    ): RedirectResponse {
        try {
            [ $next, $token ] = $this->getOauthClient($request, $projectRepo, $centralAuthProject)->initiate();
        } catch (Exception $oauthException) {
            $this->addFlashMessage('notice', 'error-login');
            return $this->redirectToRoute('homepage');
        }

        // Save the request token to the session.
        $requestStack->getSession()->set('oauth_request_token', $token);
        return new RedirectResponse($next);
    }

    /**
     * Receive authentication credentials back from the Oauth wiki.
     * @Route("/oauth_callback", name="oauth_callback")
     * @Route("/oauthredirector.php", name="old_oauth_callback")
     * @param RequestStack $requestStack
     * @param ProjectRepository $projectRepo
     * @param string $centralAuthProject
     * @return RedirectResponse
     */
    public function oauthCallbackAction(
        RequestStack $requestStack,
        ProjectRepository $projectRepo,
        string $centralAuthProject
    ): RedirectResponse {
        $request = $requestStack->getCurrentRequest();
        $session = $requestStack->getSession();
        // Give up if the required GET params don't exist.
        if (!$request->get('oauth_verifier')) {
            throw $this->createNotFoundException('No OAuth verifier given.');
        }

        // Complete authentication.
        $client = $this->getOauthClient($request, $projectRepo, $centralAuthProject);
        $client = $this->getOauthClient(/** @scrutinizer ignore-type */ $request, $projectRepo, $centralAuthProject);
        $token = $requestStack->getSession()->get('oauth_request_token');

        if (!is_a($token, Token::class)) {
            $this->addFlashMessage('notice', 'error-login');
            return $this->redirectToRoute('homepage');
        }

        $verifier = $request->get('oauth_verifier');
        $accessToken = $client->complete($token, $verifier);

        // Store access token, and remove request token.
        $session->set('oauth_access_token', $accessToken);
        $session->remove('oauth_request_token');

        // Store user identity.
        $ident = $client->identify($accessToken);
        $session->set('logged_in_user', $ident);

        // Store reference to the client.
        $session->set('oauth_client', $this->oauthClient);

        // Redirect to callback, if given.
        if ($request->query->get('redirect')) {
            return $this->redirect($request->query->get('redirect'));
        }

        // Send back to homepage.
        return $this->redirectToRoute('homepage');
    }

    /**
     * Get an OAuth client, configured to the default project.
     * (This shouldn't really be in this class, but oh well.)
     * @param Request $request
     * @param ProjectRepository $projectRepo
     * @param string $centralAuthProject
     * @return Client
     * @codeCoverageIgnore
     */
    protected function getOauthClient(
        Request $request,
        ProjectRepository $projectRepo,
        string $centralAuthProject
    ): Client {
        if (isset($this->oauthClient)) {
            return $this->oauthClient;
        }
        $defaultProject = $projectRepo->getProject($centralAuthProject);
        $endpoint = $defaultProject->getUrl(false)
                    . $defaultProject->getScript()
                    . '?title=Special:OAuth';
        $conf = new ClientConfig($endpoint);
        $consumerKey = $this->getParameter('oauth_key');
        $consumerSecret =  $this->getParameter('oauth_secret');
        $conf->setConsumer(new Consumer($consumerKey, $consumerSecret));
        $conf->setConsumer(new Consumer(/** @scrutinizer ignore-type */ $consumerKey, $consumerSecret));
        $this->oauthClient = new Client($conf);

        // Set the callback URL if given. Used to redirect back to target page after logging in.
        if ($request->query->get('callback')) {
            $this->oauthClient->setCallback($request->query->get('callback'));
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
        }

        return $this->oauthClient;
    }

    /**
     * Log out the user and return to the homepage.
     * @Route("/logout", name="logout")
     * @param RequestStack $requestStack
     * @return RedirectResponse
     */
    public function logoutAction(RequestStack $requestStack): RedirectResponse
    {
        $requestStack->getSession()->invalidate();
        return $this->redirectToRoute('homepage');
    }

    /************************ API endpoints ************************/

    /**
     * Get domain name, URL, API path and database name for the given project.
     * @Route("/api/project/normalize/{project}", name="ProjectApiNormalize", methods={"GET"})
     * @OA\Tag(name="Project API")
     * @OA\Parameter(ref="#/components/parameters/Project")
     * @OA\Response(
     *     response=200,
     *     description="The domain, URL, API path and database name.",
     *     @OA\JsonContent(
     *         @OA\Property(property="project", ref="#/components/parameters/Project/schema"),
     *         @OA\Property(property="domain", type="string", example="en.wikipedia.org"),
     *         @OA\Property(property="url", type="string", example="https://en.wikipedia.org"),
     *         @OA\Property(property="api", type="string", example="https://en.wikipedia.org/w/api.php"),
     *         @OA\Property(property="database", type="string", example="enwiki"),
     *         @OA\Property(property="elapsed_time", ref="#/components/schemas/elapsed_time")
     *     )
     * )
     * @OA\Response(response=404, ref="#/components/responses/404")
     * @OA\Response(response=503, ref="#/components/responses/503")
     * @OA\Response(response=504, ref="#/components/responses/504")
     * @return JsonResponse
     */
    public function normalizeProjectApiAction(): JsonResponse
    {
        return $this->getFormattedApiResponse([
            'domain' => $this->project->getDomain(),
            'url' => $this->project->getUrl(),
            'api' => $this->project->getApiUrl(),
            'database' => $this->project->getDatabaseName(),
        ]);
    }

    /**
     * Get the localized names for each namespaces of the given project.
     * @Route("/api/project/namespaces/{project}", name="ProjectApiNamespaces", methods={"GET"})
     * @OA\Tag(name="Project API")
     * @OA\Parameter(ref="#/components/parameters/Project")
     * @OA\Response(
     *     response=200,
     *     description="List of localized namespaces keyed by their ID.",
     *     @OA\JsonContent(
     *         @OA\Property(property="project", ref="#/components/parameters/Project/schema"),
     *         @OA\Property(property="url", type="string", example="https://en.wikipedia.org"),
     *         @OA\Property(property="api", type="string", example="https://en.wikipedia.org/w/api.php"),
     *         @OA\Property(property="database", type="string", example="enwiki"),
     *         @OA\Property(property="namespaces", type="object", example={"0": "", "3": "User talk"}),
     *         @OA\Property(property="elapsed_time", ref="#/components/schemas/elapsed_time")
     *     )
     * )
     * @OA\Response(response=404, ref="#/components/responses/404")
     * @OA\Response(response=503, ref="#/components/responses/503")
     * @OA\Response(response=504, ref="#/components/responses/504")
     * @return JsonResponse
     */
    public function namespacesApiAction(): JsonResponse
    {
        return $this->getFormattedApiResponse([
            'domain' => $this->project->getDomain(),
            'url' => $this->project->getUrl(),
            'api' => $this->project->getApiUrl(),
            'database' => $this->project->getDatabaseName(),
            'namespaces' => $this->project->getNamespaces(),
        ]);
    }

    /**
     * Get page assessment metadata for a project.
     * @Route("/api/project/assessments/{project}", name="ProjectApiAssessments", methods={"GET"})
     * @OA\Tag(name="Project API")
     * @OA\ExternalDocumentation(url="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:PageAssessments")
     * @OA\Parameter(ref="#/components/parameters/Project")
     * @OA\Response(
     *     response=200,
     *     description="List of classifications and importance levels, along with their associated colours and badges.",
     *     @OA\JsonContent(
     *         @OA\Property(property="project", ref="#/components/parameters/Project/schema"),
     *         @OA\Property(property="assessments", type="object", example={
     *             "wikiproject_prefix": "Wikipedia:WikiProject ",
     *             "class": {
     *                 "FA": {
     *                     "badge": "b/bc/Featured_article_star.svg",
     *                     "color": "#9CBDFF",
     *                     "category": "Category:FA-Class articles"
     *                 }
     *             },
     *             "importance": {
     *                 "Top": {
     *                     "color": "#FF97FF",
     *                     "category": "Category:Top-importance articles",
     *                     "weight": 5
     *                 }
     *             }
     *         }),
     *         @OA\Property(property="elapsed_time", ref="#/components/schemas/elapsed_time")
     *     )
     * )
     * @OA\Response(response=404, ref="#/components/responses/404")
     * @return JsonResponse
     */
    public function projectAssessmentsApiAction(): JsonResponse
    {
        return $this->getFormattedApiResponse([
            'project' => $this->project->getDomain(),
            'assessments' => $this->project->getPageAssessments()->getConfig(),
        ]);
    }

    /**
     * Get assessment metadata for all projects.
     * @Route("/api/project/assessments", name="ApiAssessmentsConfig", methods={"GET"})
     * @OA\Tag(name="Project API")
     * @OA\ExternalDocumentation(url="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:PageAssessments")
     * @OA\Response(
     *     response=200,
     *     description="Page assessment metadata for all projects that have
                <a href='https://w.wiki/6o9c'>PageAssessments</a> installed.",
     *     @OA\JsonContent(
     *         @OA\Property(property="projects", type="array", @OA\Items(type="string"),
     *              example={"en.wikipedia.org", "fr.wikipedia.org"}
     *         ),
     *         @OA\Property(property="config", type="object", example={
     *             "en.wikipedia.org": {
     *                 "wikiproject_prefix": "Wikipedia:WikiProject ",
     *                 "class": {
     *                     "FA": {
     *                         "badge": "b/bc/Featured_article_star.svg",
     *                         "color": "#9CBDFF",
     *                         "category": "Category:FA-Class articles"
     *                     }
     *                 },
     *                 "importance": {
     *                     "Top": {
     *                         "color": "#FF97FF",
     *                         "category": "Category:Top-importance articles",
     *                         "weight": 5
     *                     }
     *                 }
     *             }
     *         }),
     *         @OA\Property(property="elapsed_time", ref="#/components/schemas/elapsed_time")
     *     )
     * )
     * @return JsonResponse
     */
    public function assessmentsConfigApiAction(): JsonResponse
    {
        // Here there is no Project, so we don't use XtoolsController::getFormattedApiResponse().
        $response = new JsonResponse();
        $response->setEncodingOptions(JSON_NUMERIC_CHECK);
        $response->setStatusCode(Response::HTTP_OK);
        $response->setData([
            'projects' => array_keys($this->getParameter('assessments')),
            'config' => $this->getParameter('assessments'),
        ]);

        return $response;
    }

    /**
     * Transform given wikitext to HTML using the XTools parser. Wikitext must be passed in as the query 'wikitext'.
     * @Route("/api/project/parser/{project}")
     * @return JsonResponse Safe HTML.
     */
    public function wikifyApiAction(): JsonResponse
    {
        return new JsonResponse(
            Edit::wikifyString($this->request->query->get('wikitext', ''), $this->project)
        );
    }
}


Issues (196)

Security Analysis 6 potential vulnerabilities

src/Controller/DefaultController.php (5 issues)

Labels

Severity

Introduced By

1 path for user data to reach this point

Used in request-header context

General Strategies to prevent injection

1 path for user data to reach this point

Used in variable context

General Strategies to prevent injection

x-tools / xtools

Issues (196)

Security Analysis 6 potential vulnerabilities

src/Controller/DefaultController.php (5 issues)

Labels

Severity

Introduced By

1 path for user data to reach this point

Used in request-header context

General Strategies to prevent injection

1 path for user data to reach this point

Used in variable context

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like