x-tools / xtools

src/Controller/AdminScoreController.php

<?php

declare(strict_types=1);

namespace App\Controller;

use App\Model\AdminScore;
use App\Repository\AdminScoreRepository;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

/**
 * The AdminScoreController serves the search form and results page of the AdminScore tool.
 */
class AdminScoreController extends XtoolsController
{
    /**
     * @inheritDoc
     * @codeCoverageIgnore
     */
    public function getIndexRoute(): string
    {
        return 'AdminScore';
    }

    /**
     * Display the AdminScore search form.
     * @Route("/adminscore", name="AdminScore")
     * @Route("/adminscore/index.php", name="AdminScoreIndexPhp")
     * @Route("/scottywong tools/adminscore.php", name="AdminScoreLegacy")
     * @Route("/adminscore/{project}", name="AdminScoreProject")
     * @return Response
     */
    public function indexAction(): Response
    {
        // Redirect if we have a project and user.
        if (isset($this->params['project']) && isset($this->params['username'])) {
            return $this->redirectToRoute('AdminScoreResult', $this->params);
        }

        return $this->render('adminscore/index.html.twig', [
            'xtPage' => 'AdminScore',
            'xtPageTitle' => 'tool-adminscore',
            'xtSubtitle' => 'tool-adminscore-desc',
            'project' => $this->project,
        ]);
    }

    /**
     * Display the AdminScore results.
     * @Route("/adminscore/{project}/{username}", name="AdminScoreResult")
     * @param AdminScoreRepository $adminScoreRepo
     * @return Response
     * @codeCoverageIgnore
     */
    public function resultAction(AdminScoreRepository $adminScoreRepo): Response
    {
        $adminScore = new AdminScore($adminScoreRepo, $this->project, $this->user);

It seems like $this->user can also be of type null; however, parameter $user of App\Model\AdminScore::__construct() does only seem to accept App\Model\User, maybe add an additional type check?

        return $this->getFormattedResponse('adminscore/result', [
            'xtPage' => 'AdminScore',
            'xtTitle' => $this->user->getUsername(),

The method getUsername() does not exist on null.

            'as' => $adminScore,
        ]);
    }
}