Completed
Push — master ( 9572bd...47b900 )
by Sam
03:15
created
src/AppBundle/Controller/ArticleInfoController.php 4 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -380,7 +380,6 @@
 block discarded – undo
380 380
 
381 381
     /**
382 382
      * Get the size of the diff
383
-     * @param  int $rev The index of the revision within $this->pageHistory
384 383
      * @return int Size of the diff
385 384
      */
386 385
     private function getDiffSize($revIndex)
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@
 block discarded – undo
164 164
     private function getRevCount()
165 165
     {
166 166
         $query = "SELECT COUNT(*) AS count FROM " . $this->revisionTable
167
-                 . " WHERE rev_page = '" . $this->pageInfo['id'] . "'";
167
+                    . " WHERE rev_page = '" . $this->pageInfo['id'] . "'";
168 168
         $res = $this->conn->query($query)->fetchAll();
169 169
         return $res[0]['count'];
170 170
     }
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -6,11 +6,7 @@
 block discarded – undo
6 6
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7 7
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8 8
 use Symfony\Component\HttpFoundation\Request;
9
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
10 9
 use Symfony\Component\DependencyInjection\ContainerInterface;
11
-use AppBundle\Helper\Apihelper;
12
-use AppBundle\Helper\PageviewsHelper;
13
-use AppBundle\Helper\AutomatedEditsHelper;
14 10
 use Xtools\ProjectRepository;
15 11
 use Xtools\Page;
16 12
 use Xtools\PagesRepository;
Please login to merge, or discard this patch.
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -59,9 +59,9 @@  discard block
 block discarded – undo
59 59
         $article = $request->query->get('article');
60 60
 
61 61
         if ($projectQuery != '' && $article != '') {
62
-            return $this->redirectToRoute('ArticleInfoResult', [ 'project'=>$projectQuery, 'article' => $article ]);
62
+            return $this->redirectToRoute('ArticleInfoResult', ['project'=>$projectQuery, 'article' => $article]);
63 63
         } elseif ($article != '') {
64
-            return $this->redirectToRoute('ArticleInfoProject', [ 'project'=>$projectQuery ]);
64
+            return $this->redirectToRoute('ArticleInfoProject', ['project'=>$projectQuery]);
65 65
         }
66 66
 
67 67
         return $this->render('articleInfo/index.html.twig', [
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
             'url' => $basicInfo['fullurl']
120 120
         ];
121 121
 
122
-        $this->pageInfo['watchers'] = ( isset($basicInfo['watchers']) ) ? $basicInfo['watchers'] : "< 30";
122
+        $this->pageInfo['watchers'] = (isset($basicInfo['watchers'])) ? $basicInfo['watchers'] : "< 30";
123 123
 
124 124
         $pageProps = isset($basicInfo['pageprops']) ? $basicInfo['pageprops'] : [];
125 125
 
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
         $this->pageHistory = $page->getRevisions();
142 142
         $this->pageInfo['firstEdit'] = new Edit($this->pageInfo['page'], $this->pageHistory[0]);
143 143
         $this->pageInfo['lastEdit'] = new Edit(
144
-            $this->pageInfo['page'], $this->pageHistory[$page->getNumRevisions() - 1]
144
+            $this->pageInfo['page'], $this->pageHistory[$page->getNumRevisions()-1]
145 145
         );
146 146
 
147 147
         // NOTE: bots are fetched first in case we want to restrict some stats to humans editors only
@@ -185,8 +185,8 @@  discard block
 block discarded – undo
185 185
      */
186 186
     private function getRevCount()
187 187
     {
188
-        $query = "SELECT COUNT(*) AS count FROM " . $this->revisionTable
189
-                 . " WHERE rev_page = '" . $this->pageInfo['id'] . "'";
188
+        $query = "SELECT COUNT(*) AS count FROM ".$this->revisionTable
189
+                 . " WHERE rev_page = '".$this->pageInfo['id']."'";
190 190
         $res = $this->conn->query($query)->fetchAll();
191 191
         return $res[0]['count'];
192 192
     }
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
                   FROM $this->revisionTable
219 219
                   LEFT JOIN $userGroupsTable ON rev_user = ug_user
220 220
                   LEFT JOIN $userFromerGroupsTable ON rev_user = ufg_user
221
-                  WHERE rev_page = " . $this->pageInfo['id'] . " AND (ug_group = 'bot' OR ufg_group = 'bot')
221
+                  WHERE rev_page = ".$this->pageInfo['id']." AND (ug_group = 'bot' OR ufg_group = 'bot')
222 222
                   GROUP BY rev_user_text";
223 223
         $res = $this->conn->query($query)->fetchAll();
224 224
 
@@ -227,14 +227,14 @@  discard block
 block discarded – undo
227 227
         $sum = 0;
228 228
         foreach ($res as $bot) {
229 229
             $bots[$bot['username']] = [
230
-                'count' => (int) $bot['count'],
230
+                'count' => (int)$bot['count'],
231 231
                 'current' => $bot['current'] === 'bot'
232 232
             ];
233 233
             $sum += $bot['count'];
234 234
         }
235 235
 
236
-        uasort($bots, function ($a, $b) {
237
-            return $b['count'] - $a['count'];
236
+        uasort($bots, function($a, $b) {
237
+            return $b['count']-$a['count'];
238 238
         });
239 239
 
240 240
         $this->pageInfo['general']['bot_revision_count'] = $sum;
@@ -282,10 +282,10 @@  discard block
 block discarded – undo
282 282
 
283 283
             if ($info['all'] > 1) {
284 284
                 // Number of seconds between first and last edit
285
-                $secs = intval(strtotime($info['last']) - strtotime($info['first']) / $info['all']);
285
+                $secs = intval(strtotime($info['last'])-strtotime($info['first']) / $info['all']);
286 286
 
287 287
                 // Average time between edits (in days)
288
-                $this->pageInfo['editors'][$editor]['atbe'] = $secs / ( 60 * 60 * 24 );
288
+                $this->pageInfo['editors'][$editor]['atbe'] = $secs / (60 * 60 * 24);
289 289
             }
290 290
 
291 291
             if (count($info['sizes'])) {
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 
301 301
         // First sort editors array by the amount of text they added
302 302
         $topTenEditorsByAdded = $this->pageInfo['editors'];
303
-        uasort($topTenEditorsByAdded, function ($a, $b) {
303
+        uasort($topTenEditorsByAdded, function($a, $b) {
304 304
             if ($a['added'] === $b['added']) {
305 305
                 return 0;
306 306
             }
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
 
310 310
         // Then build a new array of top 10 editors by added text,
311 311
         //   in the data structure needed for the chart
312
-        $this->pageInfo['topTenEditorsByAdded'] = array_map(function ($editor) {
312
+        $this->pageInfo['topTenEditorsByAdded'] = array_map(function($editor) {
313 313
             $added = $this->pageInfo['editors'][$editor]['added'];
314 314
             return [
315 315
                 'label' => $editor,
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 
356 356
         // Transform to associative array by 'type'
357 357
         foreach ($res as $row) {
358
-            $data[$row['type'] . '_count'] = $row['value'];
358
+            $data[$row['type'].'_count'] = $row['value'];
359 359
         }
360 360
 
361 361
         return $data;
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
         $title = str_replace(' ', '_', $this->pageInfo['title']);
372 372
         $query = "SELECT log_action, log_type, log_timestamp AS timestamp
373 373
                   FROM $loggingTable
374
-                  WHERE log_namespace = '" . $this->pageInfo['namespace'] . "'
374
+                  WHERE log_namespace = '".$this->pageInfo['namespace']."'
375 375
                   AND log_title = '$title' AND log_timestamp > 1
376 376
                   AND log_type IN ('delete', 'move', 'protect', 'stable')";
377 377
         $events = $this->conn->query($query)->fetchAll();
@@ -456,7 +456,7 @@  discard block
 block discarded – undo
456 456
         $conn = $this->container->get('doctrine')->getManager('replicas')->getConnection();
457 457
         $res = $conn->query($query)->fetchAll();
458 458
 
459
-        $terms = array_map(function ($entry) {
459
+        $terms = array_map(function($entry) {
460 460
             return $entry['term'];
461 461
         }, $res);
462 462
 
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
                 'prio' => 2,
468 468
                 'name' => 'Wikidata',
469 469
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
470
-                'explanation' => "See: <a target='_blank' " .
470
+                'explanation' => "See: <a target='_blank' ".
471 471
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
472 472
             ];
473 473
         }
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
                 'prio' => 3,
477 477
                 'name' => 'Wikidata',
478 478
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
479
-                'explanation' => "See: <a target='_blank' " .
479
+                'explanation' => "See: <a target='_blank' ".
480 480
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
481 481
             ];
482 482
         }
@@ -497,14 +497,14 @@  discard block
 block discarded – undo
497 497
             return $rev['length'];
498 498
         }
499 499
 
500
-        $lastRev = $this->pageHistory[$revIndex - 1];
500
+        $lastRev = $this->pageHistory[$revIndex-1];
501 501
 
502 502
         // TODO: Remove once T101631 is resolved
503 503
         // Treat as zero change in size if length of previous edit is missing
504 504
         if ($lastRev['length'] === null) {
505 505
             return 0;
506 506
         } else {
507
-            return $rev['length'] - $lastRev['length'];
507
+            return $rev['length']-$lastRev['length'];
508 508
         }
509 509
     }
510 510
 
@@ -524,10 +524,10 @@  discard block
 block discarded – undo
524 524
 
525 525
         // Get UNIX timestamp of the first day of the month of the first edit
526 526
         // This is used as a comparison when building our array of per-month stats
527
-        $firstEditMonth = mktime(0, 0, 0, (int) $firstEdit->getMonth(), 1, $firstEdit->getYear());
527
+        $firstEditMonth = mktime(0, 0, 0, (int)$firstEdit->getMonth(), 1, $firstEdit->getYear());
528 528
 
529 529
         $lastEdit = $this->pageInfo['lastEdit'];
530
-        $secondLastEdit = $revisionCount === 1 ? $lastEdit : $this->pageHistory[ $revisionCount - 2 ];
530
+        $secondLastEdit = $revisionCount === 1 ? $lastEdit : $this->pageHistory[$revisionCount-2];
531 531
 
532 532
         // Now we can start our master array. This one will be HUGE!
533 533
         $data = [
@@ -608,7 +608,7 @@  discard block
 block discarded – undo
608 608
             // Increment year and month counts for all edits
609 609
             $data['year_count'][$edit->getYear()]['all']++;
610 610
             $data['year_count'][$edit->getYear()]['months'][$edit->getMonth()]['all']++;
611
-            $data['year_count'][$edit->getYear()]['size'] = (int) $rev['length'];
611
+            $data['year_count'][$edit->getYear()]['size'] = (int)$rev['length'];
612 612
 
613 613
             $editsThisMonth = $data['year_count'][$edit->getYear()]['months'][$edit->getMonth()]['all'];
614 614
             if ($editsThisMonth > $data['max_edits_per_month']) {
@@ -652,9 +652,9 @@  discard block
 block discarded – undo
652 652
                 }
653 653
 
654 654
                 // determine if the next revision was a revert
655
-                $nextRevision = isset($this->pageHistory[$i + 1]) ? $this->pageHistory[$i + 1] : null;
655
+                $nextRevision = isset($this->pageHistory[$i+1]) ? $this->pageHistory[$i+1] : null;
656 656
                 $nextRevisionIsRevert = $nextRevision &&
657
-                    $this->getDiffSize($i + 1) === -$edit->getSize() &&
657
+                    $this->getDiffSize($i+1) === -$edit->getSize() &&
658 658
                     $this->aeh->isRevert($nextRevision['comment']);
659 659
 
660 660
                 // don't count this edit as content removal if the next edit reverted it
Please login to merge, or discard this patch.
web/app_dev.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 // Feel free to remove this, extend it, or make something more sophisticated.
13 13
 if (isset($_SERVER['HTTP_CLIENT_IP'])
14 14
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
15
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
15
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
16 16
 ) {
17 17
     header('HTTP/1.0 403 Forbidden');
18 18
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
Please login to merge, or discard this patch.
xtools_utilities/nonautomated_edits_parse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -15,11 +15,11 @@
 block discarded – undo
15 15
 $data = json_decode($file, true);
16 16
 
17 17
 // Output the contents to the piped file
18
-print ( "parameters:
18
+print ("parameters:
19 19
   automated_tools:\r\n" );
20 20
 foreach ($data as $row) {
21
-    print "  - " . $row["name"] . ": '" . $row["regex"] . "'\r\n";
21
+    print "  - ".$row["name"].": '".$row["regex"]."'\r\n";
22 22
 }
23
-print ( "
23
+print ("
24 24
 
25
-  semi-automated edits source: $url" );
25
+  semi-automated edits source: $url");
Please login to merge, or discard this patch.
src/AppBundle/Helper/PageviewsHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@  discard block
 block discarded – undo
12 12
         $title = str_replace(' ', '_', $title);
13 13
         $client = new GuzzleHttp\Client();
14 14
 
15
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
16
-            "$project/all-access/user/" . rawurlencode($title) . '/daily/' . $start . '/' . $end;
15
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
16
+            "$project/all-access/user/".rawurlencode($title).'/daily/'.$start.'/'.$end;
17 17
 
18 18
         $res = $client->request('GET', $url);
19 19
         return json_decode($res->getBody()->getContents());
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         $data = $this->getLastDays($project, $title, $days);
33 33
 
34 34
         // FIXME: needs to handle gotchas
35
-        return array_sum(array_map(function ($item) {
35
+        return array_sum(array_map(function($item) {
36 36
             return $item->views;
37 37
         }, $data->items));
38 38
     }
Please login to merge, or discard this patch.
src/AppBundle/Twig/Extension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         }
46 46
 
47 47
         // Find the path, and complain if English doesn't exist.
48
-        $path = $this->container->getParameter("kernel.root_dir") . '/../i18n';
48
+        $path = $this->container->getParameter("kernel.root_dir").'/../i18n';
49 49
         if (!file_exists("$path/en.json")) {
50 50
             throw new Exception("Language directory doesn't exist: $path");
51 51
         }
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminStatsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 
177 177
         // Iterate over query results, loading each user id into the array
178 178
         while ($row = $res->fetch()) {
179
-            $adminIdArr[] = $row["user_id"] ;
179
+            $adminIdArr[] = $row["user_id"];
180 180
         }
181 181
 
182 182
         // Set the query results to be useful in a sql statement.
Please login to merge, or discard this patch.
src/AppBundle/Controller/QuoteController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
6 6
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7
-use Symfony\Component\Debug\Exception\ContextErrorException;
8 7
 use Symfony\Component\Routing\Exception\InvalidParameterException;
9 8
 use Symfony\Component\HttpFoundation\Request;
10 9
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
             'quote/all.html.twig',
112 112
             [
113 113
                 'base_dir' => realpath(
114
-                    $this->getParameter('kernel.root_dir') . '/..'
114
+                    $this->getParameter('kernel.root_dir').'/..'
115 115
                 ),
116 116
                 'xtPage' => 'bash',
117 117
                 'quotes' => $quotes,
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             'quote/view.html.twig',
161 161
             [
162 162
                 'base_dir' => realpath(
163
-                    $this->getParameter('kernel.root_dir') . '/..'
163
+                    $this->getParameter('kernel.root_dir').'/..'
164 164
                 ),
165 165
                 "xtPage" => "bash",
166 166
                 "text" => $text,
Please login to merge, or discard this patch.
src/AppBundle/Twig/WikiExtension.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -14,25 +14,25 @@  discard block
 block discarded – undo
14 14
 
15 15
     public function intuitionMessage($message = "", $vars = [])
16 16
     {
17
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
17
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
18 18
     }
19 19
 
20 20
     /*********************************** FUNCTIONS ***********************************/
21 21
 
22 22
     public function getFunctions()
23 23
     {
24
-        $options = [ 'is_safe' => [ 'html']];
24
+        $options = ['is_safe' => ['html']];
25 25
         return [
26
-            new Twig_SimpleFunction('wiki_link', [ $this, 'wikiLink' ], $options),
27
-            new Twig_SimpleFunction('user_link', [ $this, 'userLink' ], $options),
28
-            new Twig_SimpleFunction('user_log_link', [ $this, 'userLogLink' ], $options),
29
-            new Twig_SimpleFunction('group_link', [ $this, 'groupLink' ], $options),
30
-            new Twig_SimpleFunction('wiki_history_link', [ $this, 'wikiHistoryLink' ], $options),
31
-            new Twig_SimpleFunction('wiki_log_link', [ $this, 'wikiLogLink' ], $options),
32
-            new Twig_SimpleFunction('pageviews_links', [ $this, 'pageviewsLinks' ], $options),
33
-            new Twig_SimpleFunction('diff_link', [ $this, 'diffLink' ], $options),
34
-            new Twig_SimpleFunction('perma_link', [ $this, 'permaLink' ], $options),
35
-            new Twig_SimpleFunction('edit_link', [ $this, 'editLink' ], $options),
26
+            new Twig_SimpleFunction('wiki_link', [$this, 'wikiLink'], $options),
27
+            new Twig_SimpleFunction('user_link', [$this, 'userLink'], $options),
28
+            new Twig_SimpleFunction('user_log_link', [$this, 'userLogLink'], $options),
29
+            new Twig_SimpleFunction('group_link', [$this, 'groupLink'], $options),
30
+            new Twig_SimpleFunction('wiki_history_link', [$this, 'wikiHistoryLink'], $options),
31
+            new Twig_SimpleFunction('wiki_log_link', [$this, 'wikiLogLink'], $options),
32
+            new Twig_SimpleFunction('pageviews_links', [$this, 'pageviewsLinks'], $options),
33
+            new Twig_SimpleFunction('diff_link', [$this, 'diffLink'], $options),
34
+            new Twig_SimpleFunction('perma_link', [$this, 'permaLink'], $options),
35
+            new Twig_SimpleFunction('edit_link', [$this, 'editLink'], $options),
36 36
         ];
37 37
     }
38 38
 
@@ -244,8 +244,8 @@  discard block
 block discarded – undo
244 244
     public function getFilters()
245 245
     {
246 246
         return [
247
-            new \Twig_SimpleFilter('diff_format', [ $this, 'diffFormat' ], [ 'is_safe' => [ 'html' ] ]),
248
-            new \Twig_SimpleFilter('wikify_comment', [ $this, 'wikifyComment' ], [ 'is_safe' => [ 'html' ] ]),
247
+            new \Twig_SimpleFilter('diff_format', [$this, 'diffFormat'], ['is_safe' => ['html']]),
248
+            new \Twig_SimpleFilter('wikify_comment', [$this, 'wikifyComment'], ['is_safe' => ['html']]),
249 249
         ];
250 250
     }
251 251
 
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
         if ($isSection) {
285 285
             $sectionTitle = $sectionMatch[1][0];
286 286
             $sectionTitleLink = str_replace(' ', '_', $sectionTitle);
287
-            $sectionWikitext = "<a target='_blank' href='$projectUrl/wiki/$title#$sectionTitleLink'>&rarr;</a>" .
287
+            $sectionWikitext = "<a target='_blank' href='$projectUrl/wiki/$title#$sectionTitleLink'>&rarr;</a>".
288 288
                 "<em class='text-muted'>$sectionTitle:</em> ";
289 289
             $wikitext = str_replace($sectionMatch[0][0], $sectionWikitext, $wikitext);
290 290
         }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,6 @@  discard block
 block discarded – undo
80 80
 
81 81
     /**
82 82
      * Link to list of users who are in the given user group
83
-     * @param  string $username   Username
84 83
      * @param  string $projectUrl Project domain and protocol such as https://en.wikipedia.org
85 84
      * @param  string [$label]    The link text, defaults to $username
86 85
      * @return string Markup
@@ -230,7 +229,7 @@  discard block
 block discarded – undo
230 229
     /**
231 230
      * Get links to pageviews tools for the given page
232 231
      * @param  string $title      Title of page
233
-     * @param  string $projectUrl Project domain such as en.wikipedia.org
232
+     * @param  string $project Project domain such as en.wikipedia.org
234 233
      * @return string Markup
235 234
      */
236 235
     public function pageviewsLinks($title, $project)
Please login to merge, or discard this patch.
src/AppBundle/Helper/ApiHelper.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@
 block discarded – undo
177 177
      * Get a list of namespaces on the given project.
178 178
      *
179 179
      * @param string    $project such as en.wikipedia.org
180
-     * @return string[] Array of namespace IDs (keys) to names (values).
180
+     * @return string Array of namespace IDs (keys) to names (values).
181 181
      */
182 182
     public function namespaces($project)
183 183
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,13 +2,11 @@
 block discarded – undo
2 2
 
3 3
 namespace AppBundle\Helper;
4 4
 
5
-use DateInterval;
6 5
 use Mediawiki\Api\MediawikiApi;
7 6
 use Mediawiki\Api\SimpleRequest;
8 7
 use Mediawiki\Api\FluentRequest;
9 8
 use Psr\Cache\CacheItemPoolInterface;
10 9
 use Symfony\Component\Config\Definition\Exception\Exception;
11
-use Symfony\Component\Debug\Exception\FatalErrorException;
12 10
 use Symfony\Component\DependencyInjection\ContainerInterface;
13 11
 use Xtools\ProjectRepository;
14 12
 
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -66,12 +66,12 @@  discard block
 block discarded – undo
66 66
             throw new Exception("Unable to find project '$projectName'");
67 67
         }
68 68
 
69
-        $cacheKey = "siteinfo." . $project->getDatabaseName();
69
+        $cacheKey = "siteinfo.".$project->getDatabaseName();
70 70
         if ($this->cacheHas($cacheKey)) {
71 71
             return $this->cacheGet($cacheKey);
72 72
         }
73 73
 
74
-        $params = [ 'meta'=>'siteinfo', 'siprop'=>'general|namespaces' ];
74
+        $params = ['meta'=>'siteinfo', 'siprop'=>'general|namespaces'];
75 75
         $query = new SimpleRequest('query', $params);
76 76
 
77 77
         $result = [
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     public function groups($project, $username)
136 136
     {
137 137
         $this->setUp($project);
138
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
138
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
139 139
         $query = new SimpleRequest('query', $params);
140 140
         $result = [];
141 141
 
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     public function globalGroups($project, $username)
155 155
     {
156 156
         $this->setUp($project);
157
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
157
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
158 158
         $query = new SimpleRequest('query', $params);
159 159
         $result = [];
160 160
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
                 $groups[] = "B";
203 203
             }
204 204
             if (in_array("steward", $admin["groups"])) {
205
-                $groups[] = "S" ;
205
+                $groups[] = "S";
206 206
             }
207 207
             if (in_array("checkuser", $admin["groups"])) {
208 208
                 $groups[] = "CU";
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
             if (in_array("bot", $admin["groups"])) {
214 214
                 $groups[] = "Bot";
215 215
             }
216
-            $result[ $admin["name"] ] = [
216
+            $result[$admin["name"]] = [
217 217
                 "groups" => implode('/', $groups)
218 218
             ];
219 219
         }
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
             $normalized = [];
289 289
             if (isset($result['query']['normalized'])) {
290 290
                 array_map(
291
-                    function ($e) use (&$normalized) {
291
+                    function($e) use (&$normalized) {
292 292
                         $normalized[$e['to']] = $e['from'];
293 293
                     },
294 294
                     $result['query']['normalized']
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
         ];
335 335
 
336 336
         // get assessments for this page from the API
337
-        $assessments = $this->massApi($params, $project, function ($data) {
337
+        $assessments = $this->massApi($params, $project, function($data) {
338 338
             return isset($data['pages'][0]['pageassessments']) ? $data['pages'][0]['pageassessments'] : [];
339 339
         }, 'pacontinue')['pages'];
340 340
 
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
                 $classAttrs = $config['class']['Unknown'];
359 359
                 $assessment['class']['value'] = '???';
360 360
                 $assessment['class']['category'] = $classAttrs['category'];
361
-                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/". $classAttrs['badge'];
361
+                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".$classAttrs['badge'];
362 362
             } else {
363 363
                 $classAttrs = $config['class'][$classValue];
364 364
                 $assessment['class'] = [
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
 
370 370
                 // add full URL to badge icon
371 371
                 if ($classAttrs['badge'] !== '') {
372
-                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/" .
372
+                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".
373 373
                         $classAttrs['badge'];
374 374
                 }
375 375
 
@@ -418,9 +418,9 @@  discard block
 block discarded – undo
418 418
         $config = $this->getAssessmentsConfig();
419 419
 
420 420
         if (isset($config[$project]['class'][$class])) {
421
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class'][$class]['badge'];
421
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class'][$class]['badge'];
422 422
         } elseif (isset($config[$project]['class']['Unknown'])) {
423
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class']['Unknown']['badge'];
423
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class']['Unknown']['badge'];
424 424
         } else {
425 425
             return "";
426 426
         }
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
514 514
         $innerPromise = $this->api->getRequestAsync($query);
515 515
 
516
-        $innerPromise->then(function ($result) use (&$data) {
516
+        $innerPromise->then(function($result) use (&$data) {
517 517
             // some failures come back as 200s, so we still resolve and let the outer function handle it
518 518
             if (isset($result['error']) || !isset($result['query'])) {
519 519
                 return $data['promise']->resolve($data);
Please login to merge, or discard this patch.