x-tools / xtools

src/AppBundle/Controller/EditSummaryController.php

Spacing +5 added lines, -7 removed lines

@@ -92,7 +92,7 @@ 
                 'xtSubtitle' => 'tool-es-desc',
                 'xtPage' => 'es',
                 'project' => $theProject,
-                'namespace' => (int) $namespace,
+                'namespace' => (int)$namespace,
             ]
         );
     }
@@ -158,8 +158,8 @@ 
     {
         $dbName = $project->getDatabaseName();
 
-        $cacheKey = 'editsummaryusage.' . $dbName . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editsummaryusage.'.$dbName.'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $cache = $this->container->get('cache.app');
         if ($cache->hasItem($cacheKey)) {
@@ -246,8 +246,7 @@ 
             if ($row['rev_minor_edit'] == 0) {
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMajor++;
                 }
 
@@ -264,8 +263,7 @@ 
                 // If there is a comment, count it
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMinor++;
                     $totalEditsMinor++;
                 } else {

src/AppBundle/Controller/ApiController.php

Spacing +8 added lines, -8 removed lines

@@ -168,7 +168,7 @@ 
         $view = View::create()->setStatusCode(Response::HTTP_OK);
 
         if ($request->query->get('format') === 'html') {
-            $edits = array_map(function ($attrs) use ($project, $username) {
+            $edits = array_map(function($attrs) use ($project, $username) {
                 $page = $project->getRepository()
                     ->getPage($project, $attrs['full_page_title']);
                 $pageTitles[] = $attrs['full_page_title'];
@@ -244,19 +244,19 @@ 
         $info = $page->getBasicEditingInfo();
         $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
         $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
-        $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
+        $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
 
         $data = [
-            'revisions' => (int) $info['num_edits'],
-            'editors' => (int) $info['num_editors'],
+            'revisions' => (int)$info['num_edits'],
+            'editors' => (int)$info['num_editors'],
             'author' => $info['author'],
-            'author_editcount' => (int) $info['author_editcount'],
+            'author_editcount' => (int)$info['author_editcount'],
             'created_at' => $creationDateTime->format('Y-m-d'),
             'created_rev_id' => $info['created_rev_id'],
             'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
             'secs_since_last_edit' => $secsSinceLastEdit,
-            'last_edit_id' => (int) $info['modified_rev_id'],
-            'watchers' => (int) $page->getWatchers(),
+            'last_edit_id' => (int)$info['modified_rev_id'],
+            'watchers' => (int)$page->getWatchers(),
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
             'pageviews_offset' => $pageviewsOffset,
         ];
@@ -314,7 +314,7 @@ 
         }
 
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/AppBundle/Controller/ArticleInfoController.php

Spacing +9 added lines, -9 removed lines

@@ -81,9 +81,9 @@ 
         $article = $request->query->get('article');
 
         if ($projectQuery != '' && $article != '') {
-            return $this->redirectToRoute('ArticleInfoResult', [ 'project'=>$projectQuery, 'article' => $article ]);
+            return $this->redirectToRoute('ArticleInfoResult', ['project'=>$projectQuery, 'article' => $article]);
         } elseif ($article != '') {
-            return $this->redirectToRoute('ArticleInfoProject', [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute('ArticleInfoProject', ['project'=>$projectQuery]);
         }
 
         if ($projectQuery == '') {
@@ -121,10 +121,10 @@ 
             $rendered = str_replace('"', '\"', trim($rendered));
 
             // Uglify temporary file.
-            $tmpFile = sys_get_temp_dir() . '/xtools_articleinfo_gadget.js';
+            $tmpFile = sys_get_temp_dir().'/xtools_articleinfo_gadget.js';
             $script = "echo \"$rendered\" | tee $tmpFile >/dev/null && ";
-            $script .= $this->get('kernel')->getRootDir() .
-                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle " .
+            $script .= $this->get('kernel')->getRootDir().
+                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle ".
                 "&& rm $tmpFile >/dev/null";
             $process = new Process($script);
             $process->run();
@@ -143,10 +143,10 @@ 
             $rendered = str_replace('\"', '"', trim($rendered));
 
             // Add comment after uglifying since it removes comments.
-            $rendered = "/**\n * This code was automatically generated and should not " .
-                "be manually edited.\n * For updates, please copy and paste from " .
-                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL) .
-                "\n * Released under GPL v3 license.\n */\n" . $rendered;
+            $rendered = "/**\n * This code was automatically generated and should not ".
+                "be manually edited.\n * For updates, please copy and paste from ".
+                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL).
+                "\n * Released under GPL v3 license.\n */\n".$rendered;
         }
 
         $response = new \Symfony\Component\HttpFoundation\Response($rendered);

src/Xtools/Page.php

Spacing +9 added lines, -9 removed lines

@@ -81,7 +81,7 @@ 
         $info = $this->getPageInfo();
         $title = isset($info['title']) ? $info['title'] : $this->unnormalizedPageName;
         $nsName = $this->getNamespaceName();
-        return str_replace($nsName . ':', '', $title);
+        return str_replace($nsName.':', '', $title);
     }
 
     /**
@@ -217,7 +217,7 @@ 
     {
         // If a user is given, we will not cache the result via instance variable.
         if ($user !== null) {
-            return (int) $this->getRepository()->getNumRevisions($this, $user);
+            return (int)$this->getRepository()->getNumRevisions($this, $user);
         }
 
         // Return cached value, if present.
@@ -230,7 +230,7 @@ 
             $this->numRevisions = count($this->revisions);
         } else {
             // Otherwise do a COUNT in the event fetching all revisions is not desired.
-            $this->numRevisions = (int) $this->getRepository()->getNumRevisions($this);
+            $this->numRevisions = (int)$this->getRepository()->getNumRevisions($this);
         }
 
         return $this->numRevisions;
@@ -260,7 +260,7 @@ 
     {
         $content = $this->getRepository()->getPagesWikitext(
             $this->getProject(),
-            [ $this->getTitle() ]
+            [$this->getTitle()]
         );
 
         return isset($content[$this->getTitle()])
@@ -417,7 +417,7 @@ 
 
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
 
-        $terms = array_map(function ($entry) {
+        $terms = array_map(function($entry) {
             return $entry['term'];
         }, $wikidataInfo);
 
@@ -428,7 +428,7 @@ 
                 'prio' => 2,
                 'name' => 'Wikidata',
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
             ];
         }
@@ -438,7 +438,7 @@ 
                 'prio' => 3,
                 'name' => 'Wikidata',
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
             ];
         }
@@ -517,8 +517,8 @@ 
             return 0;
         }
 
-        return array_sum(array_map(function ($item) {
-            return (int) $item['views'];
+        return array_sum(array_map(function($item) {
+            return (int)$item['views'];
         }, $pageviews['items']));
     }
 

src/Xtools/ArticleInfo.php

Spacing +10 added lines, -10 removed lines

@@ -159,7 +159,7 @@ 
     public function getMaxRevisions()
     {
         if (!isset($this->maxRevisions)) {
-            $this->maxRevisions = (int) $this->container->getParameter('app.max_page_revisions');
+            $this->maxRevisions = (int)$this->container->getParameter('app.max_page_revisions');
         }
         return $this->maxRevisions;
     }
@@ -638,7 +638,7 @@ 
 
             if ($revCount === 0) {
                 $this->firstEdit = $edit;
-                $firstEditMonth = mktime(0, 0, 0, (int) $this->firstEdit->getMonth(), 1, $this->firstEdit->getYear());
+                $firstEditMonth = mktime(0, 0, 0, (int)$this->firstEdit->getMonth(), 1, $this->firstEdit->getYear());
             }
 
             $username = $edit->getUser()->getUsername();
@@ -824,7 +824,7 @@ 
         $userGroupsTable = $this->getProject()->getTableName('user_groups');
         $userFromerGroupsTable = $this->getProject()->getTableName('user_former_groups');
         $sql = "SELECT COUNT(rev_user_text) AS count, rev_user_text AS username, ug_group AS current
-                FROM " . $this->getProject()->getTableName('revision') . "
+                FROM " . $this->getProject()->getTableName('revision')."
                 LEFT JOIN $userGroupsTable ON rev_user = ug_user
                 LEFT JOIN $userFromerGroupsTable ON rev_user = ufg_user
                 WHERE rev_page = :pageId AND (ug_group = 'bot' OR ufg_group = 'bot')
@@ -839,14 +839,14 @@ 
         $sum = 0;
         while ($bot = $resultQuery->fetch()) {
             $bots[$bot['username']] = [
-                'count' => (int) $bot['count'],
+                'count' => (int)$bot['count'],
                 'current' => $bot['current'] === 'bot'
             ];
             $sum += $bot['count'];
         }
 
-        uasort($bots, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($bots, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         $this->botRevisionCount = $sum;
@@ -869,7 +869,7 @@ 
         $title = str_replace(' ', '_', $this->page->getTitle());
         $sql = "SELECT log_action, log_type, log_timestamp AS timestamp
                 FROM $loggingTable
-                WHERE log_namespace = '" . $this->page->getNamespace() . "'
+                WHERE log_namespace = '".$this->page->getNamespace()."'
                 AND log_title = :title AND log_timestamp > 1
                 AND log_type IN ('delete', 'move', 'protect', 'stable')";
         $resultQuery = $this->conn->prepare($sql);
@@ -944,7 +944,7 @@ 
 
             if ($info['all'] > 1) {
                 // Number of seconds/days between first and last edit
-                $secs = $info['last']->getTimestamp() - $info['first']->getTimestamp();
+                $secs = $info['last']->getTimestamp()-$info['first']->getTimestamp();
                 $days = $secs / (60 * 60 * 24);
 
                 // Average time between edits (in days)
@@ -963,7 +963,7 @@ 
 
         // First sort editors array by the amount of text they added
         $topTenEditorsByAdded = $this->editors;
-        uasort($topTenEditorsByAdded, function ($a, $b) {
+        uasort($topTenEditorsByAdded, function($a, $b) {
             if ($a['added'] === $b['added']) {
                 return 0;
             }
@@ -972,7 +972,7 @@ 
 
         // Then build a new array of top 10 editors by added text,
         //   in the data structure needed for the chart
-        $this->topTenEditorsByAdded = array_map(function ($editor) {
+        $this->topTenEditorsByAdded = array_map(function($editor) {
             $added = $this->editors[$editor]['added'];
             return [
                 'label' => $editor,

src/Xtools/PagesRepository.php

Spacing +5 added lines, -5 removed lines

@@ -148,7 +148,7 @@ 
         // supply as the OFFSET.
         $limitClause = '';
         if (intval($limit) > 0 && isset($numRevisions)) {
-            $offset = $numRevisions - $limit;
+            $offset = $numRevisions-$limit;
             $limitClause = "LIMIT $offset, $limit";
         }
 
@@ -378,7 +378,7 @@ 
 
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
 
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
                 FROM wikidatawiki_p.wb_items_per_site
                 WHERE ips_item_id = :wikidataId";
 
@@ -388,7 +388,7 @@ 
 
         $result = $resultQuery->fetchAll();
 
-        return $count ? (int) $result[0]['count'] : $result;
+        return $count ? (int)$result[0]['count'] : $result;
     }
 
     /**
@@ -428,7 +428,7 @@ 
 
         // Transform to associative array by 'type'
         foreach ($res as $row) {
-            $data[$row['type'] . '_count'] = $row['value'];
+            $data[$row['type'].'_count'] = $row['value'];
         }
 
         return $data;
@@ -466,7 +466,7 @@ 
 
         $project = $page->getProject()->getDomain();
 
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
             "$project/all-access/user/$title/daily/$start/$end";
 
         $res = $client->request('GET', $url);

src/Xtools/EditCounter.php

Spacing +27 added lines, -27 removed lines

@@ -117,8 +117,8 @@ 
             $promises[] = $promise;
 
             // Handle response of $promise asynchronously.
-            $promise->then(function ($response) use ($key, $endpoint) {
-                $result = (array) json_decode($response->getBody()->getContents());
+            $promise->then(function($response) use ($key, $endpoint) {
+                $result = (array)json_decode($response->getBody()->getContents());
 
                 if (isset($result)) {
                     // Copy result to the class class instance. From here any subsequent
@@ -131,7 +131,7 @@ 
                     // We'll log this to see how often it happens.
                     $this->getRepository()
                         ->getLog()
-                        ->error("Failed to fetch data for $endpoint via async, " .
+                        ->error("Failed to fetch data for $endpoint via async, ".
                             "re-attempting synchoronously.");
                 }
             });
@@ -187,7 +187,7 @@ 
 
         // Filter out unblocks unless requested.
         if ($blocksOnly) {
-            $blocks = array_filter($blocks, function ($block) {
+            $blocks = array_filter($blocks, function($block) {
                 return $block['log_action'] === 'block';
             });
         }
@@ -221,7 +221,7 @@ 
      */
     public function countAllRevisions()
     {
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
     }
 
     /**
@@ -240,7 +240,7 @@ 
      */
     public function countRevisionsWithoutComments()
     {
-        return $this->countLiveRevisions() - $this->countRevisionsWithComments();
+        return $this->countLiveRevisions()-$this->countRevisionsWithComments();
     }
 
     /**
@@ -279,7 +279,7 @@ 
      */
     public function countAllPagesEdited()
     {
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
     }
 
     /**
@@ -289,7 +289,7 @@ 
      */
     public function countPagesCreated()
     {
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
     }
 
     /**
@@ -429,7 +429,7 @@ 
             } elseif ($block['log_action'] === 'unblock') {
                 // The last block was lifted. So the duration will be the time from when the
                 // last block was set to the time of the unblock.
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
                 if ($timeSinceLastBlock > $this->longestBlockSeconds) {
                     $this->longestBlockSeconds = $timeSinceLastBlock;
 
@@ -440,8 +440,8 @@ 
                 // The last block was modified. So we will adjust $lastBlock to include
                 // the difference of the duration of the new reblock, and time since the last block.
                 // $lastBlock is left unchanged if its duration was indefinite.
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
-                $lastBlock[1] = $timeSinceLastBlock + $duration;
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
+                $lastBlock[1] = $timeSinceLastBlock+$duration;
             }
         }
 
@@ -451,7 +451,7 @@ 
         }
 
         // Test if the last block is still active, and if so use the expiry as the duration.
-        $lastBlockExpiry = $lastBlock[0] + $lastBlock[1];
+        $lastBlockExpiry = $lastBlock[0]+$lastBlock[1];
         if ($lastBlockExpiry > time() && $lastBlockExpiry > $this->longestBlockSeconds) {
             $this->longestBlockSeconds = $lastBlock[1];
         // Otherwise, test if the duration of the last block is now the longest overall.
@@ -492,7 +492,7 @@ 
         // If invalid, $duration is left as null.
         if (strtotime($durationStr)) {
             $expiry = strtotime($durationStr, $timestamp);
-            $duration = $expiry - $timestamp;
+            $duration = $expiry-$timestamp;
         }
 
         return [$timestamp, $duration];
@@ -569,7 +569,7 @@ 
         $import = isset($logCounts['import-import']) ? (int)$logCounts['import-import'] : 0;
         $interwiki = isset($logCounts['import-interwiki']) ? (int)$logCounts['import-interwiki'] : 0;
         $upload = isset($logCounts['import-upload']) ? (int)$logCounts['import-upload'] : 0;
-        return $import + $interwiki + $upload;
+        return $import+$interwiki+$upload;
     }
 
     /**
@@ -693,9 +693,9 @@ 
     public function approvals()
     {
         $logCounts = $this->getLogCounts();
-        $total = $logCounts['review-approve'] +
-        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
-        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
+        $total = $logCounts['review-approve']+
+        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
+        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
         (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
         return $total;
     }
@@ -719,7 +719,7 @@ 
         $logCounts = $this->getLogCounts();
         $create2 = $logCounts['newusers-create2'] ?: 0;
         $byemail = $logCounts['newusers-byemail'] ?: 0;
-        return $create2 + $byemail;
+        return $create2+$byemail;
     }
 
     /**
@@ -771,7 +771,7 @@ 
 
         $totals = $this->getRepository()->getMonthCounts($this->project, $this->user);
         $out = [
-            'yearLabels' => [],  // labels for years
+            'yearLabels' => [], // labels for years
             'monthLabels' => [], // labels for months
             'totals' => [], // actual totals, grouped by namespace, year and then month
         ];
@@ -799,7 +799,7 @@ 
                 $out['totals'][$ns][$total['year']] = [];
             }
 
-            $out['totals'][$ns][$total['year']][$total['month']] = (int) $total['count'];
+            $out['totals'][$ns][$total['year']][$total['month']] = (int)$total['count'];
         }
 
         $dateRange = new DatePeriod(
@@ -809,8 +809,8 @@ 
         );
 
         foreach ($dateRange as $monthObj) {
-            $year = (int) $monthObj->format('Y');
-            $month = (int) $monthObj->format('n');
+            $year = (int)$monthObj->format('Y');
+            $month = (int)$monthObj->format('n');
 
             // Fill in labels
             $out['monthLabels'][] = $monthObj->format('Y-m');
@@ -926,8 +926,8 @@ 
 
         if ($sorted) {
             // Sort.
-            uasort($this->globalEditCounts, function ($a, $b) {
-                return $b['total'] - $a['total'];
+            uasort($this->globalEditCounts, function($a, $b) {
+                return $b['total']-$a['total'];
             });
         }
 
@@ -963,7 +963,7 @@ 
                 $nsName = $project->getNamespaces()[$revision['page_namespace']];
             }
             $page = $project->getRepository()
-                ->getPage($project, $nsName . ':' . $revision['page_title']);
+                ->getPage($project, $nsName.':'.$revision['page_title']);
             $edit = new Edit($page, $revision);
             $globalEdits[$edit->getTimestamp()->getTimestamp().'-'.$edit->getId()] = $edit;
         }
@@ -1004,7 +1004,7 @@ 
     public function countSmallEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['small_edits']) ? (int) $editSizeData['small_edits'] : 0;
+        return isset($editSizeData['small_edits']) ? (int)$editSizeData['small_edits'] : 0;
     }
 
     /**
@@ -1014,7 +1014,7 @@ 
     public function countLargeEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['large_edits']) ? (int) $editSizeData['large_edits'] : 0;
+        return isset($editSizeData['large_edits']) ? (int)$editSizeData['large_edits'] : 0;
     }
 
     /**

src/AppBundle/Controller/EditCounterController.php

Spacing +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
         $isSubRequest = $this->container->get('request_stack')->getParentRequest() !== null;
 
         return $this->render('editCounter/result.html.twig', [
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->project->getTitle(),
+            'xtTitle' => $this->user->getUsername().' - '.$this->project->getTitle(),
             'xtPage' => 'ec',
             'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
             'is_sub_request' => $isSubRequest,

src/AppBundle/Controller/AutomatedEditsController.php

Spacing +3 added lines, -3 removed lines

@@ -86,7 +86,7 @@ 
             'xtSubtitle' => 'tool-autoedits-desc',
             'xtPage' => 'autoedits',
             'project' => $project,
-            'namespace' => (int) $namespace,
+            'namespace' => (int)$namespace,
             'start' => $startDate,
             'end' => $endDate,
         ]);
@@ -157,8 +157,8 @@ 
         // Get individual counts of how many times each tool was used.
         // This also includes a wikilink to the tool.
         $toolCounts = $user->getAutomatedCounts($projectData, $namespace, $start, $end);
-        $toolsTotal = array_reduce($toolCounts, function ($a, $b) {
-            return $a + $b['count'];
+        $toolsTotal = array_reduce($toolCounts, function($a, $b) {
+            return $a+$b['count'];
         });
 
         // Query to get combined (semi)automated using for all edits