x-tools / xtools

tests/AppBundle/Controller/ApiControllerTest.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
             $this->assertEquals(200, $client->getResponse()->getStatusCode());
 
             // Check that a correct namespace value was returned
-            $namespaces = (array) json_decode($client->getResponse()->getContent());
+            $namespaces = (array)json_decode($client->getResponse()->getContent());
             $this->assertEquals('Utilisateur', array_values($namespaces)[2]); // User in French
         }
     }

app/autoload.php

Spacing +1 added lines, -1 removed lines

@@ -8,6 +8,6 @@
  */
 $loader = require __DIR__.'/../vendor/autoload.php';
 
-AnnotationRegistry::registerLoader([ $loader, 'loadClass' ]);
+AnnotationRegistry::registerLoader([$loader, 'loadClass']);
 
 return $loader;

app/AppKernel.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
             new AppBundle\AppBundle(),
         ];
 
-        if (in_array($this->getEnvironment(), [ 'dev', 'test' ], true)) {
+        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
             $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
             $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();

src/AppBundle/Helper/AutomatedEditsHelper.php

Spacing +9 added lines, -9 removed lines

@@ -123,7 +123,7 @@ 
         $revTable = $lh->getTable('revision', $project->getDatabaseName());
         $pageTable = $lh->getTable('page', $project->getDatabaseName());
 
-        $AEBTypes = array_map(function ($AEBType) {
+        $AEBTypes = array_map(function($AEBType) {
             return $AEBType['regex'];
         }, $this->container->getParameter('automated_tools'));
 
@@ -148,12 +148,12 @@ 
         }
 
         // Get diff sizes, based on length of each parent revision
-        $parentRevIds = array_map(function ($edit) {
+        $parentRevIds = array_map(function($edit) {
             return $edit['rev_parent_id'];
         }, $editData);
         $query = "SELECT rev_len, rev_id
                   FROM revision
-                  WHERE rev_id IN (" . implode(',', $parentRevIds) . ")";
+                  WHERE rev_id IN (" . implode(',', $parentRevIds).")";
         $diffSizeData = $conn->executeQuery($query)->fetchAll();
 
         // reformat with rev_id as the key, rev_len as the value
@@ -163,24 +163,24 @@ 
         }
 
         // Build our array of nonautomated edits
-        $editData = array_map(function ($edit) use ($namespaces, $diffSizes) {
+        $editData = array_map(function($edit) use ($namespaces, $diffSizes) {
             $pageTitle = $edit['page_title'];
 
             if ($edit['page_namespace'] !== '0') {
-                $pageTitle = $namespaces[$edit['page_namespace']] . ":$pageTitle";
+                $pageTitle = $namespaces[$edit['page_namespace']].":$pageTitle";
             }
 
             $diffSize = $edit['rev_len'];
             if ($edit['rev_parent_id'] > 0) {
-                $diffSize = $edit['rev_len'] - $diffSizes[$edit['rev_parent_id']];
+                $diffSize = $edit['rev_len']-$diffSizes[$edit['rev_parent_id']];
             }
 
             return [
                 'page_title' => $pageTitle,
-                'namespace' => (int) $edit['page_namespace'],
-                'rev_id' => (int) $edit['rev_id'],
+                'namespace' => (int)$edit['page_namespace'],
+                'rev_id' => (int)$edit['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $edit['rev_timestamp']),
-                'minor_edit' => (bool) $edit['rev_minor_edit'],
+                'minor_edit' => (bool)$edit['rev_minor_edit'],
                 'summary' => $edit['rev_comment'],
                 'size' => $diffSize
             ];

src/AppBundle/Controller/AutomatedEditsController.php

Spacing +3 added lines, -3 removed lines

@@ -154,7 +154,7 @@ 
         $archiveTable = $lh->getTable('archive', $dbName);
 
         $condBegin = $start ? " AND rev_timestamp > :start " : null;
-        $condEnd = $end ? " AND rev_timestamp < :end ": null;
+        $condEnd = $end ? " AND rev_timestamp < :end " : null;
 
         $regexes = [];
 
@@ -248,8 +248,8 @@ 
         }
 
         // Sort the array and do some simple math.
-        uasort($results, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($results, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         if ($total != 0) {

src/Xtools/EditCounterRepository.php

Spacing +9 added lines, -9 removed lines

@@ -19,7 +19,7 @@ 
     public function getRevisionCounts(Project $project, User $user)
     {
         // Set up cache.
-        $cacheKey = 'revisioncounts.' . $project->getDatabaseName() . '.' . $user->getUsername();
+        $cacheKey = 'revisioncounts.'.$project->getDatabaseName().'.'.$user->getUsername();
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -80,7 +80,7 @@ 
     public function getRevisionDates(Project $project, User $user)
     {
         // Set up cache.
-        $cacheKey = 'revisiondates.' . $project->getDatabaseName() . '.' . $user->getUsername();
+        $cacheKey = 'revisiondates.'.$project->getDatabaseName().'.'.$user->getUsername();
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -152,10 +152,10 @@ 
         $results = $resultQuery->fetchAll();
 
         $pageCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -186,7 +186,7 @@ 
 
         // Query.
         $sql = "SELECT CONCAT(log_type, '-', log_action) AS source, COUNT(log_id) AS value
-            FROM " . $this->getTableName($project->getDatabaseName(), 'logging') . "
+            FROM " . $this->getTableName($project->getDatabaseName(), 'logging')."
             WHERE log_user = :userId
             GROUP BY log_type, log_action";
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
@@ -195,10 +195,10 @@ 
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
         $logCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -355,9 +355,9 @@ 
         $resultQuery->bindParam(":id", $userId);
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
-        $namespaceTotals = array_combine(array_map(function ($e) {
+        $namespaceTotals = array_combine(array_map(function($e) {
             return $e['page_namespace'];
-        }, $results), array_map(function ($e) {
+        }, $results), array_map(function($e) {
             return $e['total'];
         }, $results));
 

src/AppBundle/Helper/ApiHelper.php

Spacing +13 added lines, -13 removed lines

@@ -66,12 +66,12 @@ 
             throw new Exception("Unable to find project '$projectName'");
         }
 
-        $cacheKey = "siteinfo." . $project->getDatabaseName();
+        $cacheKey = "siteinfo.".$project->getDatabaseName();
         if ($this->cacheHas($cacheKey)) {
             return $this->cacheGet($cacheKey);
         }
 
-        $params = [ 'meta'=>'siteinfo', 'siprop'=>'general|namespaces' ];
+        $params = ['meta'=>'siteinfo', 'siprop'=>'general|namespaces'];
         $query = new SimpleRequest('query', $params);
 
         $result = [
@@ -135,7 +135,7 @@ 
     public function groups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -154,7 +154,7 @@ 
     public function globalGroups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -202,7 +202,7 @@ 
                 $groups[] = "B";
             }
             if (in_array("steward", $admin["groups"])) {
-                $groups[] = "S" ;
+                $groups[] = "S";
             }
             if (in_array("checkuser", $admin["groups"])) {
                 $groups[] = "CU";
@@ -213,7 +213,7 @@ 
             if (in_array("bot", $admin["groups"])) {
                 $groups[] = "Bot";
             }
-            $result[ $admin["name"] ] = [
+            $result[$admin["name"]] = [
                 "groups" => implode('/', $groups)
             ];
         }
@@ -288,7 +288,7 @@ 
             $normalized = [];
             if (isset($result['query']['normalized'])) {
                 array_map(
-                    function ($e) use (&$normalized) {
+                    function($e) use (&$normalized) {
                         $normalized[$e['to']] = $e['from'];
                     },
                     $result['query']['normalized']
@@ -334,7 +334,7 @@ 
         ];
 
         // get assessments for this page from the API
-        $assessments = $this->massApi($params, $project, function ($data) {
+        $assessments = $this->massApi($params, $project, function($data) {
             return isset($data['pages'][0]['pageassessments']) ? $data['pages'][0]['pageassessments'] : [];
         }, 'pacontinue')['pages'];
 
@@ -358,7 +358,7 @@ 
                 $classAttrs = $config['class']['Unknown'];
                 $assessment['class']['value'] = '???';
                 $assessment['class']['category'] = $classAttrs['category'];
-                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/". $classAttrs['badge'];
+                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".$classAttrs['badge'];
             } else {
                 $classAttrs = $config['class'][$classValue];
                 $assessment['class'] = [
@@ -369,7 +369,7 @@ 
 
                 // add full URL to badge icon
                 if ($classAttrs['badge'] !== '') {
-                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/" .
+                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".
                         $classAttrs['badge'];
                 }
 
@@ -418,9 +418,9 @@ 
         $config = $this->getAssessmentsConfig();
 
         if (isset($config[$project]['class'][$class])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class'][$class]['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class'][$class]['badge'];
         } elseif (isset($config[$project]['class']['Unknown'])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class']['Unknown']['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class']['Unknown']['badge'];
         } else {
             return "";
         }
@@ -513,7 +513,7 @@ 
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
         $innerPromise = $this->api->getRequestAsync($query);
 
-        $innerPromise->then(function ($result) use (&$data) {
+        $innerPromise->then(function($result) use (&$data) {
             // some failures come back as 200s, so we still resolve and let the outer function handle it
             if (isset($result['error']) || !isset($result['query'])) {
                 return $data['promise']->resolve($data);

src/AppBundle/Controller/MetaController.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
         $end = $request->query->get('end');
 
         if ($start != '' && $end != '') {
-            return $this->redirectToRoute('MetaResult', [ 'start' => $start, 'end' => $end ]);
+            return $this->redirectToRoute('MetaResult', ['start' => $start, 'end' => $end]);
         }
 
         return $this->render('meta/index.html.twig', [
@@ -45,7 +45,7 @@ 
             ->getConnection();
 
         $query = $this->client->createQueryBuilder();
-        $query->select([ 'date', 'tool', 'count' ])
+        $query->select(['date', 'tool', 'count'])
             ->where($query->expr()->gte('date', ':start'))
             ->where($query->expr()->lte('date', ':end'))
             ->where($query->expr()->neq('tool', '""'))
@@ -61,7 +61,7 @@ 
         $timeline = [];
         $startObj = new DateTime($start);
         $endObj = new DateTime($end);
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
         $grandSum = 0;
 
         foreach ($data as $entry) {
@@ -76,7 +76,7 @@ 
             }
 
             $date = new DateTime($entry['date']);
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
             $timeline[$entry['tool']][$dateIndex] = $entry['count'];
 
             $grandSum += $entry['count'];

src/Xtools/Edit.php

Spacing +7 added lines, -7 removed lines

@@ -46,11 +46,11 @@ 
         $this->page = $page;
 
         // Copy over supported attributes
-        $this->id = (int) $attrs['id'];
+        $this->id = (int)$attrs['id'];
         $this->timestamp = DateTime::createFromFormat('YmdHis', $attrs['timestamp']);
         $this->minor = $attrs['minor'] === '1';
-        $this->length = (int) $attrs['length'];
-        $this->length_change = (int) $attrs['length_change'];
+        $this->length = (int)$attrs['length'];
+        $this->length_change = (int)$attrs['length_change'];
         $this->user = new User($attrs['username']);
         $this->comment = $attrs['comment'];
     }
@@ -179,8 +179,8 @@ 
     public function getDiffUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -190,8 +190,8 @@ 
     public function getPermaUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**