PageTest - Code Metrics - Inspection of "ArticleInfo: moving wikidata and checkwiki queries..." - x-tools/xtools - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f9a368...59d319 )

unknown

created 2017-07-09 00:15 UTC

PageTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	205
Duplicated Lines	10.73 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	4
dl	22
loc	205
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	testTitles()	0	22	1
A	testExists()	0	23	1
A	testId()	11	11	1
A	testUrls()	11	11	1
A	testUsersEdits()	0	20	1
B	testWikidataErrors()	0	40	1

How to fix Duplicated Code

<?php
/**
 * This file contains only the PageTest class.
 */

namespace Tests\Xtools;

// use PHPUnit_Framework_TestCase;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Xtools\Page;
use Xtools\PagesRepository;
use Xtools\Project;
use Xtools\ProjectRepository;
use Xtools\User;

/**
 * Tests for the Page class.
 */
class PageTest extends KernelTestCase
{
    /** @var Container The Symfony container. */
    protected $container;

    /**
     * A page has a title and an HTML display title.
     */
    public function testTitles()
    {
        $project = new Project('TestProject');
        $pageRepo = $this->getMock(PagesRepository::class, ['getPageInfo']);
        $data = [
            [$project, 'Test_Page_1', ['title' => 'Test_Page_1']],
            [$project, 'Test_Page_2', ['title' => 'Test_Page_2', 'displaytitle' => '<em>Test</em> page 2']],
        ];
        $pageRepo->method('getPageInfo')->will($this->returnValueMap($data));

        // Page with no display title.
        $page = new Page($project, 'Test_Page_1');
        $page->setRepository($pageRepo);
        $this->assertEquals('Test_Page_1', $page->getTitle());
        $this->assertEquals('Test_Page_1', $page->getDisplayTitle());

        // Page with a display title.
        $page = new Page($project, 'Test_Page_2');
        $page->setRepository($pageRepo);
        $this->assertEquals('Test_Page_2', $page->getTitle());
        $this->assertEquals('<em>Test</em> page 2', $page->getDisplayTitle());
    }

    /**
     * A page either exists or doesn't.
     */
    public function testExists()
    {
        $pageRepo = $this->getMock(PagesRepository::class, ['getPageInfo']);
        $project = new Project('TestProject');
        // Mock data (last element of each array is the return value).
        $data = [
            [$project, 'Existing_page', []],
            [$project, 'Missing_page', ['missing' => '']],
        ];
        $pageRepo //->expects($this->exactly(2))

            ->method('getPageInfo')
            ->will($this->returnValueMap($data));

        // Existing page.
        $page1 = new Page($project, 'Existing_page');
        $page1->setRepository($pageRepo);
        $this->assertTrue($page1->exists());

        // Missing page.
        $page2 = new Page($project, 'Missing_page');
        $page2->setRepository($pageRepo);
        $this->assertFalse($page2->exists());
    }

    /**
     * A page has an integer ID on a given project.
     */
    public function testId()

    {
        $pageRepo = $this->getMock(PagesRepository::class, ['getPageInfo']);
        $pageRepo->expects($this->once())
            ->method('getPageInfo')
            ->willReturn(['pageid' => '42']);

        $page = new Page(new Project('TestProject'), 'Test_Page');
        $page->setRepository($pageRepo);
        $this->assertEquals(42, $page->getId());
    }

    /**
     * A page has a URL.
     */
    public function testUrls()

    {
        $pageRepo = $this->getMock(PagesRepository::class, ['getPageInfo']);
        $pageRepo->expects($this->once())
            ->method('getPageInfo')
            ->willReturn(['fullurl' => 'https://example.org/Page']);

        $page = new Page(new Project('exampleWiki'), 'Page');
        $page->setRepository($pageRepo);
        $this->assertEquals('https://example.org/Page', $page->getUrl());
    }

    /**
     * A list of a single user's edits on this page can be retrieved, along with the count of
     * these revisions, and the total bytes added and removed.
     * @TODO this is not finished yet
     */
    public function testUsersEdits()
    {
        $pageRepo = $this->getMock(PagesRepository::class, ['getRevisions']);
        $pageRepo
            ->method('getRevisions')
            ->with()
            ->willReturn([
                [
                    'id' => '1',
                    'timestamp' => '20170505100000',
                    'length_change' => '1',
                    'comment' => 'One'
                ],
            ]);

        $page = new Page(new Project('exampleWiki'), 'Page');
        $page->setRepository($pageRepo);
        $user = new User('Testuser');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        //$this->assertCount(3, $page->getRevisions($user)->getCount());

    }

    /**
     * Wikidata errors. With this test getWikidataInfo doesn't return a Description,
     *     so getWikidataErrors should complain accordingly
     */
    public function testWikidataErrors()
    {
        $pageRepo = $this->getMock(PagesRepository::class, ['getWikidataInfo', 'getPageInfo']);

        $pageRepo
            ->method('getWikidataInfo')
            ->with()
            ->willReturn([
                [
                    'term' => 'label',
                    'term_text' => 'My article',
                ],
            ]);
        $pageRepo
            ->method('getPageInfo')
            ->with()
            ->willReturn([
                'pagelanguage' => 'en',
                'pageprops' => [
                    'wikibase_item' => 'Q123',
                ],
            ]);

        $page = new Page(new Project('exampleWiki'), 'Page');
        $page->setRepository($pageRepo);

        $wikidataErrors = $page->getWikidataErrors();

        $this->assertArraySubset(
            [
                'prio' => 3,
                'name' => 'Wikidata',
            ],
            $wikidataErrors[0]
        );
        $this->assertContains(
            'Description',
            $wikidataErrors[0]['notice']
        );
    }

    // public function testPageAssessments()

    // {
    //     $projectRepo = $this->getMock(ProjectRepository::class, ['getAssessmentsConfig']);

    //     $projectRepo
    //         ->method('getAssessmentsConfig')

    //         ->willReturn([
    //             'wikiproject_prefix' => 'Wikipedia:WikiProject_'

    //         ]);

    //     $project = $this->getMock(Project::class, ['getDomain']);

    //     $project
    //         ->method('getDomain')

    //         ->willReturn('test.wiki.org');

    //     $project->setRepository($projectRepo);


    //     $pageRepo = $this->getMock(PagesRepository::class, ['getAssessments', 'getPageInfo']);

    //     $pageRepo
    //         ->method('getAssessments')

    //         ->with($project)

    //         ->willReturn([
    //             [
    //                 'wikiproject' => 'Military history',

    //                 'class' => 'Start',

    //                 'importance' => 'Low',

    //             ],
    //             [
    //                 'wikiproject' => 'Firearms',

    //                 'class' => 'C',

    //                 'importance' => 'High',

    //             ],
    //         ]);
    //     $pageRepo
    //         ->method('getPageInfo')

    //         ->with($project, 'Test_page')

    //         ->willReturn([
    //             'pageid' => 5,

    //         ]);

    //     $page = new Page($project, 'Test_page');

    //     $page->setRepository($pageRepo);


    //     $assessments = $page->getAssessments();


    //     $this->assertEquals('C', $assessments['assessment']);

    // }
}


1			<?php
2			/**
3			* This file contains only the PageTest class.
4			*/
5
6			namespace Tests\Xtools;
7
8			// use PHPUnit_Framework_TestCase;
9			use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
10			use Xtools\Page;
11			use Xtools\PagesRepository;
12			use Xtools\Project;
13			use Xtools\ProjectRepository;
14			use Xtools\User;
15
16			/**
17			* Tests for the Page class.
18			*/
19			class PageTest extends KernelTestCase
20			{
21			/** @var Container The Symfony container. */
22			protected $container;
23
24			/**
25			* A page has a title and an HTML display title.
26			*/
27			public function testTitles()
28			{
29			$project = new Project('TestProject');
30			$pageRepo = $this->getMock(PagesRepository::class, ['getPageInfo']);
31			$data = [
32			[$project, 'Test_Page_1', ['title' => 'Test_Page_1']],
33			[$project, 'Test_Page_2', ['title' => 'Test_Page_2', 'displaytitle' => '<em>Test</em> page 2']],
34			];
35			$pageRepo->method('getPageInfo')->will($this->returnValueMap($data));
36
37			// Page with no display title.
38			$page = new Page($project, 'Test_Page_1');
39			$page->setRepository($pageRepo);
40			$this->assertEquals('Test_Page_1', $page->getTitle());

x-tools / xtools

Push — master ( f9a368...59d319 )

PageTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like