Completed
Pull Request — master (#62)
by MusikAnimal
03:26
created
web/app_dev.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 // Feel free to remove this, extend it, or make something more sophisticated.
13 13
 if (isset($_SERVER['HTTP_CLIENT_IP'])
14 14
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
15
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
15
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
16 16
 ) {
17 17
     header('HTTP/1.0 403 Forbidden');
18 18
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
Please login to merge, or discard this patch.
src/AppBundle/Helper/PageviewsHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@  discard block
 block discarded – undo
12 12
         $title = str_replace(' ', '_', $title);
13 13
         $client = new GuzzleHttp\Client();
14 14
 
15
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
16
-            "$project/all-access/user/" . rawurlencode($title) . '/daily/' . $start . '/' . $end;
15
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
16
+            "$project/all-access/user/".rawurlencode($title).'/daily/'.$start.'/'.$end;
17 17
 
18 18
         $res = $client->request('GET', $url);
19 19
         return json_decode($res->getBody()->getContents());
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         $data = $this->getLastDays($project, $title, $days);
33 33
 
34 34
         // FIXME: needs to handle gotchas
35
-        return array_sum(array_map(function ($item) {
35
+        return array_sum(array_map(function($item) {
36 36
             return $item->views;
37 37
         }, $data->items));
38 38
     }
Please login to merge, or discard this patch.
src/AppBundle/Twig/Extension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         }
46 46
 
47 47
         // Find the path, and complain if English doesn't exist.
48
-        $path = $this->container->getParameter("kernel.root_dir") . '/../i18n';
48
+        $path = $this->container->getParameter("kernel.root_dir").'/../i18n';
49 49
         if (!file_exists("$path/en.json")) {
50 50
             throw new Exception("Language directory doesn't exist: $path");
51 51
         }
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminStatsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 
177 177
         // Iterate over query results, loading each user id into the array
178 178
         while ($row = $res->fetch()) {
179
-            $adminIdArr[] = $row["user_id"] ;
179
+            $adminIdArr[] = $row["user_id"];
180 180
         }
181 181
 
182 182
         // Set the query results to be useful in a sql statement.
Please login to merge, or discard this patch.
src/AppBundle/Controller/QuoteController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
             'quote/all.html.twig',
112 112
             [
113 113
                 'base_dir' => realpath(
114
-                    $this->getParameter('kernel.root_dir') . '/..'
114
+                    $this->getParameter('kernel.root_dir').'/..'
115 115
                 ),
116 116
                 'xtPage' => 'bash',
117 117
                 'quotes' => $quotes,
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             'quote/view.html.twig',
161 161
             [
162 162
                 'base_dir' => realpath(
163
-                    $this->getParameter('kernel.root_dir') . '/..'
163
+                    $this->getParameter('kernel.root_dir').'/..'
164 164
                 ),
165 165
                 "xtPage" => "bash",
166 166
                 "text" => $text,
Please login to merge, or discard this patch.
app/autoload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,6 +8,6 @@
 block discarded – undo
8 8
  */
9 9
 $loader = require __DIR__.'/../vendor/autoload.php';
10 10
 
11
-AnnotationRegistry::registerLoader([ $loader, 'loadClass' ]);
11
+AnnotationRegistry::registerLoader([$loader, 'loadClass']);
12 12
 
13 13
 return $loader;
Please login to merge, or discard this patch.
app/AppKernel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
             new AppBundle\AppBundle(),
28 28
         ];
29 29
 
30
-        if (in_array($this->getEnvironment(), [ 'dev', 'test' ], true)) {
30
+        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
31 31
             $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
32 32
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
33 33
             $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminScoreController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10 10
 use Symfony\Component\HttpFoundation\Request;
11 11
 use Symfony\Component\HttpFoundation\Response;
12
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
13 12
 use DateTime;
14 13
 use Xtools\ProjectRepository;
15 14
 use Xtools\UserRepository;
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@  discard block
 block discarded – undo
47 47
         $username = $request->query->get('username', $request->query->get('user'));
48 48
 
49 49
         if ($projectQuery != '' && $username != '') {
50
-            return $this->redirectToRoute('AdminScoreResult', [ 'project' => $projectQuery, 'username' => $username ]);
50
+            return $this->redirectToRoute('AdminScoreResult', ['project' => $projectQuery, 'username' => $username]);
51 51
         } elseif ($projectQuery != '') {
52
-            return $this->redirectToRoute('AdminScoreProject', [ 'project' => $projectQuery ]);
52
+            return $this->redirectToRoute('AdminScoreProject', ['project' => $projectQuery]);
53 53
         }
54 54
 
55 55
         // Set default project so we can populate the namespace selector.
@@ -95,20 +95,20 @@  discard block
 block discarded – undo
95 95
         $archiveTable = $projectRepo->getTableName($dbName, 'archive');
96 96
 
97 97
         // MULTIPLIERS (to review)
98
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
99
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
100
-        $USER_PAGE_MULT = 0.1;     # 0 if =
98
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
99
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
100
+        $USER_PAGE_MULT = 0.1; # 0 if =
101 101
         $PATROLS_MULT = 1; # 0 if =
102
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
102
+        $BLOCKS_MULT = 1.4; # 0 if = 10
103 103
         $AFD_MULT = 1.15;
104
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
104
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
105 105
         $AIV_MULT = 1.15;
106
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
107
-        $NAMESPACES_MULT = 1.0;     # 0 if =
106
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
107
+        $NAMESPACES_MULT = 1.0; # 0 if =
108 108
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
109 109
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
110
-        $RPP_MULT = 1.15;     # 0 if =
111
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
110
+        $RPP_MULT = 1.15; # 0 if =
111
+        $USERRIGHTS_MULT = 0.75; # 0 if =
112 112
 
113 113
         // Grab the connection to the replica database (which is separate from the above)
114 114
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -186,15 +186,15 @@  discard block
 block discarded – undo
186 186
                 $now = new DateTime();
187 187
                 $date = new DateTime($value);
188 188
                 $diff = $date->diff($now);
189
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
189
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
190 190
                 $value = $formula-365;
191 191
             }
192 192
 
193 193
             if ($key == "id") {
194 194
                 $id = $value;
195 195
             } else {
196
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
197
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
196
+                $multiplierKey = strtoupper($row["source"]."_MULT");
197
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
198 198
                 $score = max(min($value * $multiplier, 100), -100);
199 199
                 $master[$key]["mult"] = $multiplier;
200 200
                 $master[$key]["value"] = $value;
@@ -204,8 +204,8 @@  discard block
 block discarded – undo
204 204
         }
205 205
 
206 206
         if ($id == 0) {
207
-            $this->addFlash("notice", [ "no-result", $username ]);
208
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
207
+            $this->addFlash("notice", ["no-result", $username]);
208
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
209 209
         }
210 210
 
211 211
         return $this->render('adminscore/result.html.twig', [
Please login to merge, or discard this patch.
src/AppBundle/Controller/DefaultController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     public function loginAction()
91 91
     {
92 92
         try {
93
-            list( $next, $token ) = $this->getOauthClient()->initiate();
93
+            list($next, $token) = $this->getOauthClient()->initiate();
94 94
         } catch (Exception $oauthException) {
95 95
             throw $oauthException;
96 96
             // @TODO Make this work.
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                     . '/index.php?title=Special:OAuth';
156 156
         $conf = new ClientConfig($endpoint);
157 157
         $consumerKey = $this->getParameter('oauth_key');
158
-        $consumerSecret =  $this->getParameter('oauth_secret');
158
+        $consumerSecret = $this->getParameter('oauth_secret');
159 159
         $conf->setConsumer(new Consumer($consumerKey, $consumerSecret));
160 160
         $this->oauthClient = new Client($conf);
161 161
         // Callback URL is hardcoded in the consumer registration.
Please login to merge, or discard this patch.