Passed
Push — rate-limit-improvements ( be34fb...f1c343 )
by MusikAnimal
03:25
created
migrations/Version20171208040821.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace DoctrineMigrations;
6 6
 
Please login to merge, or discard this patch.
migrations/Version20170623205224.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace DoctrineMigrations;
6 6
 
Please login to merge, or discard this patch.
src/Model/User.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace App\Model;
6 6
 
@@ -126,14 +126,14 @@  discard block
 block discarded – undo
126 126
             $firstAddrUnpacked = unpack('H*', $firstAddrBin);
127 127
             $firstAddrHex = reset($firstAddrUnpacked);
128 128
             $range[0] = inet_ntop($firstAddrBin);
129
-            $flexBits = 128 - $prefixLen;
129
+            $flexBits = 128-$prefixLen;
130 130
             $lastAddrHex = $firstAddrHex;
131 131
 
132 132
             $pos = 31;
133 133
             while ($flexBits > 0) {
134 134
                 $orig = substr($lastAddrHex, $pos, 1);
135 135
                 $origVal = hexdec($orig);
136
-                $newVal = $origVal | (pow(2, min(4, $flexBits)) - 1);
136
+                $newVal = $origVal | (pow(2, min(4, $flexBits))-1);
137 137
                 $new = dechex($newVal);
138 138
                 $lastAddrHex = substr_replace($lastAddrHex, $new, $pos, 1);
139 139
                 $flexBits -= 4;
@@ -144,8 +144,8 @@  discard block
 block discarded – undo
144 144
             $range[1] = inet_ntop($lastAddrBin);
145 145
         } else {
146 146
             $cidr = explode('/', $this->username);
147
-            $range[0] = long2ip(ip2long($cidr[0]) & -1 << (32 - (int)$cidr[1]));
148
-            $range[1] = long2ip(ip2long($range[0]) + pow(2, (32 - (int)$cidr[1])) - 1);
147
+            $range[0] = long2ip(ip2long($cidr[0]) & -1 << (32-(int)$cidr[1]));
148
+            $range[1] = long2ip(ip2long($range[0])+pow(2, (32-(int)$cidr[1]))-1);
149 149
         }
150 150
 
151 151
         // Find the leftmost common characters between the two addresses.
Please login to merge, or discard this patch.
src/Controller/MetaController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
         $timeline = [];
105 105
         $startObj = new DateTime($start);
106 106
         $endObj = new DateTime($end);
107
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
107
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
108 108
         $grandSum = 0;
109 109
 
110 110
         // Generate array of date labels
@@ -114,17 +114,17 @@  discard block
 block discarded – undo
114 114
 
115 115
         foreach ($data as $entry) {
116 116
             if (!isset($totals[$entry['tool']])) {
117
-                $totals[$entry['tool']] = (int) $entry['count'];
117
+                $totals[$entry['tool']] = (int)$entry['count'];
118 118
 
119 119
                 // Create arrays for each tool, filled with zeros for each date in the timeline
120 120
                 $timeline[$entry['tool']] = array_fill(0, $numDays, 0);
121 121
             } else {
122
-                $totals[$entry['tool']] += (int) $entry['count'];
122
+                $totals[$entry['tool']] += (int)$entry['count'];
123 123
             }
124 124
 
125 125
             $date = new DateTime($entry['date']);
126
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
127
-            $timeline[$entry['tool']][$dateIndex] = (int) $entry['count'];
126
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
127
+            $timeline[$entry['tool']][$dateIndex] = (int)$entry['count'];
128 128
 
129 129
             $grandSum += $entry['count'];
130 130
         }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
         $timeline = [];
160 160
         $startObj = new DateTime($start);
161 161
         $endObj = new DateTime($end);
162
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
162
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
163 163
         $grandSum = 0;
164 164
 
165 165
         // Generate array of date labels
@@ -169,17 +169,17 @@  discard block
 block discarded – undo
169 169
 
170 170
         foreach ($data as $entry) {
171 171
             if (!isset($totals[$entry['endpoint']])) {
172
-                $totals[$entry['endpoint']] = (int) $entry['count'];
172
+                $totals[$entry['endpoint']] = (int)$entry['count'];
173 173
 
174 174
                 // Create arrays for each endpoint, filled with zeros for each date in the timeline
175 175
                 $timeline[$entry['endpoint']] = array_fill(0, $numDays, 0);
176 176
             } else {
177
-                $totals[$entry['endpoint']] += (int) $entry['count'];
177
+                $totals[$entry['endpoint']] += (int)$entry['count'];
178 178
             }
179 179
 
180 180
             $date = new DateTime($entry['date']);
181
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
182
-            $timeline[$entry['endpoint']][$dateIndex] = (int) $entry['count'];
181
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
182
+            $timeline[$entry['endpoint']][$dateIndex] = (int)$entry['count'];
183 183
 
184 184
             $grandSum += $entry['count'];
185 185
         }
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
 
240 240
         /** @var Connection $conn */
241 241
         $conn = $managerRegistry->getConnection('default');
242
-        $date =  date('Y-m-d');
242
+        $date = date('Y-m-d');
243 243
 
244 244
         // Tool name needs to be lowercase.
245 245
         $tool = strtolower($tool);
Please login to merge, or discard this patch.
src/Exception/BadGatewayException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace App\Exception;
6 6
 
Please login to merge, or discard this patch.
src/Model/Page.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace App\Model;
6 6
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         $title = $info['title'] ?? $this->unnormalizedPageName;
125 125
         $nsName = $this->getNamespaceName();
126 126
         return $nsName
127
-            ? str_replace($nsName . ':', '', $title)
127
+            ? str_replace($nsName.':', '', $title)
128 128
             : $title;
129 129
     }
130 130
 
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
     {
323 323
         $content = $this->repository->getPagesWikitext(
324 324
             $this->getProject(),
325
-            [ $this->getTitle() ]
325
+            [$this->getTitle()]
326 326
         );
327 327
 
328 328
         return $content[$this->getTitle()] ?? null;
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
 
389 389
         $wikidataInfo = $this->repository->getWikidataInfo($this);
390 390
 
391
-        $terms = array_map(function ($entry) {
391
+        $terms = array_map(function($entry) {
392 392
             return $entry['term'];
393 393
         }, $wikidataInfo);
394 394
 
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
                 'prio' => 2,
400 400
                 'name' => 'Wikidata',
401 401
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
402
-                'explanation' => "See: <a target='_blank' " .
402
+                'explanation' => "See: <a target='_blank' ".
403 403
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
404 404
             ];
405 405
         }
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
                 'prio' => 3,
410 410
                 'name' => 'Wikidata',
411 411
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
412
-                'explanation' => "See: <a target='_blank' " .
412
+                'explanation' => "See: <a target='_blank' ".
413 413
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
414 414
             ];
415 415
         }
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
             return null;
492 492
         }
493 493
 
494
-        return array_sum(array_map(function ($item) {
494
+        return array_sum(array_map(function($item) {
495 495
             return (int)$item['views'];
496 496
         }, $pageviews['items']));
497 497
     }
Please login to merge, or discard this patch.
src/Model/ArticleInfoApi.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace App\Model;
6 6
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         [$bytes, $chars, $words] = $this->countCharsAndWords($crawler);
172 172
 
173 173
         $refContent = [];
174
-        $refs->each(function ($ref) use (&$refContent): void {
174
+        $refs->each(function($ref) use (&$refContent): void {
175 175
             $refContent[] = $ref->text();
176 176
         });
177 177
         $uniqueRefs = count(array_unique($refContent));
@@ -206,13 +206,13 @@  discard block
 block discarded – undo
206 206
             '[typeof~="mw:Extension/templatestyles"]',
207 207
             '[typeof~="mw:Extension/math"]',
208 208
             '[typeof~="mw:Extension/ref"]',
209
-        ]))->each(function (Crawler $subCrawler) {
209
+        ]))->each(function(Crawler $subCrawler) {
210 210
             foreach ($subCrawler as $subNode) {
211 211
                 $subNode->parentNode->removeChild($subNode);
212 212
             }
213 213
         });
214 214
 
215
-        $paragraphs->each(function ($node) use (&$totalBytes, &$totalChars, &$totalWords): void {
215
+        $paragraphs->each(function($node) use (&$totalBytes, &$totalChars, &$totalWords): void {
216 216
             /** @var Crawler $node */
217 217
             $text = $node->text();
218 218
             $totalBytes += strlen($text);
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
         $data = [
275 275
             'project' => $project->getDomain(),
276 276
             'page' => $page->getTitle(),
277
-            'watchers' => (int) $page->getWatchers(),
277
+            'watchers' => (int)$page->getWatchers(),
278 278
             'pageviews' => $page->getLatestPageviews(),
279 279
             'pageviews_offset' => self::PAGEVIEWS_OFFSET,
280 280
         ];
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
         if ($info) {
298 298
             $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
299 299
             $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
300
-            $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
300
+            $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
301 301
 
302 302
             // Some wikis (such foundation.wikimedia.org) may be missing the creation date.
303 303
             $creationDateTime = false === $creationDateTime
@@ -309,16 +309,16 @@  discard block
 block discarded – undo
309 309
                 ->getAssessment($page);
310 310
 
311 311
             $data = array_merge($data, [
312
-                'revisions' => (int) $info['num_edits'],
313
-                'editors' => (int) $info['num_editors'],
314
-                'minor_edits' => (int) $info['minor_edits'],
312
+                'revisions' => (int)$info['num_edits'],
313
+                'editors' => (int)$info['num_editors'],
314
+                'minor_edits' => (int)$info['minor_edits'],
315 315
                 'author' => $info['author'],
316
-                'author_editcount' => null === $info['author_editcount'] ? null : (int) $info['author_editcount'],
316
+                'author_editcount' => null === $info['author_editcount'] ? null : (int)$info['author_editcount'],
317 317
                 'created_at' => $creationDateTime,
318 318
                 'created_rev_id' => $info['created_rev_id'],
319 319
                 'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
320 320
                 'secs_since_last_edit' => $secsSinceLastEdit,
321
-                'last_edit_id' => (int) $info['modified_rev_id'],
321
+                'last_edit_id' => (int)$info['modified_rev_id'],
322 322
                 'assessment' => $assessment,
323 323
             ]);
324 324
         }
@@ -468,8 +468,8 @@  discard block
 block discarded – undo
468 468
         }
469 469
 
470 470
         // Sort by edit count.
471
-        uasort($this->bots, function ($a, $b) {
472
-            return $b['count'] - $a['count'];
471
+        uasort($this->bots, function($a, $b) {
472
+            return $b['count']-$a['count'];
473 473
         });
474 474
 
475 475
         return $this->bots;
Please login to merge, or discard this patch.
src/Controller/ArticleInfoController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -267,7 +267,7 @@
 block discarded – undo
267 267
         $responseCode = Response::HTTP_OK;
268 268
         $this->recordApiUsage('page/prose');
269 269
         $this->setupArticleInfo($articleInfoRepo, $autoEditsHelper);
270
-        $this->addFlash('info', 'The algorithm used by this API has recently changed. ' .
270
+        $this->addFlash('info', 'The algorithm used by this API has recently changed. '.
271 271
             'See https://www.mediawiki.org/wiki/XTools/Page_History#Prose for details.');
272 272
         $ret = $this->articleInfo->getProseStats();
273 273
         if (null === $ret) {
Please login to merge, or discard this patch.
src/Repository/AuthorshipRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace App\Repository;
6 6
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
         try {
49 49
             $res = $this->guzzle->request('GET', $url, $opts);
50
-        } catch (ServerException|ConnectException $e) {
50
+        } catch (ServerException | ConnectException $e) {
51 51
             throw new BadGatewayException('api-error-wikimedia', ['WikiWho'], $e);
52 52
         }
53 53
 
Please login to merge, or discard this patch.