Completed
Pull Request — master (#14)
by Sam
02:36
created
src/AppBundle/Controller/ArticleInfoController.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -380,7 +380,6 @@
 block discarded – undo
380 380
 
381 381
     /**
382 382
      * Get the size of the diff
383
-     * @param  int $rev The index of the revision within $this->pageHistory
384 383
      * @return int Size of the diff
385 384
      */
386 385
     private function getDiffSize($revIndex)
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@
 block discarded – undo
164 164
     private function getRevCount()
165 165
     {
166 166
         $query = "SELECT COUNT(*) AS count FROM " . $this->revisionTable
167
-                 . " WHERE rev_page = '" . $this->pageInfo['id'] . "'";
167
+                    . " WHERE rev_page = '" . $this->pageInfo['id'] . "'";
168 168
         $res = $this->conn->query($query)->fetchAll();
169 169
         return $res[0]['count'];
170 170
     }
Please login to merge, or discard this patch.
src/AppBundle/Helper/LabsHelper.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
         $this->container = $container;
26 26
     }
27 27
 
28
+    /**
29
+     * @param string $tool
30
+     */
28 31
     public function checkEnabled($tool)
29 32
     {
30 33
         if (!$this->container->getParameter("enable.$tool")) {
Please login to merge, or discard this patch.
src/AppBundle/Twig/WikiExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@
 block discarded – undo
157 157
     /**
158 158
      * Get links to pageviews tools for the given page
159 159
      * @param  string $title      Title of page
160
-     * @param  string $projectUrl Project domain such as en.wikipedia.org
160
+     * @param  string $project Project domain such as en.wikipedia.org
161 161
      * @return string Markup
162 162
      */
163 163
     public function pageviewsLinks($title, $project)
Please login to merge, or discard this patch.
var/SymfonyRequirements.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      * Adds a mandatory requirement in form of a php.ini configuration.
224 224
      *
225 225
      * @param string        $cfgName           The configuration name used for ini_get()
226
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
226
+     * @param boolean|string $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
227 227
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
228 228
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
229 229
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
      * Adds an optional recommendation in form of a php.ini configuration.
242 242
      *
243 243
      * @param string        $cfgName           The configuration name used for ini_get()
244
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
244
+     * @param string|false $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
245 245
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
246 246
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
247 247
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
Please login to merge, or discard this patch.
src/AppBundle/Helper/ApiHelper.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,6 +34,9 @@  discard block
 block discarded – undo
34 34
         }
35 35
     }
36 36
 
37
+    /**
38
+     * @param string $username
39
+     */
37 40
     public function groups($project, $username)
38 41
     {
39 42
         $cacheKey = "groups.$project.$username";
@@ -59,6 +62,9 @@  discard block
 block discarded – undo
59 62
         return $result;
60 63
     }
61 64
 
65
+    /**
66
+     * @param string $username
67
+     */
62 68
     public function globalGroups($project, $username)
63 69
     {
64 70
         $cacheKey = "globalgroups.$project.$username";
@@ -363,7 +369,7 @@  discard block
 block discarded – undo
363 369
      * Adapted from https://github.com/MusikAnimal/pageviews
364 370
      * @param  array       $params        Associative array of params to pass to API
365 371
      * @param  string      $project       Project to query, e.g. en.wikipedia.org
366
-     * @param  string|func $dataKey       The key for the main chunk of data, in the query hash
372
+     * @param  \Closure $dataKey       The key for the main chunk of data, in the query hash
367 373
      *                                    (e.g. 'categorymembers' for API:Categorymembers).
368 374
      *                                    If this is a function it is given the response data,
369 375
      *                                    and expected to return the data we want to concatentate.
Please login to merge, or discard this patch.
src/AppBundle/Helper/EditCounterHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@
 block discarded – undo
146 146
 
147 147
     /**
148 148
      *
149
-     * @param $username
149
+     * @param string $username
150 150
      * @return integer
151 151
      */
152 152
     public function getPageCounts($username, $totalRevisions)
Please login to merge, or discard this patch.