x-tools / xtools

src/AppBundle/Twig/Extension.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         }
 
         // Find the path, and complain if English doesn't exist.
-        $path = $this->container->getParameter('kernel.root_dir') . '/../i18n';
+        $path = $this->container->getParameter('kernel.root_dir').'/../i18n';
         if (!file_exists("$path/en.json")) {
             throw new Exception("Language directory doesn't exist: $path");
         }

src/Xtools/TopEdits.php

Spacing +6 added lines, -6 removed lines

@@ -119,9 +119,9 @@ 
         $displayTitles = $this->getDisplayTitles($pages);
 
         foreach ($pages as $page) {
-            $nsId = (int) $page['page_namespace'];
-            $nsTitle = $nsId > 0 ? $this->project->getNamespaces()[$page['page_namespace']] . ':' : '';
-            $pageTitle = $nsTitle . $page['page_title'];
+            $nsId = (int)$page['page_namespace'];
+            $nsTitle = $nsId > 0 ? $this->project->getNamespaces()[$page['page_namespace']].':' : '';
+            $pageTitle = $nsTitle.$page['page_title'];
             $page['displaytitle'] = $displayTitles[$pageTitle];
 
             // $page['page_title'] is retained without the namespace
@@ -148,11 +148,11 @@ 
         $namespaces = $this->project->getNamespaces();
 
         // First extract page titles including namespace.
-        $pageTitles = array_map(function ($page) use ($namespaces) {
+        $pageTitles = array_map(function($page) use ($namespaces) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $page['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']] . ':' : '';
-            return $nsTitle . $page['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']].':' : '';
+            return $nsTitle.$page['page_title'];
         }, $topPages);
 
         return $this->getRepository()->getDisplayTitles($this->project, $pageTitles);

src/Xtools/TopEditsRepository.php

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments() && $namespace === 0;
         $paSelect = $hasPageAssessments
-            ?  ", (
+            ? ", (
                     SELECT pa_class
                     FROM page_assessments
                     WHERE pa_page_id = page_id
@@ -92,7 +92,7 @@ 
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments();
         $pageAssessmentsTable = $this->getTableName($project->getDatabaseName(), 'page_assessments');
         $paSelect = $hasPageAssessments
-            ?  ", (
+            ? ", (
                     SELECT pa_class
                     FROM $pageAssessmentsTable
                     WHERE pa_page_id = e.page_id

src/AppBundle/Controller/TopEditsController.php

Spacing +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,

src/Xtools/AdminStatsRepository.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
         $userGroupsTable = $project->getTableName('user_groups');
         $ufgTable = $project->getTableName('user_former_groups');
 
-        $adminGroups = join(array_map(function ($group) {
+        $adminGroups = join(array_map(function($group) {
             return "'$group'";
         }, $this->getAdminGroups($project)), ',');
 

src/Xtools/ProjectRepository.php

Spacing +2 added lines, -2 removed lines

@@ -149,7 +149,7 @@ 
                     || $projMetadata['url'] == "https://$project"
                     || $projMetadata['url'] == "https://$project.org"
                     || $projMetadata['url'] == "https://www.$project") {
-                    $this->log->debug(__METHOD__ . " Using cached data for $project");
+                    $this->log->debug(__METHOD__." Using cached data for $project");
                     return $projMetadata;
                 }
             }
@@ -292,7 +292,7 @@ 
         $optedIn = $this->container->getParameter('opted_in');
         // In case there's just one given.
         if (!is_array($optedIn)) {
-            $optedIn = [ $optedIn ];
+            $optedIn = [$optedIn];
         }
         return $optedIn;
     }

Indentation +3 added lines, -3 removed lines

@@ -339,9 +339,9 @@
         $conn = $this->getProjectsConnection();
         $pageTable = $this->getTableName($project->getDatabaseName(), 'page');
         $query = "SELECT page_id "
-             . " FROM $pageTable "
-             . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
-             . " LIMIT 1";
+                . " FROM $pageTable "
+                . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
+                . " LIMIT 1";
         $params = [
             'ns' => $namespaceId,
             'title' => str_replace(' ', '_', $pageTitle),

src/Xtools/AdminStats.php

Spacing +3 added lines, -3 removed lines

@@ -125,7 +125,7 @@ 
      */
     public function numDays()
     {
-        return ($this->end - $this->start) / 60 / 60 / 24;
+        return ($this->end-$this->start) / 60 / 60 / 24;
     }
 
     /**
@@ -154,7 +154,7 @@ 
         $stats = $this->groupAdminStatsByUsername($stats, $abbreviateGroups);
 
         // Resort, as for some reason the SQL isn't doing this properly.
-        uasort($stats, function ($a, $b) {
+        uasort($stats, function($a, $b) {
             if ($a['total'] === $b['total']) {
                 return 0;
             }
@@ -296,7 +296,7 @@ 
      */
     public function getNumAdminsWithActions()
     {
-        return $this->numAdmins() - $this->adminsWithoutActions;
+        return $this->numAdmins()-$this->adminsWithoutActions;
     }
 
     /**

src/Xtools/EditCounter.php

Spacing +27 added lines, -27 removed lines

@@ -117,8 +117,8 @@ 
             $promises[] = $promise;
 
             // Handle response of $promise asynchronously.
-            $promise->then(function ($response) use ($key, $endpoint) {
-                $result = (array) json_decode($response->getBody()->getContents());
+            $promise->then(function($response) use ($key, $endpoint) {
+                $result = (array)json_decode($response->getBody()->getContents());
 
                 $this->getRepository()
                     ->getLog()
@@ -135,7 +135,7 @@ 
                     // We'll log this to see how often it happens.
                     $this->getRepository()
                         ->getLog()
-                        ->error("Failed to fetch data for $endpoint via async, " .
+                        ->error("Failed to fetch data for $endpoint via async, ".
                             "re-attempting synchoronously.");
                 }
             });
@@ -191,7 +191,7 @@ 
 
         // Filter out unblocks unless requested.
         if ($blocksOnly) {
-            $blocks = array_filter($blocks, function ($block) {
+            $blocks = array_filter($blocks, function($block) {
                 return $block['log_action'] === 'block';
             });
         }
@@ -225,7 +225,7 @@ 
      */
     public function countAllRevisions()
     {
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
     }
 
     /**
@@ -244,7 +244,7 @@ 
      */
     public function countRevisionsWithoutComments()
     {
-        return $this->countLiveRevisions() - $this->countRevisionsWithComments();
+        return $this->countLiveRevisions()-$this->countRevisionsWithComments();
     }
 
     /**
@@ -283,7 +283,7 @@ 
      */
     public function countAllPagesEdited()
     {
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
     }
 
     /**
@@ -293,7 +293,7 @@ 
      */
     public function countPagesCreated()
     {
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
     }
 
     /**
@@ -433,7 +433,7 @@ 
             } elseif ($block['log_action'] === 'unblock') {
                 // The last block was lifted. So the duration will be the time from when the
                 // last block was set to the time of the unblock.
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
                 if ($timeSinceLastBlock > $this->longestBlockSeconds) {
                     $this->longestBlockSeconds = $timeSinceLastBlock;
 
@@ -444,8 +444,8 @@ 
                 // The last block was modified. So we will adjust $lastBlock to include
                 // the difference of the duration of the new reblock, and time since the last block.
                 // $lastBlock is left unchanged if its duration was indefinite.
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
-                $lastBlock[1] = $timeSinceLastBlock + $duration;
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
+                $lastBlock[1] = $timeSinceLastBlock+$duration;
             }
         }
 
@@ -455,7 +455,7 @@ 
         }
 
         // Test if the last block is still active, and if so use the expiry as the duration.
-        $lastBlockExpiry = $lastBlock[0] + $lastBlock[1];
+        $lastBlockExpiry = $lastBlock[0]+$lastBlock[1];
         if ($lastBlockExpiry > time() && $lastBlockExpiry > $this->longestBlockSeconds) {
             $this->longestBlockSeconds = $lastBlock[1];
         // Otherwise, test if the duration of the last block is now the longest overall.
@@ -496,7 +496,7 @@ 
         // If invalid, $duration is left as null.
         if (strtotime($durationStr)) {
             $expiry = strtotime($durationStr, $timestamp);
-            $duration = $expiry - $timestamp;
+            $duration = $expiry-$timestamp;
         }
 
         return [$timestamp, $duration];
@@ -573,7 +573,7 @@ 
         $import = isset($logCounts['import-import']) ? (int)$logCounts['import-import'] : 0;
         $interwiki = isset($logCounts['import-interwiki']) ? (int)$logCounts['import-interwiki'] : 0;
         $upload = isset($logCounts['import-upload']) ? (int)$logCounts['import-upload'] : 0;
-        return $import + $interwiki + $upload;
+        return $import+$interwiki+$upload;
     }
 
     /**
@@ -697,9 +697,9 @@ 
     public function approvals()
     {
         $logCounts = $this->getLogCounts();
-        $total = $logCounts['review-approve'] +
-        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
-        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
+        $total = $logCounts['review-approve']+
+        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
+        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
         (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
         return $total;
     }
@@ -723,7 +723,7 @@ 
         $logCounts = $this->getLogCounts();
         $create2 = $logCounts['newusers-create2'] ?: 0;
         $byemail = $logCounts['newusers-byemail'] ?: 0;
-        return $create2 + $byemail;
+        return $create2+$byemail;
     }
 
     /**
@@ -775,7 +775,7 @@ 
 
         $totals = $this->getRepository()->getMonthCounts($this->project, $this->user);
         $out = [
-            'yearLabels' => [],  // labels for years
+            'yearLabels' => [], // labels for years
             'monthLabels' => [], // labels for months
             'totals' => [], // actual totals, grouped by namespace, year and then month
         ];
@@ -842,7 +842,7 @@ 
                 $out['totals'][$ns][$total['year']] = [];
             }
 
-            $out['totals'][$ns][$total['year']][$total['month']] = (int) $total['count'];
+            $out['totals'][$ns][$total['year']][$total['month']] = (int)$total['count'];
         }
 
         return [$out, $firstEdit];
@@ -859,8 +859,8 @@ 
     private function fillInMonthTotalsAndLabels($out, DatePeriod $dateRange)
     {
         foreach ($dateRange as $monthObj) {
-            $year = (int) $monthObj->format('Y');
-            $month = (int) $monthObj->format('n');
+            $year = (int)$monthObj->format('Y');
+            $month = (int)$monthObj->format('n');
 
             // Fill in labels
             $out['monthLabels'][] = $monthObj->format('Y-m');
@@ -963,8 +963,8 @@ 
 
         if ($sorted) {
             // Sort.
-            uasort($this->globalEditCounts, function ($a, $b) {
-                return $b['total'] - $a['total'];
+            uasort($this->globalEditCounts, function($a, $b) {
+                return $b['total']-$a['total'];
             });
         }
 
@@ -1000,7 +1000,7 @@ 
                 $nsName = $project->getNamespaces()[$revision['page_namespace']];
             }
             $page = $project->getRepository()
-                ->getPage($project, $nsName . ':' . $revision['page_title']);
+                ->getPage($project, $nsName.':'.$revision['page_title']);
             $edit = new Edit($page, $revision);
             $globalEdits[$edit->getTimestamp()->getTimestamp().'-'.$edit->getId()] = $edit;
         }
@@ -1041,7 +1041,7 @@ 
     public function countSmallEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['small_edits']) ? (int) $editSizeData['small_edits'] : 0;
+        return isset($editSizeData['small_edits']) ? (int)$editSizeData['small_edits'] : 0;
     }
 
     /**
@@ -1051,7 +1051,7 @@ 
     public function countLargeEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['large_edits']) ? (int) $editSizeData['large_edits'] : 0;
+        return isset($editSizeData['large_edits']) ? (int)$editSizeData['large_edits'] : 0;
     }
 
     /**

src/AppBundle/Controller/DefaultController.php

Spacing +2 added lines, -2 removed lines

@@ -89,7 +89,7 @@ 
     public function loginAction()
     {
         try {
-            list( $next, $token ) = $this->getOauthClient()->initiate();
+            list($next, $token) = $this->getOauthClient()->initiate();
         } catch (Exception $oauthException) {
             throw $oauthException;
             // @TODO Make this work.
@@ -156,7 +156,7 @@ 
                     . '?title=Special:OAuth';
         $conf = new ClientConfig($endpoint);
         $consumerKey = $this->getParameter('oauth_key');
-        $consumerSecret =  $this->getParameter('oauth_secret');
+        $consumerSecret = $this->getParameter('oauth_secret');
         $conf->setConsumer(new Consumer($consumerKey, $consumerSecret));
         $this->oauthClient = new Client($conf);
         // Callback URL is hardcoded in the consumer registration.