Completed
Push — master ( 6e7546...159457 )
by Sam
02:58
created
src/Xtools/ProjectRepository.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -251,9 +251,9 @@
 block discarded – undo
251 251
         $conn = $this->getProjectsConnection();
252 252
         $pageTable = $this->getTableName($project->getDatabaseName(), 'page');
253 253
         $query = "SELECT page_id "
254
-             . " FROM $pageTable "
255
-             . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
256
-             . " LIMIT 1";
254
+                . " FROM $pageTable "
255
+                . " WHERE page_namespace = :ns AND page_title = :title AND page_len > 0 "
256
+                . " LIMIT 1";
257 257
         $params = [
258 258
             'ns' => $namespaceId,
259 259
             'title' => $pageTitle,
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
                 if ($projMetadata['dbName'] == "$project"
147 147
                     || $projMetadata['url'] == "$project"
148 148
                     || $projMetadata['url'] == "https://$project") {
149
-                    $this->log->debug(__METHOD__ . " Using cached data for $project");
149
+                    $this->log->debug(__METHOD__." Using cached data for $project");
150 150
                     return $projMetadata;
151 151
                 }
152 152
             }
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
         }
201 201
 
202 202
         // Redis cache
203
-        $cacheKey = "projectMetadata." . preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
203
+        $cacheKey = "projectMetadata.".preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
204 204
         if ($this->cache->hasItem($cacheKey)) {
205 205
             $this->metadata = $this->cache->getItem($cacheKey)->get();
206 206
             return $this->metadata;
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
         $optedIn = $this->container->getParameter('opted_in');
281 281
         // In case there's just one given.
282 282
         if (!is_array($optedIn)) {
283
-            $optedIn = [ $optedIn ];
283
+            $optedIn = [$optedIn];
284 284
         }
285 285
         return $optedIn;
286 286
     }
Please login to merge, or discard this patch.
src/Xtools/Edit.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Xtools;
4 4
 
5 5
 use Xtools\User;
6
-use AppBundle\Helper\AutomatedEditsHelper;
7 6
 use DateTime;
8 7
 
9 8
 /**
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -46,11 +46,11 @@  discard block
 block discarded – undo
46 46
         $this->page = $page;
47 47
 
48 48
         // Copy over supported attributes
49
-        $this->id = (int) $attrs['id'];
49
+        $this->id = (int)$attrs['id'];
50 50
         $this->timestamp = DateTime::createFromFormat('YmdHis', $attrs['timestamp']);
51 51
         $this->minor = $attrs['minor'] === '1';
52
-        $this->length = (int) $attrs['length'];
53
-        $this->length_change = (int) $attrs['length_change'];
52
+        $this->length = (int)$attrs['length'];
53
+        $this->length_change = (int)$attrs['length_change'];
54 54
         $this->user = new User($attrs['username']);
55 55
         $this->comment = $attrs['comment'];
56 56
     }
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
     public function getDiffUrl()
180 180
     {
181 181
         $project = $this->getProject();
182
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
183
-        return rtrim($project->getUrl(), '/') . $path;
182
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
183
+        return rtrim($project->getUrl(), '/').$path;
184 184
     }
185 185
 
186 186
     /**
@@ -190,8 +190,8 @@  discard block
 block discarded – undo
190 190
     public function getPermaUrl()
191 191
     {
192 192
         $project = $this->getProject();
193
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
194
-        return rtrim($project->getUrl(), '/') . $path;
193
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
194
+        return rtrim($project->getUrl(), '/').$path;
195 195
     }
196 196
 
197 197
     /**
Please login to merge, or discard this patch.
src/AppBundle/Controller/ApiController.php 2 patches
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -2,13 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace AppBundle\Controller;
4 4
 
5
-use AppBundle\Helper\AutomatedEditsHelper;
6
-use Exception;
7
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
8 5
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
9
-use Symfony\Component\HttpFoundation\Request;
10 6
 use Symfony\Component\HttpFoundation\Response;
11
-use Symfony\Component\Debug\Exception\FatalErrorException;
12 7
 use FOS\RestBundle\Controller\Annotations as Rest;
13 8
 use FOS\RestBundle\Controller\FOSRestController;
14 9
 use FOS\RestBundle\View\View;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@
 block discarded – undo
139 139
         }
140 140
 
141 141
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
142
-        $date =  date('Y-m-d');
142
+        $date = date('Y-m-d');
143 143
 
144 144
         // Increment count in timeline
145 145
         $existsSql = "SELECT 1 FROM usage_timeline
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminScoreController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10 10
 use Symfony\Component\HttpFoundation\Request;
11 11
 use Symfony\Component\HttpFoundation\Response;
12
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
13 12
 use DateTime;
14 13
 use Xtools\ProjectRepository;
15 14
 use Xtools\UserRepository;
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@  discard block
 block discarded – undo
47 47
         $username = $request->query->get('username', $request->query->get('user'));
48 48
 
49 49
         if ($projectQuery != '' && $username != '') {
50
-            return $this->redirectToRoute('AdminScoreResult', [ 'project' => $projectQuery, 'username' => $username ]);
50
+            return $this->redirectToRoute('AdminScoreResult', ['project' => $projectQuery, 'username' => $username]);
51 51
         } elseif ($projectQuery != '') {
52
-            return $this->redirectToRoute('AdminScoreProject', [ 'project' => $projectQuery ]);
52
+            return $this->redirectToRoute('AdminScoreProject', ['project' => $projectQuery]);
53 53
         }
54 54
 
55 55
         // Set default project so we can populate the namespace selector.
@@ -95,20 +95,20 @@  discard block
 block discarded – undo
95 95
         $archiveTable = $projectRepo->getTableName($dbName, 'archive');
96 96
 
97 97
         // MULTIPLIERS (to review)
98
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
99
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
100
-        $USER_PAGE_MULT = 0.1;     # 0 if =
98
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
99
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
100
+        $USER_PAGE_MULT = 0.1; # 0 if =
101 101
         $PATROLS_MULT = 1; # 0 if =
102
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
102
+        $BLOCKS_MULT = 1.4; # 0 if = 10
103 103
         $AFD_MULT = 1.15;
104
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
104
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
105 105
         $AIV_MULT = 1.15;
106
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
107
-        $NAMESPACES_MULT = 1.0;     # 0 if =
106
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
107
+        $NAMESPACES_MULT = 1.0; # 0 if =
108 108
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
109 109
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
110
-        $RPP_MULT = 1.15;     # 0 if =
111
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
110
+        $RPP_MULT = 1.15; # 0 if =
111
+        $USERRIGHTS_MULT = 0.75; # 0 if =
112 112
 
113 113
         // Grab the connection to the replica database (which is separate from the above)
114 114
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -186,15 +186,15 @@  discard block
 block discarded – undo
186 186
                 $now = new DateTime();
187 187
                 $date = new DateTime($value);
188 188
                 $diff = $date->diff($now);
189
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
189
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
190 190
                 $value = $formula-365;
191 191
             }
192 192
 
193 193
             if ($key == "id") {
194 194
                 $id = $value;
195 195
             } else {
196
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
197
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
196
+                $multiplierKey = strtoupper($row["source"]."_MULT");
197
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
198 198
                 $score = max(min($value * $multiplier, 100), -100);
199 199
                 $master[$key]["mult"] = $multiplier;
200 200
                 $master[$key]["value"] = $value;
@@ -204,8 +204,8 @@  discard block
 block discarded – undo
204 204
         }
205 205
 
206 206
         if ($id == 0) {
207
-            $this->addFlash("notice", [ "no-result", $username ]);
208
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
207
+            $this->addFlash("notice", ["no-result", $username]);
208
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
209 209
         }
210 210
 
211 211
         return $this->render('adminscore/result.html.twig', [
Please login to merge, or discard this patch.
src/AppBundle/Controller/DefaultController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
     public function loginAction()
91 91
     {
92 92
         try {
93
-            list( $next, $token ) = $this->getOauthClient()->initiate();
93
+            list($next, $token) = $this->getOauthClient()->initiate();
94 94
         } catch (Exception $oauthException) {
95 95
             throw $oauthException;
96 96
             // @TODO Make this work.
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                     . '/index.php?title=Special:OAuth';
156 156
         $conf = new ClientConfig($endpoint);
157 157
         $consumerKey = $this->getParameter('oauth_key');
158
-        $consumerSecret =  $this->getParameter('oauth_secret');
158
+        $consumerSecret = $this->getParameter('oauth_secret');
159 159
         $conf->setConsumer(new Consumer($consumerKey, $consumerSecret));
160 160
         $this->oauthClient = new Client($conf);
161 161
         // Callback URL is hardcoded in the consumer registration.
Please login to merge, or discard this patch.
src/Xtools/Page.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 
60 60
     /**
61 61
      * Get this page's database ID.
62
-     * @return int
62
+     * @return \string|null
63 63
      */
64 64
     public function getId()
65 65
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
     /**
71 71
      * Get this page's length in bytes.
72
-     * @return int
72
+     * @return \string|null
73 73
      */
74 74
     public function getLength()
75 75
     {
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
     /**
95 95
      * Get the full URL of this page.
96
-     * @return string
96
+     * @return \string|null
97 97
      */
98 98
     public function getUrl()
99 99
     {
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 
104 104
     /**
105 105
      * Get the numerical ID of the namespace of this page.
106
-     * @return int
106
+     * @return \string|null
107 107
      */
108 108
     public function getNamespace()
109 109
     {
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 
114 114
     /**
115 115
      * Get the number of page watchers.
116
-     * @return int
116
+     * @return \string|null
117 117
      */
118 118
     public function getWatchers()
119 119
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -235,7 +235,7 @@
 block discarded – undo
235 235
                 $classAttrs = $config['class']['Unknown'];
236 236
                 $assessment['class']['value'] = '???';
237 237
                 $assessment['class']['category'] = $classAttrs['category'];
238
-                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/". $classAttrs['badge'];
238
+                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".$classAttrs['badge'];
239 239
             } else {
240 240
                 $classAttrs = $config['class'][$classValue];
241 241
                 $assessment['class'] = [
Please login to merge, or discard this patch.
src/AppBundle/Twig/AppExtension.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 
25 25
     /**
26 26
      * Get all functions that this class provides.
27
-     * @return array
27
+     * @return \Twig_SimpleFunction[]
28 28
      */
29 29
     public function getFunctions()
30 30
     {
@@ -520,7 +520,7 @@  discard block
 block discarded – undo
520 520
 
521 521
     /**
522 522
      * Get all filters for this extension.
523
-     * @return array
523
+     * @return \Twig_SimpleFilter[]
524 524
      */
525 525
     public function getFilters()
526 526
     {
Please login to merge, or discard this patch.
Spacing   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -30,32 +30,32 @@  discard block
 block discarded – undo
30 30
     {
31 31
         $options = ['is_safe' => ['html']];
32 32
         return [
33
-            new \Twig_SimpleFunction('request_time', [ $this, 'requestTime' ], $options),
34
-            new \Twig_SimpleFunction('memory_usage', [ $this, 'requestMemory' ], $options),
35
-            new \Twig_SimpleFunction('year', [ $this, 'generateYear' ], $options),
36
-            new \Twig_SimpleFunction('msgPrintExists', [ $this, 'intuitionMessagePrintExists' ], $options),
37
-            new \Twig_SimpleFunction('msgExists', [ $this, 'intuitionMessageExists' ], $options),
38
-            new \Twig_SimpleFunction('msg', [ $this, 'intuitionMessage' ], $options),
39
-            new \Twig_SimpleFunction('lang', [ $this, 'getLang' ], $options),
40
-            new \Twig_SimpleFunction('langName', [ $this, 'getLangName' ], $options),
41
-            new \Twig_SimpleFunction('allLangs', [ $this, 'getAllLangs' ]),
42
-            new \Twig_SimpleFunction('isRTL', [ $this, 'intuitionIsRTL' ]),
43
-            new \Twig_SimpleFunction('isRTLLang', [ $this, 'intuitionIsRTLLang' ]),
44
-            new \Twig_SimpleFunction('shortHash', [ $this, 'gitShortHash' ]),
45
-            new \Twig_SimpleFunction('hash', [ $this, 'gitHash' ]),
46
-            new \Twig_SimpleFunction('enabled', [ $this, 'tabEnabled' ]),
47
-            new \Twig_SimpleFunction('tools', [ $this, 'allTools' ]),
48
-            new \Twig_SimpleFunction('color', [ $this, 'getColorList' ]),
49
-            new \Twig_SimpleFunction('chartColor', [ $this, 'chartColor' ]),
50
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
51
-            new \Twig_SimpleFunction('isSingleWiki', [ $this, 'isSingleWiki' ]),
52
-            new \Twig_SimpleFunction('getReplagThreshold', [ $this, 'getReplagThreshold' ]),
53
-            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [ $this, 'loadStylesheetsFromCDN' ]),
54
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
55
-            new \Twig_SimpleFunction('replag', [ $this, 'replag' ]),
56
-            new \Twig_SimpleFunction('link', [ $this, 'link' ]),
57
-            new \Twig_SimpleFunction('quote', [ $this, 'quote' ]),
58
-            new \Twig_SimpleFunction('bugReportURL', [ $this, 'bugReportURL' ]),
33
+            new \Twig_SimpleFunction('request_time', [$this, 'requestTime'], $options),
34
+            new \Twig_SimpleFunction('memory_usage', [$this, 'requestMemory'], $options),
35
+            new \Twig_SimpleFunction('year', [$this, 'generateYear'], $options),
36
+            new \Twig_SimpleFunction('msgPrintExists', [$this, 'intuitionMessagePrintExists'], $options),
37
+            new \Twig_SimpleFunction('msgExists', [$this, 'intuitionMessageExists'], $options),
38
+            new \Twig_SimpleFunction('msg', [$this, 'intuitionMessage'], $options),
39
+            new \Twig_SimpleFunction('lang', [$this, 'getLang'], $options),
40
+            new \Twig_SimpleFunction('langName', [$this, 'getLangName'], $options),
41
+            new \Twig_SimpleFunction('allLangs', [$this, 'getAllLangs']),
42
+            new \Twig_SimpleFunction('isRTL', [$this, 'intuitionIsRTL']),
43
+            new \Twig_SimpleFunction('isRTLLang', [$this, 'intuitionIsRTLLang']),
44
+            new \Twig_SimpleFunction('shortHash', [$this, 'gitShortHash']),
45
+            new \Twig_SimpleFunction('hash', [$this, 'gitHash']),
46
+            new \Twig_SimpleFunction('enabled', [$this, 'tabEnabled']),
47
+            new \Twig_SimpleFunction('tools', [$this, 'allTools']),
48
+            new \Twig_SimpleFunction('color', [$this, 'getColorList']),
49
+            new \Twig_SimpleFunction('chartColor', [$this, 'chartColor']),
50
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
51
+            new \Twig_SimpleFunction('isSingleWiki', [$this, 'isSingleWiki']),
52
+            new \Twig_SimpleFunction('getReplagThreshold', [$this, 'getReplagThreshold']),
53
+            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [$this, 'loadStylesheetsFromCDN']),
54
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
55
+            new \Twig_SimpleFunction('replag', [$this, 'replag']),
56
+            new \Twig_SimpleFunction('link', [$this, 'link']),
57
+            new \Twig_SimpleFunction('quote', [$this, 'quote']),
58
+            new \Twig_SimpleFunction('bugReportURL', [$this, 'bugReportURL']),
59 59
             new \Twig_SimpleFunction('logged_in_user', [$this, 'functionLoggedInUser']),
60 60
             new \Twig_SimpleFunction('isUserAnon', [$this, 'isUserAnon']),
61 61
             new \Twig_SimpleFunction('nsName', [$this, 'nsName']),
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function requestTime($decimals = 3)
71 71
     {
72
-        return number_format(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT'], $decimals);
72
+        return number_format(microtime(true)-$_SERVER['REQUEST_TIME_FLOAT'], $decimals);
73 73
     }
74 74
 
75 75
     /**
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      */
103 103
     public function intuitionMessageExists($message = "")
104 104
     {
105
-        return $this->getIntuition()->msgExists($message, [ "domain" => "xtools" ]);
105
+        return $this->getIntuition()->msgExists($message, ["domain" => "xtools"]);
106 106
     }
107 107
 
108 108
     /**
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
      */
134 134
     public function intuitionMessage($message = "", $vars = [])
135 135
     {
136
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
136
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
137 137
     }
138 138
 
139 139
     /**
@@ -162,10 +162,10 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public function getAllLangs()
164 164
     {
165
-        $messageFiles = glob($this->container->getParameter("kernel.root_dir") . '/../i18n/*.json');
165
+        $messageFiles = glob($this->container->getParameter("kernel.root_dir").'/../i18n/*.json');
166 166
 
167 167
         $languages = array_values(array_unique(array_map(
168
-            function ($filename) {
168
+            function($filename) {
169 169
                 return basename($filename, '.json');
170 170
             },
171 171
             $messageFiles
@@ -253,41 +253,41 @@  discard block
 block discarded – undo
253 253
     public static function getColorList($num = false)
254 254
     {
255 255
         $colors = [
256
-            0 => '#Cc0000',# '#FF005A', #red '#FF5555',
256
+            0 => '#Cc0000', # '#FF005A', #red '#FF5555',
257 257
             1 => '#F7b7b7',
258
-            2 => '#5c8d20',# '#008800', #green'#55FF55',
258
+            2 => '#5c8d20', # '#008800', #green'#55FF55',
259 259
             3 => '#85eD82',
260 260
             4 => '#2E97E0', # blue
261 261
             5 => '#B9E3F9',
262
-            6 => '#e1711d',  # orange
262
+            6 => '#e1711d', # orange
263 263
             7 => '#ffc04c',
264 264
             8 => '#FDFF98', # yellow
265 265
             9 => '#5555FF',
266 266
             10 => '#55FFFF',
267
-            11 => '#0000C0',  #
268
-            12 => '#008800',  # green
267
+            11 => '#0000C0', #
268
+            12 => '#008800', # green
269 269
             13 => '#00C0C0',
270
-            14 => '#FFAFAF',  # rosé
271
-            15 => '#808080',  # gray
270
+            14 => '#FFAFAF', # rosé
271
+            15 => '#808080', # gray
272 272
             16 => '#00C000',
273 273
             17 => '#404040',
274
-            18 => '#C0C000',  # green
274
+            18 => '#C0C000', # green
275 275
             19 => '#C000C0',
276
-            100 => '#75A3D1',  # blue
277
-            101 => '#A679D2',  # purple
276
+            100 => '#75A3D1', # blue
277
+            101 => '#A679D2', # purple
278 278
             102 => '#660000',
279 279
             103 => '#000066',
280
-            104 => '#FAFFAF',  # caramel
280
+            104 => '#FAFFAF', # caramel
281 281
             105 => '#408345',
282 282
             106 => '#5c8d20',
283
-            107 => '#e1711d',  # red
284
-            108 => '#94ef2b',  # light green
285
-            109 => '#756a4a',  # brown
283
+            107 => '#e1711d', # red
284
+            108 => '#94ef2b', # light green
285
+            109 => '#756a4a', # brown
286 286
             110 => '#6f1dab',
287 287
             111 => '#301e30',
288 288
             112 => '#5c9d96',
289
-            113 => '#a8cd8c',  # earth green
290
-            114 => '#f2b3f1',  # light purple
289
+            113 => '#a8cd8c', # earth green
290
+            114 => '#f2b3f1', # light purple
291 291
             115 => '#9b5828',
292 292
             118 => '#99FFFF',
293 293
             119 => '#99BBFF',
@@ -308,8 +308,8 @@  discard block
 block discarded – undo
308 308
             446 => '#06DCFB',
309 309
             447 => '#892EE4',
310 310
             460 => '#99FF66',
311
-            461 => '#99CC66',  # green
312
-            470 => '#CCCC33',  # ocker
311
+            461 => '#99CC66', # green
312
+            470 => '#CCCC33', # ocker
313 313
             471 => '#CCFF33',
314 314
             480 => '#6699FF',
315 315
             481 => '#66FFFF',
@@ -324,18 +324,18 @@  discard block
 block discarded – undo
324 324
             1198 => '#FF34B3',
325 325
             1199 => '#8B1C62',
326 326
 
327
-            '#61a9f3',# blue
328
-            '#f381b9',# pink
327
+            '#61a9f3', # blue
328
+            '#f381b9', # pink
329 329
             '#61E3A9',
330 330
             '#D56DE2',
331 331
             '#85eD82',
332 332
             '#F7b7b7',
333 333
             '#CFDF49',
334 334
             '#88d8f2',
335
-            '#07AF7B',# green
335
+            '#07AF7B', # green
336 336
             '#B9E3F9',
337 337
             '#FFF3AD',
338
-            '#EF606A',# red
338
+            '#EF606A', # red
339 339
             '#EC8833',
340 340
             '#FFF100',
341 341
             '#87C9A5',
@@ -526,8 +526,8 @@  discard block
 block discarded – undo
526 526
     public function getFilters()
527 527
     {
528 528
         return [
529
-            new \Twig_SimpleFilter('capitalize_first', [ $this, 'capitalizeFirst' ]),
530
-            new \Twig_SimpleFilter('percent_format', [ $this, 'percentFormat' ]),
529
+            new \Twig_SimpleFilter('capitalize_first', [$this, 'capitalizeFirst']),
530
+            new \Twig_SimpleFilter('percent_format', [$this, 'percentFormat']),
531 531
         ];
532 532
     }
533 533
 
@@ -554,10 +554,10 @@  discard block
 block discarded – undo
554 554
         if (!$denominator) {
555 555
             $quotient = $numerator;
556 556
         } else {
557
-            $quotient = ( $numerator / $denominator ) * 100;
557
+            $quotient = ($numerator / $denominator) * 100;
558 558
         }
559 559
 
560
-        return round($quotient, $precision) . '%';
560
+        return round($quotient, $precision).'%';
561 561
     }
562 562
 
563 563
     /**
Please login to merge, or discard this patch.
src/AppBundle/Controller/EditCounterController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 use Symfony\Component\HttpFoundation\Response;
13 13
 use Xtools\EditCounter;
14 14
 use Xtools\EditCounterRepository;
15
-use Xtools\Page;
16 15
 use Xtools\Project;
17 16
 use Xtools\ProjectRepository;
18 17
 use Xtools\User;
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -78,10 +78,10 @@  discard block
 block discarded – undo
78 78
         $username = $request->query->get('username', $request->query->get('user'));
79 79
 
80 80
         if (($project || $queryProject) && $username) {
81
-            $routeParams = [ 'project'=>($project ?: $queryProject), 'username' => $username ];
81
+            $routeParams = ['project'=>($project ?: $queryProject), 'username' => $username];
82 82
             return $this->redirectToRoute("EditCounterResult", $routeParams);
83 83
         } elseif (!$project && $queryProject) {
84
-            return $this->redirectToRoute("EditCounterProject", [ 'project'=>$queryProject ]);
84
+            return $this->redirectToRoute("EditCounterProject", ['project'=>$queryProject]);
85 85
         }
86 86
 
87 87
         $project = ProjectRepository::getProject($queryProject, $this->container);
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
         }
117 117
         $isSubRequest = $this->container->get('request_stack')->getParentRequest() !== null;
118 118
         return $this->render('editCounter/result.html.twig', [
119
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->project->getTitle(),
119
+            'xtTitle' => $this->user->getUsername().' - '.$this->project->getTitle(),
120 120
             'xtPage' => 'ec',
121 121
             'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
122 122
             'is_sub_request' => $isSubRequest,
Please login to merge, or discard this patch.
src/Xtools/Project.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 namespace Xtools;
7 7
 
8 8
 use Mediawiki\Api\MediawikiApi;
9
-use Symfony\Component\VarDumper\VarDumper;
10 9
 
11 10
 /**
12 11
  * A Project is a single wiki that XTools is querying.
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@
 block discarded – undo
200 200
     /**
201 201
      * Get an array of this project's namespaces and their IDs.
202 202
      *
203
-     * @return string[] Keys are IDs, values are names.
203
+     * @return string Keys are IDs, values are names.
204 204
      */
205 205
     public function getNamespaces()
206 206
     {
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
      */
118 118
     public function getUrl($withTrailingSlash = true)
119 119
     {
120
-        return rtrim($this->getBasicInfo()['url'], '/') . ($withTrailingSlash ? '/' : '');
120
+        return rtrim($this->getBasicInfo()['url'], '/').($withTrailingSlash ? '/' : '');
121 121
     }
122 122
 
123 123
     /**
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
         $metadata = $this->getMetadata();
175 175
         return isset($metadata['general']['script'])
176 176
             ? $metadata['general']['script']
177
-            : $this->getScriptPath() . '/index.php';
177
+            : $this->getScriptPath().'/index.php';
178 178
     }
179 179
 
180 180
     /**
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
      */
185 185
     public function getApiUrl()
186 186
     {
187
-        return rtrim($this->getUrl(), '/') . $this->getRepository()->getApiPath();
187
+        return rtrim($this->getUrl(), '/').$this->getRepository()->getApiPath();
188 188
     }
189 189
 
190 190
     /**
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
      */
217 217
     public function userOptInPage(User $user)
218 218
     {
219
-        $localPageName = 'User:' . $user->getUsername() . '/EditCounterOptIn.js';
219
+        $localPageName = 'User:'.$user->getUsername().'/EditCounterOptIn.js';
220 220
         return $localPageName;
221 221
     }
222 222
 
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         }
251 251
 
252 252
         // 4. Lastly, see if they've opted in globally on the default project or Meta.
253
-        $globalPageName = $user->getUsername() . '/EditCounterGlobalOptIn.js';
253
+        $globalPageName = $user->getUsername().'/EditCounterGlobalOptIn.js';
254 254
         $globalProject = $this->getRepository()->getGlobalProject();
255 255
         if ($globalProject instanceof Project) {
256 256
             $globalExists = $globalProject->getRepository()
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
      */
270 270
     public function hasPageAssessments()
271 271
     {
272
-        return (bool) $this->getRepository()->getAssessmentsConfig($this->getDomain());
272
+        return (bool)$this->getRepository()->getAssessmentsConfig($this->getDomain());
273 273
     }
274 274
 
275 275
     /**
@@ -282,9 +282,9 @@  discard block
 block discarded – undo
282 282
         $config = $this->getRepository()->getAssessmentsConfig($this->getDomain());
283 283
 
284 284
         if (isset($config['class'][$class])) {
285
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config['class'][$class]['badge'];
285
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config['class'][$class]['badge'];
286 286
         } elseif (isset($config['class']['Unknown'])) {
287
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config['class']['Unknown']['badge'];
287
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config['class']['Unknown']['badge'];
288 288
         } else {
289 289
             return "";
290 290
         }
Please login to merge, or discard this patch.