x-tools / xtools

src/Xtools/User.php

Spacing +11 added lines, -11 removed lines

@@ -92,7 +92,7 @@ 
             return $this->editCounts[$domain];
         }
 
-        $this->editCounts[$domain] = (int) $this->getRepository()->getEditCount(
+        $this->editCounts[$domain] = (int)$this->getRepository()->getEditCount(
             $project->getDatabaseName(),
             $this->getUsername()
         );
@@ -158,7 +158,7 @@ 
      */
     public function isAnon()
     {
-        return (bool) filter_var($this->username, FILTER_VALIDATE_IP);
+        return (bool)filter_var($this->username, FILTER_VALIDATE_IP);
     }
 
     /**
@@ -220,7 +220,7 @@ 
      */
     public function countEdits(Project $project, $namespace = 'all', $start = '', $end = '')
     {
-        return (int) $this->getRepository()->countEdits($project, $this, $namespace, $start, $end);
+        return (int)$this->getRepository()->countEdits($project, $this, $namespace, $start, $end);
     }
 
     /**
@@ -233,7 +233,7 @@ 
      */
     public function countAutomatedEdits(Project $project, $namespace = 'all', $start = '', $end = '')
     {
-        return (int) $this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
+        return (int)$this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
     }
 
     /**
@@ -265,12 +265,12 @@ 
 
         $namespaces = $project->getNamespaces();
 
-        return array_map(function ($rev) use ($namespaces) {
+        return array_map(function($rev) use ($namespaces) {
             $pageTitle = $rev['page_title'];
             $fullPageTitle = '';
 
             if ($rev['page_namespace'] !== '0') {
-                $fullPageTitle = $namespaces[$rev['page_namespace']] . ":$pageTitle";
+                $fullPageTitle = $namespaces[$rev['page_namespace']].":$pageTitle";
             } else {
                 $fullPageTitle = $pageTitle;
             }
@@ -278,12 +278,12 @@ 
             return [
                 'full_page_title' => $fullPageTitle,
                 'page_title' => $pageTitle,
-                'page_namespace' => (int) $rev['page_namespace'],
-                'rev_id' => (int) $rev['rev_id'],
+                'page_namespace' => (int)$rev['page_namespace'],
+                'rev_id' => (int)$rev['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $rev['timestamp']),
-                'minor' => (bool) $rev['minor'],
-                'length' => (int) $rev['length'],
-                'length_change' => (int) $rev['length_change'],
+                'minor' => (bool)$rev['minor'],
+                'length' => (int)$rev['length'],
+                'length_change' => (int)$rev['length_change'],
                 'comment' => $rev['comment'],
             ];
         }, $revs);

src/AppBundle/Controller/MetaController.php

Spacing +7 added lines, -7 removed lines

@@ -31,7 +31,7 @@ 
         $end = $request->query->get('end');
 
         if ($start != '' && $end != '') {
-            return $this->redirectToRoute('MetaResult', [ 'start' => $start, 'end' => $end ]);
+            return $this->redirectToRoute('MetaResult', ['start' => $start, 'end' => $end]);
         }
 
         return $this->render('meta/index.html.twig', [
@@ -73,7 +73,7 @@ 
         $timeline = [];
         $startObj = new DateTime($start);
         $endObj = new DateTime($end);
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
         $grandSum = 0;
 
         // Generate array of date labels
@@ -83,17 +83,17 @@ 
 
         foreach ($data as $entry) {
             if (!isset($totals[$entry['tool']])) {
-                $totals[$entry['tool']] = (int) $entry['count'];
+                $totals[$entry['tool']] = (int)$entry['count'];
 
                 // Create arrays for each tool, filled with zeros for each date in the timeline
                 $timeline[$entry['tool']] = array_fill(0, $numDays, 0);
             } else {
-                $totals[$entry['tool']] += (int) $entry['count'];
+                $totals[$entry['tool']] += (int)$entry['count'];
             }
 
             $date = new DateTime($entry['date']);
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
-            $timeline[$entry['tool']][$dateIndex] = (int) $entry['count'];
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
+            $timeline[$entry['tool']][$dateIndex] = (int)$entry['count'];
 
             $grandSum += $entry['count'];
         }
@@ -143,7 +143,7 @@ 
         }
 
         $conn = $this->container->get('doctrine')->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/AppBundle/Controller/TopEditsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -155,7 +155,7 @@
      * @param Request $request The HTTP request.
      * @param User $user The User.
      * @param Project $project The project.
-     * @param integer|string $namespace The namespace ID or 'all'
+     * @param integer $namespace The namespace ID or 'all'
      * @return \Symfony\Component\HttpFoundation\Response
      */
     public function namespaceTopEdits(Request $request, User $user, Project $project, $namespace)

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 
 namespace AppBundle\Controller;
 
-use AppBundle\Helper\ApiHelper;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\RedirectResponse;

Spacing +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
             'xtSubtitle' => 'tool-topedits-desc',
             'xtPage' => 'topedits',
             'project' => $project,
-            'namespace' => (int) $namespace,
+            'namespace' => (int)$namespace,
             'article' => $article,
         ]);
     }
@@ -248,7 +248,7 @@ 
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,

src/Xtools/TopEdits.php

Unused Use Statements -3 removed lines

@@ -5,9 +5,6 @@
 
 namespace Xtools;
 
-use Symfony\Component\DependencyInjection\Container;
-use DateTime;
-
 /**
  * TopEdits returns the top-edited pages by a user. There is not a separate
  * repository because there is only one query :)

Spacing +6 added lines, -6 removed lines

@@ -119,9 +119,9 @@ 
         $displayTitles = $this->getDisplayTitles($pages);
 
         foreach ($pages as $page) {
-            $nsId = (int) $page['page_namespace'];
-            $nsTitle = $nsId > 0 ? $this->project->getNamespaces()[$page['page_namespace']] . ':' : '';
-            $pageTitle = $nsTitle . $page['page_title'];
+            $nsId = (int)$page['page_namespace'];
+            $nsTitle = $nsId > 0 ? $this->project->getNamespaces()[$page['page_namespace']].':' : '';
+            $pageTitle = $nsTitle.$page['page_title'];
             $page['displaytitle'] = $displayTitles[$pageTitle];
 
             // $page['page_title'] is retained without the namespace
@@ -148,11 +148,11 @@ 
         $namespaces = $this->project->getNamespaces();
 
         // First extract page titles including namespace.
-        $pageTitles = array_map(function ($page) use ($namespaces) {
+        $pageTitles = array_map(function($page) use ($namespaces) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $page['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']] . ':' : '';
-            return $nsTitle . $page['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']].':' : '';
+            return $nsTitle.$page['page_title'];
         }, $topPages);
 
         return $this->getRepository()->getDisplayTitles($this->project, $pageTitles);

src/AppBundle/Controller/DeleteCounterController.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use Symfony\Component\HttpFoundation\Response;
 use Xtools\Project;
 use Xtools\ProjectRepository;
-use Xtools\User;
 use Xtools\UserRepository;
 
 /**

Spacing +5 added lines, -5 removed lines

@@ -56,7 +56,7 @@ 
 
         // If we've got a project and user, redirect to results.
         if ($projectName != '' && $username != '') {
-            $routeParams = [ 'project' => $projectName, 'username' => $username ];
+            $routeParams = ['project' => $projectName, 'username' => $username];
             return $this->redirectToRoute(
                 'DeletionCounterResult',
                 $routeParams
@@ -127,7 +127,7 @@ 
         $types = $this->container->getParameter("deletion_counter");
 
         if (!isset($types[$domain])) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
             return $this->redirectToRoute(
                 'DeletionCounter',
                 [
@@ -153,7 +153,7 @@ 
         $resultQuery->execute();
 
         if ($resultQuery->errorCode() > 0) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
             return $this->redirectToRoute(
                 'DeletionCounterProject',
                 [
@@ -166,7 +166,7 @@ 
         $resultData = $resultQuery->fetchAll();
 
         if (count($resultData) == 0) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
             return $this->redirectToRoute(
                 'DeletionCounterProject',
                 [
@@ -185,7 +185,7 @@ 
         // Unknown user or generated no results
         // This is a workaround to detect non-existent IPs.
         if (count($results) == 0) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
 
             return $this->redirectToRoute(
                 'DeletionCounterProject',

src/Xtools/TopEditsRepository.php

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments() && $namespace === 0;
         $paSelect = $hasPageAssessments
-            ?  ", (
+            ? ", (
                     SELECT pa_class
                     FROM page_assessments
                     WHERE pa_page_id = page_id
@@ -92,7 +92,7 @@ 
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments();
         $pageAssessmentsTable = $this->getTableName($project->getDatabaseName(), 'page_assessments');
         $paSelect = $hasPageAssessments
-            ?  ", (
+            ? ", (
                     SELECT pa_class
                     FROM $pageAssessmentsTable
                     WHERE pa_page_id = e.page_id