x-tools / xtools

src/Xtools/Page.php

Doc Comments +7 added lines, -7 removed lines

@@ -59,7 +59,7 @@ 
 
     /**
      * Get this page's database ID.
-     * @return int
+     * @return \string|null
      */
     public function getId()
     {
@@ -69,7 +69,7 @@ 
 
     /**
      * Get this page's length in bytes.
-     * @return int
+     * @return \string|null
      */
     public function getLength()
     {
@@ -93,7 +93,7 @@ 
 
     /**
      * Get the full URL of this page.
-     * @return string
+     * @return \string|null
      */
     public function getUrl()
     {
@@ -103,7 +103,7 @@ 
 
     /**
      * Get the numerical ID of the namespace of this page.
-     * @return int
+     * @return \string|null
      */
     public function getNamespace()
     {
@@ -113,7 +113,7 @@ 
 
     /**
      * Get the number of page watchers.
-     * @return int
+     * @return \string|null
      */
     public function getWatchers()
     {
@@ -420,8 +420,8 @@ 
 
     /**
      * Get the sum of pageviews for the given page and timeframe.
-     * @param string|DateTime $start In the format YYYYMMDD
-     * @param string|DateTime $end In the format YYYYMMDD
+     * @param string $start In the format YYYYMMDD
+     * @param string $end In the format YYYYMMDD
      * @return string[]
      */
     public function getPageviews($start, $end)

Spacing +9 added lines, -9 removed lines

@@ -81,7 +81,7 @@ 
         $info = $this->getPageInfo();
         $title = isset($info['title']) ? $info['title'] : $this->unnormalizedPageName;
         $nsName = $this->getNamespaceName();
-        return str_replace($nsName . ':', '', $title);
+        return str_replace($nsName.':', '', $title);
     }
 
     /**
@@ -217,7 +217,7 @@ 
     {
         // If a user is given, we will not cache the result via instance variable.
         if ($user !== null) {
-            return (int) $this->getRepository()->getNumRevisions($this, $user);
+            return (int)$this->getRepository()->getNumRevisions($this, $user);
         }
 
         // Return cached value, if present.
@@ -230,7 +230,7 @@ 
             $this->numRevisions = count($this->revisions);
         } else {
             // Otherwise do a COUNT in the event fetching all revisions is not desired.
-            $this->numRevisions = (int) $this->getRepository()->getNumRevisions($this);
+            $this->numRevisions = (int)$this->getRepository()->getNumRevisions($this);
         }
 
         return $this->numRevisions;
@@ -260,7 +260,7 @@ 
     {
         $content = $this->getRepository()->getPagesWikitext(
             $this->getProject(),
-            [ $this->getTitle() ]
+            [$this->getTitle()]
         );
 
         return isset($content[$this->getTitle()])
@@ -417,7 +417,7 @@ 
 
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
 
-        $terms = array_map(function ($entry) {
+        $terms = array_map(function($entry) {
             return $entry['term'];
         }, $wikidataInfo);
 
@@ -428,7 +428,7 @@ 
                 'prio' => 2,
                 'name' => 'Wikidata',
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
             ];
         }
@@ -438,7 +438,7 @@ 
                 'prio' => 3,
                 'name' => 'Wikidata',
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
             ];
         }
@@ -517,8 +517,8 @@ 
             return 0;
         }
 
-        return array_sum(array_map(function ($item) {
-            return (int) $item['views'];
+        return array_sum(array_map(function($item) {
+            return (int)$item['views'];
         }, $pageviews['items']));
     }
 

src/AppBundle/EventSubscriber/RateLimitSubscriber.php

Spacing +10 added lines, -10 removed lines

@@ -56,8 +56,8 @@ 
      */
     public function onKernelController(FilterControllerEvent $event)
     {
-        $this->rateLimit = (int) $this->container->getParameter('app.rate_limit_count');
-        $this->rateDuration = (int) $this->container->getParameter('app.rate_limit_time');
+        $this->rateLimit = (int)$this->container->getParameter('app.rate_limit_count');
+        $this->rateDuration = (int)$this->container->getParameter('app.rate_limit_time');
 
         // Zero values indicate the rate limiting feature should be disabled.
         if ($this->rateLimit === 0 || $this->rateDuration === 0) {
@@ -65,7 +65,7 @@ 
         }
 
         $controller = $event->getController();
-        $loggedIn = (bool) $this->container->get('session')->get('logged_in_user');
+        $loggedIn = (bool)$this->container->get('session')->get('logged_in_user');
 
         /**
          * Rate limiting will not apply to these actions
@@ -91,7 +91,7 @@ 
         $cacheItem = $cache->getItem($cacheKey);
 
         // If increment value already in cache, or start with 1.
-        $count = $cacheItem->isHit() ? (int) $cacheItem->get() + 1 : 1;
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
 
         // Check if limit has been exceeded, and if so, throw an error.
         if ($count > $this->rateLimit) {
@@ -143,14 +143,14 @@ 
         // Log the denied request
         $logger = $this->container->get('monolog.logger.rate_limit');
         $logger->info(
-            "<URI>: " . $request->getRequestUri() .
-            ($logComment != '' ? "\t<Reason>: $logComment" : '') .
-            "\t<User agent>: " . $request->headers->get('User-Agent')
+            "<URI>: ".$request->getRequestUri().
+            ($logComment != '' ? "\t<Reason>: $logComment" : '').
+            "\t<User agent>: ".$request->headers->get('User-Agent')
         );
 
-        throw new AccessDeniedHttpException("Possible spider crawl detected. " .
-            'If you are human, you are making too many requests during a short period of time. ' .
-            "Please wait $this->rateDuration minutes before reloading this tool. You can then " .
+        throw new AccessDeniedHttpException("Possible spider crawl detected. ".
+            'If you are human, you are making too many requests during a short period of time. '.
+            "Please wait $this->rateDuration minutes before reloading this tool. You can then ".
             'login to prevent this from happening again.');
     }
 }

src/AppBundle/Controller/RfXAnalysisController.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 use Xtools\Page;
 use Xtools\PagesRepository;

Doc Comments +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
      * @Route("/rfx/{project}",        name="rfxAnalysisProject")
      * @Route("/rfx/{project}/{type}", name="rfxAnalysisProjectType")
      *
-     * @return Response|RedirectResponse
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function indexAction(Request $request, $project = null, $type = null)
     {
@@ -110,7 +110,7 @@ 
      *
      * @Route("/rfx/{project}/{type}/{username}", name="rfxAnalysisResult")
      *
-     * @return Response|RedirectResponse
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function resultAction($project, $type, $username)
     {

Spacing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
         $neutral = $rfx->getSection('neutral');
         $dup = $rfx->getDuplicates();
 
-        $total = count($support) + count($oppose) + count($neutral);
+        $total = count($support)+count($oppose)+count($neutral);
 
         if ($total === 0) {
             $this->addFlash('notice', ['no-result', $pagename]);

src/Xtools/RFX.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      * Returns matches.
      *
      * @param string $input   The line we're looking for
-     * @param array  $matches Pointer to an array where we stash results
+     * @param string[]  $matches Pointer to an array where we stash results
      *
      * @TODO: Make this cleaner
      *

Spacing +2 added lines, -2 removed lines

@@ -119,7 +119,7 @@ 
             }
         }
 
-        $final = [];    // initialize the final array
+        $final = []; // initialize the final array
         $finalRaw = []; // Initialize the raw data array
 
         foreach ($this->data as $key => $value) {
@@ -132,7 +132,7 @@ 
 
         $final = array_count_values($final); // find repetition and its count
 
-        $final = array_diff($final, [1]);    // remove single occurrences
+        $final = array_diff($final, [1]); // remove single occurrences
 
         $this->duplicates = array_keys($final);
     }

src/AppBundle/Controller/EditCounterController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Xtools\EditCounter;
 use Xtools\EditCounterRepository;
-use Xtools\Page;
 use Xtools\Project;
 use Xtools\ProjectRepository;
 use Xtools\User;

Spacing +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
         $isSubRequest = $this->container->get('request_stack')->getParentRequest() !== null;
 
         return $this->render('editCounter/result.html.twig', [
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->project->getTitle(),
+            'xtTitle' => $this->user->getUsername().' - '.$this->project->getTitle(),
             'xtPage' => 'ec',
             'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
             'is_sub_request' => $isSubRequest,

src/Xtools/ArticleInfo.php

Doc Comments +1 added lines, -1 removed lines

@@ -505,7 +505,7 @@
     /**
      * Get a list of (semi-)automated tools that were used to edit the page, including
      * the number of times they were used, and a link to the tool's homepage.
-     * @return mixed[]
+     * @return string[]
      */
     public function getTools()
     {

Indentation +1 added lines, -1 removed lines

@@ -389,7 +389,7 @@
          * The edit previously deemed as having the maximum amount of content added.
          * This is used to discount content that was reverted.
          * @var Edit|null
-        */
+         */
         $prevMaxAddEdit = null;
 
         /**

Spacing +10 added lines, -10 removed lines

@@ -159,7 +159,7 @@ 
     public function getMaxRevisions()
     {
         if (!isset($this->maxRevisions)) {
-            $this->maxRevisions = (int) $this->container->getParameter('app.max_page_revisions');
+            $this->maxRevisions = (int)$this->container->getParameter('app.max_page_revisions');
         }
         return $this->maxRevisions;
     }
@@ -638,7 +638,7 @@ 
 
             if ($revCount === 0) {
                 $this->firstEdit = $edit;
-                $firstEditMonth = mktime(0, 0, 0, (int) $this->firstEdit->getMonth(), 1, $this->firstEdit->getYear());
+                $firstEditMonth = mktime(0, 0, 0, (int)$this->firstEdit->getMonth(), 1, $this->firstEdit->getYear());
             }
 
             $username = $edit->getUser()->getUsername();
@@ -824,7 +824,7 @@ 
         $userGroupsTable = $this->getProject()->getTableName('user_groups');
         $userFromerGroupsTable = $this->getProject()->getTableName('user_former_groups');
         $sql = "SELECT COUNT(rev_user_text) AS count, rev_user_text AS username, ug_group AS current
-                FROM " . $this->getProject()->getTableName('revision') . "
+                FROM " . $this->getProject()->getTableName('revision')."
                 LEFT JOIN $userGroupsTable ON rev_user = ug_user
                 LEFT JOIN $userFromerGroupsTable ON rev_user = ufg_user
                 WHERE rev_page = :pageId AND (ug_group = 'bot' OR ufg_group = 'bot')
@@ -839,14 +839,14 @@ 
         $sum = 0;
         while ($bot = $resultQuery->fetch()) {
             $bots[$bot['username']] = [
-                'count' => (int) $bot['count'],
+                'count' => (int)$bot['count'],
                 'current' => $bot['current'] === 'bot'
             ];
             $sum += $bot['count'];
         }
 
-        uasort($bots, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($bots, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         $this->botRevisionCount = $sum;
@@ -869,7 +869,7 @@ 
         $title = str_replace(' ', '_', $this->page->getTitle());
         $sql = "SELECT log_action, log_type, log_timestamp AS timestamp
                 FROM $loggingTable
-                WHERE log_namespace = '" . $this->page->getNamespace() . "'
+                WHERE log_namespace = '".$this->page->getNamespace()."'
                 AND log_title = :title AND log_timestamp > 1
                 AND log_type IN ('delete', 'move', 'protect', 'stable')";
         $resultQuery = $this->conn->prepare($sql);
@@ -944,7 +944,7 @@ 
 
             if ($info['all'] > 1) {
                 // Number of seconds/days between first and last edit
-                $secs = $info['last']->getTimestamp() - $info['first']->getTimestamp();
+                $secs = $info['last']->getTimestamp()-$info['first']->getTimestamp();
                 $days = $secs / (60 * 60 * 24);
 
                 // Average time between edits (in days)
@@ -963,7 +963,7 @@ 
 
         // First sort editors array by the amount of text they added
         $topTenEditorsByAdded = $this->editors;
-        uasort($topTenEditorsByAdded, function ($a, $b) {
+        uasort($topTenEditorsByAdded, function($a, $b) {
             if ($a['added'] === $b['added']) {
                 return 0;
             }
@@ -972,7 +972,7 @@ 
 
         // Then build a new array of top 10 editors by added text,
         //   in the data structure needed for the chart
-        $this->topTenEditorsByAdded = array_map(function ($editor) {
+        $this->topTenEditorsByAdded = array_map(function($editor) {
             $added = $this->editors[$editor]['added'];
             return [
                 'label' => $editor,

src/Xtools/PagesRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
      * Get metadata about a single page from the API.
      * @param Project $project The project to which the page belongs.
      * @param string $pageTitle Page title.
-     * @return string[] Array with some of the following keys: pageid, title, missing, displaytitle,
+     * @return string|null Array with some of the following keys: pageid, title, missing, displaytitle,
      * url.
      */
     public function getPageInfo(Project $project, $pageTitle)
@@ -135,7 +135,7 @@ 
      * @param int $numRevisions Number of revisions, if known. This is used solely to determine the
      *   OFFSET if we are given a $limit (see below). If $limit is set and $numRevisions is not set,
      *   a separate query is ran to get the nuber of revisions.
-     * @return Doctrine\DBAL\Driver\PDOStatement
+     * @return \Doctrine\DBAL\Driver\Statement
      */
     public function getRevisionsStmt(Page $page, User $user = null, $limit = null, $numRevisions = null)
     {

Spacing +5 added lines, -5 removed lines

@@ -148,7 +148,7 @@ 
         // supply as the OFFSET.
         $limitClause = '';
         if (intval($limit) > 0 && isset($numRevisions)) {
-            $offset = $numRevisions - $limit;
+            $offset = $numRevisions-$limit;
             $limitClause = "LIMIT $offset, $limit";
         }
 
@@ -378,7 +378,7 @@ 
 
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
 
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
                 FROM wikidatawiki_p.wb_items_per_site
                 WHERE ips_item_id = :wikidataId";
 
@@ -388,7 +388,7 @@ 
 
         $result = $resultQuery->fetchAll();
 
-        return $count ? (int) $result[0]['count'] : $result;
+        return $count ? (int)$result[0]['count'] : $result;
     }
 
     /**
@@ -428,7 +428,7 @@ 
 
         // Transform to associative array by 'type'
         foreach ($res as $row) {
-            $data[$row['type'] . '_count'] = $row['value'];
+            $data[$row['type'].'_count'] = $row['value'];
         }
 
         return $data;
@@ -466,7 +466,7 @@ 
 
         $project = $page->getProject()->getDomain();
 
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
             "$project/all-access/user/$title/daily/$start/$end";
 
         $res = $client->request('GET', $url);

src/AppBundle/Controller/ArticleInfoController.php

Spacing +9 added lines, -9 removed lines

@@ -81,9 +81,9 @@ 
         $article = $request->query->get('article');
 
         if ($projectQuery != '' && $article != '') {
-            return $this->redirectToRoute('ArticleInfoResult', [ 'project'=>$projectQuery, 'article' => $article ]);
+            return $this->redirectToRoute('ArticleInfoResult', ['project'=>$projectQuery, 'article' => $article]);
         } elseif ($article != '') {
-            return $this->redirectToRoute('ArticleInfoProject', [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute('ArticleInfoProject', ['project'=>$projectQuery]);
         }
 
         if ($projectQuery == '') {
@@ -121,10 +121,10 @@ 
             $rendered = str_replace('"', '\"', trim($rendered));
 
             // Uglify temporary file.
-            $tmpFile = sys_get_temp_dir() . '/xtools_articleinfo_gadget.js';
+            $tmpFile = sys_get_temp_dir().'/xtools_articleinfo_gadget.js';
             $script = "echo \"$rendered\" | tee $tmpFile >/dev/null && ";
-            $script .= $this->get('kernel')->getRootDir() .
-                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle " .
+            $script .= $this->get('kernel')->getRootDir().
+                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle ".
                 "&& rm $tmpFile >/dev/null";
             $process = new Process($script);
             $process->run();
@@ -143,10 +143,10 @@ 
             $rendered = str_replace('\"', '"', trim($rendered));
 
             // Add comment after uglifying since it removes comments.
-            $rendered = "/**\n * This code was automatically generated and should not " .
-                "be manually edited.\n * For updates, please copy and paste from " .
-                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL) .
-                "\n * Released under GPL v3 license.\n */\n" . $rendered;
+            $rendered = "/**\n * This code was automatically generated and should not ".
+                "be manually edited.\n * For updates, please copy and paste from ".
+                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL).
+                "\n * Released under GPL v3 license.\n */\n".$rendered;
         }
 
         $response = new \Symfony\Component\HttpFoundation\Response($rendered);

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Process\Process;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

src/AppBundle/Twig/Extension.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         }
 
         // Find the path, and complain if English doesn't exist.
-        $path = $this->container->getParameter('kernel.root_dir') . '/../i18n';
+        $path = $this->container->getParameter('kernel.root_dir').'/../i18n';
         if (!file_exists("$path/en.json")) {
             throw new Exception("Language directory doesn't exist: $path");
         }