x-tools / xtools

src/AppBundle/Controller/PagesController.php

Spacing +3 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("PagesProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("PagesProject", ['project'=>$projectQuery]);
         }
 
         // set default wiki so we can populate the namespace selector
@@ -207,8 +207,8 @@ 
         }
 
         if ($total < 1) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
-            return $this->redirectToRoute('PagesProject', [ 'project' => $project ]);
+            $this->addFlash('notice', ['no-result', $username]);
+            return $this->redirectToRoute('PagesProject', ['project' => $project]);
         }
 
         ksort($pagesByNamespaceByDate);

src/Xtools/EditCounterRepository.php

Spacing +5 added lines, -5 removed lines

@@ -146,10 +146,10 @@ 
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
         $logCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -366,9 +366,9 @@ 
         $resultQuery->bindParam(":id", $userId);
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
-        $namespaceTotals = array_combine(array_map(function ($e) {
+        $namespaceTotals = array_combine(array_map(function($e) {
             return $e['page_namespace'];
-        }, $results), array_map(function ($e) {
+        }, $results), array_map(function($e) {
             return $e['total'];
         }, $results));
 
@@ -427,7 +427,7 @@ 
             }
             $queries[] = $sql;
         }
-        $sql = "(\n" . join("\n) UNION (\n", $queries) . ")\n";
+        $sql = "(\n".join("\n) UNION (\n", $queries).")\n";
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
         $resultQuery->bindParam(":username", $username);
         $resultQuery->execute();

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 namespace Xtools;
 
 use DateInterval;
-use DateTime;
 use Mediawiki\Api\SimpleRequest;
 
 /**

src/AppBundle/Controller/AutomatedEditsController.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Xtools\ProjectRepository;
-use Xtools\User;
 use Xtools\UserRepository;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -86,7 +86,7 @@ 
             'xtSubtitle' => 'tool-autoedits-desc',
             'xtPage' => 'autoedits',
             'project' => $project,
-            'namespace' => (int) $namespace,
+            'namespace' => (int)$namespace,
             'start' => $startDate,
             'end' => $endDate,
         ]);
@@ -157,8 +157,8 @@ 
         // Get individual counts of how many times each tool was used.
         // This also includes a wikilink to the tool.
         $toolCounts = $user->getAutomatedCounts($projectData, $namespace, $start, $end);
-        $toolsTotal = array_reduce($toolCounts, function ($a, $b) {
-            return $a + $b['count'];
+        $toolsTotal = array_reduce($toolCounts, function($a, $b) {
+            return $a+$b['count'];
         });
 
         // Query to get combined (semi)automated using for all edits

src/AppBundle/Controller/EditSummaryController.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Psr\Cache\CacheItemPoolInterface;
 use Xtools\Project;
 use Xtools\ProjectRepository;
 use Xtools\User;

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      *
      * @param string $project  The project domain name.
      * @param string $username The username.
-     * @param string $namespace Namespace ID or 'all' for all namespaces.
+     * @param integer $namespace Namespace ID or 'all' for all namespaces.
      *
      * @Route("/editsummary/{project}/{username}/{namespace}", name="EditSummaryResult")
      *

Spacing +5 added lines, -7 removed lines

@@ -92,7 +92,7 @@ 
                 'xtSubtitle' => 'tool-es-desc',
                 'xtPage' => 'es',
                 'project' => $theProject,
-                'namespace' => (int) $namespace,
+                'namespace' => (int)$namespace,
             ]
         );
     }
@@ -158,8 +158,8 @@ 
     {
         $dbName = $project->getDatabaseName();
 
-        $cacheKey = 'editsummaryusage.' . $dbName . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editsummaryusage.'.$dbName.'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $cache = $this->container->get('cache.app');
         if ($cache->hasItem($cacheKey)) {
@@ -246,8 +246,7 @@ 
             if ($row['rev_minor_edit'] == 0) {
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMajor++;
                 }
 
@@ -264,8 +263,7 @@ 
                 // If there is a comment, count it
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMinor++;
                     $totalEditsMinor++;
                 } else {

src/AppBundle/Helper/AutomatedEditsHelper.php

Spacing +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
      */
     public function isAutomated($summary, $projectDomain)
     {
-        return (bool) $this->getTool($summary, $projectDomain);
+        return (bool)$this->getTool($summary, $projectDomain);
     }
 
     /**
@@ -109,14 +109,14 @@ 
 
         $revertEntries = array_filter(
             $this->getTools($projectDomain),
-            function ($tool) {
+            function($tool) {
                 return isset($tool['revert']);
             }
         );
 
         // If 'revert' is set to `true`, the use 'regex' as the regular expression,
         //  otherwise 'revert' is assumed to be the regex string.
-        $this->revertTools[$projectDomain] = array_map(function ($revertTool) {
+        $this->revertTools[$projectDomain] = array_map(function($revertTool) {
             return [
                 'link' => $revertTool['link'],
                 'regex' => $revertTool['revert'] === true ? $revertTool['regex'] : $revertTool['revert']

src/Xtools/Edit.php

Spacing +10 added lines, -10 removed lines

@@ -49,7 +49,7 @@ 
         $this->page = $page;
 
         // Copy over supported attributes
-        $this->id = (int) $attrs['id'];
+        $this->id = (int)$attrs['id'];
 
         // Allow DateTime or string (latter assumed to be of format YmdHis)
         if ($attrs['timestamp'] instanceof DateTime) {
@@ -198,7 +198,7 @@ 
         $isSection = preg_match_all("/^\/\* (.*?) \*\//", $summary, $sectionMatch);
 
         if ($isSection) {
-            $pageUrl = $this->getProject()->getUrl(false) . str_replace(
+            $pageUrl = $this->getProject()->getUrl(false).str_replace(
                 '$1',
                 $this->getPage()->getTitle(),
                 $this->getProject()->getArticlePath()
@@ -208,8 +208,8 @@ 
             // Must have underscores for the link to properly go to the section
             $sectionTitleLink = htmlspecialchars(str_replace(' ', '_', $sectionTitle));
 
-            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>" .
-                "<em class='text-muted'>" . htmlspecialchars($sectionTitle) . ":</em> ";
+            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>".
+                "<em class='text-muted'>".htmlspecialchars($sectionTitle).":</em> ";
             $summary = str_replace($sectionMatch[0][0], $sectionWikitext, $summary);
         }
 
@@ -223,7 +223,7 @@ 
             );
 
             // Use normalized page title (underscored, capitalized)
-            $pageUrl = $this->getProject()->getUrl(false) . str_replace(
+            $pageUrl = $this->getProject()->getUrl(false).str_replace(
                 '$1',
                 ucfirst(str_replace(' ', '_', $wikiLinkPath)),
                 $this->getProject()->getArticlePath()
@@ -261,8 +261,8 @@ 
     public function getDiffUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -272,8 +272,8 @@ 
     public function getPermaUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -305,7 +305,7 @@ 
      */
     public function isAutomated(Container $container)
     {
-        return (bool) $this->getTool($container);
+        return (bool)$this->getTool($container);
     }
 
     /**

src/AppBundle/Controller/RfXVoteCalculatorController.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace AppBundle\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\CssSelector\Exception\InternalErrorException;
-use Symfony\Component\Debug\Exception\ContextErrorException;
 use Symfony\Component\HttpFoundation\Request;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Xtools\ProjectRepository;

Spacing +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
         $username = $request->query->get('username');
 
         if ($projectQuery != '' && $username != '') {
-            $routeParams = [ 'project' => $projectQuery, 'username' => $username ];
+            $routeParams = ['project' => $projectQuery, 'username' => $username];
             return $this->redirectToRoute(
                 'rfxvoteResult',
                 $routeParams
@@ -167,8 +167,8 @@ 
             $titles = [];
 
             while ($row = $sth->fetch()) {
-                $titles[] = $namespaces[$row['page_namespace']] .
-                    ':' .$row['page_title'];
+                $titles[] = $namespaces[$row['page_namespace']].
+                    ':'.$row['page_title'];
             }
 
             // Chunking... it's possible to make a URI too long

Doc Comments +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
      * @Route("/rfxvote/index.php", name="rfxvoteIndexPhp")
      * @Route("/rfxvote", name="RfXVoteCalculator")
      *
-     * @return Response
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function indexAction()
     {
@@ -88,7 +88,7 @@ 
      *
      * @Route("/rfxvote/{project}/{username}", name="rfxvoteResult")
      *
-     * @return Response
+     * @return \Symfony\Component\HttpFoundation\Response
      */
     public function resultAction($project, $username)
     {

src/Xtools/UserRepository.php

Spacing +27 added lines, -27 removed lines

@@ -78,7 +78,7 @@ 
 
         $this->stopwatch->start($cacheKey, 'XTools');
         $api = $this->getMediawikiApi($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
         $res = $api->getRequest($query);
@@ -113,7 +113,7 @@ 
 
         // Create the API query.
         $api = $this->getMediawikiApi($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
 
         // Get the result.
@@ -157,8 +157,8 @@ 
     {
         $username = $user->getUsername();
 
-        $cacheKey = 'pages.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $redirects;
+        $cacheKey = 'pages.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$redirects;
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -216,7 +216,7 @@ 
             JOIN $revisionTable ON page_id = rev_page
             $paJoin
             WHERE $whereRev AND rev_parent_id = '0' $namespaceConditionRev $redirectCondition
-            " . ($hasPageAssessments ? 'GROUP BY rev_page' : '') . "
+            ".($hasPageAssessments ? 'GROUP BY rev_page' : '')."
             )
 
             UNION
@@ -263,21 +263,21 @@ 
      */
     public function countEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'editcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -337,21 +337,21 @@ 
      */
     public function countAutomatedEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'autoeditcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autoeditcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -383,7 +383,7 @@ 
             $tagJoin = $tags != '' ? "LEFT OUTER JOIN $tagTable ON ct_rev_id = rev_id" : '';
             $condTools[] = "ct_tag IN ($tags)";
         }
-        $condTool = 'AND (' . implode(' OR ', $condTools) . ')';
+        $condTool = 'AND ('.implode(' OR ', $condTools).')';
 
         $sql = "SELECT COUNT(DISTINCT(rev_id))
                 FROM $revisionTable
@@ -408,7 +408,7 @@ 
             $resultQuery->bindParam('namespace', $namespace);
         }
         $resultQuery->execute();
-        $result = (int) $resultQuery->fetchColumn();
+        $result = (int)$resultQuery->fetchColumn();
 
         // Cache for 10 minutes, and return.
         $cacheItem = $this->cache->getItem($cacheKey)
@@ -440,21 +440,21 @@ 
         $end = '',
         $offset = 0
     ) {
-        $cacheKey = 'nonautoedits.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $offset;
+        $cacheKey = 'nonautoedits.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$offset;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND revs.rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -547,21 +547,21 @@ 
         $start = '',
         $end = ''
     ) {
-        $cacheKey = 'autotoolcounts.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autotoolcounts.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -608,13 +608,13 @@ 
                 if ($condTool === '') {
                     $condTool = "ct_tag = $tag";
                 } else {
-                    $condTool = '(' . $condTool . " OR ct_tag = $tag)";
+                    $condTool = '('.$condTool." OR ct_tag = $tag)";
                 }
             }
 
             // Developer error, no regex or tag provided for this tool.
             if ($condTool === '') {
-                throw new Exception("No regex or tag found for the tool $toolname. " .
+                throw new Exception("No regex or tag found for the tool $toolname. ".
                     "Please verify this entry in semi_automated.yml");
             }
 
@@ -666,8 +666,8 @@ 
         }
 
         // Sort the array by count
-        uasort($results, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($results, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         // Cache for 10 minutes, and return.

Doc Comments +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
      * Get the user's (system) edit count.
      * @param string $databaseName The database to query.
      * @param string $username The username to find.
-     * @return int|null As returned by the database.
+     * @return string|boolean As returned by the database.
      */
     public function getEditCount($databaseName, $username)
     {
@@ -741,7 +741,7 @@ 
      * Get the combined regex and tags for all semi-automated tools,
      *   ready to be used in a query.
      * @param string $projectDomain Such as en.wikipedia.org
-     * @param $conn Doctrine\DBAL\Connection Used for proper escaping
+     * @param \Doctrine\DBAL\Connection $conn Doctrine\DBAL\Connection Used for proper escaping
      * @return string[] In the format:
      *    ['combined|regex', 'combined,tags']
      */

src/Xtools/EditCounter.php

Doc Comments +2 added lines, -2 removed lines

@@ -473,7 +473,7 @@ 
 
     /**
      * Get the date and time of the user's first edit.
-     * @return DateTime|bool The time of the first revision, or false.
+     * @return DateInterval The time of the first revision, or false.
      */
     public function datetimeFirstRevision()
     {
@@ -483,7 +483,7 @@ 
 
     /**
      * Get the date and time of the user's first edit.
-     * @return DateTime|bool The time of the last revision, or false.
+     * @return DateInterval The time of the last revision, or false.
      */
     public function datetimeLastRevision()
     {

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 namespace Xtools;
 
 use DateTime;
-use Exception;
 use DatePeriod;
 use DateInterval;
 use GuzzleHttp;

Spacing +27 added lines, -27 removed lines

@@ -117,8 +117,8 @@ 
             $promises[] = $promise;
 
             // Handle response of $promise asynchronously.
-            $promise->then(function ($response) use ($key, $endpoint) {
-                $result = (array) json_decode($response->getBody()->getContents());
+            $promise->then(function($response) use ($key, $endpoint) {
+                $result = (array)json_decode($response->getBody()->getContents());
 
                 $this->getRepository()
                     ->getLog()
@@ -135,7 +135,7 @@ 
                     // We'll log this to see how often it happens.
                     $this->getRepository()
                         ->getLog()
-                        ->error("Failed to fetch data for $endpoint via async, " .
+                        ->error("Failed to fetch data for $endpoint via async, ".
                             "re-attempting synchoronously.");
                 }
             });
@@ -191,7 +191,7 @@ 
 
         // Filter out unblocks unless requested.
         if ($blocksOnly) {
-            $blocks = array_filter($blocks, function ($block) {
+            $blocks = array_filter($blocks, function($block) {
                 return $block['log_action'] === 'block';
             });
         }
@@ -225,7 +225,7 @@ 
      */
     public function countAllRevisions()
     {
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
     }
 
     /**
@@ -244,7 +244,7 @@ 
      */
     public function countRevisionsWithoutComments()
     {
-        return $this->countLiveRevisions() - $this->countRevisionsWithComments();
+        return $this->countLiveRevisions()-$this->countRevisionsWithComments();
     }
 
     /**
@@ -283,7 +283,7 @@ 
      */
     public function countAllPagesEdited()
     {
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
     }
 
     /**
@@ -293,7 +293,7 @@ 
      */
     public function countPagesCreated()
     {
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
     }
 
     /**
@@ -433,7 +433,7 @@ 
             } elseif ($block['log_action'] === 'unblock') {
                 // The last block was lifted. So the duration will be the time from when the
                 // last block was set to the time of the unblock.
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
                 if ($timeSinceLastBlock > $this->longestBlockSeconds) {
                     $this->longestBlockSeconds = $timeSinceLastBlock;
 
@@ -444,8 +444,8 @@ 
                 // The last block was modified. So we will adjust $lastBlock to include
                 // the difference of the duration of the new reblock, and time since the last block.
                 // $lastBlock is left unchanged if its duration was indefinite.
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
-                $lastBlock[1] = $timeSinceLastBlock + $duration;
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
+                $lastBlock[1] = $timeSinceLastBlock+$duration;
             }
         }
 
@@ -455,7 +455,7 @@ 
         }
 
         // Test if the last block is still active, and if so use the expiry as the duration.
-        $lastBlockExpiry = $lastBlock[0] + $lastBlock[1];
+        $lastBlockExpiry = $lastBlock[0]+$lastBlock[1];
         if ($lastBlockExpiry > time() && $lastBlockExpiry > $this->longestBlockSeconds) {
             $this->longestBlockSeconds = $lastBlock[1];
         // Otherwise, test if the duration of the last block is now the longest overall.
@@ -496,7 +496,7 @@ 
         // If invalid, $duration is left as null.
         if (strtotime($durationStr)) {
             $expiry = strtotime($durationStr, $timestamp);
-            $duration = $expiry - $timestamp;
+            $duration = $expiry-$timestamp;
         }
 
         return [$timestamp, $duration];
@@ -573,7 +573,7 @@ 
         $import = isset($logCounts['import-import']) ? (int)$logCounts['import-import'] : 0;
         $interwiki = isset($logCounts['import-interwiki']) ? (int)$logCounts['import-interwiki'] : 0;
         $upload = isset($logCounts['import-upload']) ? (int)$logCounts['import-upload'] : 0;
-        return $import + $interwiki + $upload;
+        return $import+$interwiki+$upload;
     }
 
     /**
@@ -697,9 +697,9 @@ 
     public function approvals()
     {
         $logCounts = $this->getLogCounts();
-        $total = $logCounts['review-approve'] +
-        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
-        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
+        $total = $logCounts['review-approve']+
+        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
+        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
         (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
         return $total;
     }
@@ -723,7 +723,7 @@ 
         $logCounts = $this->getLogCounts();
         $create2 = $logCounts['newusers-create2'] ?: 0;
         $byemail = $logCounts['newusers-byemail'] ?: 0;
-        return $create2 + $byemail;
+        return $create2+$byemail;
     }
 
     /**
@@ -775,7 +775,7 @@ 
 
         $totals = $this->getRepository()->getMonthCounts($this->project, $this->user);
         $out = [
-            'yearLabels' => [],  // labels for years
+            'yearLabels' => [], // labels for years
             'monthLabels' => [], // labels for months
             'totals' => [], // actual totals, grouped by namespace, year and then month
         ];
@@ -803,7 +803,7 @@ 
                 $out['totals'][$ns][$total['year']] = [];
             }
 
-            $out['totals'][$ns][$total['year']][$total['month']] = (int) $total['count'];
+            $out['totals'][$ns][$total['year']][$total['month']] = (int)$total['count'];
         }
 
         $dateRange = new DatePeriod(
@@ -813,8 +813,8 @@ 
         );
 
         foreach ($dateRange as $monthObj) {
-            $year = (int) $monthObj->format('Y');
-            $month = (int) $monthObj->format('n');
+            $year = (int)$monthObj->format('Y');
+            $month = (int)$monthObj->format('n');
 
             // Fill in labels
             $out['monthLabels'][] = $monthObj->format('Y-m');
@@ -930,8 +930,8 @@ 
 
         if ($sorted) {
             // Sort.
-            uasort($this->globalEditCounts, function ($a, $b) {
-                return $b['total'] - $a['total'];
+            uasort($this->globalEditCounts, function($a, $b) {
+                return $b['total']-$a['total'];
             });
         }
 
@@ -967,7 +967,7 @@ 
                 $nsName = $project->getNamespaces()[$revision['page_namespace']];
             }
             $page = $project->getRepository()
-                ->getPage($project, $nsName . ':' . $revision['page_title']);
+                ->getPage($project, $nsName.':'.$revision['page_title']);
             $edit = new Edit($page, $revision);
             $globalEdits[$edit->getTimestamp()->getTimestamp().'-'.$edit->getId()] = $edit;
         }
@@ -1008,7 +1008,7 @@ 
     public function countSmallEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['small_edits']) ? (int) $editSizeData['small_edits'] : 0;
+        return isset($editSizeData['small_edits']) ? (int)$editSizeData['small_edits'] : 0;
     }
 
     /**
@@ -1018,7 +1018,7 @@ 
     public function countLargeEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['large_edits']) ? (int) $editSizeData['large_edits'] : 0;
+        return isset($editSizeData['large_edits']) ? (int)$editSizeData['large_edits'] : 0;
     }
 
     /**