Completed
Pull Request — master (#34)
by Sam
03:39
created
src/AppBundle/Controller/SimpleEditCounterController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
         $username = $request->query->get('username');
32 32
 
33 33
         if ($projectQuery != "" && $username != "") {
34
-            $routeParams = [ 'project'=>$projectQuery, 'username' => $username ];
34
+            $routeParams = ['project'=>$projectQuery, 'username' => $username];
35 35
             return $this->redirectToRoute("SimpleEditCounterResult", $routeParams);
36 36
         } elseif ($projectQuery != "") {
37
-            return $this->redirectToRoute("SimpleEditCounterProject", [ 'project'=>$projectQuery ]);
37
+            return $this->redirectToRoute("SimpleEditCounterProject", ['project'=>$projectQuery]);
38 38
         }
39 39
 
40 40
         // Otherwise fall through.
@@ -87,8 +87,8 @@  discard block
 block discarded – undo
87 87
         $resultQuery->execute();
88 88
 
89 89
         if ($resultQuery->errorCode() > 0) {
90
-            $this->addFlash("notice", [ "no-result", $username ]);
91
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
90
+            $this->addFlash("notice", ["no-result", $username]);
91
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
92 92
         }
93 93
 
94 94
         // Fetch the result data
@@ -112,16 +112,16 @@  discard block
 block discarded – undo
112 112
                 $rev = $row["value"];
113 113
             }
114 114
             if ($row["source"] == "groups") {
115
-                $groups .= $row["value"]. ", ";
115
+                $groups .= $row["value"].", ";
116 116
             }
117 117
         }
118 118
 
119 119
         // Unknown user - If the user is created the $results variable will have 3 entries.
120 120
         // This is a workaround to detect non-existent IPs.
121 121
         if (count($results) < 3 && $arch == 0 && $rev == 0) {
122
-            $this->addFlash('notice', [ "no-result", $username ]);
122
+            $this->addFlash('notice', ["no-result", $username]);
123 123
 
124
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
124
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
125 125
         }
126 126
 
127 127
         // Remove the last comma and space
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
             'project_url' => $url,
152 152
             'id' => $id,
153 153
             'arch' => $arch,
154
-            'rev' => $rev + $arch,
154
+            'rev' => $rev+$arch,
155 155
             'live' => $rev,
156 156
             'groups' => $groups,
157 157
             'globalGroups' => $globalGroups,
Please login to merge, or discard this patch.
src/AppBundle/Helper/AutomatedEditsHelper.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -143,12 +143,12 @@  discard block
 block discarded – undo
143 143
         }
144 144
 
145 145
         // Get diff sizes, based on length of each parent revision
146
-        $parentRevIds = array_map(function ($edit) {
146
+        $parentRevIds = array_map(function($edit) {
147 147
             return $edit['rev_parent_id'];
148 148
         }, $editData);
149 149
         $query = "SELECT rev_len, rev_id
150 150
                   FROM revision
151
-                  WHERE rev_id IN (" . implode(',', $parentRevIds) . ")";
151
+                  WHERE rev_id IN (" . implode(',', $parentRevIds).")";
152 152
         $diffSizeData = $conn->executeQuery($query)->fetchAll();
153 153
 
154 154
         // reformat with rev_id as the key, rev_len as the value
@@ -158,24 +158,24 @@  discard block
 block discarded – undo
158 158
         }
159 159
 
160 160
         // Build our array of nonautomated edits
161
-        $editData = array_map(function ($edit) use ($namespaces, $diffSizes) {
161
+        $editData = array_map(function($edit) use ($namespaces, $diffSizes) {
162 162
             $pageTitle = $edit['page_title'];
163 163
 
164 164
             if ($edit['page_namespace'] !== '0') {
165
-                $pageTitle = $namespaces[$edit['page_namespace']] . ":$pageTitle";
165
+                $pageTitle = $namespaces[$edit['page_namespace']].":$pageTitle";
166 166
             }
167 167
 
168 168
             $diffSize = $edit['rev_len'];
169 169
             if ($edit['rev_parent_id'] > 0) {
170
-                $diffSize = $edit['rev_len'] - $diffSizes[$edit['rev_parent_id']];
170
+                $diffSize = $edit['rev_len']-$diffSizes[$edit['rev_parent_id']];
171 171
             }
172 172
 
173 173
             return [
174 174
                 'page_title' => $pageTitle,
175
-                'namespace' => (int) $edit['page_namespace'],
176
-                'rev_id' => (int) $edit['rev_id'],
175
+                'namespace' => (int)$edit['page_namespace'],
176
+                'rev_id' => (int)$edit['rev_id'],
177 177
                 'timestamp' => DateTime::createFromFormat('YmdHis', $edit['rev_timestamp']),
178
-                'minor_edit' => (bool) $edit['rev_minor_edit'],
178
+                'minor_edit' => (bool)$edit['rev_minor_edit'],
179 179
                 'summary' => $edit['rev_comment'],
180 180
                 'size' => $diffSize
181 181
             ];
Please login to merge, or discard this patch.
src/Xtools/EditCounterRepository.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
     public function getRevisionCounts(Project $project, User $user)
19 19
     {
20 20
         // Set up cache.
21
-        $cacheKey = 'revisioncounts.' . $project->getDatabaseName() . '.' . $user->getUsername();
21
+        $cacheKey = 'revisioncounts.'.$project->getDatabaseName().'.'.$user->getUsername();
22 22
         if ($this->cache->hasItem($cacheKey)) {
23 23
             return $this->cache->getItem($cacheKey)->get();
24 24
         }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     public function getRevisionDates(Project $project, User $user)
80 80
     {
81 81
         // Set up cache.
82
-        $cacheKey = 'revisiondates.' . $project->getDatabaseName() . '.' . $user->getUsername();
82
+        $cacheKey = 'revisiondates.'.$project->getDatabaseName().'.'.$user->getUsername();
83 83
         if ($this->cache->hasItem($cacheKey)) {
84 84
             return $this->cache->getItem($cacheKey)->get();
85 85
         }
@@ -151,10 +151,10 @@  discard block
 block discarded – undo
151 151
         $results = $resultQuery->fetchAll();
152 152
 
153 153
         $pageCounts = array_combine(
154
-            array_map(function ($e) {
154
+            array_map(function($e) {
155 155
                 return $e['source'];
156 156
             }, $results),
157
-            array_map(function ($e) {
157
+            array_map(function($e) {
158 158
                 return $e['value'];
159 159
             }, $results)
160 160
         );
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
         // Query.
187 187
         $sql = "SELECT CONCAT(log_type, '-', log_action) AS source, COUNT(log_id) AS value
188
-            FROM " . $this->getTableName($project->getDatabaseName(), 'logging') . "
188
+            FROM " . $this->getTableName($project->getDatabaseName(), 'logging')."
189 189
             WHERE log_user = :userId
190 190
             GROUP BY log_type, log_action";
191 191
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
@@ -194,10 +194,10 @@  discard block
 block discarded – undo
194 194
         $resultQuery->execute();
195 195
         $results = $resultQuery->fetchAll();
196 196
         $logCounts = array_combine(
197
-            array_map(function ($e) {
197
+            array_map(function($e) {
198 198
                 return $e['source'];
199 199
             }, $results),
200
-            array_map(function ($e) {
200
+            array_map(function($e) {
201 201
                 return $e['value'];
202 202
             }, $results)
203 203
         );
@@ -346,9 +346,9 @@  discard block
 block discarded – undo
346 346
         $resultQuery->bindParam(":id", $userId);
347 347
         $resultQuery->execute();
348 348
         $results = $resultQuery->fetchAll();
349
-        $namespaceTotals = array_combine(array_map(function ($e) {
349
+        $namespaceTotals = array_combine(array_map(function($e) {
350 350
             return $e['page_namespace'];
351
-        }, $results), array_map(function ($e) {
351
+        }, $results), array_map(function($e) {
352 352
             return $e['total'];
353 353
         }, $results));
354 354
         return $namespaceTotals;
@@ -412,14 +412,14 @@  discard block
 block discarded – undo
412 412
                 $revisions = $this->cache->getItem($cacheKey)->get();
413 413
             } else {
414 414
                 $sql =
415
-                    "SELECT rev_id, rev_timestamp, UNIX_TIMESTAMP(rev_timestamp) AS unix_timestamp, " .
416
-                    " rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_comment, " .
417
-                    " page_title, page_namespace " . " FROM " .
418
-                    $this->getTableName($project['dbname'], 'revision') . "    JOIN " .
419
-                    $this->getTableName($project['dbname'], 'page') .
420
-                    "    ON (rev_page = page_id)" .
421
-                    " WHERE rev_timestamp > NOW() - INTERVAL $days DAY AND rev_user_text LIKE :username" .
422
-                    " ORDER BY rev_timestamp DESC" . " LIMIT 10";
415
+                    "SELECT rev_id, rev_timestamp, UNIX_TIMESTAMP(rev_timestamp) AS unix_timestamp, ".
416
+                    " rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_comment, ".
417
+                    " page_title, page_namespace "." FROM ".
418
+                    $this->getTableName($project['dbname'], 'revision')."    JOIN ".
419
+                    $this->getTableName($project['dbname'], 'page').
420
+                    "    ON (rev_page = page_id)".
421
+                    " WHERE rev_timestamp > NOW() - INTERVAL $days DAY AND rev_user_text LIKE :username".
422
+                    " ORDER BY rev_timestamp DESC"." LIMIT 10";
423 423
                 $resultQuery = $this->getProjectsConnection()->prepare($sql);
424 424
                 $resultQuery->bindParam(":username", $username);
425 425
                 $resultQuery->execute();
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
             if (count($revisions) === 0) {
435 435
                 continue;
436 436
             }
437
-            $revsWithProject = array_map(function (&$item) use ($project) {
437
+            $revsWithProject = array_map(function(&$item) use ($project) {
438 438
                 $item['project_name'] = $project['wikiName'];
439 439
                 $item['project_url'] = $project['url'];
440 440
                 $item['project_db_name'] = $project['dbName'];
@@ -444,8 +444,8 @@  discard block
 block discarded – undo
444 444
             }, $revisions);
445 445
             $allRevisions = array_merge($allRevisions, $revsWithProject);
446 446
         }
447
-        usort($allRevisions, function ($a, $b) {
448
-            return $b['rev_timestamp'] - $a['rev_timestamp'];
447
+        usort($allRevisions, function($a, $b) {
448
+            return $b['rev_timestamp']-$a['rev_timestamp'];
449 449
         });
450 450
 
451 451
         return array_slice($allRevisions, 0, $topN);
@@ -467,12 +467,12 @@  discard block
 block discarded – undo
467 467
         $revisionTable = $this->getTableName($project->getDatabaseName(), 'revision');
468 468
         $pageTable = $this->getTableName($project->getDatabaseName(), 'page');
469 469
         $sql =
470
-            "SELECT " . "     YEAR(rev_timestamp) AS `year`," .
471
-            "     MONTH(rev_timestamp) AS `month`," . "     page_namespace," .
470
+            "SELECT "."     YEAR(rev_timestamp) AS `year`,".
471
+            "     MONTH(rev_timestamp) AS `month`,"."     page_namespace,".
472 472
             "     COUNT(rev_id) AS `count` "
473
-            . " FROM $revisionTable    JOIN $pageTable ON (rev_page = page_id)" .
474
-            " WHERE rev_user_text = :username" .
475
-            " GROUP BY YEAR(rev_timestamp), MONTH(rev_timestamp), page_namespace " .
473
+            . " FROM $revisionTable    JOIN $pageTable ON (rev_page = page_id)".
474
+            " WHERE rev_user_text = :username".
475
+            " GROUP BY YEAR(rev_timestamp), MONTH(rev_timestamp), page_namespace ".
476 476
             " ORDER BY rev_timestamp DESC";
477 477
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
478 478
         $resultQuery->bindParam(":username", $username);
Please login to merge, or discard this patch.
tests/AppBundle/Controller/ApiControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
             $this->assertEquals(200, $client->getResponse()->getStatusCode());
35 35
 
36 36
             // Check that a correct namespace value was returned
37
-            $namespaces = (array) json_decode($client->getResponse()->getContent());
37
+            $namespaces = (array)json_decode($client->getResponse()->getContent());
38 38
             $this->assertEquals('Utilisateur', array_values($namespaces)[2]); // User in French
39 39
         }
40 40
     }
Please login to merge, or discard this patch.
app/autoload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,6 +8,6 @@
 block discarded – undo
8 8
  */
9 9
 $loader = require __DIR__.'/../vendor/autoload.php';
10 10
 
11
-AnnotationRegistry::registerLoader([ $loader, 'loadClass' ]);
11
+AnnotationRegistry::registerLoader([$loader, 'loadClass']);
12 12
 
13 13
 return $loader;
Please login to merge, or discard this patch.
app/AppKernel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
             new AppBundle\AppBundle(),
28 28
         ];
29 29
 
30
-        if (in_array($this->getEnvironment(), [ 'dev', 'test' ], true)) {
30
+        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
31 31
             $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
32 32
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
33 33
             $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();
Please login to merge, or discard this patch.