User::getId() - Code Metrics - Inspection of "Merge pull request #26 from x-tools/oop-user" - x-tools/xtools - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fcf66f...4020b1 )

by Sam

created 2017-05-09 04:11 UTC

User::getId() A

↳ Parent: User

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Xtools;

/**
 * A User is a wiki user who has the same username across all projects in an Xtools installation.
 */
class User extends Model
{

    /** @var int */
    protected $id;

    /** @var string */
    protected $username;

    /**
     * Create a new User given a username.
     * @param string $username
     */
    public function __construct($username)
    {
        $this->username = ucfirst($username);
    }

    /**
     * Get the username.
     * @return string
     */
    public function getUsername()
    {
        return $this->username;
    }

    /**
     * Get the user's ID on the given project.
     * @param Project $project
     * @return int
     */
    public function getId(Project $project)
    {
        return $this->getRepository()->getId($project->getDatabaseName(), $this->getUsername());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * Get a list of this user's groups on the given project.
     */
    public function getGroups(Project $project)

    {
    }

    /**
     * Get the full URL to Special:UserRights for this user on the given project.
     * @param Project $project
     * @return string
     */
    public function userRightsUrl(Project $project)
    {
        return $project->getUrl() . $project->getScriptPath() . "?title=Special:UserRights&user=" .
               $this->getUsername();
    }
}


1			<?php
2
3			namespace Xtools;
4
5			/**
6			* A User is a wiki user who has the same username across all projects in an Xtools installation.
7			*/
8			class User extends Model
9			{
10
11			/** @var int */
12			protected $id;
13
14			/** @var string */
15			protected $username;
16
17			/**
18			* Create a new User given a username.
19			* @param string $username
20			*/
21			public function __construct($username)
22			{
23			$this->username = ucfirst($username);
24			}
25
26			/**
27			* Get the username.
28			* @return string
29			*/
30			public function getUsername()
31			{
32			return $this->username;
33			}
34
35			/**
36			* Get the user's ID on the given project.
37			* @param Project $project
38			* @return int
39			*/
40			public function getId(Project $project)
41			{
42			return $this->getRepository()->getId($project->getDatabaseName(), $this->getUsername());
			1 ignored issue – show Bug introduced 2017-05-02 01:55 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Xtools\Repository` as the method `getId()` does only exist in the following sub-classes of `Xtools\Repository`: `Xtools\UserRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
43			}
44
45			/**
46			* Get a list of this user's groups on the given project.
47			*/
48			public function getGroups(Project $project)
			0 ignored issues – show Unused Code introduced 2017-05-01 09:11 UTC by Report Bug Copy Issue Report The parameter `$project` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
49			{
50			}
51
52			/**
53			* Get the full URL to Special:UserRights for this user on the given project.
54			* @param Project $project
55			* @return string
56			*/
57			public function userRightsUrl(Project $project)
58			{
59			return $project->getUrl() . $project->getScriptPath() . "?title=Special:UserRights&user=" .
60			$this->getUsername();
61			}
62			}
63

x-tools / xtools

Push — master ( fcf66f...4020b1 )

User::getId() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like