Test Failed
Pull Request — master (#378)
by MusikAnimal
19:01
created
src/AppBundle/Model/ArticleInfo.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1319,10 +1319,10 @@
 block discarded – undo
1319 1319
         // Slice to the top 10.
1320 1320
         $topTenEditorsByAdded = array_keys(array_slice($topTenEditorsByAdded, 0, 10, true));
1321 1321
 
1322
-         // Get the sum of added text so that we can add in percentages.
1323
-         $topTenTotalAdded = array_sum(array_map(function ($editor) {
1324
-             return $this->editors[$editor]['added'];
1325
-         }, $topTenEditorsByAdded));
1322
+            // Get the sum of added text so that we can add in percentages.
1323
+            $topTenTotalAdded = array_sum(array_map(function ($editor) {
1324
+                return $this->editors[$editor]['added'];
1325
+            }, $topTenEditorsByAdded));
1326 1326
 
1327 1327
         // Then build a new array of top 10 editors by added text in the data structure needed for the chart.
1328 1328
         return array_map(function ($editor) use ($topTenTotalAdded) {
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the ArticleInfo class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     public function getMaxRevisions(): int
174 174
     {
175 175
         if (!isset($this->maxRevisions)) {
176
-            $this->maxRevisions = (int) $this->container->getParameter('app.max_page_revisions');
176
+            $this->maxRevisions = (int)$this->container->getParameter('app.max_page_revisions');
177 177
         }
178 178
         return $this->maxRevisions;
179 179
     }
@@ -792,7 +792,7 @@  discard block
 block discarded – undo
792 792
         $this->yearMonthCounts[$editYear]['all']++;
793 793
         $this->yearMonthCounts[$editYear]['months'][$editMonth]['all']++;
794 794
         // This will ultimately be the size of the page by the end of the year
795
-        $this->yearMonthCounts[$editYear]['size'] = (int) $edit->getLength();
795
+        $this->yearMonthCounts[$editYear]['size'] = (int)$edit->getLength();
796 796
 
797 797
         // Keep track of which month had the most edits
798 798
         $editsThisMonth = $this->yearMonthCounts[$editYear]['months'][$editMonth]['all'];
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
 
1004 1004
             if ($info['all'] > 1) {
1005 1005
                 // Number of seconds/days between first and last edit.
1006
-                $secs = $info['last']->getTimestamp() - $info['first']->getTimestamp();
1006
+                $secs = $info['last']->getTimestamp()-$info['first']->getTimestamp();
1007 1007
                 $days = $secs / (60 * 60 * 24);
1008 1008
 
1009 1009
                 // Average time between edits (in days).
@@ -1012,7 +1012,7 @@  discard block
 block discarded – undo
1012 1012
         }
1013 1013
 
1014 1014
         // Loop through again and add percentages.
1015
-        $this->topTenEditorsByEdits = array_map(function ($editor) use ($topTenCount) {
1015
+        $this->topTenEditorsByEdits = array_map(function($editor) use ($topTenCount) {
1016 1016
             $editor['percentage'] = 100 * ($editor['value'] / $topTenCount);
1017 1017
             return $editor;
1018 1018
         }, $topTenEditorsByEdits);
@@ -1030,7 +1030,7 @@  discard block
 block discarded – undo
1030 1030
     {
1031 1031
         // First sort editors array by the amount of text they added.
1032 1032
         $topTenEditorsByAdded = $this->editors;
1033
-        uasort($topTenEditorsByAdded, function ($a, $b) {
1033
+        uasort($topTenEditorsByAdded, function($a, $b) {
1034 1034
             if ($a['added'] === $b['added']) {
1035 1035
                 return 0;
1036 1036
             }
@@ -1041,12 +1041,12 @@  discard block
 block discarded – undo
1041 1041
         $topTenEditorsByAdded = array_keys(array_slice($topTenEditorsByAdded, 0, 10, true));
1042 1042
 
1043 1043
          // Get the sum of added text so that we can add in percentages.
1044
-         $topTenTotalAdded = array_sum(array_map(function ($editor) {
1044
+         $topTenTotalAdded = array_sum(array_map(function($editor) {
1045 1045
              return $this->editors[$editor]['added'];
1046 1046
          }, $topTenEditorsByAdded));
1047 1047
 
1048 1048
         // Then build a new array of top 10 editors by added text in the data structure needed for the chart.
1049
-        return array_map(function ($editor) use ($topTenTotalAdded) {
1049
+        return array_map(function($editor) use ($topTenTotalAdded) {
1050 1050
             $added = $this->editors[$editor]['added'];
1051 1051
             return [
1052 1052
                 'label' => $editor,
Please login to merge, or discard this patch.
src/AppBundle/Repository/EditRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Repository;
5 5
 
Please login to merge, or discard this patch.
src/AppBundle/Repository/BlameRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Repository;
5 5
 
Please login to merge, or discard this patch.
src/AppBundle/Model/Blame.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Model;
5 5
 
Please login to merge, or discard this patch.
src/AppBundle/Repository/PageRepository.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the PageRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 
307 307
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
308 308
 
309
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
309
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
310 310
                 FROM wikidatawiki_p.wb_items_per_site
311 311
                 WHERE ips_item_id = :wikidataId";
312 312
 
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
             'wikidataId' => $wikidataId,
315 315
         ])->fetchAll();
316 316
 
317
-        return $count ? (int) $result[0]['count'] : $result;
317
+        return $count ? (int)$result[0]['count'] : $result;
318 318
     }
319 319
 
320 320
     /**
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
 
353 353
         // Transform to associative array by 'type'
354 354
         foreach ($res as $row) {
355
-            $data[$row['type'] . '_count'] = (int)$row['value'];
355
+            $data[$row['type'].'_count'] = (int)$row['value'];
356 356
         }
357 357
 
358 358
         return $data;
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 
397 397
         $project = $page->getProject()->getDomain();
398 398
 
399
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
399
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
400 400
             "$project/all-access/user/$title/daily/$start/$end";
401 401
 
402 402
         $res = $client->request('GET', $url);
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
             $normalized = [];
472 472
             if (isset($result['query']['normalized'])) {
473 473
                 array_map(
474
-                    function ($e) use (&$normalized): void {
474
+                    function($e) use (&$normalized): void {
475 475
                         $normalized[$e['to']] = $e['from'];
476 476
                     },
477 477
                     $result['query']['normalized']
Please login to merge, or discard this patch.
src/AppBundle/Repository/ArticleInfoRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the ArticleInfoRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $sql = "SELECT log_action, log_type, log_timestamp AS 'timestamp'
86 86
                 FROM $loggingTable
87
-                WHERE log_namespace = '" . $page->getNamespace() . "'
87
+                WHERE log_namespace = '".$page->getNamespace()."'
88 88
                 AND log_title = :title AND log_timestamp > 1 $datesConditions
89 89
                 AND log_type IN ('delete', 'move', 'protect', 'stable')";
90 90
         $title = str_replace(' ', '_', $page->getTitle());
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         $time2 = time();
266 266
 
267 267
         // If it took over 5 seconds, cache the result for 20 minutes.
268
-        if ($time2 - $time1 > 5) {
268
+        if ($time2-$time1 > 5) {
269 269
             $this->setCache($cacheKey, $result, 'PT20M');
270 270
         }
271 271
 
Please login to merge, or discard this patch.
src/AppBundle/Controller/TopEditsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@
 block discarded – undo
166 166
         // Send all to the template.
167 167
         return $this->getFormattedResponse('topedits/result_article', [
168 168
             'xtPage' => 'TopEdits',
169
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->page->getTitle(),
169
+            'xtTitle' => $this->user->getUsername().' - '.$this->page->getTitle(),
170 170
             'te' => $topEdits,
171 171
         ]);
172 172
     }
Please login to merge, or discard this patch.
src/AppBundle/EventSubscriber/RateLimitSubscriber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the RateLimitSubscriber class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\EventSubscriber;
9 9
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         $cacheItem = $this->cache->getItem($cacheKey);
125 125
 
126 126
         // If increment value already in cache, or start with 1.
127
-        $count = $cacheItem->isHit() ? (int) $cacheItem->get() + 1 : 1;
127
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
128 128
 
129 129
         // Check if limit has been exceeded, and if so, throw an error.
130 130
         if ($count > $this->rateLimit) {
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         $cacheItem = $this->cache->getItem($cacheKey);
165 165
 
166 166
         // If increment value already in cache, or start with 1.
167
-        $count = $cacheItem->isHit() ? (int)$cacheItem->get() + 1 : 1;
167
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
168 168
 
169 169
         // Check if limit has been exceeded, and if so, add a log entry.
170 170
         if ($count > 3) {
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
         $message = $this->i18n->msg('error-rate-limit', [
240 240
             $this->rateDuration,
241 241
             "<a href='/login'>".$this->i18n->msg('error-rate-limit-login')."</a>",
242
-            "<a href='https://xtools.readthedocs.io/en/stable/api' target='_blank'>" .
243
-                $this->i18n->msg('api') .
242
+            "<a href='https://xtools.readthedocs.io/en/stable/api' target='_blank'>".
243
+                $this->i18n->msg('api').
244 244
             "</a>",
245 245
         ]);
246 246
 
Please login to merge, or discard this patch.
src/AppBundle/Repository/Repository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the Repository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
         // $tableExtension in order to generate the new table name
167 167
         if ($this->isLabs() && null !== $tableExtension) {
168 168
             $mapped = true;
169
-            $tableName .=('' === $tableExtension ? '' : '_'.$tableExtension);
169
+            $tableName .= ('' === $tableExtension ? '' : '_'.$tableExtension);
170 170
         } elseif ($this->container->hasParameter("app.table.$tableName")) {
171 171
             // Use the table specified in the table mapping configuration, if present.
172 172
             $mapped = true;
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
         // This is a safeguard in case table mapping isn't properly set up.
179 179
         $isLoggingOrRevision = in_array($tableName, ['revision', 'logging', 'archive']);
180 180
         if (!$mapped && $isLoggingOrRevision && $this->isLabs()) {
181
-            $tableName .="_userindex";
181
+            $tableName .= "_userindex";
182 182
         }
183 183
 
184 184
         // Figure out database name.
Please login to merge, or discard this patch.