x-tools / xtools

src/AppBundle/Twig/WikiExtension.php

Doc Comments +1 added lines, -2 removed lines

@@ -72,7 +72,6 @@ 
 
     /**
      * Get a link to the given user's userpage, or to Special:Contribs if $username is an IP
-     * @param  string $username   Username
      * @param  string $projectUrl Project domain and protocol such as https://en.wikipedia.org
      * @param  string [$label]    The link text, defaults to $username
      * @return string Markup
@@ -176,7 +175,7 @@ 
     /**
      * Get links to pageviews tools for the given page
      * @param  string $title      Title of page
-     * @param  string $projectUrl Project domain such as en.wikipedia.org
+     * @param  string $project Project domain such as en.wikipedia.org
      * @return string Markup
      */
     public function pageviewsLinks($title, $project)

Spacing +15 added lines, -15 removed lines

@@ -14,25 +14,25 @@ 
 
     public function intuitionMessage($message = "", $vars = [])
     {
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
     }
 
     /*********************************** FUNCTIONS ***********************************/
 
     public function getFunctions()
     {
-        $options = [ 'is_safe' => [ 'html']];
+        $options = ['is_safe' => ['html']];
         return [
-            new Twig_SimpleFunction('wiki_link', [ $this, 'wikiLink' ], $options),
-            new Twig_SimpleFunction('user_link', [ $this, 'userLink' ], $options),
-            new Twig_SimpleFunction('user_log_link', [ $this, 'userLogLink' ], $options),
-            new Twig_SimpleFunction('group_link', [ $this, 'groupLink' ], $options),
-            new Twig_SimpleFunction('wiki_history_link', [ $this, 'wikiHistoryLink' ], $options),
-            new Twig_SimpleFunction('wiki_log_link', [ $this, 'wikiLogLink' ], $options),
-            new Twig_SimpleFunction('pageviews_links', [ $this, 'pageviewsLinks' ], $options),
-            new Twig_SimpleFunction('diff_link', [ $this, 'diffLink' ], $options),
-            new Twig_SimpleFunction('perma_link', [ $this, 'permaLink' ], $options),
-            new Twig_SimpleFunction('edit_link', [ $this, 'editLink' ], $options),
+            new Twig_SimpleFunction('wiki_link', [$this, 'wikiLink'], $options),
+            new Twig_SimpleFunction('user_link', [$this, 'userLink'], $options),
+            new Twig_SimpleFunction('user_log_link', [$this, 'userLogLink'], $options),
+            new Twig_SimpleFunction('group_link', [$this, 'groupLink'], $options),
+            new Twig_SimpleFunction('wiki_history_link', [$this, 'wikiHistoryLink'], $options),
+            new Twig_SimpleFunction('wiki_log_link', [$this, 'wikiLogLink'], $options),
+            new Twig_SimpleFunction('pageviews_links', [$this, 'pageviewsLinks'], $options),
+            new Twig_SimpleFunction('diff_link', [$this, 'diffLink'], $options),
+            new Twig_SimpleFunction('perma_link', [$this, 'permaLink'], $options),
+            new Twig_SimpleFunction('edit_link', [$this, 'editLink'], $options),
         ];
     }
 
@@ -244,8 +244,8 @@ 
     public function getFilters()
     {
         return [
-            new \Twig_SimpleFilter('diff_format', [ $this, 'diffFormat' ], [ 'is_safe' => [ 'html' ] ]),
-            new \Twig_SimpleFilter('wikify_comment', [ $this, 'wikifyComment' ], [ 'is_safe' => [ 'html' ] ]),
+            new \Twig_SimpleFilter('diff_format', [$this, 'diffFormat'], ['is_safe' => ['html']]),
+            new \Twig_SimpleFilter('wikify_comment', [$this, 'wikifyComment'], ['is_safe' => ['html']]),
         ];
     }
 
@@ -284,7 +284,7 @@ 
         if ($isSection) {
             $sectionTitle = $sectionMatch[1][0];
             $sectionTitleLink = str_replace(' ', '_', $sectionTitle);
-            $sectionWikitext = "<a target='_blank' href='$projectUrl/wiki/$title#$sectionTitleLink'>&rarr;</a>" .
+            $sectionWikitext = "<a target='_blank' href='$projectUrl/wiki/$title#$sectionTitleLink'>&rarr;</a>".
                 "<em class='text-muted'>$sectionTitle:</em> ";
             $wikitext = str_replace($sectionMatch[0][0], $sectionWikitext, $wikitext);
         }

src/AppBundle/Controller/AdminStatsController.php

Spacing +1 added lines, -1 removed lines

@@ -176,7 +176,7 @@
 
         // Iterate over query results, loading each user id into the array
         while ($row = $res->fetch()) {
-            $adminIdArr[] = $row["user_id"] ;
+            $adminIdArr[] = $row["user_id"];
         }
 
         // Set the query results to be useful in a sql statement.

src/AppBundle/Helper/ApiHelper.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace AppBundle\Helper;
 
-use DateInterval;
 use Mediawiki\Api\MediawikiApi;
 use Mediawiki\Api\SimpleRequest;
 use Mediawiki\Api\FluentRequest;

Spacing +14 added lines, -14 removed lines

@@ -39,7 +39,7 @@ 
             $apiPath = $this->container->getParameter('api_path');
 
             try {
-                $this->api = MediawikiApi::newFromApiEndpoint($normalizedProject . $apiPath);
+                $this->api = MediawikiApi::newFromApiEndpoint($normalizedProject.$apiPath);
             } catch (Exception $e) {
                 // Do nothing...
             } catch (FatalErrorException $e) {
@@ -68,13 +68,13 @@ 
             throw new Exception("Unable to find project '$project'");
         }
 
-        $cacheKey = "siteinfo." . str_replace('/', '_', $normalizedProject);
+        $cacheKey = "siteinfo.".str_replace('/', '_', $normalizedProject);
         if ($this->cacheHas($cacheKey)) {
             return $this->cacheGet($cacheKey);
         }
 
         $this->setUp($normalizedProject);
-        $params = [ 'meta'=>'siteinfo', 'siprop'=>'general|namespaces' ];
+        $params = ['meta'=>'siteinfo', 'siprop'=>'general|namespaces'];
         $query = new SimpleRequest('query', $params);
 
         $result = [
@@ -138,7 +138,7 @@ 
     public function groups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -157,7 +157,7 @@ 
     public function globalGroups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -205,7 +205,7 @@ 
                 $groups[] = "B";
             }
             if (in_array("steward", $admin["groups"])) {
-                $groups[] = "S" ;
+                $groups[] = "S";
             }
             if (in_array("checkuser", $admin["groups"])) {
                 $groups[] = "CU";
@@ -216,7 +216,7 @@ 
             if (in_array("bot", $admin["groups"])) {
                 $groups[] = "Bot";
             }
-            $result[ $admin["name"] ] = [
+            $result[$admin["name"]] = [
                 "groups" => implode('/', $groups)
             ];
         }
@@ -291,7 +291,7 @@ 
             $normalized = [];
             if (isset($result['query']['normalized'])) {
                 array_map(
-                    function ($e) use (&$normalized) {
+                    function($e) use (&$normalized) {
                         $normalized[$e['to']] = $e['from'];
                     },
                     $result['query']['normalized']
@@ -337,7 +337,7 @@ 
         ];
 
         // get assessments for this page from the API
-        $assessments = $this->massApi($params, $project, function ($data) {
+        $assessments = $this->massApi($params, $project, function($data) {
             return isset($data['pages'][0]['pageassessments']) ? $data['pages'][0]['pageassessments'] : [];
         }, 'pacontinue')['pages'];
 
@@ -361,7 +361,7 @@ 
                 $classAttrs = $config['class']['Unknown'];
                 $assessment['class']['value'] = '???';
                 $assessment['class']['category'] = $classAttrs['category'];
-                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/". $classAttrs['badge'];
+                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".$classAttrs['badge'];
             } else {
                 $classAttrs = $config['class'][$classValue];
                 $assessment['class'] = [
@@ -372,7 +372,7 @@ 
 
                 // add full URL to badge icon
                 if ($classAttrs['badge'] !== '') {
-                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/" .
+                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".
                         $classAttrs['badge'];
                 }
 
@@ -421,9 +421,9 @@ 
         $config = $this->getAssessmentsConfig();
 
         if (isset($config[$project]['class'][$class])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class'][$class]['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class'][$class]['badge'];
         } elseif (isset($config[$project]['class']['Unknown'])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class']['Unknown']['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class']['Unknown']['badge'];
         } else {
             return "";
         }
@@ -516,7 +516,7 @@ 
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
         $innerPromise = $this->api->getRequestAsync($query);
 
-        $innerPromise->then(function ($result) use (&$data) {
+        $innerPromise->then(function($result) use (&$data) {
             // some failures come back as 200s, so we still resolve and let the outer function handle it
             if (isset($result['error']) || !isset($result['query'])) {
                 return $data['promise']->resolve($data);

Doc Comments +1 added lines, -1 removed lines

@@ -177,7 +177,7 @@
      * Get a list of namespaces on the given project.
      *
      * @param string    $project such as en.wikipedia.org
-     * @return string[] Array of namespace IDs (keys) to names (values).
+     * @return string Array of namespace IDs (keys) to names (values).
      */
     public function namespaces($project)
     {

src/AppBundle/Controller/QuoteController.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
-use Symfony\Component\Debug\Exception\ContextErrorException;
 use Symfony\Component\Routing\Exception\InvalidParameterException;
 use Symfony\Component\HttpFoundation\Request;
 

Spacing +2 added lines, -2 removed lines

@@ -111,7 +111,7 @@ 
             'quote/all.html.twig',
             [
                 'base_dir' => realpath(
-                    $this->getParameter('kernel.root_dir') . '/..'
+                    $this->getParameter('kernel.root_dir').'/..'
                 ),
                 'xtPage' => 'bash',
                 'quotes' => $quotes,
@@ -160,7 +160,7 @@ 
             'quote/view.html.twig',
             [
                 'base_dir' => realpath(
-                    $this->getParameter('kernel.root_dir') . '/..'
+                    $this->getParameter('kernel.root_dir').'/..'
                 ),
                 "xtPage" => "bash",
                 "text" => $text,

src/AppBundle/Controller/AutomatedEditsController.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class AutomatedEditsController extends Controller
 {

Spacing +1 added lines, -1 removed lines

@@ -155,7 +155,7 @@
         $archiveTable = $lh->getTable("archive", $dbName);
 
         $cond_begin = $start ? " AND rev_timestamp > :start " : null;
-        $cond_end = $end ? " AND rev_timestamp < :end ": null;
+        $cond_end = $end ? " AND rev_timestamp < :end " : null;
 
         foreach ($AEBTypes as $toolname => $check) {
             $toolname = $dbh->quote($toolname, \PDO::PARAM_STR);

src/AppBundle/Helper/LabsHelper.php

Spacing +3 added lines, -3 removed lines

@@ -71,7 +71,7 @@ 
         $this->dbName = $dbName;
         $this->url = $url;
 
-        return [ 'dbName' => $dbName, 'wikiName' => $wikiName, 'url' => $url, 'lang' => $lang ];
+        return ['dbName' => $dbName, 'wikiName' => $wikiName, 'url' => $url, 'lang' => $lang];
     }
 
     /**
@@ -99,7 +99,7 @@ 
         // Create the query we're going to run against the meta database
         $wikiQuery = $this->client->createQueryBuilder();
         $wikiQuery
-            ->select([ 'dbname', 'name', 'url', 'lang' ])
+            ->select(['dbname', 'name', 'url', 'lang'])
             ->from('wiki')
             ->where($wikiQuery->expr()->eq('dbname', ':project'))
             // The meta database will have the project's URL stored as https://en.wikipedia.org
@@ -149,7 +149,7 @@ 
     public function allProjects()
     {
         $wikiQuery = $this->client->createQueryBuilder();
-        $wikiQuery->select([ 'dbName', 'name', 'url' ])->from('wiki');
+        $wikiQuery->select(['dbName', 'name', 'url'])->from('wiki');
         $stmt = $wikiQuery->execute();
         $out = $stmt->fetchAll();
         return $out;

src/Xtools/Project.php

Doc Comments +3 added lines

@@ -14,6 +14,9 @@
     /** @var string[] Basic metadata about the project */
     protected $metadata;
 
+    /**
+     * @param string $nameOrUrl
+     */
     public function __construct($nameOrUrl)
     {
         $this->nameUnnormalized = $nameOrUrl;

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
      */
     public function getUrl()
     {
-        return rtrim($this->getMetadata()['url'], '/') . '/';
+        return rtrim($this->getMetadata()['url'], '/').'/';
     }
 
     /**

src/Xtools/Page.php

Doc Comments +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
 
     /**
      * Get this page's database ID.
-     * @return int
+     * @return \string|null
      */
     public function getId()
     {
@@ -75,7 +75,7 @@ 
     }
 
     /**
-     * @return string
+     * @return \string|null
      */
     public function getUrl()
     {

src/Xtools/User.php

Indentation +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     public function userRightsUrl(Project $project)
     {
         return $project->getUrl() . $project->getScriptPath() . "?title=Special:UserRights&user=" .
-               $this->getUsername();
+                $this->getUsername();
     }
 
     /**

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
      */
     public function userRightsUrl(Project $project)
     {
-        return $project->getUrl() . $project->getScriptPath() . "?title=Special:UserRights&user=" .
+        return $project->getUrl().$project->getScriptPath()."?title=Special:UserRights&user=".
                $this->getUsername();
     }