AutomatedEditsHelper::getTools() - Code Metrics - Inspection of "AutoEdits: use OAuth when requesting sandbox confi..." - x-tools/xtools - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( b2964c...05352e )

by MusikAnimal
created 2020-12-11 23:27 UTC
AutomatedEditsHelper::getTools() B

↳ Parent: AutomatedEditsHelper
Complexity

Conditions	8
Paths	5
Size

Total Lines	60
Code Lines	30
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	24
CRAP Score	8.7368
Importance

Changes
Metric	Value
cc	8
eloc	30
nc	5
nop	2
dl	0
loc	60
rs	8.1954
c	0
b	0
f	0
ccs	24
cts	31
cp	0.7742
crap	8.7368
How to fix Long Method

<?php
/**
 * This file contains only the AutomatedEditsHelper class.
 */

declare(strict_types = 1);

namespace AppBundle\Helper;

use AppBundle\Model\Project;
use DateInterval;
use MediaWiki\OAuthClient\Client;
use Psr\Cache\CacheItemPoolInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Helper class for fetching semi-automated definitions.
 */
class AutomatedEditsHelper
{
    /** @var array The list of tools that are considered reverting. */
    protected $revertTools = [];

    /** @var array The list of tool names and their regexes/tags. */
    protected $tools = [];

    /** @var ContainerInterface */
    private $container;

    /** @var CacheItemPoolInterface */
    protected $cache;

    /**
     * AutomatedEditsHelper constructor.
     * @param ContainerInterface $container
     */
    public function __construct(ContainerInterface $container)
    {
        $this->container = $container;
        $this->cache = $container->get('cache.app');
    }

    /**
     * Get the tool that matched the given edit summary.
     * This only works for tools defined with regular expressions, not tags.
     * @param string $summary Edit summary
     * @param Project $project
     * @return string[]|false Tool entry including key for 'name', or false if nothing was found
     */
    public function getTool(string $summary, Project $project)
    {
        foreach ($this->getTools($project) as $tool => $values) {
            if (isset($values['regex']) && preg_match('/'.$values['regex'].'/', $summary)) {
                return array_merge([
                    'name' => $tool,
                ], $values);
            }
        }

        return false;
    }

    /**
     * Was the edit (semi-)automated, based on the edit summary?
     * This only works for tools defined with regular expressions, not tags.
     * @param string $summary Edit summary
     * @param Project $project
     * @return bool
     */
    public function isAutomated(string $summary, Project $project): bool
    {
        return (bool)$this->getTool($summary, $project);
    }

    /**
     * Fetch the config from https://meta.wikimedia.org/wiki/MediaWiki:XTools-AutoEdits.json
     * @param bool $useSandbox Use the sandbox version of the config, located at MediaWiki:XTools-AutoEdits.json/sandbox
     * @return array
     */
    public function getConfig(bool $useSandbox = false): array
    {
        $cacheKey = 'autoedits_config';
        if (!$useSandbox && $this->cache->hasItem($cacheKey)) {
            return $this->cache->getItem($cacheKey)->get();
        }

        $session = $this->container->get('session');
        $uri = 'https://meta.wikimedia.org/w/index.php?action=raw&ctype=application/json&title=' .
            'MediaWiki:XTools-AutoEdits.json' . ($useSandbox ? '/sandbox' : '');

        if ($useSandbox && $session->get('logged_in_user')) {
            // Request via OAuth to get around server-side caching.
            /** @var Client $client */
            $client = $this->container->get('session')->get('oauth_client');
            $resp = $client->makeOAuthCall(
                $this->container->get('session')->get('oauth_access_token'),
                $uri
            );
        } else {
            $resp = file_get_contents($uri);
        }

        $ret = json_decode($resp, true);

        if (!$useSandbox) {
            $cacheItem = $this->cache
                ->getItem($cacheKey)
                ->set($ret)
                ->expiresAfter(new DateInterval('PT20M'));
            $this->cache->save($cacheItem);
        }

        return $ret;
    }

    /**
     * Get list of automated tools and their associated info for the given project.
     * This defaults to the 'default_project' if entries for the given project are not found.
     * @param Project $project
     * @param bool $useSandbox Whether to use the /sandbox version for testing (also bypasses caching).
     * @return array Each tool with the tool name as the key and 'link', 'regex' and/or 'tag' as the subarray keys.
     */
    public function getTools(Project $project, bool $useSandbox = false): array
    {
        $projectDomain = $project->getDomain();

        if (isset($this->tools[$projectDomain])) {
            return $this->tools[$projectDomain];
        }

        // Load the semi-automated edit types.
        $tools = $this->getConfig($useSandbox);

        if (isset($tools[$projectDomain])) {
            $localRules = $tools[$projectDomain];
        } else {
            $localRules = [];
        }

        $langRules = $tools[$project->getLang()] ?? [];

        // Per-wiki rules have priority, followed by language-specific and global.
        $globalWithLangRules = $this->mergeRules($tools['global'], $langRules);

        $this->tools[$projectDomain] = $this->mergeRules(
            $globalWithLangRules,
            $localRules
        );

        // Once last walk through for some tidying up and validation.
        $invalid = [];
        array_walk($this->tools[$projectDomain], function (&$data, $tool) use (&$invalid): void {
            // Populate the 'label' with the tool name, if a label doesn't already exist.
            $data['label'] = $data['label'] ?? $tool;

            // 'namespaces' should be an array of ints.
            $data['namespaces'] = $data['namespaces'] ?? [];
            if (isset($data['namespace'])) {
                $data['namespaces'][] = $data['namespace'];
                unset($data['namespace']);
            }

            // 'tags' should be an array of strings.
            $data['tags'] = $data['tags'] ?? [];
            if (isset($data['tag'])) {
                $data['tags'][] = $data['tag'];
                unset($data['tag']);
            }

            // If neither a tag or regex is given, it's invalid.
            if (empty($data['tags']) && empty($data['regex'])) {
                $invalid[] = $tool;
            }
        });

        uksort($this->tools[$projectDomain], 'strcasecmp');

        if ($invalid) {
            $this->tools[$projectDomain]['invalid'] = $invalid;
        }

        return $this->tools[$projectDomain];
    }

    /**
     * Merges the given rule sets, giving priority to the local set. Regex is concatenated, not overridden.
     * @param string[] $globalRules The global rule set.
     * @param string[] $localRules The rule set for the local wiki.
     * @return string[] Merged rules.
     */
    private function mergeRules(array $globalRules, array $localRules): array
    {
        // Initial set, including just the global rules.
        $tools = $globalRules;

        // Loop through local rules and override/merge as necessary.
        foreach ($localRules as $tool => $rules) {
            $newRules = $rules;

            if (isset($globalRules[$tool])) {
                // Order within array_merge is important, so that local rules get priority.
                $newRules = array_merge($globalRules[$tool], $rules);
                $newRules = array_merge($globalRules[$tool], /** @scrutinizer ignore-type */ $rules);
            }

            // Regex should be merged, not overridden.
            if (isset($rules['regex']) && isset($globalRules[$tool]['regex'])) {
                $newRules['regex'] = implode('|', [
                    $rules['regex'],
                    $globalRules[$tool]['regex'],
                ]);
            }

            $tools[$tool] = $newRules;
        }

        return $tools;
    }

    /**
     * Get only tools that are used to revert edits.
     * Revert detection happens only by testing against a regular expression, and not by checking tags.
     * @param Project $project
     * @return string[][] Each tool with the tool name as the key,
     *   and 'link' and 'regex' as the subarray keys.
     */
    public function getRevertTools(Project $project): array
    {
        $projectDomain = $project->getDomain();

        if (isset($this->revertTools[$projectDomain])) {
            return $this->revertTools[$projectDomain];
        }

        $revertEntries = array_filter(
            $this->getTools($project),
            function ($tool) {
                return isset($tool['revert']) && isset($tool['regex']);
            }
        );

        // If 'revert' is set to `true`, then use 'regex' as the regular expression,
        //  otherwise 'revert' is assumed to be the regex string.
        $this->revertTools[$projectDomain] = array_map(function ($revertTool) {
            return [
                'link' => $revertTool['link'],
                'regex' => true === $revertTool['revert'] ? $revertTool['regex'] : $revertTool['revert'],
            ];
        }, $revertEntries);

        return $this->revertTools[$projectDomain];
    }

    /**
     * Was the edit a revert, based on the edit summary?
     * This only works for tools defined with regular expressions, not tags.
     * @param string|null $summary Edit summary. Can be null for instance for suppressed edits.
     * @param Project $project
     * @return bool
     */
    public function isRevert(?string $summary, Project $project): bool
    {
        foreach (array_values($this->getRevertTools($project)) as $values) {
            if (preg_match('/'.$values['regex'].'/', (string)$summary)) {
                return true;
            }
        }

        return false;
    }
}

x-tools / xtools

Push — master ( b2964c...05352e )

AutomatedEditsHelper::getTools() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
