x-tools / xtools

src/AppBundle/Controller/ApiController.php

Unused Use Statements -3 removed lines

@@ -5,12 +5,9 @@
 
 namespace AppBundle\Controller;
 
-use Exception;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Debug\Exception\FatalErrorException;
 use FOS\RestBundle\Controller\Annotations as Rest;
 use FOS\RestBundle\Controller\FOSRestController;
 use FOS\RestBundle\View\View;

Spacing +9 added lines, -9 removed lines

@@ -117,13 +117,13 @@ 
         $view = View::create()->setStatusCode(Response::HTTP_OK);
 
         if ($request->query->get('format') === 'html') {
-            $edits = array_map(function ($attrs) use ($project, $username) {
+            $edits = array_map(function($attrs) use ($project, $username) {
                 $nsName = '';
                 if ($attrs['page_namespace']) {
                     $nsName = $project->getNamespaces()[$attrs['page_namespace']];
                 }
                 $page = $project->getRepository()
-                    ->getPage($project, $nsName . ':' . $attrs['page_title']);
+                    ->getPage($project, $nsName.':'.$attrs['page_title']);
                 $attrs['id'] = $attrs['rev_id'];
                 $attrs['username'] = $username;
                 return new Edit($page, $attrs);
@@ -180,19 +180,19 @@ 
         $info = $page->getBasicEditingInfo();
         $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
         $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
-        $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
+        $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
 
         $data = [
-            'revisions' => (int) $info['num_edits'],
-            'editors' => (int) $info['num_editors'],
+            'revisions' => (int)$info['num_edits'],
+            'editors' => (int)$info['num_editors'],
             'author' => $info['author'],
-            'author_editcount' => (int) $info['author_editcount'],
+            'author_editcount' => (int)$info['author_editcount'],
             'created_at' => $creationDateTime->format('Y-m-d'),
             'created_rev_id' => $info['created_rev_id'],
             'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
             'secs_since_last_edit' => $secsSinceLastEdit,
-            'last_edit_id' => (int) $info['modified_rev_id'],
-            'watchers' => (int) $page->getWatchers(),
+            'last_edit_id' => (int)$info['modified_rev_id'],
+            'watchers' => (int)$page->getWatchers(),
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
             'pageviews_offset' => $pageviewsOffset,
         ];
@@ -247,7 +247,7 @@ 
         }
 
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/Xtools/Page.php

Doc Comments +7 added lines, -7 removed lines

@@ -59,7 +59,7 @@ 
 
     /**
      * Get this page's database ID.
-     * @return int
+     * @return \string|null
      */
     public function getId()
     {
@@ -69,7 +69,7 @@ 
 
     /**
      * Get this page's length in bytes.
-     * @return int
+     * @return \string|null
      */
     public function getLength()
     {
@@ -93,7 +93,7 @@ 
 
     /**
      * Get the full URL of this page.
-     * @return string
+     * @return \string|null
      */
     public function getUrl()
     {
@@ -103,7 +103,7 @@ 
 
     /**
      * Get the numerical ID of the namespace of this page.
-     * @return int
+     * @return \string|null
      */
     public function getNamespace()
     {
@@ -113,7 +113,7 @@ 
 
     /**
      * Get the number of page watchers.
-     * @return int
+     * @return \string|null
      */
     public function getWatchers()
     {
@@ -420,8 +420,8 @@ 
 
     /**
      * Get the sum of pageviews for the given page and timeframe.
-     * @param string|DateTime $start In the format YYYYMMDD
-     * @param string|DateTime $end In the format YYYYMMDD
+     * @param string $start In the format YYYYMMDD
+     * @param string $end In the format YYYYMMDD
      * @return string[]
      */
     public function getPageviews($start, $end)

Spacing +6 added lines, -6 removed lines

@@ -183,7 +183,7 @@ 
 
         // Otherwise do a COUNT in the event fetching
         // all revisions is not desired
-        return (int) $this->getRepository()->getNumRevisions($this, $user);
+        return (int)$this->getRepository()->getNumRevisions($this, $user);
     }
 
     /**
@@ -341,7 +341,7 @@ 
 
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
 
-        $terms = array_map(function ($entry) {
+        $terms = array_map(function($entry) {
             return $entry['term'];
         }, $wikidataInfo);
 
@@ -352,7 +352,7 @@ 
                 'prio' => 2,
                 'name' => 'Wikidata',
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
             ];
         }
@@ -362,7 +362,7 @@ 
                 'prio' => 3,
                 'name' => 'Wikidata',
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
             ];
         }
@@ -433,8 +433,8 @@ 
             return 0;
         }
 
-        return array_sum(array_map(function ($item) {
-            return (int) $item['views'];
+        return array_sum(array_map(function($item) {
+            return (int)$item['views'];
         }, $pageviews['items']));
     }