x-tools / xtools

src/Xtools/UserRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -695,7 +695,7 @@
      * Get the combined regex and tags for all semi-automated tools,
      *   ready to be used in a query.
      * @param string $projectDomain Such as en.wikipedia.org
-     * @param $conn Doctrine\DBAL\Connection Used for proper escaping
+     * @param \Doctrine\DBAL\Connection $conn Doctrine\DBAL\Connection Used for proper escaping
      * @return string[] In the format:
      *    ['combined|regex', 'combined,tags']
      */

Spacing +27 added lines, -27 removed lines

@@ -78,7 +78,7 @@ 
 
         $this->stopwatch->start($cacheKey, 'XTools');
         $api = $this->getMediawikiApi($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
         $res = $api->getRequest($query);
@@ -113,7 +113,7 @@ 
 
         // Create the API query.
         $api = $this->getMediawikiApi($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
 
         // Get the result.
@@ -157,8 +157,8 @@ 
     {
         $username = $user->getUsername();
 
-        $cacheKey = 'pages.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $redirects;
+        $cacheKey = 'pages.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$redirects;
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -216,7 +216,7 @@ 
             JOIN $revisionTable ON page_id = rev_page
             $paJoin
             WHERE $whereRev AND rev_parent_id = '0' $namespaceConditionRev $redirectCondition
-            " . ($hasPageAssessments ? 'GROUP BY rev_page' : '') . "
+            ".($hasPageAssessments ? 'GROUP BY rev_page' : '')."
             )
 
             UNION
@@ -263,21 +263,21 @@ 
      */
     public function countEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'editcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -337,21 +337,21 @@ 
      */
     public function countAutomatedEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'autoeditcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autoeditcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -383,7 +383,7 @@ 
             $tagJoin = $tags != '' ? "LEFT OUTER JOIN $tagTable ON ct_rev_id = rev_id" : '';
             $condTools[] = "ct_tag IN ($tags)";
         }
-        $condTool = 'AND (' . implode(' OR ', $condTools) . ')';
+        $condTool = 'AND ('.implode(' OR ', $condTools).')';
 
         $sql = "SELECT COUNT(DISTINCT(rev_id))
                 FROM $revisionTable
@@ -408,7 +408,7 @@ 
             $resultQuery->bindParam('namespace', $namespace);
         }
         $resultQuery->execute();
-        $result = (int) $resultQuery->fetchColumn();
+        $result = (int)$resultQuery->fetchColumn();
 
         // Cache for 10 minutes, and return.
         $cacheItem = $this->cache->getItem($cacheKey)
@@ -440,21 +440,21 @@ 
         $end = '',
         $offset = 0
     ) {
-        $cacheKey = 'nonautoedits.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $offset;
+        $cacheKey = 'nonautoedits.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$offset;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND revs.rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -547,21 +547,21 @@ 
         $start = '',
         $end = ''
     ) {
-        $cacheKey = 'autotoolcounts.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autotoolcounts.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -608,13 +608,13 @@ 
                 if ($condTool === '') {
                     $condTool = "ct_tag = $tag";
                 } else {
-                    $condTool = '(' . $condTool . " OR ct_tag = $tag)";
+                    $condTool = '('.$condTool." OR ct_tag = $tag)";
                 }
             }
 
             // Developer error, no regex or tag provided for this tool.
             if ($condTool === '') {
-                throw new Exception("No regex or tag found for the tool $toolname. " .
+                throw new Exception("No regex or tag found for the tool $toolname. ".
                     "Please verify this entry in semi_automated.yml");
             }
 
@@ -666,8 +666,8 @@ 
         }
 
         // Sort the array by count
-        uasort($results, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($results, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         // Cache for 10 minutes, and return.

src/AppBundle/Helper/AutomatedEditsHelper.php

Spacing +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
      */
     public function isAutomated($summary, $projectDomain)
     {
-        return (bool) $this->getTool($summary, $projectDomain);
+        return (bool)$this->getTool($summary, $projectDomain);
     }
 
     /**
@@ -109,14 +109,14 @@ 
 
         $revertEntries = array_filter(
             $this->getTools($projectDomain),
-            function ($tool) {
+            function($tool) {
                 return isset($tool['revert']);
             }
         );
 
         // If 'revert' is set to `true`, the use 'regex' as the regular expression,
         //  otherwise 'revert' is assumed to be the regex string.
-        $this->revertTools[$projectDomain] = array_map(function ($revertTool) {
+        $this->revertTools[$projectDomain] = array_map(function($revertTool) {
             return [
                 'link' => $revertTool['link'],
                 'regex' => $revertTool['revert'] === true ? $revertTool['regex'] : $revertTool['revert']

src/Xtools/Edit.php

Spacing +10 added lines, -10 removed lines

@@ -49,7 +49,7 @@ 
         $this->page = $page;
 
         // Copy over supported attributes
-        $this->id = (int) $attrs['id'];
+        $this->id = (int)$attrs['id'];
 
         // Allow DateTime or string (latter assumed to be of format YmdHis)
         if ($attrs['timestamp'] instanceof DateTime) {
@@ -198,7 +198,7 @@ 
         $isSection = preg_match_all("/^\/\* (.*?) \*\//", $summary, $sectionMatch);
 
         if ($isSection) {
-            $pageUrl = $this->getProject()->getUrl(false) . str_replace(
+            $pageUrl = $this->getProject()->getUrl(false).str_replace(
                 '$1',
                 $this->getPage()->getTitle(),
                 $this->getProject()->getArticlePath()
@@ -208,8 +208,8 @@ 
             // Must have underscores for the link to properly go to the section
             $sectionTitleLink = htmlspecialchars(str_replace(' ', '_', $sectionTitle));
 
-            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>" .
-                "<em class='text-muted'>" . htmlspecialchars($sectionTitle) . ":</em> ";
+            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>".
+                "<em class='text-muted'>".htmlspecialchars($sectionTitle).":</em> ";
             $summary = str_replace($sectionMatch[0][0], $sectionWikitext, $summary);
         }
 
@@ -223,7 +223,7 @@ 
             );
 
             // Use normalized page title (underscored, capitalized)
-            $pageUrl = $this->getProject()->getUrl(false) . str_replace(
+            $pageUrl = $this->getProject()->getUrl(false).str_replace(
                 '$1',
                 ucfirst(str_replace(' ', '_', $wikiLinkPath)),
                 $this->getProject()->getArticlePath()
@@ -261,8 +261,8 @@ 
     public function getDiffUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -272,8 +272,8 @@ 
     public function getPermaUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -305,7 +305,7 @@ 
      */
     public function isAutomated(Container $container)
     {
-        return (bool) $this->getTool($container);
+        return (bool)$this->getTool($container);
     }
 
     /**

src/Xtools/User.php

Spacing +8 added lines, -8 removed lines

@@ -174,7 +174,7 @@ 
      */
     public function countAutomatedEdits(Project $project, $namespace = 'all', $start = '', $end = '')
     {
-        return (int) $this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
+        return (int)$this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
     }
 
     /**
@@ -206,21 +206,21 @@ 
 
         $namespaces = $project->getNamespaces();
 
-        return array_map(function ($rev) use ($namespaces) {
+        return array_map(function($rev) use ($namespaces) {
             $pageTitle = $rev['page_title'];
 
             if ($rev['page_namespace'] !== '0') {
-                $pageTitle = $namespaces[$rev['page_namespace']] . ":$pageTitle";
+                $pageTitle = $namespaces[$rev['page_namespace']].":$pageTitle";
             }
 
             return [
                 'page_title' => $pageTitle,
-                'page_namespace' => (int) $rev['page_namespace'],
-                'rev_id' => (int) $rev['rev_id'],
+                'page_namespace' => (int)$rev['page_namespace'],
+                'rev_id' => (int)$rev['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $rev['timestamp']),
-                'minor' => (bool) $rev['minor'],
-                'length' => (int) $rev['length'],
-                'length_change' => (int) $rev['length_change'],
+                'minor' => (bool)$rev['minor'],
+                'length' => (int)$rev['length'],
+                'length_change' => (int)$rev['length_change'],
                 'comment' => $rev['comment'],
             ];
         }, $revs);

src/AppBundle/EventSubscriber/RateLimitSubscriber.php

Spacing +10 added lines, -10 removed lines

@@ -56,8 +56,8 @@ 
      */
     public function onKernelController(FilterControllerEvent $event)
     {
-        $this->rateLimit = (int) $this->container->getParameter('app.rate_limit_count');
-        $this->rateDuration = (int) $this->container->getParameter('app.rate_limit_time');
+        $this->rateLimit = (int)$this->container->getParameter('app.rate_limit_count');
+        $this->rateDuration = (int)$this->container->getParameter('app.rate_limit_time');
 
         // Zero values indicate the rate limiting feature should be disabled.
         if ($this->rateLimit === 0 || $this->rateDuration === 0) {
@@ -65,7 +65,7 @@ 
         }
 
         $controller = $event->getController();
-        $loggedIn = (bool) $this->container->get('session')->get('logged_in_user');
+        $loggedIn = (bool)$this->container->get('session')->get('logged_in_user');
 
         // No rate limits on index pages or if they are logged in.
         if ($controller[1] === 'indexAction' || $loggedIn) {
@@ -85,7 +85,7 @@ 
         $cacheItem = $cache->getItem($cacheKey);
 
         // If increment value already in cache, or start with 1.
-        $count = $cacheItem->isHit() ? (int) $cacheItem->get() + 1 : 1;
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
 
         // Check if limit has been exceeded, and if so, throw an error.
         if ($count > $this->rateLimit) {
@@ -137,14 +137,14 @@ 
         // Log the denied request
         $logger = $this->container->get('monolog.logger.rate_limit');
         $logger->info(
-            "<URI>: " . $request->getRequestUri() .
-            ($logComment != '' ? "\t<Reason>: $logComment" : '') .
-            "\t<User agent>: " . $request->headers->get('User-Agent')
+            "<URI>: ".$request->getRequestUri().
+            ($logComment != '' ? "\t<Reason>: $logComment" : '').
+            "\t<User agent>: ".$request->headers->get('User-Agent')
         );
 
-        throw new AccessDeniedHttpException("Possible spider crawl detected. " .
-            'If you are human, you are making too many requests during a short period of time. ' .
-            "Please wait $this->rateDuration minutes before reloading this tool. You can then " .
+        throw new AccessDeniedHttpException("Possible spider crawl detected. ".
+            'If you are human, you are making too many requests during a short period of time. '.
+            "Please wait $this->rateDuration minutes before reloading this tool. You can then ".
             'login to prevent this from happening again.');
     }
 }

src/Xtools/EditCounter.php

Doc Comments +2 added lines, -2 removed lines

@@ -473,7 +473,7 @@ 
 
     /**
      * Get the date and time of the user's first edit.
-     * @return DateTime|bool The time of the first revision, or false.
+     * @return DateInterval The time of the first revision, or false.
      */
     public function datetimeFirstRevision()
     {
@@ -483,7 +483,7 @@ 
 
     /**
      * Get the date and time of the user's first edit.
-     * @return DateTime|bool The time of the last revision, or false.
+     * @return DateInterval The time of the last revision, or false.
      */
     public function datetimeLastRevision()
     {

Spacing +22 added lines, -22 removed lines

@@ -82,7 +82,7 @@ 
      */
     protected function getPairData()
     {
-        if (! is_array($this->pairData)) {
+        if (!is_array($this->pairData)) {
             $this->pairData = $this->getRepository()
                 ->getPairData($this->project, $this->user);
         }
@@ -95,7 +95,7 @@ 
      */
     protected function getLogCounts()
     {
-        if (! is_array($this->logCounts)) {
+        if (!is_array($this->logCounts)) {
             $this->logCounts = $this->getRepository()
                 ->getLogCounts($this->project, $this->user);
         }
@@ -144,7 +144,7 @@ 
      */
     public function countAllRevisions()
     {
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
     }
 
     /**
@@ -163,7 +163,7 @@ 
      */
     public function countRevisionsWithoutComments()
     {
-        return $this->countLiveRevisions() - $this->countRevisionsWithComments();
+        return $this->countLiveRevisions()-$this->countRevisionsWithComments();
     }
 
     /**
@@ -202,7 +202,7 @@ 
      */
     public function countAllPagesEdited()
     {
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
     }
 
     /**
@@ -212,7 +212,7 @@ 
      */
     public function countPagesCreated()
     {
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
     }
 
     /**
@@ -340,7 +340,7 @@ 
             // Try block just in case there are older, unpredictable formats
             try {
                 $expiry = strtotime($durationStr, $timestamp);
-                $duration = ($expiry - $timestamp) / (60 * 60 * 24);
+                $duration = ($expiry-$timestamp) / (60 * 60 * 24);
 
                 if (!$duration || $duration > $this->longestBlockDays) {
                     $this->longestBlockDays = $duration;
@@ -424,7 +424,7 @@ 
         $import = isset($logCounts['import-import']) ? (int)$logCounts['import-import'] : 0;
         $interwiki = isset($logCounts['import-interwiki']) ? (int)$logCounts['import-interwiki'] : 0;
         $upload = isset($logCounts['import-upload']) ? (int)$logCounts['import-upload'] : 0;
-        return $import + $interwiki + $upload;
+        return $import+$interwiki+$upload;
     }
 
     /**
@@ -548,9 +548,9 @@ 
     public function approvals()
     {
         $logCounts = $this->getLogCounts();
-        $total = $logCounts['review-approve'] +
-        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
-        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
+        $total = $logCounts['review-approve']+
+        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
+        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
         (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
         return $total;
     }
@@ -574,7 +574,7 @@ 
         $logCounts = $this->getLogCounts();
         $create2 = $logCounts['newusers-create2'] ?: 0;
         $byemail = $logCounts['newusers-byemail'] ?: 0;
-        return $create2 + $byemail;
+        return $create2+$byemail;
     }
 
     /**
@@ -622,7 +622,7 @@ 
 
         $totals = $this->getRepository()->getMonthCounts($this->project, $this->user);
         $out = [
-            'yearLabels' => [],  // labels for years
+            'yearLabels' => [], // labels for years
             'monthLabels' => [], // labels for months
             'totals' => [], // actual totals, grouped by namespace, year and then month
         ];
@@ -650,7 +650,7 @@ 
                 $out['totals'][$ns][$total['year']] = [];
             }
 
-            $out['totals'][$ns][$total['year']][$total['month']] = (int) $total['count'];
+            $out['totals'][$ns][$total['year']][$total['month']] = (int)$total['count'];
         }
 
         $dateRange = new DatePeriod(
@@ -660,8 +660,8 @@ 
         );
 
         foreach ($dateRange as $monthObj) {
-            $year = (int) $monthObj->format('Y');
-            $month = (int) $monthObj->format('n');
+            $year = (int)$monthObj->format('Y');
+            $month = (int)$monthObj->format('n');
 
             // Fill in labels
             $out['monthLabels'][] = $monthObj->format('Y-m');
@@ -770,8 +770,8 @@ 
                 ->globalEditCounts($this->user, $this->project);
             if ($sorted) {
                 // Sort.
-                uasort($this->globalEditCounts, function ($a, $b) {
-                    return $b['total'] - $a['total'];
+                uasort($this->globalEditCounts, function($a, $b) {
+                    return $b['total']-$a['total'];
                 });
             }
         }
@@ -807,7 +807,7 @@ 
                 $nsName = $project->getNamespaces()[$revision['page_namespace']];
             }
             $page = $project->getRepository()
-                ->getPage($project, $nsName . ':' . $revision['page_title']);
+                ->getPage($project, $nsName.':'.$revision['page_title']);
             $edit = new Edit($page, $revision);
             $globalEdits[$edit->getTimestamp()->getTimestamp().'-'.$edit->getId()] = $edit;
         }
@@ -824,7 +824,7 @@ 
      */
     protected function getEditSizeData()
     {
-        if (! is_array($this->editSizeData)) {
+        if (!is_array($this->editSizeData)) {
             $this->editSizeData = $this->getRepository()
                 ->getEditSizeData($this->project, $this->user);
         }
@@ -848,7 +848,7 @@ 
     public function countSmallEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['small_edits']) ? (int) $editSizeData['small_edits'] : 0;
+        return isset($editSizeData['small_edits']) ? (int)$editSizeData['small_edits'] : 0;
     }
 
     /**
@@ -858,7 +858,7 @@ 
     public function countLargeEdits()
     {
         $editSizeData = $this->getEditSizeData();
-        return isset($editSizeData['large_edits']) ? (int) $editSizeData['large_edits'] : 0;
+        return isset($editSizeData['large_edits']) ? (int)$editSizeData['large_edits'] : 0;
     }
 
     /**

src/AppBundle/Twig/AppExtension.php

Spacing +40 added lines, -40 removed lines

@@ -32,32 +32,32 @@ 
     {
         $options = ['is_safe' => ['html']];
         return [
-            new \Twig_SimpleFunction('request_time', [ $this, 'requestTime' ], $options),
-            new \Twig_SimpleFunction('memory_usage', [ $this, 'requestMemory' ], $options),
-            new \Twig_SimpleFunction('year', [ $this, 'generateYear' ], $options),
-            new \Twig_SimpleFunction('msgPrintExists', [ $this, 'intuitionMessagePrintExists' ], $options),
-            new \Twig_SimpleFunction('msgExists', [ $this, 'intuitionMessageExists' ], $options),
-            new \Twig_SimpleFunction('msg', [ $this, 'intuitionMessage' ], $options),
-            new \Twig_SimpleFunction('lang', [ $this, 'getLang' ], $options),
-            new \Twig_SimpleFunction('langName', [ $this, 'getLangName' ], $options),
-            new \Twig_SimpleFunction('allLangs', [ $this, 'getAllLangs' ]),
-            new \Twig_SimpleFunction('isRTL', [ $this, 'intuitionIsRTL' ]),
-            new \Twig_SimpleFunction('isRTLLang', [ $this, 'intuitionIsRTLLang' ]),
-            new \Twig_SimpleFunction('shortHash', [ $this, 'gitShortHash' ]),
-            new \Twig_SimpleFunction('hash', [ $this, 'gitHash' ]),
-            new \Twig_SimpleFunction('enabled', [ $this, 'tabEnabled' ]),
-            new \Twig_SimpleFunction('tools', [ $this, 'allTools' ]),
-            new \Twig_SimpleFunction('color', [ $this, 'getColorList' ]),
-            new \Twig_SimpleFunction('chartColor', [ $this, 'chartColor' ]),
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
-            new \Twig_SimpleFunction('isSingleWiki', [ $this, 'isSingleWiki' ]),
-            new \Twig_SimpleFunction('getReplagThreshold', [ $this, 'getReplagThreshold' ]),
-            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [ $this, 'loadStylesheetsFromCDN' ]),
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
-            new \Twig_SimpleFunction('replag', [ $this, 'replag' ]),
-            new \Twig_SimpleFunction('link', [ $this, 'link' ]),
-            new \Twig_SimpleFunction('quote', [ $this, 'quote' ]),
-            new \Twig_SimpleFunction('bugReportURL', [ $this, 'bugReportURL' ]),
+            new \Twig_SimpleFunction('request_time', [$this, 'requestTime'], $options),
+            new \Twig_SimpleFunction('memory_usage', [$this, 'requestMemory'], $options),
+            new \Twig_SimpleFunction('year', [$this, 'generateYear'], $options),
+            new \Twig_SimpleFunction('msgPrintExists', [$this, 'intuitionMessagePrintExists'], $options),
+            new \Twig_SimpleFunction('msgExists', [$this, 'intuitionMessageExists'], $options),
+            new \Twig_SimpleFunction('msg', [$this, 'intuitionMessage'], $options),
+            new \Twig_SimpleFunction('lang', [$this, 'getLang'], $options),
+            new \Twig_SimpleFunction('langName', [$this, 'getLangName'], $options),
+            new \Twig_SimpleFunction('allLangs', [$this, 'getAllLangs']),
+            new \Twig_SimpleFunction('isRTL', [$this, 'intuitionIsRTL']),
+            new \Twig_SimpleFunction('isRTLLang', [$this, 'intuitionIsRTLLang']),
+            new \Twig_SimpleFunction('shortHash', [$this, 'gitShortHash']),
+            new \Twig_SimpleFunction('hash', [$this, 'gitHash']),
+            new \Twig_SimpleFunction('enabled', [$this, 'tabEnabled']),
+            new \Twig_SimpleFunction('tools', [$this, 'allTools']),
+            new \Twig_SimpleFunction('color', [$this, 'getColorList']),
+            new \Twig_SimpleFunction('chartColor', [$this, 'chartColor']),
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
+            new \Twig_SimpleFunction('isSingleWiki', [$this, 'isSingleWiki']),
+            new \Twig_SimpleFunction('getReplagThreshold', [$this, 'getReplagThreshold']),
+            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [$this, 'loadStylesheetsFromCDN']),
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
+            new \Twig_SimpleFunction('replag', [$this, 'replag']),
+            new \Twig_SimpleFunction('link', [$this, 'link']),
+            new \Twig_SimpleFunction('quote', [$this, 'quote']),
+            new \Twig_SimpleFunction('bugReportURL', [$this, 'bugReportURL']),
             new \Twig_SimpleFunction('logged_in_user', [$this, 'functionLoggedInUser']),
             new \Twig_SimpleFunction('isUserAnon', [$this, 'isUserAnon']),
             new \Twig_SimpleFunction('nsName', [$this, 'nsName']),
@@ -72,7 +72,7 @@ 
      */
     public function requestTime($decimals = 3)
     {
-        return number_format(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT'], $decimals);
+        return number_format(microtime(true)-$_SERVER['REQUEST_TIME_FLOAT'], $decimals);
     }
 
     /**
@@ -105,7 +105,7 @@ 
      */
     public function intuitionMessageExists($message = "")
     {
-        return $this->getIntuition()->msgExists($message, [ "domain" => "xtools" ]);
+        return $this->getIntuition()->msgExists($message, ["domain" => "xtools"]);
     }
 
     /**
@@ -136,7 +136,7 @@ 
      */
     public function intuitionMessage($message = "", $vars = [])
     {
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
     }
 
     /**
@@ -165,10 +165,10 @@ 
      */
     public function getAllLangs()
     {
-        $messageFiles = glob($this->container->getParameter("kernel.root_dir") . '/../i18n/*.json');
+        $messageFiles = glob($this->container->getParameter("kernel.root_dir").'/../i18n/*.json');
 
         $languages = array_values(array_unique(array_map(
-            function ($filename) {
+            function($filename) {
                 return basename($filename, '.json');
             },
             $messageFiles
@@ -516,9 +516,9 @@ 
     public function getFilters()
     {
         return [
-            new \Twig_SimpleFilter('capitalize_first', [ $this, 'capitalizeFirst' ]),
-            new \Twig_SimpleFilter('percent_format', [ $this, 'percentFormat' ]),
-            new \Twig_SimpleFilter('diff_format', [ $this, 'diffFormat' ], [ 'is_safe' => [ 'html' ] ]),
+            new \Twig_SimpleFilter('capitalize_first', [$this, 'capitalizeFirst']),
+            new \Twig_SimpleFilter('percent_format', [$this, 'percentFormat']),
+            new \Twig_SimpleFilter('diff_format', [$this, 'diffFormat'], ['is_safe' => ['html']]),
         ];
     }
 
@@ -545,10 +545,10 @@ 
         if (!$denominator) {
             $quotient = $numerator;
         } else {
-            $quotient = ( $numerator / $denominator ) * 100;
+            $quotient = ($numerator / $denominator) * 100;
         }
 
-        return round($quotient, $precision) . '%';
+        return round($quotient, $precision).'%';
     }
 
     /**
@@ -623,20 +623,20 @@ 
 
         if ($seconds >= 86400) {
             // Over a day
-            $val = (int) floor($seconds / 86400);
+            $val = (int)floor($seconds / 86400);
             $key = 'days';
         } elseif ($seconds >= 3600) {
             // Over an hour, less than a day
-            $val = (int) floor($seconds / 3600);
+            $val = (int)floor($seconds / 3600);
             $key = 'hours';
         } elseif ($seconds >= 60) {
             // Over a minute, less than an hour
-            $val = (int) floor($seconds / 60);
+            $val = (int)floor($seconds / 60);
             $key = 'minutes';
         }
 
         if ($translate) {
-            return number_format($val) . ' ' . $this->intuitionMessage("num-$key", [$val]);
+            return number_format($val).' '.$this->intuitionMessage("num-$key", [$val]);
         } else {
             return [number_format($val), "num-$key"];
         }

src/AppBundle/Controller/ApiController.php

Unused Use Statements -3 removed lines

@@ -5,12 +5,9 @@
 
 namespace AppBundle\Controller;
 
-use Exception;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Debug\Exception\FatalErrorException;
 use FOS\RestBundle\Controller\Annotations as Rest;
 use FOS\RestBundle\Controller\FOSRestController;
 use FOS\RestBundle\View\View;

Spacing +9 added lines, -9 removed lines

@@ -117,13 +117,13 @@ 
         $view = View::create()->setStatusCode(Response::HTTP_OK);
 
         if ($request->query->get('format') === 'html') {
-            $edits = array_map(function ($attrs) use ($project, $username) {
+            $edits = array_map(function($attrs) use ($project, $username) {
                 $nsName = '';
                 if ($attrs['page_namespace']) {
                     $nsName = $project->getNamespaces()[$attrs['page_namespace']];
                 }
                 $page = $project->getRepository()
-                    ->getPage($project, $nsName . ':' . $attrs['page_title']);
+                    ->getPage($project, $nsName.':'.$attrs['page_title']);
                 $attrs['id'] = $attrs['rev_id'];
                 $attrs['username'] = $username;
                 return new Edit($page, $attrs);
@@ -180,19 +180,19 @@ 
         $info = $page->getBasicEditingInfo();
         $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
         $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
-        $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
+        $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
 
         $data = [
-            'revisions' => (int) $info['num_edits'],
-            'editors' => (int) $info['num_editors'],
+            'revisions' => (int)$info['num_edits'],
+            'editors' => (int)$info['num_editors'],
             'author' => $info['author'],
-            'author_editcount' => (int) $info['author_editcount'],
+            'author_editcount' => (int)$info['author_editcount'],
             'created_at' => $creationDateTime->format('Y-m-d'),
             'created_rev_id' => $info['created_rev_id'],
             'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
             'secs_since_last_edit' => $secsSinceLastEdit,
-            'last_edit_id' => (int) $info['modified_rev_id'],
-            'watchers' => (int) $page->getWatchers(),
+            'last_edit_id' => (int)$info['modified_rev_id'],
+            'watchers' => (int)$page->getWatchers(),
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
             'pageviews_offset' => $pageviewsOffset,
         ];
@@ -247,7 +247,7 @@ 
         }
 
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/Xtools/Page.php

Doc Comments +7 added lines, -7 removed lines

@@ -59,7 +59,7 @@ 
 
     /**
      * Get this page's database ID.
-     * @return int
+     * @return \string|null
      */
     public function getId()
     {
@@ -69,7 +69,7 @@ 
 
     /**
      * Get this page's length in bytes.
-     * @return int
+     * @return \string|null
      */
     public function getLength()
     {
@@ -93,7 +93,7 @@ 
 
     /**
      * Get the full URL of this page.
-     * @return string
+     * @return \string|null
      */
     public function getUrl()
     {
@@ -103,7 +103,7 @@ 
 
     /**
      * Get the numerical ID of the namespace of this page.
-     * @return int
+     * @return \string|null
      */
     public function getNamespace()
     {
@@ -113,7 +113,7 @@ 
 
     /**
      * Get the number of page watchers.
-     * @return int
+     * @return \string|null
      */
     public function getWatchers()
     {
@@ -420,8 +420,8 @@ 
 
     /**
      * Get the sum of pageviews for the given page and timeframe.
-     * @param string|DateTime $start In the format YYYYMMDD
-     * @param string|DateTime $end In the format YYYYMMDD
+     * @param string $start In the format YYYYMMDD
+     * @param string $end In the format YYYYMMDD
      * @return string[]
      */
     public function getPageviews($start, $end)

Spacing +7 added lines, -7 removed lines

@@ -66,7 +66,7 @@ 
         $info = $this->getPageInfo();
         $title = isset($info['title']) ? $info['title'] : $this->unnormalizedPageName;
         $nsName = $this->getNamespaceName();
-        return str_replace($nsName . ':', '', $title);
+        return str_replace($nsName.':', '', $title);
     }
 
     /**
@@ -207,7 +207,7 @@ 
 
         // Otherwise do a COUNT in the event fetching
         // all revisions is not desired
-        return (int) $this->getRepository()->getNumRevisions($this, $user);
+        return (int)$this->getRepository()->getNumRevisions($this, $user);
     }
 
     /**
@@ -365,7 +365,7 @@ 
 
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
 
-        $terms = array_map(function ($entry) {
+        $terms = array_map(function($entry) {
             return $entry['term'];
         }, $wikidataInfo);
 
@@ -376,7 +376,7 @@ 
                 'prio' => 2,
                 'name' => 'Wikidata',
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
             ];
         }
@@ -386,7 +386,7 @@ 
                 'prio' => 3,
                 'name' => 'Wikidata',
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
-                'explanation' => "See: <a target='_blank' " .
+                'explanation' => "See: <a target='_blank' ".
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
             ];
         }
@@ -457,8 +457,8 @@ 
             return 0;
         }
 
-        return array_sum(array_map(function ($item) {
-            return (int) $item['views'];
+        return array_sum(array_map(function($item) {
+            return (int)$item['views'];
         }, $pageviews['items']));
     }