Completed
Pull Request — master (#86)
by Sam
04:58 queued 02:14
created
src/AppBundle/Controller/AdminScoreController.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@  discard block
 block discarded – undo
47 47
         $username = $request->query->get('username', $request->query->get('user'));
48 48
 
49 49
         if ($projectQuery != '' && $username != '') {
50
-            return $this->redirectToRoute('AdminScoreResult', [ 'project' => $projectQuery, 'username' => $username ]);
50
+            return $this->redirectToRoute('AdminScoreResult', ['project' => $projectQuery, 'username' => $username]);
51 51
         } elseif ($projectQuery != '' && $project === null) {
52
-            return $this->redirectToRoute('AdminScoreProject', [ 'project' => $projectQuery ]);
52
+            return $this->redirectToRoute('AdminScoreProject', ['project' => $projectQuery]);
53 53
         }
54 54
 
55 55
         // Set default project so we can populate the namespace selector.
@@ -95,20 +95,20 @@  discard block
 block discarded – undo
95 95
         $archiveTable = $projectRepo->getTableName($dbName, 'archive');
96 96
 
97 97
         // MULTIPLIERS (to review)
98
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
99
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
100
-        $USER_PAGE_MULT = 0.1;     # 0 if =
98
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
99
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
100
+        $USER_PAGE_MULT = 0.1; # 0 if =
101 101
         $PATROLS_MULT = 1; # 0 if =
102
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
102
+        $BLOCKS_MULT = 1.4; # 0 if = 10
103 103
         $AFD_MULT = 1.15;
104
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
104
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
105 105
         $AIV_MULT = 1.15;
106
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
107
-        $NAMESPACES_MULT = 1.0;     # 0 if =
106
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
107
+        $NAMESPACES_MULT = 1.0; # 0 if =
108 108
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
109 109
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
110
-        $RPP_MULT = 1.15;     # 0 if =
111
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
110
+        $RPP_MULT = 1.15; # 0 if =
111
+        $USERRIGHTS_MULT = 0.75; # 0 if =
112 112
 
113 113
         // Grab the connection to the replica database (which is separate from the above)
114 114
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -186,15 +186,15 @@  discard block
 block discarded – undo
186 186
                 $now = new DateTime();
187 187
                 $date = new DateTime($value);
188 188
                 $diff = $date->diff($now);
189
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
189
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
190 190
                 $value = $formula-365;
191 191
             }
192 192
 
193 193
             if ($key == "id") {
194 194
                 $id = $value;
195 195
             } else {
196
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
197
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
196
+                $multiplierKey = strtoupper($row["source"]."_MULT");
197
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
198 198
                 $score = max(min($value * $multiplier, 100), -100);
199 199
                 $master[$key]["mult"] = $multiplier;
200 200
                 $master[$key]["value"] = $value;
@@ -204,8 +204,8 @@  discard block
 block discarded – undo
204 204
         }
205 205
 
206 206
         if ($id == 0) {
207
-            $this->addFlash("notice", [ "no-result", $username ]);
208
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
207
+            $this->addFlash("notice", ["no-result", $username]);
208
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
209 209
         }
210 210
 
211 211
         return $this->render('adminscore/result.html.twig', [
Please login to merge, or discard this patch.
src/AppBundle/EventSubscriber/RateLimitSubscriber.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function onKernelController(FilterControllerEvent $event)
58 58
     {
59
-        $this->rateLimit = (int) $this->container->getParameter('app.rate_limit_count');
60
-        $this->rateDuration = (int) $this->container->getParameter('app.rate_limit_time');
59
+        $this->rateLimit = (int)$this->container->getParameter('app.rate_limit_count');
60
+        $this->rateDuration = (int)$this->container->getParameter('app.rate_limit_time');
61 61
 
62 62
         // Zero values indicate the rate limiting feature should be disabled.
63 63
         if ($this->rateLimit === 0 || $this->rateDuration === 0) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         }
66 66
 
67 67
         $controller = $event->getController();
68
-        $loggedIn = (bool) $this->container->get('session')->get('logged_in_user');
68
+        $loggedIn = (bool)$this->container->get('session')->get('logged_in_user');
69 69
 
70 70
         // No rate limits on index pages or if they are logged in.
71 71
         if ($controller[1] === 'indexAction' || $loggedIn) {
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         $cacheItem = $cache->getItem($cacheKey);
86 86
 
87 87
         // If increment value already in cache, or start with 1.
88
-        $count = $cacheItem->isHit() ? (int) $cacheItem->get() + 1 : 1;
88
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
89 89
 
90 90
         // Check if limit has been exceeded, and if so, throw an error.
91 91
         if ($count > $this->rateLimit) {
@@ -137,14 +137,14 @@  discard block
 block discarded – undo
137 137
         // Log the denied request
138 138
         $logger = $this->container->get('monolog.logger.rate_limit');
139 139
         $logger->info(
140
-            "<URI>: " . $request->getRequestUri() .
141
-            ($logComment != '' ? "\t<Reason>: $logComment" : '') .
142
-            "\t<User agent>: " . $request->headers->get('User-Agent')
140
+            "<URI>: ".$request->getRequestUri().
141
+            ($logComment != '' ? "\t<Reason>: $logComment" : '').
142
+            "\t<User agent>: ".$request->headers->get('User-Agent')
143 143
         );
144 144
 
145
-        throw new AccessDeniedHttpException("Possible spider crawl detected. " .
146
-            'If you are human, you are making too many requests during a short period of time. ' .
147
-            "Please wait $this->rateDuration minutes before reloading this tool. You can then " .
145
+        throw new AccessDeniedHttpException("Possible spider crawl detected. ".
146
+            'If you are human, you are making too many requests during a short period of time. '.
147
+            "Please wait $this->rateDuration minutes before reloading this tool. You can then ".
148 148
             'login to prevent this from happening again.');
149 149
     }
150 150
 }
Please login to merge, or discard this patch.
src/Xtools/PagesRepository.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 
323 323
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
324 324
 
325
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
325
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
326 326
                 FROM wikidatawiki_p.wb_items_per_site
327 327
                 WHERE ips_item_id = :wikidataId";
328 328
 
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
 
333 333
         $result = $resultQuery->fetchAll();
334 334
 
335
-        return $count ? (int) $result[0]['count'] : $result;
335
+        return $count ? (int)$result[0]['count'] : $result;
336 336
     }
337 337
 
338 338
     /**
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
 
373 373
         // Transform to associative array by 'type'
374 374
         foreach ($res as $row) {
375
-            $data[$row['type'] . '_count'] = $row['value'];
375
+            $data[$row['type'].'_count'] = $row['value'];
376 376
         }
377 377
 
378 378
         return $data;
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
 
410 410
         $project = $page->getProject()->getDomain();
411 411
 
412
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
412
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
413 413
             "$project/all-access/user/$title/daily/$start/$end";
414 414
 
415 415
         $res = $client->request('GET', $url);
Please login to merge, or discard this patch.
src/AppBundle/Twig/AppExtension.php 1 patch
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -32,32 +32,32 @@  discard block
 block discarded – undo
32 32
     {
33 33
         $options = ['is_safe' => ['html']];
34 34
         return [
35
-            new \Twig_SimpleFunction('request_time', [ $this, 'requestTime' ], $options),
36
-            new \Twig_SimpleFunction('memory_usage', [ $this, 'requestMemory' ], $options),
37
-            new \Twig_SimpleFunction('year', [ $this, 'generateYear' ], $options),
38
-            new \Twig_SimpleFunction('msgPrintExists', [ $this, 'intuitionMessagePrintExists' ], $options),
39
-            new \Twig_SimpleFunction('msgExists', [ $this, 'intuitionMessageExists' ], $options),
40
-            new \Twig_SimpleFunction('msg', [ $this, 'intuitionMessage' ], $options),
41
-            new \Twig_SimpleFunction('lang', [ $this, 'getLang' ], $options),
42
-            new \Twig_SimpleFunction('langName', [ $this, 'getLangName' ], $options),
43
-            new \Twig_SimpleFunction('allLangs', [ $this, 'getAllLangs' ]),
44
-            new \Twig_SimpleFunction('isRTL', [ $this, 'intuitionIsRTL' ]),
45
-            new \Twig_SimpleFunction('isRTLLang', [ $this, 'intuitionIsRTLLang' ]),
46
-            new \Twig_SimpleFunction('shortHash', [ $this, 'gitShortHash' ]),
47
-            new \Twig_SimpleFunction('hash', [ $this, 'gitHash' ]),
48
-            new \Twig_SimpleFunction('enabled', [ $this, 'tabEnabled' ]),
49
-            new \Twig_SimpleFunction('tools', [ $this, 'allTools' ]),
50
-            new \Twig_SimpleFunction('color', [ $this, 'getColorList' ]),
51
-            new \Twig_SimpleFunction('chartColor', [ $this, 'chartColor' ]),
52
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
53
-            new \Twig_SimpleFunction('isSingleWiki', [ $this, 'isSingleWiki' ]),
54
-            new \Twig_SimpleFunction('getReplagThreshold', [ $this, 'getReplagThreshold' ]),
55
-            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [ $this, 'loadStylesheetsFromCDN' ]),
56
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
57
-            new \Twig_SimpleFunction('replag', [ $this, 'replag' ]),
58
-            new \Twig_SimpleFunction('link', [ $this, 'link' ]),
59
-            new \Twig_SimpleFunction('quote', [ $this, 'quote' ]),
60
-            new \Twig_SimpleFunction('bugReportURL', [ $this, 'bugReportURL' ]),
35
+            new \Twig_SimpleFunction('request_time', [$this, 'requestTime'], $options),
36
+            new \Twig_SimpleFunction('memory_usage', [$this, 'requestMemory'], $options),
37
+            new \Twig_SimpleFunction('year', [$this, 'generateYear'], $options),
38
+            new \Twig_SimpleFunction('msgPrintExists', [$this, 'intuitionMessagePrintExists'], $options),
39
+            new \Twig_SimpleFunction('msgExists', [$this, 'intuitionMessageExists'], $options),
40
+            new \Twig_SimpleFunction('msg', [$this, 'intuitionMessage'], $options),
41
+            new \Twig_SimpleFunction('lang', [$this, 'getLang'], $options),
42
+            new \Twig_SimpleFunction('langName', [$this, 'getLangName'], $options),
43
+            new \Twig_SimpleFunction('allLangs', [$this, 'getAllLangs']),
44
+            new \Twig_SimpleFunction('isRTL', [$this, 'intuitionIsRTL']),
45
+            new \Twig_SimpleFunction('isRTLLang', [$this, 'intuitionIsRTLLang']),
46
+            new \Twig_SimpleFunction('shortHash', [$this, 'gitShortHash']),
47
+            new \Twig_SimpleFunction('hash', [$this, 'gitHash']),
48
+            new \Twig_SimpleFunction('enabled', [$this, 'tabEnabled']),
49
+            new \Twig_SimpleFunction('tools', [$this, 'allTools']),
50
+            new \Twig_SimpleFunction('color', [$this, 'getColorList']),
51
+            new \Twig_SimpleFunction('chartColor', [$this, 'chartColor']),
52
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
53
+            new \Twig_SimpleFunction('isSingleWiki', [$this, 'isSingleWiki']),
54
+            new \Twig_SimpleFunction('getReplagThreshold', [$this, 'getReplagThreshold']),
55
+            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [$this, 'loadStylesheetsFromCDN']),
56
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
57
+            new \Twig_SimpleFunction('replag', [$this, 'replag']),
58
+            new \Twig_SimpleFunction('link', [$this, 'link']),
59
+            new \Twig_SimpleFunction('quote', [$this, 'quote']),
60
+            new \Twig_SimpleFunction('bugReportURL', [$this, 'bugReportURL']),
61 61
             new \Twig_SimpleFunction('logged_in_user', [$this, 'functionLoggedInUser']),
62 62
             new \Twig_SimpleFunction('isUserAnon', [$this, 'isUserAnon']),
63 63
             new \Twig_SimpleFunction('nsName', [$this, 'nsName']),
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      */
73 73
     public function requestTime($decimals = 3)
74 74
     {
75
-        return number_format(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT'], $decimals);
75
+        return number_format(microtime(true)-$_SERVER['REQUEST_TIME_FLOAT'], $decimals);
76 76
     }
77 77
 
78 78
     /**
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
      */
106 106
     public function intuitionMessageExists($message = "")
107 107
     {
108
-        return $this->getIntuition()->msgExists($message, [ "domain" => "xtools" ]);
108
+        return $this->getIntuition()->msgExists($message, ["domain" => "xtools"]);
109 109
     }
110 110
 
111 111
     /**
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      */
137 137
     public function intuitionMessage($message = "", $vars = [])
138 138
     {
139
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
139
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
140 140
     }
141 141
 
142 142
     /**
@@ -165,10 +165,10 @@  discard block
 block discarded – undo
165 165
      */
166 166
     public function getAllLangs()
167 167
     {
168
-        $messageFiles = glob($this->container->getParameter("kernel.root_dir") . '/../i18n/*.json');
168
+        $messageFiles = glob($this->container->getParameter("kernel.root_dir").'/../i18n/*.json');
169 169
 
170 170
         $languages = array_values(array_unique(array_map(
171
-            function ($filename) {
171
+            function($filename) {
172 172
                 return basename($filename, '.json');
173 173
             },
174 174
             $messageFiles
@@ -516,9 +516,9 @@  discard block
 block discarded – undo
516 516
     public function getFilters()
517 517
     {
518 518
         return [
519
-            new \Twig_SimpleFilter('capitalize_first', [ $this, 'capitalizeFirst' ]),
520
-            new \Twig_SimpleFilter('percent_format', [ $this, 'percentFormat' ]),
521
-            new \Twig_SimpleFilter('diff_format', [ $this, 'diffFormat' ], [ 'is_safe' => [ 'html' ] ]),
519
+            new \Twig_SimpleFilter('capitalize_first', [$this, 'capitalizeFirst']),
520
+            new \Twig_SimpleFilter('percent_format', [$this, 'percentFormat']),
521
+            new \Twig_SimpleFilter('diff_format', [$this, 'diffFormat'], ['is_safe' => ['html']]),
522 522
         ];
523 523
     }
524 524
 
@@ -545,10 +545,10 @@  discard block
 block discarded – undo
545 545
         if (!$denominator) {
546 546
             $quotient = $numerator;
547 547
         } else {
548
-            $quotient = ( $numerator / $denominator ) * 100;
548
+            $quotient = ($numerator / $denominator) * 100;
549 549
         }
550 550
 
551
-        return round($quotient, $precision) . '%';
551
+        return round($quotient, $precision).'%';
552 552
     }
553 553
 
554 554
     /**
@@ -623,20 +623,20 @@  discard block
 block discarded – undo
623 623
 
624 624
         if ($seconds >= 86400) {
625 625
             // Over a day
626
-            $val = (int) floor($seconds / 86400);
626
+            $val = (int)floor($seconds / 86400);
627 627
             $key = 'days';
628 628
         } elseif ($seconds >= 3600) {
629 629
             // Over an hour, less than a day
630
-            $val = (int) floor($seconds / 3600);
630
+            $val = (int)floor($seconds / 3600);
631 631
             $key = 'hours';
632 632
         } elseif ($seconds >= 60) {
633 633
             // Over a minute, less than an hour
634
-            $val = (int) floor($seconds / 60);
634
+            $val = (int)floor($seconds / 60);
635 635
             $key = 'minutes';
636 636
         }
637 637
 
638 638
         if ($translate) {
639
-            return number_format($val) . ' ' . $this->intuitionMessage("num-$key", [$val]);
639
+            return number_format($val).' '.$this->intuitionMessage("num-$key", [$val]);
640 640
         } else {
641 641
             return [number_format($val), "num-$key"];
642 642
         }
Please login to merge, or discard this patch.
src/AppBundle/Controller/ApiController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -117,13 +117,13 @@  discard block
 block discarded – undo
117 117
         $view = View::create()->setStatusCode(Response::HTTP_OK);
118 118
 
119 119
         if ($request->query->get('format') === 'html') {
120
-            $edits = array_map(function ($attrs) use ($project, $username) {
120
+            $edits = array_map(function($attrs) use ($project, $username) {
121 121
                 $nsName = '';
122 122
                 if ($attrs['page_namespace']) {
123 123
                     $nsName = $project->getNamespaces()[$attrs['page_namespace']];
124 124
                 }
125 125
                 $page = $project->getRepository()
126
-                    ->getPage($project, $nsName . ':' . $attrs['page_title']);
126
+                    ->getPage($project, $nsName.':'.$attrs['page_title']);
127 127
                 $attrs['id'] = $attrs['rev_id'];
128 128
                 $attrs['username'] = $username;
129 129
                 return new Edit($page, $attrs);
@@ -180,19 +180,19 @@  discard block
 block discarded – undo
180 180
         $info = $page->getBasicEditingInfo();
181 181
         $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
182 182
         $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
183
-        $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
183
+        $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
184 184
 
185 185
         $data = [
186
-            'revisions' => (int) $info['num_edits'],
187
-            'editors' => (int) $info['num_editors'],
186
+            'revisions' => (int)$info['num_edits'],
187
+            'editors' => (int)$info['num_editors'],
188 188
             'author' => $info['author'],
189
-            'author_editcount' => (int) $info['author_editcount'],
189
+            'author_editcount' => (int)$info['author_editcount'],
190 190
             'created_at' => $creationDateTime->format('Y-m-d'),
191 191
             'created_rev_id' => $info['created_rev_id'],
192 192
             'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
193 193
             'secs_since_last_edit' => $secsSinceLastEdit,
194
-            'last_edit_id' => (int) $info['modified_rev_id'],
195
-            'watchers' => (int) $page->getWatchers(),
194
+            'last_edit_id' => (int)$info['modified_rev_id'],
195
+            'watchers' => (int)$page->getWatchers(),
196 196
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
197 197
             'pageviews_offset' => $pageviewsOffset,
198 198
         ];
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         }
248 248
 
249 249
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
250
-        $date =  date('Y-m-d');
250
+        $date = date('Y-m-d');
251 251
 
252 252
         // Increment count in timeline
253 253
         $existsSql = "SELECT 1 FROM usage_timeline
Please login to merge, or discard this patch.
src/Xtools/Page.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         $info = $this->getPageInfo();
67 67
         $title = isset($info['title']) ? $info['title'] : $this->unnormalizedPageName;
68 68
         $nsName = $this->getNamespaceName();
69
-        return str_replace($nsName . ':', '', $title);
69
+        return str_replace($nsName.':', '', $title);
70 70
     }
71 71
 
72 72
     /**
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         // Otherwise do a COUNT in the event fetching
209 209
         // all revisions is not desired
210
-        return (int) $this->getRepository()->getNumRevisions($this, $user);
210
+        return (int)$this->getRepository()->getNumRevisions($this, $user);
211 211
     }
212 212
 
213 213
     /**
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
 
366 366
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
367 367
 
368
-        $terms = array_map(function ($entry) {
368
+        $terms = array_map(function($entry) {
369 369
             return $entry['term'];
370 370
         }, $wikidataInfo);
371 371
 
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
                 'prio' => 2,
377 377
                 'name' => 'Wikidata',
378 378
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
379
-                'explanation' => "See: <a target='_blank' " .
379
+                'explanation' => "See: <a target='_blank' ".
380 380
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
381 381
             ];
382 382
         }
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
                 'prio' => 3,
387 387
                 'name' => 'Wikidata',
388 388
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
389
-                'explanation' => "See: <a target='_blank' " .
389
+                'explanation' => "See: <a target='_blank' ".
390 390
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
391 391
             ];
392 392
         }
@@ -457,8 +457,8 @@  discard block
 block discarded – undo
457 457
             return 0;
458 458
         }
459 459
 
460
-        return array_sum(array_map(function ($item) {
461
-            return (int) $item['views'];
460
+        return array_sum(array_map(function($item) {
461
+            return (int)$item['views'];
462 462
         }, $pageviews['items']));
463 463
     }
464 464
 
Please login to merge, or discard this patch.
src/Xtools/EditCounter.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
      */
83 83
     protected function getPairData()
84 84
     {
85
-        if (! is_array($this->pairData)) {
85
+        if (!is_array($this->pairData)) {
86 86
             $this->pairData = $this->getRepository()
87 87
                 ->getPairData($this->project, $this->user);
88 88
         }
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      */
96 96
     protected function getLogCounts()
97 97
     {
98
-        if (! is_array($this->logCounts)) {
98
+        if (!is_array($this->logCounts)) {
99 99
             $this->logCounts = $this->getRepository()
100 100
                 ->getLogCounts($this->project, $this->user);
101 101
         }
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
      */
145 145
     public function countAllRevisions()
146 146
     {
147
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
147
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
148 148
     }
149 149
 
150 150
     /**
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
      */
164 164
     public function countRevisionsWithoutComments()
165 165
     {
166
-        return $this->countLiveRevisions() - $this->countRevisionsWithComments();
166
+        return $this->countLiveRevisions()-$this->countRevisionsWithComments();
167 167
     }
168 168
 
169 169
     /**
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
      */
203 203
     public function countAllPagesEdited()
204 204
     {
205
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
205
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
206 206
     }
207 207
 
208 208
     /**
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
      */
213 213
     public function countPagesCreated()
214 214
     {
215
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
215
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
216 216
     }
217 217
 
218 218
     /**
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
             // Try block just in case there are older, unpredictable formats
341 341
             try {
342 342
                 $expiry = strtotime($durationStr, $timestamp);
343
-                $duration = ($expiry - $timestamp) / (60 * 60 * 24);
343
+                $duration = ($expiry-$timestamp) / (60 * 60 * 24);
344 344
 
345 345
                 if (!$duration || $duration > $this->longestBlockDays) {
346 346
                     $this->longestBlockDays = $duration;
@@ -424,7 +424,7 @@  discard block
 block discarded – undo
424 424
         $import = isset($logCounts['import-import']) ? (int)$logCounts['import-import'] : 0;
425 425
         $interwiki = isset($logCounts['import-interwiki']) ? (int)$logCounts['import-interwiki'] : 0;
426 426
         $upload = isset($logCounts['import-upload']) ? (int)$logCounts['import-upload'] : 0;
427
-        return $import + $interwiki + $upload;
427
+        return $import+$interwiki+$upload;
428 428
     }
429 429
 
430 430
     /**
@@ -548,9 +548,9 @@  discard block
 block discarded – undo
548 548
     public function approvals()
549 549
     {
550 550
         $logCounts = $this->getLogCounts();
551
-        $total = $logCounts['review-approve'] +
552
-        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
553
-        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
551
+        $total = $logCounts['review-approve']+
552
+        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
553
+        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
554 554
         (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
555 555
         return $total;
556 556
     }
@@ -574,7 +574,7 @@  discard block
 block discarded – undo
574 574
         $logCounts = $this->getLogCounts();
575 575
         $create2 = $logCounts['newusers-create2'] ?: 0;
576 576
         $byemail = $logCounts['newusers-byemail'] ?: 0;
577
-        return $create2 + $byemail;
577
+        return $create2+$byemail;
578 578
     }
579 579
 
580 580
     /**
@@ -622,7 +622,7 @@  discard block
 block discarded – undo
622 622
 
623 623
         $totals = $this->getRepository()->getMonthCounts($this->project, $this->user);
624 624
         $out = [
625
-            'yearLabels' => [],  // labels for years
625
+            'yearLabels' => [], // labels for years
626 626
             'monthLabels' => [], // labels for months
627 627
             'totals' => [], // actual totals, grouped by namespace, year and then month
628 628
         ];
@@ -650,7 +650,7 @@  discard block
 block discarded – undo
650 650
                 $out['totals'][$ns][$total['year']] = [];
651 651
             }
652 652
 
653
-            $out['totals'][$ns][$total['year']][$total['month']] = (int) $total['count'];
653
+            $out['totals'][$ns][$total['year']][$total['month']] = (int)$total['count'];
654 654
         }
655 655
 
656 656
         $dateRange = new DatePeriod(
@@ -660,8 +660,8 @@  discard block
 block discarded – undo
660 660
         );
661 661
 
662 662
         foreach ($dateRange as $monthObj) {
663
-            $year = (int) $monthObj->format('Y');
664
-            $month = (int) $monthObj->format('n');
663
+            $year = (int)$monthObj->format('Y');
664
+            $month = (int)$monthObj->format('n');
665 665
 
666 666
             // Fill in labels
667 667
             $out['monthLabels'][] = $monthObj->format('Y-m');
@@ -770,8 +770,8 @@  discard block
 block discarded – undo
770 770
                 ->globalEditCounts($this->user, $this->project);
771 771
             if ($sorted) {
772 772
                 // Sort.
773
-                uasort($this->globalEditCounts, function ($a, $b) {
774
-                    return $b['total'] - $a['total'];
773
+                uasort($this->globalEditCounts, function($a, $b) {
774
+                    return $b['total']-$a['total'];
775 775
                 });
776 776
             }
777 777
         }
@@ -807,7 +807,7 @@  discard block
 block discarded – undo
807 807
                 $nsName = $project->getNamespaces()[$revision['page_namespace']];
808 808
             }
809 809
             $page = $project->getRepository()
810
-                ->getPage($project, $nsName . ':' . $revision['page_title']);
810
+                ->getPage($project, $nsName.':'.$revision['page_title']);
811 811
             $edit = new Edit($page, $revision);
812 812
             $globalEdits[$edit->getTimestamp()->getTimestamp().'-'.$edit->getId()] = $edit;
813 813
         }
@@ -824,7 +824,7 @@  discard block
 block discarded – undo
824 824
      */
825 825
     protected function getEditSizeData()
826 826
     {
827
-        if (! is_array($this->editSizeData)) {
827
+        if (!is_array($this->editSizeData)) {
828 828
             $this->editSizeData = $this->getRepository()
829 829
                 ->getEditSizeData($this->project, $this->user);
830 830
         }
@@ -848,7 +848,7 @@  discard block
 block discarded – undo
848 848
     public function countSmallEdits()
849 849
     {
850 850
         $editSizeData = $this->getEditSizeData();
851
-        return isset($editSizeData['small_edits']) ? (int) $editSizeData['small_edits'] : 0;
851
+        return isset($editSizeData['small_edits']) ? (int)$editSizeData['small_edits'] : 0;
852 852
     }
853 853
 
854 854
     /**
@@ -858,7 +858,7 @@  discard block
 block discarded – undo
858 858
     public function countLargeEdits()
859 859
     {
860 860
         $editSizeData = $this->getEditSizeData();
861
-        return isset($editSizeData['large_edits']) ? (int) $editSizeData['large_edits'] : 0;
861
+        return isset($editSizeData['large_edits']) ? (int)$editSizeData['large_edits'] : 0;
862 862
     }
863 863
 
864 864
     /**
Please login to merge, or discard this patch.
src/Xtools/ProjectRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
                     || $projMetadata['url'] == "https://$project"
149 149
                     || $projMetadata['url'] == "https://$project.org"
150 150
                     || $projMetadata['url'] == "https://www.$project") {
151
-                    $this->log->debug(__METHOD__ . " Using cached data for $project");
151
+                    $this->log->debug(__METHOD__." Using cached data for $project");
152 152
                     return $projMetadata;
153 153
                 }
154 154
             }
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
         }
205 205
 
206 206
         // Redis cache
207
-        $cacheKey = "projectMetadata." . preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
207
+        $cacheKey = "projectMetadata.".preg_replace("/[^A-Za-z0-9]/", '', $projectUrl);
208 208
         if ($this->cache->hasItem($cacheKey)) {
209 209
             $this->metadata = $this->cache->getItem($cacheKey)->get();
210 210
             return $this->metadata;
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
         $optedIn = $this->container->getParameter('opted_in');
285 285
         // In case there's just one given.
286 286
         if (!is_array($optedIn)) {
287
-            $optedIn = [ $optedIn ];
287
+            $optedIn = [$optedIn];
288 288
         }
289 289
         return $optedIn;
290 290
     }
Please login to merge, or discard this patch.