x-tools / xtools

src/Xtools/Edit.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Xtools;
 
 use Xtools\User;
-use AppBundle\Helper\AutomatedEditsHelper;
 use DateTime;
 
 /**

Spacing +7 added lines, -7 removed lines

@@ -46,11 +46,11 @@ 
         $this->page = $page;
 
         // Copy over supported attributes
-        $this->id = (int) $attrs['id'];
+        $this->id = (int)$attrs['id'];
         $this->timestamp = DateTime::createFromFormat('YmdHis', $attrs['timestamp']);
         $this->minor = $attrs['minor'] === '1';
-        $this->length = (int) $attrs['length'];
-        $this->length_change = (int) $attrs['length_change'];
+        $this->length = (int)$attrs['length'];
+        $this->length_change = (int)$attrs['length_change'];
         $this->user = new User($attrs['username']);
         $this->comment = $attrs['comment'];
     }
@@ -179,8 +179,8 @@ 
     public function getDiffUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -190,8 +190,8 @@ 
     public function getPermaUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**

src/AppBundle/Controller/ApiController.php

Unused Use Statements -5 removed lines

@@ -2,13 +2,8 @@
 
 namespace AppBundle\Controller;
 
-use AppBundle\Helper\AutomatedEditsHelper;
-use Exception;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Debug\Exception\FatalErrorException;
 use FOS\RestBundle\Controller\Annotations as Rest;
 use FOS\RestBundle\Controller\FOSRestController;
 use FOS\RestBundle\View\View;

Spacing +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
         }
 
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/AppBundle/Controller/AdminScoreController.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use DateTime;
 use Xtools\ProjectRepository;
 use Xtools\UserRepository;

Spacing +16 added lines, -16 removed lines

@@ -47,9 +47,9 @@ 
         $username = $request->query->get('username', $request->query->get('user'));
 
         if ($projectQuery != '' && $username != '') {
-            return $this->redirectToRoute('AdminScoreResult', [ 'project' => $projectQuery, 'username' => $username ]);
+            return $this->redirectToRoute('AdminScoreResult', ['project' => $projectQuery, 'username' => $username]);
         } elseif ($projectQuery != '') {
-            return $this->redirectToRoute('AdminScoreProject', [ 'project' => $projectQuery ]);
+            return $this->redirectToRoute('AdminScoreProject', ['project' => $projectQuery]);
         }
 
         // Set default project so we can populate the namespace selector.
@@ -95,20 +95,20 @@ 
         $archiveTable = $projectRepo->getTableName($dbName, 'archive');
 
         // MULTIPLIERS (to review)
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
-        $USER_PAGE_MULT = 0.1;     # 0 if =
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
+        $USER_PAGE_MULT = 0.1; # 0 if =
         $PATROLS_MULT = 1; # 0 if =
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
+        $BLOCKS_MULT = 1.4; # 0 if = 10
         $AFD_MULT = 1.15;
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
         $AIV_MULT = 1.15;
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
-        $NAMESPACES_MULT = 1.0;     # 0 if =
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
+        $NAMESPACES_MULT = 1.0; # 0 if =
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
-        $RPP_MULT = 1.15;     # 0 if =
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
+        $RPP_MULT = 1.15; # 0 if =
+        $USERRIGHTS_MULT = 0.75; # 0 if =
 
         // Grab the connection to the replica database (which is separate from the above)
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -186,15 +186,15 @@ 
                 $now = new DateTime();
                 $date = new DateTime($value);
                 $diff = $date->diff($now);
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
                 $value = $formula-365;
             }
 
             if ($key == "id") {
                 $id = $value;
             } else {
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
+                $multiplierKey = strtoupper($row["source"]."_MULT");
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
                 $score = max(min($value * $multiplier, 100), -100);
                 $master[$key]["mult"] = $multiplier;
                 $master[$key]["value"] = $value;
@@ -204,8 +204,8 @@ 
         }
 
         if ($id == 0) {
-            $this->addFlash("notice", [ "no-result", $username ]);
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
+            $this->addFlash("notice", ["no-result", $username]);
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
         }
 
         return $this->render('adminscore/result.html.twig', [

src/AppBundle/Controller/DefaultController.php

Spacing +2 added lines, -2 removed lines

@@ -90,7 +90,7 @@ 
     public function loginAction()
     {
         try {
-            list( $next, $token ) = $this->getOauthClient()->initiate();
+            list($next, $token) = $this->getOauthClient()->initiate();
         } catch (Exception $oauthException) {
             throw $oauthException;
             // @TODO Make this work.
@@ -155,7 +155,7 @@ 
                     . '/index.php?title=Special:OAuth';
         $conf = new ClientConfig($endpoint);
         $consumerKey = $this->getParameter('oauth_key');
-        $consumerSecret =  $this->getParameter('oauth_secret');
+        $consumerSecret = $this->getParameter('oauth_secret');
         $conf->setConsumer(new Consumer($consumerKey, $consumerSecret));
         $this->oauthClient = new Client($conf);
         // Callback URL is hardcoded in the consumer registration.

src/AppBundle/Twig/AppExtension.php

Doc Comments +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
 
     /**
      * Get all functions that this class provides.
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {
@@ -520,7 +520,7 @@ 
 
     /**
      * Get all filters for this extension.
-     * @return array
+     * @return \Twig_SimpleFilter[]
      */
     public function getFilters()
     {

Spacing +35 added lines, -35 removed lines

@@ -30,32 +30,32 @@ 
     {
         $options = ['is_safe' => ['html']];
         return [
-            new \Twig_SimpleFunction('request_time', [ $this, 'requestTime' ], $options),
-            new \Twig_SimpleFunction('memory_usage', [ $this, 'requestMemory' ], $options),
-            new \Twig_SimpleFunction('year', [ $this, 'generateYear' ], $options),
-            new \Twig_SimpleFunction('msgPrintExists', [ $this, 'intuitionMessagePrintExists' ], $options),
-            new \Twig_SimpleFunction('msgExists', [ $this, 'intuitionMessageExists' ], $options),
-            new \Twig_SimpleFunction('msg', [ $this, 'intuitionMessage' ], $options),
-            new \Twig_SimpleFunction('lang', [ $this, 'getLang' ], $options),
-            new \Twig_SimpleFunction('langName', [ $this, 'getLangName' ], $options),
-            new \Twig_SimpleFunction('allLangs', [ $this, 'getAllLangs' ]),
-            new \Twig_SimpleFunction('isRTL', [ $this, 'intuitionIsRTL' ]),
-            new \Twig_SimpleFunction('isRTLLang', [ $this, 'intuitionIsRTLLang' ]),
-            new \Twig_SimpleFunction('shortHash', [ $this, 'gitShortHash' ]),
-            new \Twig_SimpleFunction('hash', [ $this, 'gitHash' ]),
-            new \Twig_SimpleFunction('enabled', [ $this, 'tabEnabled' ]),
-            new \Twig_SimpleFunction('tools', [ $this, 'allTools' ]),
-            new \Twig_SimpleFunction('color', [ $this, 'getColorList' ]),
-            new \Twig_SimpleFunction('chartColor', [ $this, 'chartColor' ]),
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
-            new \Twig_SimpleFunction('isSingleWiki', [ $this, 'isSingleWiki' ]),
-            new \Twig_SimpleFunction('getReplagThreshold', [ $this, 'getReplagThreshold' ]),
-            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [ $this, 'loadStylesheetsFromCDN' ]),
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
-            new \Twig_SimpleFunction('replag', [ $this, 'replag' ]),
-            new \Twig_SimpleFunction('link', [ $this, 'link' ]),
-            new \Twig_SimpleFunction('quote', [ $this, 'quote' ]),
-            new \Twig_SimpleFunction('bugReportURL', [ $this, 'bugReportURL' ]),
+            new \Twig_SimpleFunction('request_time', [$this, 'requestTime'], $options),
+            new \Twig_SimpleFunction('memory_usage', [$this, 'requestMemory'], $options),
+            new \Twig_SimpleFunction('year', [$this, 'generateYear'], $options),
+            new \Twig_SimpleFunction('msgPrintExists', [$this, 'intuitionMessagePrintExists'], $options),
+            new \Twig_SimpleFunction('msgExists', [$this, 'intuitionMessageExists'], $options),
+            new \Twig_SimpleFunction('msg', [$this, 'intuitionMessage'], $options),
+            new \Twig_SimpleFunction('lang', [$this, 'getLang'], $options),
+            new \Twig_SimpleFunction('langName', [$this, 'getLangName'], $options),
+            new \Twig_SimpleFunction('allLangs', [$this, 'getAllLangs']),
+            new \Twig_SimpleFunction('isRTL', [$this, 'intuitionIsRTL']),
+            new \Twig_SimpleFunction('isRTLLang', [$this, 'intuitionIsRTLLang']),
+            new \Twig_SimpleFunction('shortHash', [$this, 'gitShortHash']),
+            new \Twig_SimpleFunction('hash', [$this, 'gitHash']),
+            new \Twig_SimpleFunction('enabled', [$this, 'tabEnabled']),
+            new \Twig_SimpleFunction('tools', [$this, 'allTools']),
+            new \Twig_SimpleFunction('color', [$this, 'getColorList']),
+            new \Twig_SimpleFunction('chartColor', [$this, 'chartColor']),
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
+            new \Twig_SimpleFunction('isSingleWiki', [$this, 'isSingleWiki']),
+            new \Twig_SimpleFunction('getReplagThreshold', [$this, 'getReplagThreshold']),
+            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [$this, 'loadStylesheetsFromCDN']),
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
+            new \Twig_SimpleFunction('replag', [$this, 'replag']),
+            new \Twig_SimpleFunction('link', [$this, 'link']),
+            new \Twig_SimpleFunction('quote', [$this, 'quote']),
+            new \Twig_SimpleFunction('bugReportURL', [$this, 'bugReportURL']),
             new \Twig_SimpleFunction('logged_in_user', [$this, 'functionLoggedInUser']),
             new \Twig_SimpleFunction('isUserAnon', [$this, 'isUserAnon']),
             new \Twig_SimpleFunction('nsName', [$this, 'nsName']),
@@ -69,7 +69,7 @@ 
      */
     public function requestTime($decimals = 3)
     {
-        return number_format(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT'], $decimals);
+        return number_format(microtime(true)-$_SERVER['REQUEST_TIME_FLOAT'], $decimals);
     }
 
     /**
@@ -102,7 +102,7 @@ 
      */
     public function intuitionMessageExists($message = "")
     {
-        return $this->getIntuition()->msgExists($message, [ "domain" => "xtools" ]);
+        return $this->getIntuition()->msgExists($message, ["domain" => "xtools"]);
     }
 
     /**
@@ -133,7 +133,7 @@ 
      */
     public function intuitionMessage($message = "", $vars = [])
     {
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
     }
 
     /**
@@ -162,10 +162,10 @@ 
      */
     public function getAllLangs()
     {
-        $messageFiles = glob($this->container->getParameter("kernel.root_dir") . '/../i18n/*.json');
+        $messageFiles = glob($this->container->getParameter("kernel.root_dir").'/../i18n/*.json');
 
         $languages = array_values(array_unique(array_map(
-            function ($filename) {
+            function($filename) {
                 return basename($filename, '.json');
             },
             $messageFiles
@@ -513,8 +513,8 @@ 
     public function getFilters()
     {
         return [
-            new \Twig_SimpleFilter('capitalize_first', [ $this, 'capitalizeFirst' ]),
-            new \Twig_SimpleFilter('percent_format', [ $this, 'percentFormat' ]),
+            new \Twig_SimpleFilter('capitalize_first', [$this, 'capitalizeFirst']),
+            new \Twig_SimpleFilter('percent_format', [$this, 'percentFormat']),
         ];
     }
 
@@ -541,10 +541,10 @@ 
         if (!$denominator) {
             $quotient = $numerator;
         } else {
-            $quotient = ( $numerator / $denominator ) * 100;
+            $quotient = ($numerator / $denominator) * 100;
         }
 
-        return round($quotient, $precision) . '%';
+        return round($quotient, $precision).'%';
     }
 
     /**

src/AppBundle/Controller/EditCounterController.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use Symfony\Component\HttpFoundation\Response;
 use Xtools\EditCounter;
 use Xtools\EditCounterRepository;
-use Xtools\Page;
 use Xtools\Project;
 use Xtools\ProjectRepository;
 use Xtools\User;

Spacing +3 added lines, -3 removed lines

@@ -78,10 +78,10 @@ 
         $username = $request->query->get('username', $request->query->get('user'));
 
         if (($project || $queryProject) && $username) {
-            $routeParams = [ 'project'=>($project ?: $queryProject), 'username' => $username ];
+            $routeParams = ['project'=>($project ?: $queryProject), 'username' => $username];
             return $this->redirectToRoute("EditCounterResult", $routeParams);
         } elseif (!$project && $queryProject) {
-            return $this->redirectToRoute("EditCounterProject", [ 'project'=>$queryProject ]);
+            return $this->redirectToRoute("EditCounterProject", ['project'=>$queryProject]);
         }
 
         $project = ProjectRepository::getProject($queryProject, $this->container);
@@ -116,7 +116,7 @@ 
         }
         $isSubRequest = $this->container->get('request_stack')->getParentRequest() !== null;
         return $this->render('editCounter/result.html.twig', [
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->project->getTitle(),
+            'xtTitle' => $this->user->getUsername().' - '.$this->project->getTitle(),
             'xtPage' => 'ec',
             'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
             'is_sub_request' => $isSubRequest,

src/Xtools/Project.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 namespace Xtools;
 
 use Mediawiki\Api\MediawikiApi;
-use Symfony\Component\VarDumper\VarDumper;
 
 /**
  * A Project is a single wiki that XTools is querying.

Doc Comments +1 added lines, -1 removed lines

@@ -200,7 +200,7 @@
     /**
      * Get an array of this project's namespaces and their IDs.
      *
-     * @return string[] Keys are IDs, values are names.
+     * @return string Keys are IDs, values are names.
      */
     public function getNamespaces()
     {

Spacing +8 added lines, -8 removed lines

@@ -117,7 +117,7 @@ 
      */
     public function getUrl($withTrailingSlash = true)
     {
-        return rtrim($this->getBasicInfo()['url'], '/') . ($withTrailingSlash ? '/' : '');
+        return rtrim($this->getBasicInfo()['url'], '/').($withTrailingSlash ? '/' : '');
     }
 
     /**
@@ -174,7 +174,7 @@ 
         $metadata = $this->getMetadata();
         return isset($metadata['general']['script'])
             ? $metadata['general']['script']
-            : $this->getScriptPath() . '/index.php';
+            : $this->getScriptPath().'/index.php';
     }
 
     /**
@@ -184,7 +184,7 @@ 
      */
     public function getApiUrl()
     {
-        return rtrim($this->getUrl(), '/') . $this->getRepository()->getApiPath();
+        return rtrim($this->getUrl(), '/').$this->getRepository()->getApiPath();
     }
 
     /**
@@ -216,7 +216,7 @@ 
      */
     public function userOptInPage(User $user)
     {
-        $localPageName = 'User:' . $user->getUsername() . '/EditCounterOptIn.js';
+        $localPageName = 'User:'.$user->getUsername().'/EditCounterOptIn.js';
         return $localPageName;
     }
 
@@ -250,7 +250,7 @@ 
         }
 
         // 4. Lastly, see if they've opted in globally on the default project or Meta.
-        $globalPageName = $user->getUsername() . '/EditCounterGlobalOptIn.js';
+        $globalPageName = $user->getUsername().'/EditCounterGlobalOptIn.js';
         $globalProject = $this->getRepository()->getGlobalProject();
         if ($globalProject instanceof Project) {
             $globalExists = $globalProject->getRepository()
@@ -269,7 +269,7 @@ 
      */
     public function hasPageAssessments()
     {
-        return (bool) $this->getRepository()->getAssessmentsConfig($this->getDomain());
+        return (bool)$this->getRepository()->getAssessmentsConfig($this->getDomain());
     }
 
     /**
@@ -282,9 +282,9 @@ 
         $config = $this->getRepository()->getAssessmentsConfig($this->getDomain());
 
         if (isset($config['class'][$class])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config['class'][$class]['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config['class'][$class]['badge'];
         } elseif (isset($config['class']['Unknown'])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config['class']['Unknown']['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config['class']['Unknown']['badge'];
         } else {
             return "";
         }

src/AppBundle/Controller/MetaController.php

Spacing +6 added lines, -6 removed lines

@@ -31,7 +31,7 @@ 
         $end = $request->query->get('end');
 
         if ($start != '' && $end != '') {
-            return $this->redirectToRoute('MetaResult', [ 'start' => $start, 'end' => $end ]);
+            return $this->redirectToRoute('MetaResult', ['start' => $start, 'end' => $end]);
         }
 
         return $this->render('meta/index.html.twig', [
@@ -73,7 +73,7 @@ 
         $timeline = [];
         $startObj = new DateTime($start);
         $endObj = new DateTime($end);
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
         $grandSum = 0;
 
         // Generate array of date labels
@@ -85,17 +85,17 @@ 
 
         foreach ($data as $entry) {
             if (!isset($totals[$entry['tool']])) {
-                $totals[$entry['tool']] = (int) $entry['count'];
+                $totals[$entry['tool']] = (int)$entry['count'];
 
                 // Create arrays for each tool, filled with zeros for each date in the timeline
                 $timeline[$entry['tool']] = array_fill(0, $numDays, 0);
             } else {
-                $totals[$entry['tool']] += (int) $entry['count'];
+                $totals[$entry['tool']] += (int)$entry['count'];
             }
 
             $date = new DateTime($entry['date']);
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
-            $timeline[$entry['tool']][$dateIndex] = (int) $entry['count'];
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
+            $timeline[$entry['tool']][$dateIndex] = (int)$entry['count'];
 
             $grandSum += $entry['count'];
         }

src/AppBundle/Controller/PagesController.php

Unused Use Statements -3 removed lines

@@ -11,11 +11,8 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 use Xtools\UserRepository;
-use Xtools\Page;
-use Xtools\Edit;
 
 /**
  * This controller serves the Pages tool.

Spacing +3 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("PagesProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("PagesProject", ['project'=>$projectQuery]);
         }
 
         // set default wiki so we can populate the namespace selector
@@ -207,8 +207,8 @@ 
         }
 
         if ($total < 1) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
-            return $this->redirectToRoute('PagesProject', [ 'project' => $project ]);
+            $this->addFlash('notice', ['no-result', $username]);
+            return $this->redirectToRoute('PagesProject', ['project' => $project]);
         }
 
         ksort($pagesByNamespaceByDate);