App\Controller\PageInfoController::resultAction()

Complexity

Conditions	7
Paths	25

Size

Total Lines	60
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function resultAction(
        PageInfoRepository $pageInfoRepo,
        AutomatedEditsHelper $autoEditsHelper
    ): Response {
        if (!$this->isDateRangeValid($this->page, $this->start, $this->end)) {

It seems like $this->page can also be of type null; however, parameter $page of App\Controller\PageInfoController::isDateRangeValid() does only seem to accept App\Model\Page, maybe add an additional type check?

            $this->addFlashMessage('notice', 'date-range-outside-revisions');

            return $this->redirectToRoute('PageInfo', [
                'project' => $this->request->get('project'),
            ]);
        }

        $this->setupPageInfo($pageInfoRepo, $autoEditsHelper);
        $this->pageInfo->prepareData();

        $maxRevisions = $this->getParameter('app.max_page_revisions');

        // Show message if we hit the max revisions.
        if ($this->pageInfo->tooManyRevisions()) {
            $this->addFlashMessage('notice', 'too-many-revisions', [
                $this->i18n->numberFormat($maxRevisions),
                $maxRevisions,
            ]);
        }

        // For when there is very old data (2001 era) which may cause miscalculations.
        if ($this->pageInfo->getFirstEdit()->getYear() < 2003) {
            $this->addFlashMessage('warning', 'old-page-notice');
        }

        // When all username info has been hidden (see T303724).
        if (0 === $this->pageInfo->getNumEditors()) {
            $this->addFlashMessage('warning', 'error-usernames-missing');
        } elseif ($this->pageInfo->numDeletedRevisions()) {
            $link = new Markup(
                $this->renderView('flashes/deleted_data.html.twig', [
                    'numRevs' => $this->pageInfo->numDeletedRevisions(),
                ]),
                'UTF-8'
            );
            $this->addFlashMessage(
                'warning',
                $link,
                [$this->pageInfo->numDeletedRevisions(), $link]
            );
        }

        $ret = [
            'xtPage' => 'PageInfo',
            'xtTitle' => $this->page->getTitle(),

The method getTitle() does not exist on null.

            'project' => $this->project,
            'editorlimit' => (int)$this->request->query->get('editorlimit', 20),
            'botlimit' => $this->request->query->get('botlimit', 10),
            'pageviewsOffset' => 60,
            'ai' => $this->pageInfo,
            'showAuthorship' => Authorship::isSupportedPage($this->page) && $this->pageInfo->getNumEditors() > 0,

It seems like $this->page can also be of type null; however, parameter $page of App\Model\Authorship::isSupportedPage() does only seem to accept App\Model\Page, maybe add an additional type check?

        ];

        // Output the relevant format template.
        return $this->getFormattedResponse('pageInfo/result', $ret);
    }