x-tools / xtools

web/app_dev.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 // Feel free to remove this, extend it, or make something more sophisticated.
 if (isset($_SERVER['HTTP_CLIENT_IP'])
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
 ) {
     header('HTTP/1.0 403 Forbidden');
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');

xtools_utilities/nonautomated_edits_parse.php

Spacing +4 added lines, -4 removed lines

@@ -15,11 +15,11 @@
 $data = json_decode($file, true);
 
 // Output the contents to the piped file
-print ( "parameters:
+print ("parameters:
   automated_tools:\r\n" );
 foreach ($data as $row) {
-    print "  - " . $row["name"] . ": '" . $row["regex"] . "'\r\n";
+    print "  - ".$row["name"].": '".$row["regex"]."'\r\n";
 }
-print ( "
+print ("
 
-  semi-automated edits source: $url" );
+  semi-automated edits source: $url");

src/AppBundle/Controller/TopEditsController.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($project != "") {
-            return $this->redirectToRoute("TopEditsResults", [ 'project'=>$project ]);
+            return $this->redirectToRoute("TopEditsResults", ['project'=>$project]);
         }
 
         // replace this example code with whatever you need
@@ -100,7 +100,7 @@ 
         $editData = $conn->executeQuery($query, $params)->fetchAll();
 
         // Get page info about these 100 pages, so we can use their display title.
-        $titles = array_map(function ($e) {
+        $titles = array_map(function($e) {
             return $e['page_title'];
         }, $editData);
         /** @var ApiHelper $apiHelper */

src/AppBundle/Controller/AdminScoreController.php

Spacing +16 added lines, -16 removed lines

@@ -27,9 +27,9 @@ 
         $username = $request->query->get('user');
 
         if ($projectQuery != "" && $username != "") {
-            return $this->redirectToRoute("AdminScoreResult", [ 'project'=>$projectQuery, 'username' => $username ]);
+            return $this->redirectToRoute("AdminScoreResult", ['project'=>$projectQuery, 'username' => $username]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("AdminScoreProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("AdminScoreProject", ['project'=>$projectQuery]);
         }
 
         // Otherwise fall through.
@@ -67,20 +67,20 @@ 
         $archiveTable = $lh->getTable("archive", $dbName);
 
         // MULTIPLIERS (to review)
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
-        $USER_PAGE_MULT = 0.1;     # 0 if =
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
+        $USER_PAGE_MULT = 0.1; # 0 if =
         $PATROLS_MULT = 1; # 0 if =
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
+        $BLOCKS_MULT = 1.4; # 0 if = 10
         $AFD_MULT = 1.15;
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
         $AIV_MULT = 1.15;
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
-        $NAMESPACES_MULT = 1.0;     # 0 if =
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
+        $NAMESPACES_MULT = 1.0; # 0 if =
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
-        $RPP_MULT = 1.15;     # 0 if =
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
+        $RPP_MULT = 1.15; # 0 if =
+        $USERRIGHTS_MULT = 0.75; # 0 if =
 
         // Grab the connection to the replica database (which is separate from the above)
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -154,15 +154,15 @@ 
                 $now = new DateTime();
                 $date = new DateTime($value);
                 $diff = $date->diff($now);
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
                 $value = $formula-365;
             }
 
             if ($key == "id") {
                 $id = $value;
             } else {
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
+                $multiplierKey = strtoupper($row["source"]."_MULT");
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
                 $score = max(min($value * $multiplier, 100), -100);
                 $master[$key]["mult"] = $multiplier;
                 $master[$key]["value"] = $value;
@@ -172,8 +172,8 @@ 
         }
 
         if ($id == 0) {
-            $this->addFlash("notice", [ "noresult", $username ]);
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
+            $this->addFlash("notice", ["noresult", $username]);
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
         }
 
         // replace this example code with whatever you need

src/AppBundle/Controller/AdminStatsController.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
                 'start' => $startDate,
             ]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("AdminStatsResult", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("AdminStatsResult", ['project'=>$projectQuery]);
         }
 
         // Otherwise fall through.

src/AppBundle/Controller/PagesController.php

Spacing +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("PagesProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("PagesProject", ['project'=>$projectQuery]);
         }
 
         // Retrieving the global groups, using the ApiHelper class
@@ -218,8 +218,8 @@ 
         }
 
         if ($total < 1) {
-            $this->addFlash("notice", [ "noresult", $username ]);
-            return $this->redirectToRoute("PagesProject", [ "project"=>$project ]);
+            $this->addFlash("notice", ["noresult", $username]);
+            return $this->redirectToRoute("PagesProject", ["project"=>$project]);
         }
 
         ksort($pagesArray);

src/AppBundle/Controller/SimpleEditCounterController.php

Spacing +8 added lines, -8 removed lines

@@ -31,10 +31,10 @@ 
         $username = $request->query->get('user');
 
         if ($projectQuery != "" && $username != "") {
-            $routeParams = [ 'project'=>$projectQuery, 'username' => $username ];
+            $routeParams = ['project'=>$projectQuery, 'username' => $username];
             return $this->redirectToRoute("SimpleEditCounterResult", $routeParams);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("SimpleEditCounterProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("SimpleEditCounterProject", ['project'=>$projectQuery]);
         }
 
         // Otherwise fall through.
@@ -89,8 +89,8 @@ 
         $resultQuery->execute();
 
         if ($resultQuery->errorCode() > 0) {
-            $this->addFlash("notice", [ "noresult", $username ]);
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
+            $this->addFlash("notice", ["noresult", $username]);
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
         }
 
         // Fetch the result data
@@ -114,16 +114,16 @@ 
                 $rev = $row["value"];
             }
             if ($row["source"] == "groups") {
-                $groups .= $row["value"]. ", ";
+                $groups .= $row["value"].", ";
             }
         }
 
         // Unknown user - If the user is created the $results variable will have 3 entries.
         // This is a workaround to detect non-existent IPs.
         if (count($results) < 3 && $arch == 0 && $rev == 0) {
-            $this->addFlash('notice', [ "noresult", $username ]);
+            $this->addFlash('notice', ["noresult", $username]);
 
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
         }
 
         // Remove the last comma and space
@@ -152,7 +152,7 @@ 
             'project_url' => $url,
             'id' => $id,
             'arch' => $arch,
-            'rev' => $rev + $arch,
+            'rev' => $rev+$arch,
             'live' => $rev,
             'groups' => $groups,
             'globalGroups' => $globalGroups,

src/AppBundle/Controller/ArticleInfoController.php

Spacing +22 added lines, -22 removed lines

@@ -55,9 +55,9 @@ 
         $article = $request->query->get('article');
 
         if ($projectQuery != '' && $article != '') {
-            return $this->redirectToRoute('ArticleInfoResult', [ 'project'=>$projectQuery, 'article' => $article ]);
+            return $this->redirectToRoute('ArticleInfoResult', ['project'=>$projectQuery, 'article' => $article]);
         } elseif ($article != '') {
-            return $this->redirectToRoute('ArticleInfoProject', [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute('ArticleInfoProject', ['project'=>$projectQuery]);
         }
 
         return $this->render('articleInfo/index.html.twig', [
@@ -101,7 +101,7 @@ 
             'url' => $basicInfo['fullurl']
         ];
 
-        $this->pageInfo['watchers'] = ( isset($basicInfo['watchers']) ) ? $basicInfo['watchers'] : "< 30";
+        $this->pageInfo['watchers'] = (isset($basicInfo['watchers'])) ? $basicInfo['watchers'] : "< 30";
 
         $pageProps = isset($basicInfo['pageprops']) ? $basicInfo['pageprops'] : [];
 
@@ -163,8 +163,8 @@ 
      */
     private function getRevCount()
     {
-        $query = "SELECT COUNT(*) AS count FROM " . $this->revisionTable
-                 . " WHERE rev_page = '" . $this->pageInfo['id'] . "'";
+        $query = "SELECT COUNT(*) AS count FROM ".$this->revisionTable
+                 . " WHERE rev_page = '".$this->pageInfo['id']."'";
         $res = $this->conn->query($query)->fetchAll();
         return $res[0]['count'];
     }
@@ -196,7 +196,7 @@ 
                   FROM $this->revisionTable
                   LEFT JOIN $userGroupsTable ON rev_user = ug_user
                   LEFT JOIN $userFromerGroupsTable ON rev_user = ufg_user
-                  WHERE rev_page = " . $this->pageInfo['id'] . " AND (ug_group = 'bot' OR ufg_group = 'bot')
+                  WHERE rev_page = ".$this->pageInfo['id']." AND (ug_group = 'bot' OR ufg_group = 'bot')
                   GROUP BY rev_user_text";
         $res = $this->conn->query($query)->fetchAll();
 
@@ -205,14 +205,14 @@ 
         $sum = 0;
         foreach ($res as $bot) {
             $bots[$bot['username']] = [
-                'count' => (int) $bot['count'],
+                'count' => (int)$bot['count'],
                 'current' => $bot['current'] === 'bot'
             ];
             $sum += $bot['count'];
         }
 
-        uasort($bots, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($bots, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         $this->pageInfo['general']['bot_revision_count'] = $sum;
@@ -248,10 +248,10 @@ 
 
             if ($info['all'] > 1) {
                 // Number of seconds between first and last edit
-                $secs = intval(strtotime($info['last']) - strtotime($info['first']) / $info['all']);
+                $secs = intval(strtotime($info['last'])-strtotime($info['first']) / $info['all']);
 
                 // Average time between edits (in days)
-                $this->pageInfo['editors'][$editor]['atbe'] = $secs / ( 60 * 60 * 24 );
+                $this->pageInfo['editors'][$editor]['atbe'] = $secs / (60 * 60 * 24);
             }
 
             if (count($info['sizes'])) {
@@ -297,7 +297,7 @@ 
 
         // Transform to associative array by 'type'
         foreach ($res as $row) {
-            $data[$row['type'] . '_count'] = $row['value'];
+            $data[$row['type'].'_count'] = $row['value'];
         }
 
         return $data;
@@ -313,7 +313,7 @@ 
         $title = str_replace(' ', '_', $this->pageInfo['title']);
         $query = "SELECT log_action, log_type, log_timestamp AS timestamp
                   FROM $loggingTable
-                  WHERE log_namespace = '" . $this->pageInfo['namespace'] . "'
+                  WHERE log_namespace = '".$this->pageInfo['namespace']."'
                   AND log_title = '$title' AND log_timestamp > 1
                   AND log_type IN ('delete', 'move', 'protect', 'stable')";
         $events = $this->conn->query($query)->fetchAll();
@@ -371,7 +371,7 @@ 
         $query = "SELECT rev_id, rev_parent_id, rev_user_text, rev_user, rev_timestamp,
                   rev_minor_edit, rev_len, rev_comment
                   FROM $this->revisionTable
-                  WHERE rev_page = '" . $this->pageInfo['id'] . "' AND rev_timestamp > 1
+                  WHERE rev_page = '".$this->pageInfo['id']."' AND rev_timestamp > 1
                   ORDER BY rev_timestamp";
 
         $res = $this->conn->query($query)->fetchAll();
@@ -391,9 +391,9 @@ 
             return $rev['rev_len'];
         }
 
-        $lastRev = $this->pageHistory[$revIndex - 1];
+        $lastRev = $this->pageHistory[$revIndex-1];
 
-        return $rev['rev_len'] - $lastRev['rev_len'];
+        return $rev['rev_len']-$lastRev['rev_len'];
     }
 
     /**
@@ -413,12 +413,12 @@ 
         // The month of the first edit. Used as a comparison when building the per-month data
         $firstEditMonth = strtotime(date('Y-m-01, 00:00', strtotime($firstEdit['rev_timestamp'])));
 
-        $lastEdit = $this->pageHistory[ $revisionCount - 1 ];
-        $secondLastEdit = $revisionCount === 1 ? $lastEdit : $this->pageHistory[ $revisionCount - 2 ];
+        $lastEdit = $this->pageHistory[$revisionCount-1];
+        $secondLastEdit = $revisionCount === 1 ? $lastEdit : $this->pageHistory[$revisionCount-2];
 
         // Now we can start our master array. This one will be HUGE!
         $lastEditSize = ($revisionCount > 1)
-            ? $lastEdit['rev_len'] - $secondLastEdit['rev_len']
+            ? $lastEdit['rev_len']-$secondLastEdit['rev_len']
             : $lastEdit['rev_len'];
         $data = [
             'general' => [
@@ -514,7 +514,7 @@ 
             // Increment year and month counts for all edits
             $data['year_count'][$timestamp['year']]['all']++;
             $data['year_count'][$timestamp['year']]['months'][$timestamp['month']]['all']++;
-            $data['year_count'][$timestamp['year']]['size'] = (int) $rev['rev_len'];
+            $data['year_count'][$timestamp['year']]['size'] = (int)$rev['rev_len'];
 
             // Fill in various user stats
             if (!isset($data['editors'][$username])) {
@@ -553,9 +553,9 @@ 
                 }
 
                 // determine if the next revision was a revert
-                $nextRevision = isset($this->pageHistory[$i + 1]) ? $this->pageHistory[$i + 1] : null;
+                $nextRevision = isset($this->pageHistory[$i+1]) ? $this->pageHistory[$i+1] : null;
                 $nextRevisionIsRevert = $nextRevision &&
-                    $this->getDiffSize($i + 1) === -$diffSize &&
+                    $this->getDiffSize($i+1) === -$diffSize &&
                     $this->aeh->isRevert($nextRevision['rev_comment']);
 
                 // don't count this edit as content removal if the next edit reverted it

src/AppBundle/Helper/ApiHelper.php

Spacing +9 added lines, -9 removed lines

@@ -41,7 +41,7 @@ 
     {
 
         $this->setUp($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -61,7 +61,7 @@ 
     {
 
         $this->setUp($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -86,13 +86,13 @@ 
     public function namespaces($project)
     {
         // Use cache if possible.
-        $cacheItem = $this->cache->getItem('api.namespaces.' . $project);
+        $cacheItem = $this->cache->getItem('api.namespaces.'.$project);
         if ($cacheItem->isHit()) {
             return $cacheItem->get();
         }
 
         $this->setUp($project);
-        $query = new SimpleRequest('query', [ "meta"=>"siteinfo", "siprop"=>"namespaces" ]);
+        $query = new SimpleRequest('query', ["meta"=>"siteinfo", "siprop"=>"namespaces"]);
         $result = [];
 
         try {
@@ -197,7 +197,7 @@ 
             $normalized = [];
             if (isset($result['query']['normalized'])) {
                 array_map(
-                    function ($e) use (&$normalized) {
+                    function($e) use (&$normalized) {
                         $normalized[$e['to']] = $e['from'];
                     },
                     $result['query']['normalized']
@@ -240,7 +240,7 @@ 
         ];
 
         // get assessments for this page from the API
-        $assessments = $this->massApi($params, $project, function ($data) {
+        $assessments = $this->massApi($params, $project, function($data) {
             return isset($data['pages'][0]['pageassessments']) ? $data['pages'][0]['pageassessments'] : [];
         }, 'pacontinue')['pages'];
 
@@ -268,7 +268,7 @@ 
                 $assessment['class']['value'] = '???';
                 // $1 is used to substitute the WikiProject name, e.g. Category:FA-Class Wikipedia 1.0 articles
                 $assessment['class']['category'] = str_replace('$1', $wikiproject, $classAttrs['category']);
-                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/". $classAttrs['badge'];
+                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".$classAttrs['badge'];
             } else {
                 $classAttrs = $config['class'][$classValue];
                 $assessment['class'] = [
@@ -279,7 +279,7 @@ 
 
                 // add full URL to badge icon
                 if ($classAttrs['badge'] !== '') {
-                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/" .
+                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".
                         $classAttrs['badge'];
                 }
 
@@ -405,7 +405,7 @@ 
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
         $innerPromise = $this->api->getRequestAsync($query);
 
-        $innerPromise->then(function ($result) use (&$data) {
+        $innerPromise->then(function($result) use (&$data) {
             // some failures come back as 200s, so we still resolve and let the outer function handle it
             if (isset($result['error']) || !isset($result['query'])) {
                 return $data['promise']->resolve($data);