AppBundle\Controller\XtoolsController::validateUser()

Complexity

Conditions	6
Paths	8

Size

Total Lines	34
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function validateUser($params, Project $project, $tooHighEditCountAction = null)
    {
        if (is_string($params)) {
            $params = ['username' => $params];
        }

        $userData = UserRepository::getUser($params['username'], $this->container);

$this->container of type object<Symfony\Component\DependencyInjection\ContainerInterface> is not a sub-type of object<Symfony\Component\DependencyInjection\Container>. It seems like you assume a concrete implementation of the interface Symfony\Component\DependencyInjection\ContainerInterface to be always present.

        // Don't continue if the user doesn't exist.
        if (!$userData->existsOnProject($project)) {
            $this->addFlash('danger', 'user-not-found');
            unset($params['username']);
            return $this->redirectToRoute($this->getToolShortname(), $params);

It seems like you code against a specific sub-type and not the parent class AppBundle\Controller\XtoolsController as the method getToolShortname() does only exist in the following sub-classes of AppBundle\Controller\XtoolsController: AppBundle\Controller\AdminScoreController, AppBundle\Controller\AdminStatsController, AppBundle\Controller\ArticleInfoController, AppBundle\Controller\AutomatedEditsController, AppBundle\Controller\EditCounterController, AppBundle\Controller\EditSummaryController, AppBundle\Controller\PagesController, AppBundle\Controller\SimpleEditCounterController, AppBundle\Controller\TopEditsController. Maybe you want to instanceof check for one of these explicitly?

        }

        // Reject users with a crazy high edit count.
        if ($tooHighEditCountAction && $userData->hasTooManyEdits($project)) {

The expression $tooHighEditCountAction of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $this->addFlash('danger', ['too-many-edits', number_format($userData->maxEdits())]);

array('too-many-edits', number_format($userData->maxEdits())) is of type array<integer,string,{"0":"string","1":"string"}>, but the function expects a string.

            // If redirecting to a different controller, show an informative message accordingly.
            if ($tooHighEditCountAction !== $this->getToolShortname()) {

It seems like you code against a specific sub-type and not the parent class AppBundle\Controller\XtoolsController as the method getToolShortname() does only exist in the following sub-classes of AppBundle\Controller\XtoolsController: AppBundle\Controller\AdminScoreController, AppBundle\Controller\AdminStatsController, AppBundle\Controller\ArticleInfoController, AppBundle\Controller\AutomatedEditsController, AppBundle\Controller\EditCounterController, AppBundle\Controller\EditSummaryController, AppBundle\Controller\PagesController, AppBundle\Controller\SimpleEditCounterController, AppBundle\Controller\TopEditsController. Maybe you want to instanceof check for one of these explicitly?

                // FIXME: This is currently only done for Edit Counter, redirecting to Simple Edit Counter,
                // so this bit is hardcoded. We need to instead give the i18n key of the route.
                $this->addFlash('info', ['too-many-edits-redir', 'Simple Counter']);

array('too-many-edits-redir', 'Simple Counter') is of type array<integer,string,{"0":"string","1":"string"}>, but the function expects a string.

            } else {
                // Redirecting back to index, so remove username (otherwise we'd get a redirect loop).
                unset($params['username']);
            }

            return $this->redirectToRoute($tooHighEditCountAction, $params);
        }

        return $userData;
    }